jira-ruby 2.1.3

data/spec/jira/client_spec.rb

@@ -0,0 +1,291 @@
+require 'spec_helper'
+
+# We have three forms of authentication with two clases to represent the client for those different authentications.
+# Some behaviours are shared across all three types of authentication.  these are captured here.
+RSpec.shared_examples 'Client Common Tests' do
+  it { is_expected.to be_a JIRA::Client }
+
+  it 'freezes the options once initialised' do
+    expect(subject.options).to be_frozen
+  end
+
+  it 'prepends context path to rest base_path' do
+    options = [:rest_base_path]
+    defaults = JIRA::Client::DEFAULT_OPTIONS
+    options.each { |key| expect(subject.options[key]).to eq(defaults[:context_path] + defaults[key]) }
+  end
+
+  it 'merges headers' do
+    expect(subject.send(:merge_default_headers, {})).to eq('Accept' => 'application/json')
+  end
+
+  describe 'http methods' do
+    it 'merges default headers' do
+      # stubbed response for generic client request method
+      expect(subject).to receive(:request).exactly(5).times.and_return(successful_response)
+
+      # response for merging headers for http methods with no body
+      expect(subject).to receive(:merge_default_headers).exactly(3).times.with({})
+
+      # response for merging headers for http methods with body
+      expect(subject).to receive(:merge_default_headers).exactly(2).times.with(content_type_header)
+
+      %i[delete get head].each { |method| subject.send(method, '/path', {}) }
+      %i[post put].each { |method| subject.send(method, '/path', '', content_type_header) }
+    end
+
+    it 'calls the generic request method' do
+      %i[delete get head].each do |method|
+        expect(subject).to receive(:request).with(method, '/path', nil, headers).and_return(successful_response)
+        subject.send(method, '/path', {})
+      end
+
+      %i[post put].each do |method|
+        expect(subject).to receive(:request).with(method, '/path', '', merged_headers)
+        subject.send(method, '/path', '', {})
+      end
+    end
+  end
+
+  describe 'Resource Factories' do
+    it 'gets all projects' do
+      expect(JIRA::Resource::Project).to receive(:all).with(subject).and_return([])
+      expect(subject.Project.all).to eq([])
+    end
+
+    it 'finds a single project' do
+      find_result = double
+      expect(JIRA::Resource::Project).to receive(:find).with(subject, '123').and_return(find_result)
+      expect(subject.Project.find('123')).to eq(find_result)
+    end
+  end
+
+  describe 'SSL client options' do
+    context 'without certificate and key' do
+      let(:options) { { use_client_cert: true } }
+      subject { JIRA::Client.new(options) }
+
+      it 'raises an ArgumentError' do
+        expect { subject }.to raise_exception(ArgumentError, 'Options: :cert_path or :ssl_client_cert must be set when :use_client_cert is true')
+        options[:ssl_client_cert] = '<cert></cert>'
+        expect { subject }.to raise_exception(ArgumentError, 'Options: :key_path or :ssl_client_key must be set when :use_client_cert is true')
+      end
+    end
+  end
+end
+
+RSpec.shared_examples 'HttpClient tests' do
+  it 'makes a valid request' do
+    %i[delete get head].each do |method|
+      expect(subject.request_client).to receive(:make_request).with(method, '/path', nil, headers).and_return(successful_response)
+      subject.send(method, '/path', headers)
+    end
+    %i[post put].each do |method|
+      expect(subject.request_client).to receive(:make_request).with(method, '/path', '', merged_headers).and_return(successful_response)
+      subject.send(method, '/path', '', headers)
+    end
+  end
+end
+
+RSpec.shared_examples 'OAuth Common Tests' do
+  include_examples 'Client Common Tests'
+
+  specify { expect(subject.request_client).to be_a JIRA::OauthClient }
+
+  it 'allows setting an access token' do
+    token = double
+    expect(OAuth::AccessToken).to receive(:new).with(subject.consumer, '', '').and_return(token)
+
+    expect(subject.authenticated?).to be_falsey
+    access_token = subject.set_access_token('', '')
+    expect(access_token).to eq(token)
+    expect(subject.access_token).to eq(token)
+    expect(subject.authenticated?).to be_truthy
+  end
+
+  describe 'that call a oauth client' do
+    specify 'which makes a request' do
+      %i[delete get head].each do |method|
+        expect(subject.request_client).to receive(:make_request).with(method, '/path', nil, headers).and_return(successful_response)
+        subject.send(method, '/path', {})
+      end
+      %i[post put].each do |method|
+        expect(subject.request_client).to receive(:make_request).with(method, '/path', '', merged_headers).and_return(successful_response)
+        subject.send(method, '/path', '', {})
+      end
+    end
+  end
+end
+
+describe JIRA::Client do
+  let(:request) { subject.request_client.class }
+  let(:successful_response) do
+    response = double('response')
+    allow(response).to receive(:is_a?).with(Net::HTTPSuccess).and_return(true)
+    response
+  end
+  let(:content_type_header) { { 'Content-Type' => 'application/json' } }
+  let(:headers) { { 'Accept' => 'application/json' } }
+  let(:merged_headers) { headers.merge(content_type_header) }
+
+  context 'behaviour that applies to all client classes irrespective of authentication method' do
+    it 'allows the overriding of some options' do
+      client = JIRA::Client.new(consumer_key: 'foo', consumer_secret: 'bar', site: 'http://foo.com/')
+      expect(client.options[:site]).to eq('http://foo.com/')
+      expect(JIRA::Client::DEFAULT_OPTIONS[:site]).not_to eq('http://foo.com/')
+    end
+  end
+
+  context 'with basic http authentication' do
+    subject { JIRA::Client.new(username: 'foo', password: 'bar', auth_type: :basic) }
+
+    before(:each) do
+      stub_request(:get, 'https://foo:bar@localhost:2990/jira/rest/api/2/project')
+        .to_return(status: 200, body: '[]', headers: {})
+
+      stub_request(:get, 'https://foo:badpassword@localhost:2990/jira/rest/api/2/project')
+        .to_return(status: 401, headers: {})
+    end
+
+    include_examples 'Client Common Tests'
+    include_examples 'HttpClient tests'
+
+    specify { expect(subject.request_client).to be_a JIRA::HttpClient }
+
+    it 'sets the username and password' do
+      expect(subject.options[:username]).to eq('foo')
+      expect(subject.options[:password]).to eq('bar')
+    end
+
+    it 'fails with wrong user name and password' do
+      bad_login = JIRA::Client.new(username: 'foo', password: 'badpassword', auth_type: :basic)
+      expect(bad_login.authenticated?).to be_falsey
+      expect { bad_login.Project.all }.to raise_error JIRA::HTTPError
+    end
+
+    it 'only returns a true for #authenticated? once we have requested some data' do
+      expect(subject.authenticated?).to be_falsey
+      expect(subject.Project.all).to be_empty
+      expect(subject.authenticated?).to be_truthy
+    end
+  end
+
+  context 'with cookie authentication' do
+    subject { JIRA::Client.new(username: 'foo', password: 'bar', auth_type: :cookie) }
+
+    let(:session_cookie) { '6E3487971234567896704A9EB4AE501F' }
+    let(:session_body) do
+      {
+        'session': { 'name' => 'JSESSIONID', 'value' => session_cookie },
+        'loginInfo': { 'failedLoginCount' => 1, 'loginCount' => 2,
+                       'lastFailedLoginTime' => (DateTime.now - 2).iso8601,
+                       'previousLoginTime' => (DateTime.now - 5).iso8601 }
+      }
+    end
+
+    before(:each) do
+      # General case of API call with no authentication, or wrong authentication
+      stub_request(:post, 'https://localhost:2990/jira/rest/auth/1/session')
+        .to_return(status: 401, headers: {})
+
+      # Now special case of API with correct authentication.  This gets checked first by RSpec.
+      stub_request(:post, 'https://localhost:2990/jira/rest/auth/1/session')
+        .with(body: '{"username":"foo","password":"bar"}')
+        .to_return(status: 200, body: session_body.to_json,
+                   headers: { 'Set-Cookie': "JSESSIONID=#{session_cookie}; Path=/; HttpOnly" })
+
+      stub_request(:get, 'https://localhost:2990/jira/rest/api/2/project')
+        .with(headers: { cookie: "JSESSIONID=#{session_cookie}" })
+        .to_return(status: 200, body: '[]', headers: {})
+    end
+
+    include_examples 'Client Common Tests'
+    include_examples 'HttpClient tests'
+
+    specify { expect(subject.request_client).to be_a JIRA::HttpClient }
+
+    it 'authenticates with a correct username and password' do
+      expect(subject).to be_authenticated
+      expect(subject.Project.all).to be_empty
+    end
+
+    it 'does not authenticate with an incorrect username and password' do
+      bad_client = JIRA::Client.new(username: 'foo', password: 'bad_password', auth_type: :cookie)
+      expect(bad_client).not_to be_authenticated
+    end
+
+    it 'destroys the username and password once authenticated' do
+      expect(subject.options[:username]).to be_nil
+      expect(subject.options[:password]).to be_nil
+    end
+  end
+
+  context 'with jwt authentication' do
+    subject do
+      JIRA::Client.new(
+        issuer: 'foo',
+        base_url: 'https://host.tld',
+        shared_secret: 'shared_secret_key',
+        auth_type: :jwt
+      )
+    end
+
+    before(:each) do
+      stub_request(:get, 'https://localhost:2990/jira/rest/api/2/project')
+          .with(query: hash_including(:jwt))
+          .to_return(status: 200, body: '[]', headers: {})
+    end
+
+    include_examples 'Client Common Tests'
+    include_examples 'HttpClient tests'
+
+    specify { expect(subject.request_client).to be_a JIRA::JwtClient }
+
+    it 'sets the username and password' do
+      expect(subject.options[:shared_secret]).to eq('shared_secret_key')
+    end
+
+    context 'with a incorrect jwt key' do
+      before do
+        stub_request(:get, 'https://localhost:2990/jira/rest/api/2/project')
+            .with(query: hash_including(:jwt))
+            .to_return(status: 401, body: '[]', headers: {})
+      end
+
+      it 'is not authenticated' do
+        expect(subject.authenticated?).to be_falsey
+      end
+
+      it 'raises a JIRA::HTTPError when trying to fetch projects' do
+        expect { subject.Project.all }.to raise_error JIRA::HTTPError
+      end
+    end
+
+    it 'only returns a true for #authenticated? once we have requested some data' do
+      expect(subject.authenticated?).to be_falsey
+      expect(subject.Project.all).to be_empty
+      expect(subject.authenticated?).to be_truthy
+    end
+  end
+
+  context 'oauth authentication' do
+    subject { JIRA::Client.new(consumer_key: 'foo', consumer_secret: 'bar') }
+
+    include_examples 'OAuth Common Tests'
+  end
+
+  context 'with oauth_2legged' do
+    subject { JIRA::Client.new(consumer_key: 'foo', consumer_secret: 'bar', auth_type: :oauth_2legged) }
+
+    include_examples 'OAuth Common Tests'
+  end
+
+  context 'with unknown options' do
+    let(:options) { { 'username' => 'foo', 'password' => 'bar', auth_type: :basic } }
+    subject { JIRA::Client.new(options) }
+
+    it 'raises an ArgumentError' do
+      expect { subject }.to raise_exception(ArgumentError, 'Unknown option(s) given: ["username", "password"]')
+    end
+  end
+end

data/spec/jira/has_many_proxy_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe JIRA::HasManyProxy do
+  class Foo; end
+
+  subject { JIRA::HasManyProxy.new(parent, Foo, collection) }
+
+  let(:parent)      { double('parent') }
+  let(:collection)  { double('collection') }
+
+  it 'has a target class' do
+    expect(subject.target_class).to eq(Foo)
+  end
+
+  it 'has a parent' do
+    expect(subject.parent).to eq(parent)
+  end
+
+  it 'has a collection' do
+    expect(subject.collection).to eq(collection)
+  end
+
+  it 'can build a new instance' do
+    client = double('client')
+    foo = double('foo')
+    allow(parent).to receive(:client).and_return(client)
+    allow(parent).to receive(:to_sym).and_return(:parent)
+    expect(Foo).to receive(:new).with(client, attrs: { 'foo' => 'bar' }, parent: parent).and_return(foo)
+    expect(collection).to receive(:<<).with(foo)
+    expect(subject.build('foo' => 'bar')).to eq(foo)
+  end
+
+  it 'can get all the instances' do
+    foo = double('foo')
+    client = double('client')
+    allow(parent).to receive(:client).and_return(client)
+    allow(parent).to receive(:to_sym).and_return(:parent)
+    expect(Foo).to receive(:all).with(client, parent: parent).and_return(foo)
+    expect(subject.all).to eq(foo)
+  end
+
+  it 'delegates missing methods to the collection' do
+    expect(collection).to receive(:missing_method)
+    subject.missing_method
+  end
+end

data/spec/jira/http_client_spec.rb

@@ -0,0 +1,328 @@
+require 'spec_helper'
+
+describe JIRA::HttpClient do
+  let(:basic_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS
+              .merge(JIRA::HttpClient::DEFAULT_OPTIONS)
+              .merge(basic_auth_credentials)
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_cookie_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS
+              .merge(JIRA::HttpClient::DEFAULT_OPTIONS)
+              .merge(use_cookies: true)
+              .merge(basic_auth_credentials)
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:custom_ssl_version_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS.merge(JIRA::HttpClient::DEFAULT_OPTIONS).merge(ssl_version: :TLSv1_2)
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_cookie_client_with_context_path) do
+    options = JIRA::Client::DEFAULT_OPTIONS.merge(JIRA::HttpClient::DEFAULT_OPTIONS).merge(
+      use_cookies: true,
+      context_path: '/context'
+    )
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_cookie_client_with_additional_cookies) do
+    options = JIRA::Client::DEFAULT_OPTIONS
+              .merge(JIRA::HttpClient::DEFAULT_OPTIONS)
+              .merge(
+                use_cookies: true,
+                additional_cookies: ['sessionToken=abc123', 'internal=true']
+              )
+              .merge(basic_auth_credentials)
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_client_cert_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS.merge(JIRA::HttpClient::DEFAULT_OPTIONS).merge(
+      use_client_cert: true,
+      cert: 'public certificate contents',
+      key: 'private key contents'
+    )
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_client_with_no_auth_credentials) do
+    options = JIRA::Client::DEFAULT_OPTIONS
+              .merge(JIRA::HttpClient::DEFAULT_OPTIONS)
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:basic_auth_credentials) do
+    { username: 'donaldduck', password: 'supersecret' }
+  end
+
+  let(:proxy_client) do
+    options = JIRA::Client::DEFAULT_OPTIONS.merge(JIRA::HttpClient::DEFAULT_OPTIONS).merge(
+      proxy_address: 'proxyAddress',
+      proxy_port: 42,
+      proxy_username: 'proxyUsername',
+      proxy_password: 'proxyPassword'
+    )
+    JIRA::HttpClient.new(options)
+  end
+
+  let(:response) do
+    response = double('response')
+    allow(response).to receive(:kind_of?).with(Net::HTTPSuccess).and_return(true)
+    response
+  end
+
+  let(:cookie_response) do
+    response = double('response')
+    allow(response).to receive(:kind_of?).with(Net::HTTPSuccess).and_return(true)
+    response
+  end
+
+  it 'creates an instance of Net:HTTP for a basic auth client' do
+    expect(basic_client.basic_auth_http_conn.class).to eq(Net::HTTP)
+  end
+
+  it 'makes a correct HTTP request for make_cookie_auth_request' do
+    request = double
+    basic_auth_http_conn = double
+
+    headers = { 'Content-Type' => 'application/json' }
+    expected_path = '/context/rest/auth/1/session'
+    expected_body = '{"username":"","password":""}'
+
+    allow(basic_cookie_client_with_context_path).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    expect(basic_auth_http_conn).to receive(:request).with(request).and_return(response)
+
+    allow(request).to receive(:basic_auth)
+    allow(response).to receive(:get_fields).with('set-cookie')
+
+    expect(request).to receive(:body=).with(expected_body)
+    expect(Net::HTTP.const_get(:post.to_s.capitalize)).to receive(:new).with(expected_path, headers).and_return(request)
+
+    basic_cookie_client_with_context_path.make_cookie_auth_request
+  end
+
+  it 'responds to the http methods' do
+    body = ''
+    headers = double
+    basic_auth_http_conn = double
+    request = double
+    allow(basic_client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    expect(request).to receive(:basic_auth).with(basic_client.options[:username], basic_client.options[:password]).exactly(5).times.and_return(request)
+    expect(basic_auth_http_conn).to receive(:request).exactly(5).times.with(request).and_return(response)
+    %i[delete get head].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(basic_client.make_request(method, '/path', nil, headers)).to eq(response)
+    end
+    %i[post put].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(request).to receive(:body=).with(body).and_return(request)
+      expect(basic_client.make_request(method, '/path', body, headers)).to eq(response)
+    end
+  end
+
+  it 'gets and sets cookies' do
+    body = ''
+    headers = double
+    basic_auth_http_conn = double
+    request = double
+    allow(basic_cookie_client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    expect(request).to receive(:basic_auth).with(basic_cookie_client.options[:username], basic_cookie_client.options[:password]).exactly(5).times.and_return(request)
+    expect(cookie_response).to receive(:get_fields).with('set-cookie').exactly(5).times
+    expect(basic_auth_http_conn).to receive(:request).exactly(5).times.with(request).and_return(cookie_response)
+    %i[delete get head].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(basic_cookie_client.make_request(method, '/path', nil, headers)).to eq(cookie_response)
+    end
+    %i[post put].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(request).to receive(:body=).with(body).and_return(request)
+      expect(basic_cookie_client.make_request(method, '/path', body, headers)).to eq(cookie_response)
+    end
+  end
+
+  it 'sets additional cookies when they are provided' do
+    client = basic_cookie_client_with_additional_cookies
+    body = ''
+    headers = double
+    basic_auth_http_conn = double
+    request = double
+    allow(client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    expect(request).to receive(:basic_auth).with(client.options[:username], client.options[:password]).exactly(5).times.and_return(request)
+    expect(request).to receive(:add_field).with('Cookie', 'sessionToken=abc123; internal=true').exactly(5).times
+    expect(cookie_response).to receive(:get_fields).with('set-cookie').exactly(5).times
+    expect(basic_auth_http_conn).to receive(:request).exactly(5).times.with(request).and_return(cookie_response)
+    %i[delete get head].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(client.make_request(method, '/path', nil, headers)).to eq(cookie_response)
+    end
+    %i[post put].each do |method|
+      expect(Net::HTTP.const_get(method.to_s.capitalize)).to receive(:new).with('/path', headers).and_return(request)
+      expect(request).to receive(:body=).with(body).and_return(request)
+      expect(client.make_request(method, '/path', body, headers)).to eq(cookie_response)
+    end
+  end
+
+  it 'performs a basic http client request' do
+    body = nil
+    headers = double
+    basic_auth_http_conn = double
+    http_request = double
+    expect(Net::HTTP::Get).to receive(:new).with('/foo', headers).and_return(http_request)
+
+    expect(basic_auth_http_conn).to receive(:request).with(http_request).and_return(response)
+    expect(http_request).to receive(:basic_auth).with(basic_client.options[:username], basic_client.options[:password]).and_return(http_request)
+    allow(basic_client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    basic_client.make_request(:get, '/foo', body, headers)
+  end
+
+  it 'performs a basic http client request with a full domain' do
+    body = nil
+    headers = double
+    basic_auth_http_conn = double
+    http_request = double
+    expect(Net::HTTP::Get).to receive(:new).with('/foo', headers).and_return(http_request)
+
+    expect(basic_auth_http_conn).to receive(:request).with(http_request).and_return(response)
+    expect(http_request).to receive(:basic_auth).with(basic_client.options[:username], basic_client.options[:password]).and_return(http_request)
+    allow(basic_client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    basic_client.make_request(:get, 'http://mydomain.com/foo', body, headers)
+  end
+
+  it 'does not try to use basic auth if the credentials are not set' do
+    body = nil
+    headers = double
+    basic_auth_http_conn = double
+    http_request = double
+    expect(Net::HTTP::Get).to receive(:new).with('/foo', headers).and_return(http_request)
+
+    expect(basic_auth_http_conn).to receive(:request).with(http_request).and_return(response)
+    expect(http_request).not_to receive(:basic_auth)
+    allow(basic_client_with_no_auth_credentials).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+    basic_client_with_no_auth_credentials.make_request(:get, '/foo', body, headers)
+  end
+
+  it 'returns a URI' do
+    uri = URI.parse(basic_client.options[:site])
+    expect(basic_client.uri).to eq(uri)
+  end
+
+  it 'sets up a http connection with options' do
+    http_conn = double
+    uri = double
+    host = double
+    port = double
+    expect(uri).to receive(:host).and_return(host)
+    expect(uri).to receive(:port).and_return(port)
+    expect(Net::HTTP).to receive(:new).with(host, port).and_return(http_conn)
+    expect(http_conn).to receive(:use_ssl=).with(basic_client.options[:use_ssl]).and_return(http_conn)
+    expect(http_conn).to receive(:verify_mode=).with(basic_client.options[:ssl_verify_mode]).and_return(http_conn)
+    expect(http_conn).to receive(:read_timeout=).with(basic_client.options[:read_timeout]).and_return(http_conn)
+    expect(basic_client.http_conn(uri)).to eq(http_conn)
+  end
+
+  it 'sets the SSL version when one is provided' do
+    http_conn = double
+    uri = double
+    host = double
+    port = double
+    expect(uri).to receive(:host).and_return(host)
+    expect(uri).to receive(:port).and_return(port)
+    expect(Net::HTTP).to receive(:new).with(host, port).and_return(http_conn)
+    expect(http_conn).to receive(:use_ssl=).with(basic_client.options[:use_ssl]).and_return(http_conn)
+    expect(http_conn).to receive(:verify_mode=).with(basic_client.options[:ssl_verify_mode]).and_return(http_conn)
+    expect(http_conn).to receive(:ssl_version=).with(custom_ssl_version_client.options[:ssl_version]).and_return(http_conn)
+    expect(http_conn).to receive(:read_timeout=).with(basic_client.options[:read_timeout]).and_return(http_conn)
+    expect(custom_ssl_version_client.http_conn(uri)).to eq(http_conn)
+  end
+
+  it 'sets up a non-proxied http connection by default' do
+    uri = double
+    host = double
+    port = double
+
+    expect(uri).to receive(:host).and_return(host)
+    expect(uri).to receive(:port).and_return(port)
+
+    proxy_configuration = basic_client.http_conn(uri).class
+    expect(proxy_configuration.proxy_address).to be_nil
+    expect(proxy_configuration.proxy_port).to be_nil
+    expect(proxy_configuration.proxy_user).to be_nil
+    expect(proxy_configuration.proxy_pass).to be_nil
+  end
+
+  it 'sets up a proxied http connection when using proxy options' do
+    uri = double
+    host = double
+    port = double
+
+    expect(uri).to receive(:host).and_return(host)
+    expect(uri).to receive(:port).and_return(port)
+
+    proxy_configuration = proxy_client.http_conn(uri).class
+    expect(proxy_configuration.proxy_address).to eq(proxy_client.options[:proxy_address])
+    expect(proxy_configuration.proxy_port).to eq(proxy_client.options[:proxy_port])
+    expect(proxy_configuration.proxy_user).to eq(proxy_client.options[:proxy_username])
+    expect(proxy_configuration.proxy_pass).to eq(proxy_client.options[:proxy_password])
+  end
+
+  it 'can use client certificates' do
+    http_conn = double
+    uri = double
+    host = double
+    port = double
+    expect(Net::HTTP).to receive(:new).with(host, port).and_return(http_conn)
+    expect(uri).to receive(:host).and_return(host)
+    expect(uri).to receive(:port).and_return(port)
+    expect(http_conn).to receive(:use_ssl=).with(basic_client.options[:use_ssl])
+    expect(http_conn).to receive(:verify_mode=).with(basic_client.options[:ssl_verify_mode])
+    expect(http_conn).to receive(:read_timeout=).with(basic_client.options[:read_timeout])
+    expect(http_conn).to receive(:cert=).with(basic_client_cert_client.options[:ssl_client_cert])
+    expect(http_conn).to receive(:key=).with(basic_client_cert_client.options[:ssl_client_key])
+    expect(basic_client_cert_client.http_conn(uri)).to eq(http_conn)
+  end
+
+  it 'returns a http connection' do
+    http_conn = double
+    uri = double
+    expect(basic_client).to receive(:uri).and_return(uri)
+    expect(basic_client).to receive(:http_conn).and_return(http_conn)
+    expect(basic_client.basic_auth_http_conn).to eq(http_conn)
+  end
+
+  describe '#make_multipart_request' do
+    subject do
+      basic_client.make_multipart_request(path, data, headers)
+    end
+
+    let(:path) { '/foo' }
+    let(:data) { {} }
+    let(:headers) { { 'X-Atlassian-Token' => 'no-check' } }
+    let(:basic_auth_http_conn) { double }
+    let(:request) { double('Http Request', path: path) }
+    let(:response) { double('response') }
+
+    before do
+      allow(request).to receive(:basic_auth)
+      allow(Net::HTTP::Post::Multipart).to receive(:new).with(path, data, headers).and_return(request)
+      allow(basic_client).to receive(:basic_auth_http_conn).and_return(basic_auth_http_conn)
+      allow(basic_auth_http_conn).to receive(:request).with(request).and_return(response)
+    end
+
+    it 'performs a basic http client request' do
+      expect(request).to receive(:basic_auth).with(basic_client.options[:username], basic_client.options[:password]).and_return(request)
+
+      subject
+    end
+
+    it 'makes a correct HTTP request' do
+      expect(basic_auth_http_conn).to receive(:request).with(request).and_return(response)
+      expect(response).to receive(:is_a?).with(Net::HTTPOK)
+
+      subject
+    end
+  end
+end