jira-auto-tool 1.1.5 → 1.2.1

data/spec/jira/auto/tool_spec.rb

@@ -16,7 +16,10 @@ module Jira
         end
 
         describe "#board_controller" do
-          before { allow(tool).to receive_messages(jira_client: instance_double(RateLimitedJiraClient)) }
+          before do
+            allow(tool)
+              .to receive_messages(jira_client: instance_double(RateLimitedJiraClient))
+          end
 
           it { expect(tool.board_controller).to be_a(BoardController) }
         end
@@ -118,7 +121,9 @@ module Jira
         end
 
         describe "#project" do
-          let(:jira_client) { instance_double(RateLimitedJiraClient, Project: project_query) }
+          let(:jira_client) do
+            instance_double(RateLimitedJiraClient, Project: project_query)
+          end
           let(:jira_project) { instance_double(JIRA::Resource::Project) }
           let(:jira_project_key) { "JIRA_PROJECT_KEY" }
           let(:project_query) { double("project_query", find: jira_project) } # rubocop:disable RSpec/VerifiedDoubles
@@ -131,7 +136,7 @@ module Jira
         end
 
         # TODO: move that to environment_based_value_spec
-        RSpec.shared_examples "an overridable environment based value" do |method_name|
+        RSpec.shared_examples "an overridable environment based value" do |method_name, holds_a_secret_expectation|
           let(:env_var_name) { method_name.to_s.upcase }
           let(:method_name?) { :"#{method_name}_defined?" }
           let(:config) { Config.new(object_with_overridable_value) }
@@ -141,6 +146,13 @@ module Jira
             allow(config).to receive_messages(value_store: {})
           end
 
+          context "when dealing with sensitive information" do
+            it "defines a predicate informing about the value being a secret or not" do
+              expect(object_with_overridable_value.send("#{method_name}_holds_a_secret?"))
+                .to eq(holds_a_secret_expectation)
+            end
+          end
+
           context "when the environment variable is set" do
             let(:expected_value) { "#{env_var_name} env_value" }
 
@@ -217,25 +229,13 @@ module Jira
           end
         end
 
-        %i[
-          expected_start_date_field_name
-          implementation_team_field_name
-          jat_tickets_for_team_sprint_ticket_dispatcher_jql
-          jat_rate_limit_in_seconds
-          jat_rate_interval_in_seconds
-          jira_api_token
-          jira_board_name
-          jira_board_name_regex
-          jira_context_path
-          jira_http_debug
-          jira_project_key
-          jira_site_url jira_username
-          jira_sprint_field_name
-        ].each do |method_name|
-          describe "environment based values" do
+        described_class::ENVIRONMENT_BASED_VALUE_SYMBOLS.each do |method_name, holds_a_secret|
+          holds_a_secret ||= false
+
+          describe "environment based values - #{method_name} - holds_a_secret = #{holds_a_secret}}" do
             let(:object_with_overridable_value) { tool }
 
-            it_behaves_like "an overridable environment based value", method_name
+            it_behaves_like "an overridable environment based value", method_name, holds_a_secret
           end
         end
 
@@ -277,21 +277,24 @@ module Jira
             }
           end
 
+          let(:expected_jira_client) { instance_double(RateLimitedJiraClient) }
+
           before do
             allow(tool)
               .to receive_messages(jira_username: "jira_username_value", jira_site_url: "https://jira_site_url_value",
                                    jira_api_token: "jira_api_token_value",
                                    jira_context_path_when_defined_else: "/context_path_value",
                                    jira_http_debug?: false,
-                                   jat_rate_limit_in_seconds_when_defined_else: "10",
+                                   jat_rate_limit_per_interval_when_defined_else: "10",
                                    jat_rate_interval_in_seconds_when_defined_else: "60")
           end
 
           it "has a jira client" do
-            expected_jira_client = instance_double(RateLimitedJiraClient)
-
             allow(RateLimitedJiraClient)
-              .to receive(:new).with(client_options, rate_limit: 10, rate_interval: 60)
+              .to receive(:implementation_class_for).with(tool).and_return(RateLimitedJiraClient::InProcessBased)
+
+            allow(RateLimitedJiraClient::InProcessBased)
+              .to receive(:new).with(client_options, rate_limit_per_interval: 10, rate_interval_in_seconds: 60)
                                .and_return(expected_jira_client)
 
             expect(tool.jira_client).to equal(expected_jira_client)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jira-auto-tool
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.2.1
 platform: ruby
 authors:
 - Christophe Broult
@@ -163,6 +163,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: ruby-limiter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: syslog
   requirement: !ruby/object:Gem::Requirement
@@ -195,7 +209,6 @@ email:
 - cbroult@yahoo.com
 executables:
 - jira-auto-tool
-- setup
 extensions: []
 extra_rdoc_files: []
 files:
@@ -209,13 +222,12 @@ files:
 - Rakefile
 - bin/jira-auto-tool
 - bin/jira-auto-tool.bat
-- bin/setup
-- bin/setup-dev-win.bat
 - config/examples/jira-auto-tool.env.yaml.erb
 - cucumber.yml
 - documentation/JiraToolClassDiagram.uml
 - documentation/class_diagram.md
 - documentation/principle.md
+- ext/no_wrappers_win.rb
 - features/align_sprint_time_in_dates.feature
 - features/assign_tickets_to_team_sprints.feature
 - features/cache_boards.feature
@@ -276,6 +288,8 @@ files:
 - lib/jira/auto/tool/project/options.rb
 - lib/jira/auto/tool/project/ticket_fields.rb
 - lib/jira/auto/tool/rate_limited_jira_client.rb
+- lib/jira/auto/tool/rate_limited_jira_client/in_process_based.rb
+- lib/jira/auto/tool/rate_limited_jira_client/redis_based.rb
 - lib/jira/auto/tool/request_builder.rb
 - lib/jira/auto/tool/request_builder/field_context_fetcher.rb
 - lib/jira/auto/tool/request_builder/field_option_fetcher.rb
@@ -327,6 +341,8 @@ files:
 - spec/jira/auto/tool/performer/sprint_time_in_dates_aligner_spec.rb
 - spec/jira/auto/tool/project/ticket_fields_spec.rb
 - spec/jira/auto/tool/project_spec.rb
+- spec/jira/auto/tool/rate_limited_jira_client/in_process_based_spec.rb
+- spec/jira/auto/tool/rate_limited_jira_client/redis_based_spec.rb
 - spec/jira/auto/tool/rate_limited_jira_client_spec.rb
 - spec/jira/auto/tool/request_builder/field_context_fetcher_spec.rb
 - spec/jira/auto/tool/request_builder/field_option_fetcher_spec.rb

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/bin/setup-dev-win.bat

@@ -1,3 +0,0 @@
-
-
-choco install act-cli