jimson 0.8.0 → 0.9.0

data/CHANGELOG.rdoc

@@ -1,3 +1,9 @@
+== 0.9.0 / 2012-08-22
+
+* Minor enhancements
+
+  * Add show_errors option to server, which will cause application errors to include the error name and the first line of the backtrace
+
 == 0.8.0 / 2012-08-17
 
 * Major enhancements

data/VERSION

@@ -1 +1 @@
-0.8.0
+0.9.0

data/lib/jimson/server.rb

@@ -61,6 +61,7 @@ module Jimson
 
       @host = opts.delete(:host) || '0.0.0.0'
       @port = opts.delete(:port) || 8999
+      @show_errors = opts.delete(:show_errors) || false 
       @opts = opts
     end
 
@@ -168,7 +169,7 @@ module Jimson
       rescue ArgumentError
         raise Server::Error::InvalidParams.new
       rescue Exception, StandardError => e
-        raise Server::Error::ApplicationError.new(e)
+        raise Server::Error::ApplicationError.new(e, @show_errors)
     end
 
     def dispatch_request(method, params)

data/lib/jimson/server/error.rb

@@ -47,8 +47,10 @@ module Jimson
       end
 
       class ApplicationError < Error
-        def initialize(err)
-          super(-32099, "Server application error")
+        def initialize(err, show_error = false)
+          msg = "Server application error"
+          msg += ': ' + err.message + ' at ' + err.backtrace.first if show_error
+          super(-32099, msg)
         end
       end
 

data/spec/server_spec.rb

@@ -239,23 +239,51 @@ module Jimson
       end
 
       describe "receiving a call for ugly method" do
-        it "returns only global error without stack trace" do
-          req = {
-                  'jsonrpc' => '2.0',
-                  'method'  => 'ugly_method',
-                  'id'      => 1
-                }
-          post_json(req)
+        context "by default" do
+          it "returns only global error without stack trace" do
+            req = {
+                    'jsonrpc' => '2.0',
+                    'method'  => 'ugly_method',
+                    'id'      => 1
+                  }
+            post_json(req)
 
-          resp = MultiJson.decode(last_response.body)
-          resp.should == {
-                            'jsonrpc' => '2.0',
-                            'error'   => {
-                                            'code' => -32099,
-                                            'message' => 'Server application error'
-                                          },
-                            'id'      => 1
-                          }
+            resp = MultiJson.decode(last_response.body)
+            resp.should == {
+                              'jsonrpc' => '2.0',
+                              'error'   => {
+                                              'code' => -32099,
+                                              'message' => 'Server application error'
+                                            },
+                              'id'      => 1
+                            }
+          end
+        end
+
+        context "with 'show_errors' enabled" do
+          it "returns an error name and first line of the stack trace" do
+            req = {
+                    'jsonrpc' => '2.0',
+                    'method'  => 'ugly_method',
+                    'id'      => 1
+                  }
+
+            app = Server.new(router, :environment => "production", :show_errors => true)
+
+            # have to make a new Rack::Test browser since this server is different than the normal one
+            browser = Rack::Test::Session.new(Rack::MockSession.new(app))
+            browser.post '/', MultiJson.encode(req), {'Content-Type' => 'application/json'}
+
+            resp = MultiJson.decode(browser.last_response.body)
+            resp.should == {
+                              'jsonrpc' => '2.0',
+                              'error'   => {
+                                              'code' => -32099,
+                                              'message' => "Server application error: RuntimeError at /home/chris/repos/jimson/spec/server_spec.rb:40:in `ugly_method'"
+                                            },
+                              'id'      => 1
+                            }
+          end
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jimson
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-17 00:00:00.000000000 Z
+date: 2012-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blankslate