jiffyshirts_spree_reviews 2.3.1.1

data/spec/features/admin_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+
+feature 'Review Admin', js: true do
+  stub_authorization!
+
+  given!(:review) { create(:review) }
+
+  context 'index' do
+    background do
+      visit spree.admin_reviews_path
+    end
+
+    scenario 'list reviews' do
+      expect(page).to have_text review.product.name
+    end
+
+    scenario 'approve reviews' do
+      expect(review.approved).to be false
+      within("tr#review_#{review.id}") do
+        find('.approve').click
+      end
+      expect(review.reload.approved).to be true
+    end
+
+    scenario 'edit reviews' do
+      expect(page).to have_text review.product.name
+      within("tr#review_#{review.id}") do
+        find('.edit').click
+      end
+
+      expect(page).to have_text 'Editing'
+      expect(page).to have_text review.title
+    end
+  end
+end

data/spec/features/reviews_spec.rb

@@ -0,0 +1,106 @@
+require 'spec_helper'
+
+feature 'Reviews', js: true do
+  given!(:someone) { create(:user, email: 'ryan@spree.com') }
+  given!(:review) { create(:review, :approved, user: someone) }
+
+  background do
+    Spree::Reviews::Config.include_unapproved_reviews = false
+  end
+
+  context 'product with no review' do
+    given!(:product_no_reviews) { create(:product) }
+    scenario 'informs that no reviews has been written yet' do
+      visit spree.product_path(product_no_reviews)
+      expect(page).to have_text Spree.t(:no_reviews_available)
+    end
+
+    # Regression test for #103
+    context "shows correct number of previews" do
+      background do
+        FactoryGirl.create_list :review, 3, product: product_no_reviews, approved: true
+        Spree::Reviews::Config[:preview_size] = 2
+      end
+
+      scenario "displayed reviews are limited by the set preview size" do
+        visit spree.product_path(product_no_reviews)
+        expect(page.all(".review").count).to eql(2)
+      end
+    end
+  end
+
+  context 'when anonymous user' do
+    background do
+      Spree::Reviews::Config.require_login = true
+    end
+
+    context 'visit product with review' do
+      background do
+        visit spree.product_path(review.product)
+      end
+
+      scenario 'should see review title' do
+        expect(page).to have_text review.title
+      end
+
+      scenario 'can not create review' do
+        expect(page).not_to have_text Spree.t(:write_your_own_review)
+      end
+    end
+  end
+
+  context 'when logged in user' do
+    given!(:user) { create(:user) }
+
+    background do
+      sign_in_as! user
+    end
+
+    context 'visit product with review' do
+      background do
+        visit spree.product_path(review.product)
+      end
+
+      scenario 'can see review title' do
+        expect(page).to have_text review.title
+      end
+
+      scenario 'can see create new review button' do
+        expect(page).to have_text Spree.t(:write_your_own_review)
+      end
+
+      scenario 'can create new review' do
+        click_on Spree.t(:write_your_own_review)
+
+        expect(page).to have_text Spree.t(:leave_us_a_review_for, name: review.product.name)
+
+        within '#new_review' do
+          click_star(3)
+
+          fill_in 'review_name', with: user.email
+          fill_in 'review_title', with: 'Great product!'
+          fill_in 'review_review', with: 'Some big review text..'
+          click_on 'Submit your review'
+        end
+
+        expect(page.find('.flash.notice', text: Spree.t(:review_successfully_submitted))).to be_truthy
+        expect(page).not_to have_text 'Some big review text..'
+      end
+    end
+  end
+
+  private
+
+  def sign_in_as!(user)
+    visit spree.login_path
+    within '#new_spree_user' do
+      fill_in 'Email', with: user.email
+      fill_in 'Password', with: user.password
+    end
+    click_button 'Login'
+  end
+
+  def click_star(num)
+    page.all(:xpath, "//a[@title='#{num} stars']")[0].click
+  end
+end

data/spec/helpers/review_helper_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe Spree::ReviewsHelper do
+  context 'star' do
+    specify do
+      expect(star('a_class')).to eq '<span class="a_class"> &#10030; </span>'
+    end
+  end
+
+  context 'mk_stars' do
+    specify do
+      matches = mk_stars(2).scan(/unlit/)
+      expect(matches.length).to eq 3
+
+    end
+  end
+
+  context 'txt_stars' do
+    specify do
+      expect(txt_stars(2, true)).to eq '2 out of 5'
+    end
+
+    specify do
+      expect(txt_stars(3, false)).to be_a String
+      expect(txt_stars(3, false)).to eq('3')
+    end
+  end
+end

data/spec/models/feedback_review_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Spree::FeedbackReview do
+  context 'validations' do
+    it 'validates by default' do
+      build(:feedback_review).should be_valid
+    end
+
+    it 'validates with a nil user' do
+      build(:feedback_review, user: nil).should be_valid
+    end
+
+    it 'does not validate with a nil review' do
+      build(:feedback_review, review: nil).should_not be_valid
+    end
+
+    context 'rating' do
+      it 'does not validate when no rating is specified' do
+        build(:feedback_review, rating: nil).should_not be_valid
+      end
+
+      it 'does not validate when the rating is not a number' do
+        build(:feedback_review, rating: 'not_a_number').should_not be_valid
+      end
+
+      it 'does not validate when the rating is a float' do
+        build(:feedback_review, rating: 2.718).should_not be_valid
+      end
+
+      it 'does not validate when the rating is less than 1' do
+        build(:feedback_review, rating: 0).should_not be_valid
+        build(:feedback_review, rating: -5).should_not be_valid
+      end
+
+      it 'does not validate when the rating is greater than 5' do
+        build(:feedback_review, rating: 6).should_not be_valid
+        build(:feedback_review, rating: 8).should_not be_valid
+      end
+
+      (1..5).each do |i|
+        it "validates when the rating is #{i}" do
+          build(:feedback_review, rating: i).should be_valid
+        end
+      end
+    end
+  end
+
+  context 'scopes' do
+    context 'most_recent_first' do
+      let!(:feedback_review_1) { create(:feedback_review, created_at: 10.days.ago) }
+      let!(:feedback_review_2) { create(:feedback_review, created_at: 2.days.ago) }
+      let!(:feedback_review_3) { create(:feedback_review, created_at: 5.days.ago) }
+
+      it 'properly runs most_recent_first queries' do
+        Spree::FeedbackReview.most_recent_first.to_a.should eq([feedback_review_2, feedback_review_3, feedback_review_1])
+      end
+
+      it 'defaults to most_recent_first queries' do
+        Spree::FeedbackReview.all.to_a.should eq([feedback_review_2, feedback_review_3, feedback_review_1])
+      end
+    end
+
+    context 'localized' do
+      let!(:en_feedback_review_1) { create(:feedback_review, locale: 'en', created_at: 10.days.ago) }
+      let!(:en_feedback_review_2) { create(:feedback_review, locale: 'en', created_at: 2.days.ago) }
+      let!(:en_feedback_review_3) { create(:feedback_review, locale: 'en', created_at: 5.days.ago) }
+
+      let!(:es_feedback_review_1) { create(:feedback_review, locale: 'es', created_at: 10.days.ago) }
+      let!(:fr_feedback_review_1) { create(:feedback_review, locale: 'fr', created_at: 10.days.ago) }
+
+      it 'properly runs localized queries' do
+        Spree::FeedbackReview.localized('en').to_a.should eq([en_feedback_review_2, en_feedback_review_3, en_feedback_review_1])
+        Spree::FeedbackReview.localized('es').to_a.should eq([es_feedback_review_1])
+        Spree::FeedbackReview.localized('fr').to_a.should eq([fr_feedback_review_1])
+      end
+    end
+  end
+end

data/spec/models/product_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+describe Spree::Product do
+  it { should respond_to(:avg_rating) }
+  it { should respond_to(:reviews) }
+  it { should respond_to(:stars) }
+
+  context '#stars' do
+    let(:product) { build(:product) }
+
+    it 'rounds' do
+      product.stub(:avg_rating).and_return(3.7)
+      expect(product.stars).to eq(4)
+
+      product.stub(:avg_rating).and_return(2.3)
+      expect(product.stars).to eq(2)
+    end
+
+
+    it 'handles a nil value' do
+      product.stub(:avg_rating).and_return(nil)
+      expect {
+        expect(product.stars).to eq(0)
+      }.not_to raise_error
+    end
+  end
+
+  context '#recalculate_rating' do
+    let!(:product) { create(:product) }
+
+    context 'when there are approved reviews' do
+      let!(:approved_review_1) { create(:review, product: product, approved: true, rating: 4) }
+      let!(:approved_review_2) { create(:review, product: product, approved: true, rating: 5) }
+      let!(:unapproved_review_1) { create(:review, product: product, approved: false, rating: 4) }
+
+      it "updates the product average rating and ignores unapproved reviews" do
+        product.avg_rating = 0
+        product.reviews_count = 0
+        product.save!
+
+        product.recalculate_rating
+        product.avg_rating.should eq(4.5)
+        product.reviews_count.should eq(2)
+      end
+    end
+
+    context 'when no approved reviews' do
+      let!(:unapproved_review_1) { create(:review, product: product, approved: false, rating: 4) }
+
+      it "updates the product average rating and ignores unapproved reviews" do
+        product.avg_rating = 3
+        product.reviews_count = 20
+        product.save!
+
+        product.recalculate_rating
+        product.avg_rating.should eq(0)
+        product.reviews_count.should eq(0)
+      end
+    end
+
+  end
+end

data/spec/models/review_spec.rb

@@ -0,0 +1,169 @@
+require 'spec_helper'
+
+describe Spree::Review do
+
+  context 'validations' do
+    it 'validates by default' do
+      build(:review).should be_valid
+    end
+
+    it 'validates with a nil user' do
+      build(:review, user: nil).should be_valid
+    end
+
+    it 'does not validate with a nil review' do
+      build(:review, review: nil).should_not be_valid
+    end
+
+    context 'rating' do
+      it 'does not validate when no rating is specified' do
+        build(:review, rating: nil).should_not be_valid
+      end
+
+      it 'doesnot validate when the rating is not a number' do
+        build(:review, rating: 'not_a_number').should_not be_valid
+      end
+
+      it 'does validate when the rating is a float' do
+        build(:review, rating: 2.718).should be_valid
+      end
+
+      it 'does not validate when the rating is less than 1' do
+        build(:review, rating: 0).should_not be_valid
+        build(:review, rating: -5).should_not be_valid
+      end
+
+      it 'does not validate when the rating is greater than 5' do
+        build(:review, rating: 6).should_not be_valid
+        build(:review, rating: 8).should_not be_valid
+      end
+
+      (1..5).each do |i|
+        it "validates when the rating is #{i}" do
+          build(:review, rating: i).should be_valid
+        end
+      end
+    end
+
+    context 'review body' do
+      it 'should not be valid without a body' do
+        build(:review, review: nil).should_not be_valid
+      end
+    end
+  end
+
+  context 'scopes' do
+    context 'most_recent_first' do
+      let!(:review_1) { create(:review, created_at: 10.days.ago) }
+      let!(:review_2) { create(:review, created_at: 2.days.ago) }
+      let!(:review_3) { create(:review, created_at: 5.days.ago) }
+
+      it 'properly runs most_recent_first queries' do
+        Spree::Review.most_recent_first.to_a.should eq([review_2, review_3, review_1])
+      end
+
+      it 'defaults to most_recent_first queries' do
+        Spree::Review.all.to_a.should eq([review_2, review_3, review_1])
+      end
+    end
+
+    context 'oldest_first' do
+      let!(:review_1) { create(:review, created_at: 10.days.ago) }
+      let!(:review_2) { create(:review, created_at: 2.days.ago) }
+      let!(:review_3) { create(:review, created_at: 5.days.ago) }
+      let!(:review_4) { create(:review, created_at: 1.days.ago) }
+
+      before do
+        reset_spree_preferences
+      end
+
+      it 'properly runs oldest_first queries' do
+        Spree::Review.oldest_first.to_a.should eq([review_1, review_3, review_2, review_4])
+      end
+
+      it 'uses oldest_first for preview' do
+        reset_spree_preferences
+        Spree::Review.preview.to_a.should eq([review_1, review_3, review_2])
+      end
+    end
+
+    context 'localized' do
+      let!(:en_review_1) { create(:review, locale: 'en', created_at: 10.days.ago) }
+      let!(:en_review_2) { create(:review, locale: 'en', created_at: 2.days.ago) }
+      let!(:en_review_3) { create(:review, locale: 'en', created_at: 5.days.ago) }
+
+      let!(:es_review_1) { create(:review, locale: 'es', created_at: 10.days.ago) }
+      let!(:fr_review_1) { create(:review, locale: 'fr', created_at: 10.days.ago) }
+
+      it 'properly runs localized queries' do
+        Spree::Review.localized('en').to_a.should eq([en_review_2, en_review_3, en_review_1])
+        Spree::Review.localized('es').to_a.should eq([es_review_1])
+        Spree::Review.localized('fr').to_a.should eq([fr_review_1])
+      end
+    end
+
+    context 'approved / not_approved / default_approval_filter' do
+      let!(:approved_review_1) { create(:review, approved: true, created_at: 10.days.ago) }
+      let!(:approved_review_2) { create(:review, approved: true, created_at: 2.days.ago) }
+      let!(:approved_review_3) { create(:review, approved: true, created_at: 5.days.ago) }
+
+      let!(:unapproved_review_1) { create(:review, approved: false, created_at: 7.days.ago) }
+      let!(:unapproved_review_2) { create(:review, approved: false, created_at: 1.days.ago) }
+
+      it 'properly runs approved and unapproved queries' do
+        Spree::Review.approved.to_a.should eq([approved_review_2, approved_review_3, approved_review_1])
+        Spree::Review.not_approved.to_a.should eq([unapproved_review_2, unapproved_review_1])
+
+        Spree::Reviews::Config[:include_unapproved_reviews] = true
+        Spree::Review.default_approval_filter.to_a.should eq([unapproved_review_2,
+                                                              approved_review_2,
+                                                              approved_review_3,
+                                                              unapproved_review_1,
+                                                              approved_review_1])
+
+        Spree::Reviews::Config[:include_unapproved_reviews] = false
+        Spree::Review.default_approval_filter.to_a.should eq([approved_review_2, approved_review_3, approved_review_1])
+      end
+    end
+  end
+
+  context "#recalculate_product_rating" do
+    let(:product) { create(:product) }
+    let!(:review) { create(:review, product: product) }
+
+    before { product.reviews << review }
+
+    it "if approved" do
+      review.should_receive(:recalculate_product_rating)
+      review.approved = true
+      review.save!
+    end
+
+    it "if not approved" do
+      review.should_not_receive(:recalculate_product_rating)
+      review.save!
+    end
+
+    it "updates the product average rating" do
+      review.product.should_receive(:recalculate_rating)
+      review.approved = true
+      review.save!
+    end
+  end
+
+  context "#feedback_stars" do
+    let!(:review) { create(:review) }
+    before do
+      3.times do |i|
+        f = Spree::FeedbackReview.new
+        f.review = review
+        f.rating = (i+1)
+        f.save
+      end
+    end
+
+    it "should return the average rating from feedback reviews" do
+      review.feedback_stars.should == 2
+    end
+  end
+end

data/spec/models/reviews_ability_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+require "cancan/matchers"
+
+describe Spree::ReviewsAbility do
+  context '.allow_anonymous_reviews?' do
+    it 'should depend on Spree::Reviews::Config[:require_login]' do
+      Spree::Reviews::Config[:require_login] = false
+      Spree::ReviewsAbility.allow_anonymous_reviews?.should be true
+      Spree::Reviews::Config[:require_login] = true
+      Spree::ReviewsAbility.allow_anonymous_reviews?.should be false
+    end
+  end
+
+  context 'permissions' do
+    let(:user_without_email) { double(:user, email: nil) }
+    let(:user_with_email) { double(:user, email: 'a@b.com') }
+
+    context 'when anonymous reviews are allowed' do
+      before do
+        Spree::Reviews::Config[:require_login] = false
+      end
+
+      it 'lets anyone create a review or feedback review' do
+        [user_without_email, user_with_email].each do |u|
+          Spree::ReviewsAbility.new(u).should be_able_to(:create, Spree::Review.new)
+          Spree::ReviewsAbility.new(u).should be_able_to(:create, Spree::FeedbackReview.new)
+        end
+      end
+    end
+
+    context 'when anonymous reviews are not allowed' do
+      before do
+        Spree::Reviews::Config[:require_login] = true
+      end
+
+      it 'only allows users with an email to create a review or feedback review' do
+        Spree::ReviewsAbility.new(user_without_email).should_not be_able_to(:create, Spree::Review.new)
+        Spree::ReviewsAbility.new(user_without_email).should_not be_able_to(:create, Spree::FeedbackReview.new)
+
+        Spree::ReviewsAbility.new(user_with_email).should be_able_to(:create, Spree::Review.new)
+        Spree::ReviewsAbility.new(user_with_email).should be_able_to(:create, Spree::FeedbackReview.new)
+      end
+    end
+  end
+end

data/spec/models/reviews_configuration_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe Spree::ReviewsConfiguration do
+  subject { Spree::ReviewsConfiguration.new }
+
+  before do
+    reset_spree_preferences
+  end
+
+  it 'should have the include_unapproved_reviews preference' do
+    subject.should respond_to(:preferred_include_unapproved_reviews)
+    subject.should respond_to(:preferred_include_unapproved_reviews=)
+    subject.preferred_include_unapproved_reviews.should be false
+  end
+
+  it 'should have the preview_size preference' do
+    subject.should respond_to(:preferred_preview_size)
+    subject.should respond_to(:preferred_preview_size=)
+    subject.preferred_preview_size.should eq(3)
+  end
+
+  it 'should have the show_email preference' do
+    subject.should respond_to(:preferred_show_email)
+    subject.should respond_to(:preferred_show_email=)
+    subject.preferred_show_email.should be false
+  end
+
+  it 'should have the feedback_rating preference' do
+    subject.should respond_to(:preferred_feedback_rating)
+    subject.should respond_to(:preferred_feedback_rating=)
+    subject.preferred_feedback_rating.should be false
+  end
+
+  it 'should have the require_login preference' do
+    subject.should respond_to(:preferred_require_login)
+    subject.should respond_to(:preferred_require_login=)
+    subject.preferred_require_login.should be true
+  end
+
+  it 'should have the track_locale preference' do
+    subject.should respond_to(:preferred_track_locale)
+    subject.should respond_to(:preferred_track_locale=)
+    subject.preferred_track_locale.should be false
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,48 @@
+require 'simplecov'
+SimpleCov.start 'rails'
+
+ENV["RAILS_ENV"] = "test"
+
+require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require 'rspec/rails'
+require 'ffaker'
+require 'database_cleaner'
+require 'capybara'
+require 'capybara/rspec'
+require 'capybara/rails'
+require 'capybara/poltergeist'
+
+Dir[File.join(File.dirname(__FILE__), "support/**/*.rb")].each {|f| require f }
+
+require 'spree/testing_support/factories'
+require 'spree/testing_support/controller_requests'
+require 'spree/testing_support/authorization_helpers'
+require 'spree/testing_support/preferences'
+require 'spree/testing_support/url_helpers'
+
+FactoryGirl.find_definitions
+
+RSpec.configure do |config|
+  config.include Spree::TestingSupport::ControllerRequests
+  config.include Spree::TestingSupport::Preferences
+  config.include FactoryGirl::Syntax::Methods
+  config.include Spree::TestingSupport::UrlHelpers
+  config.infer_spec_type_from_file_location!
+  config.use_transactional_fixtures = false
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before do
+    DatabaseCleaner.strategy = RSpec.current_example.metadata[:js] ? :truncation : :transaction
+    DatabaseCleaner.start
+  end
+
+  config.after do
+    DatabaseCleaner.clean
+  end
+
+  Capybara.javascript_driver = :poltergeist
+end