jeweler 1.8.2 → 2.3.7

data/test/jeweler/test_generator_initialization.rb

@@ -5,102 +5,88 @@ class TestGeneratorInitialization < Test::Unit::TestCase
     set_default_git_config
   end
 
-  context "given a nil github repo name" do
+  context 'given a nil github repo name' do
     setup do
       stub_git_config
     end
 
     should 'raise NoGithubRepoNameGiven' do
       assert_raise Jeweler::NoGitHubRepoNameGiven do
-        Jeweler::Generator.new()
+        Jeweler::Generator.new
       end
     end
   end
 
   context "without git user's name set" do
     setup do
-      stub_git_config 
+      stub_git_config
     end
 
     should 'raise an NoGitUserName' do
       assert_raise Jeweler::NoGitUserName do
-        Jeweler::Generator.new(:project_name => @project_name, :testing_framework => :shoulda, :documentation_framework => :rdoc)
+        Jeweler::Generator.new(project_name: @project_name, testing_framework: :shoulda, documentation_framework: :rdoc)
       end
     end
   end
 
   context "without git user's email set" do
     setup do
-      stub_git_config 
+      stub_git_config
     end
 
     should 'raise NoGitUserEmail' do
       assert_raise Jeweler::NoGitUserEmail do
-        Jeweler::Generator.new(:project_name => @project_name, :user_name => @git_name, :testing_framework => :shoulda, :documentation_framework => :rdoc)
+        Jeweler::Generator.new(project_name: @project_name, user_name: @git_name, testing_framework: :shoulda, documentation_framework: :rdoc)
       end
     end
   end
 
-  context "without github username set" do
+  context 'without github username set' do
     setup do
       stub_git_config
     end
 
     should 'raise NotGitHubUser' do
       assert_raise Jeweler::NoGitHubUser do
-        Jeweler::Generator.new(:project_name => @project_name, :user_name => @git_name, :user_email => @git_email, :testing_framework => :shoulda, :documentation_framework => :rdoc)
+        Jeweler::Generator.new(project_name: @project_name, user_name: @git_name, user_email: @git_email, testing_framework: :shoulda, documentation_framework: :rdoc)
       end
     end
   end
-  
-  context "without github token set" do
-    setup do
-      stub_git_config
-    end
-
-    should 'raise NoGitHubToken if creating repo' do
-      assert_raise Jeweler::NoGitHubToken do
-        Jeweler::Generator.new(:project_name => @project_name, :user_name => @git_name, :user_email => @git_email, :github_username => @github_user, :create_repo => true, :testing_framework => :shoulda, :documentation_framework => :rdoc)
-      end
-    end
-  end
-
   def build_generator(options = {})
-    defaults = { :project_name => @project_name,
-                 :user_name => @git_name,
-                 :user_email => @git_email,
-                 :github_username => @github_user,
-                 :github_token => @github_token,
-                 :testing_framework =>             :shoulda,
-                 :documentation_framework =>       :rdoc }
+    defaults = { project_name: @project_name,
+                 user_name: @git_name,
+                 user_email: @git_email,
+                 github_username: @github_user,
+                 testing_framework: :shoulda,
+                 documentation_framework: :rdoc }
 
     options = defaults.merge(options)
-    Jeweler::Generator.new(options) 
+    Jeweler::Generator.new(options)
   end
 
-  context "default configuration" do
+  context 'default configuration' do
     setup do
       stub_git_config
       @generator = build_generator
     end
 
-    should "use shoulda for testing" do
+    should 'use shoulda for testing' do
       assert_equal :shoulda, @generator.testing_framework
     end
 
-    should "use rdoc for documentation" do
+    should 'use rdoc for documentation' do
       assert_equal :rdoc, @generator.documentation_framework
     end
 
-    should "set todo in summary" do
-      assert_match /todo/i, @generator.summary
+    should 'set todo in summary' do
+      assert_match(/todo/i, @generator.summary)
     end
 
-    should "set todo in description" do
-      assert_match /todo/i, @generator.description
+    should 'set todo in description' do
+      assert_match(/todo/i, @generator.description)
     end
 
-    should "set target directory to the project name" do
+    should 'set target directory to the project name' do
       assert_equal @project_name, File.split(@generator.target_dir).last
     end
 
@@ -108,57 +94,54 @@ class TestGeneratorInitialization < Test::Unit::TestCase
       assert_equal @git_name, @generator.user_name
     end
 
-    should "set email from git config" do
+    should 'set email from git config' do
       assert_equal @git_email, @generator.user_email
     end
 
-    should "set origin remote as github, based on username and project name" do
+    should 'set origin remote as github, based on username and project name' do
       assert_equal "git@github.com:#{@github_user}/#{@project_name}.git", @generator.git_remote
     end
 
-    should "set homepage as github based on username and project name" do
+    should 'set homepage as github based on username and project name' do
       assert_equal "http://github.com/#{@github_user}/#{@project_name}", @generator.homepage
     end
 
-    should "set github username from git config" do
+    should 'set github username from git config' do
       assert_equal @github_user, @generator.github_username
     end
 
-    should "set project name as the-perfect-gem" do
+    should 'set project name as the-perfect-gem' do
       assert_equal @project_name, @generator.project_name
     end
   end
 
-  context "using yard" do
+  context 'using yard' do
     setup do
-      @generator = build_generator(:documentation_framework => :yard)
+      @generator = build_generator(documentation_framework: :yard)
     end
 
-    should "set the doc_task to yardoc" do
-      assert_equal "yardoc", @generator.doc_task
+    should 'set the doc_task to yardoc' do
+      assert_equal 'yardoc', @generator.doc_task
     end
-
   end
 
-  context "using rdoc" do
+  context 'using rdoc' do
     setup do
-      @generator = build_generator(:documentation_framework => :rdoc)
+      @generator = build_generator(documentation_framework: :rdoc)
     end
 
-    should "set the doc_task to rdoc" do
-      assert_equal "rdoc", @generator.doc_task
+    should 'set the doc_task to rdoc' do
+      assert_equal 'rdoc', @generator.doc_task
     end
   end
 
-  context "using a custom homepage" do
+  context 'using a custom homepage' do
     setup do
-      @generator = build_generator(:homepage => 'http://zomg.com')
+      @generator = build_generator(homepage: 'http://zomg.com')
     end
 
-    should "set the homepage" do
-      assert_equal "http://zomg.com", @generator.homepage
+    should 'set the homepage' do
+      assert_equal 'http://zomg.com', @generator.homepage
     end
-
   end
-
 end

data/test/jeweler/test_generator_mixins.rb

@@ -1,23 +1,22 @@
 require 'test_helper'
 
 class TestGeneratorMixins < Test::Unit::TestCase
-
   [Jeweler::Generator::BaconMixin,
    Jeweler::Generator::MicronautMixin,
    Jeweler::Generator::MinitestMixin,
    Jeweler::Generator::RspecMixin,
    Jeweler::Generator::ShouldaMixin,
    Jeweler::Generator::TestspecMixin,
-   Jeweler::Generator::TestunitMixin,
+   Jeweler::Generator::TestunitMixin
   ].each do |mixin|
-    context "#{mixin}" do
+    context mixin.to_s do
       %w(default_task feature_support_require feature_support_extend
          test_dir test_task test_pattern test_filename
          test_helper_filename).each do |method|
-          should "define #{method}" do
-            assert mixin.method_defined?(method)
-          end
-       end
+        should "define #{method}" do
+          assert mixin.method_defined?(method)
+        end
+      end
     end
   end
 end

data/test/jeweler/test_specification.rb

@@ -13,37 +13,36 @@ class TestSpecification < Test::Unit::TestCase
     gemspec = if block
                 Gem::Specification.new(&block)
               else
-                Gem::Specification.new()
+                Gem::Specification.new
               end
     gemspec.extend(Jeweler::Specification)
     gemspec
   end
 
-  should "be able to use to_ruby on a duped gemspec without error" do
+  should 'be able to use to_ruby on a duped gemspec without error' do
     gemspec = build_jeweler_gemspec
     gemspec.files.include 'throwaway value'
 
     gemspec.dup.to_ruby
   end
 
-  context "basic defaults" do
+  context 'basic defaults' do
     setup do
       @gemspec = build_jeweler_gemspec
     end
 
-    should "make files a FileList" do
+    should 'make files a FileList' do
       assert_equal FileList, @gemspec.files.class
     end
 
-    should "make extra_rdoc_files a FileList" do
+    should 'make extra_rdoc_files a FileList' do
       assert_equal FileList, @gemspec.extra_rdoc_files.class
     end
-
   end
- 
+
   context "there aren't any executables in the project directory" do
     setup do
-      @project.directory 'bin' 
+      @project.directory 'bin'
     end
 
     context "and there hasn't been any set on the gemspec" do
@@ -52,61 +51,62 @@ class TestSpecification < Test::Unit::TestCase
         @gemspec.set_jeweler_defaults(@project)
       end
 
-
-      should "have empty gemspec executables" do
+      should 'have empty gemspec executables' do
         assert_equal [], @gemspec.executables
       end
     end
 
-    context "and has been previously set executables" do
+    context 'and has been previously set executables' do
       setup do
-        @gemspec  = build_jeweler_gemspec do |gemspec|
+        @gemspec = build_jeweler_gemspec do |gemspec|
           gemspec.executables = %w(non-existant)
         end
         @gemspec.set_jeweler_defaults(@project)
       end
 
-      should "have only the original executables in the gemspec" do
+      should 'have only the original executables in the gemspec' do
         assert_equal %w(non-existant), @gemspec.executables
       end
     end
   end
 
-  context "there are multiple executables in the project directory" do
+  context 'there are multiple executables in the project directory' do
     setup do
       @project.directory('bin') do |bin|
         bin.file 'burnination'
         bin.file 'trogdor'
       end
       repo = Git.init(@project.to_s)
+      repo.config('user.name', 'who')
+      repo.config('user.email', 'who@where.com')
       repo.add('bin/burnination')
       repo.commit('Initial commit')
     end
 
     context "and there hasn't been any set on the gemspec" do
       setup do
-        @gemspec  = build_jeweler_gemspec
+        @gemspec = build_jeweler_gemspec
         @gemspec.set_jeweler_defaults(@project)
       end
 
-      should "have the executables under version control in the gemspec" do
+      should 'have the executables under version control in the gemspec' do
         assert_equal %w(burnination), @gemspec.executables
       end
     end
-    context "and has been previously set executables" do
+    context 'and has been previously set executables' do
       setup do
-        @gemspec  = build_jeweler_gemspec do |gemspec|
+        @gemspec = build_jeweler_gemspec do |gemspec|
           gemspec.executables = %w(burnination)
         end
         @gemspec.set_jeweler_defaults(@project)
       end
-      should "have only the original executables in the gemspec" do
+      should 'have only the original executables in the gemspec' do
         assert_equal %w(burnination), @gemspec.executables
       end
     end
   end
 
-  context "there are mutiple extconf.rb and mkrf_conf.rb in the project directory" do
+  context 'there are mutiple extconf.rb and mkrf_conf.rb in the project directory' do
     setup do
       @project.directory('ext') do |ext|
         ext.file 'extconf.rb'
@@ -120,19 +120,17 @@ class TestSpecification < Test::Unit::TestCase
 
     context "and there hasn't been any extensions set on the gemspec" do
       setup do
-        @gemspec  = build_jeweler_gemspec
+        @gemspec = build_jeweler_gemspec
         @gemspec.set_jeweler_defaults(@project)
       end
 
-      should "have all the extconf.rb and mkrf_config.rb files in extensions" do
+      should 'have all the extconf.rb and mkrf_config.rb files in extensions' do
         assert_equal %w(ext/mkrf_conf.rb ext/trogdor_native/mkrf_conf.rb ext/extconf.rb ext/trogdor_native/extconf.rb).sort, @gemspec.extensions.sort
       end
-
     end
-
   end
 
-  context "there are some files and is setup for git" do
+  context 'there are some files and is setup for git' do
     setup do
       @project.file 'Rakefile'
       @project.directory('lib') do |lib|
@@ -140,37 +138,38 @@ class TestSpecification < Test::Unit::TestCase
       end
 
       repo = Git.init(@project.to_s)
+      repo.config('user.name', 'who')
+      repo.config('user.email', 'who@where.com')
       repo.add('.')
       repo.commit('Initial commit')
     end
 
-    context "and the files defaults are used" do
+    context 'and the files defaults are used' do
       setup do
-        @gemspec  = build_jeweler_gemspec
+        @gemspec = build_jeweler_gemspec
         @gemspec.set_jeweler_defaults(@project, @project)
       end
 
-      should "populate files from git" do
+      should 'populate files from git' do
         assert_equal %w(Rakefile lib/example.rb), @gemspec.files.sort
       end
     end
 
-    context "and the files specified manually" do
+    context 'and the files specified manually' do
       setup do
-        @gemspec  = build_jeweler_gemspec do |gemspec|
+        @gemspec = build_jeweler_gemspec do |gemspec|
           gemspec.files = %w(Rakefile)
         end
         @gemspec.set_jeweler_defaults(@project, @project)
       end
 
-      should "not be overridden by files from git" do
+      should 'not be overridden by files from git' do
         assert_equal %w(Rakefile), @gemspec.files
       end
     end
-
   end
 
-  context "there are some files and is setup for git with ignored files" do
+  context 'there are some files and is setup for git with ignored files' do
     setup do
       @project.file '.gitignore', 'ignored'
       @project.file 'ignored'
@@ -180,20 +179,21 @@ class TestSpecification < Test::Unit::TestCase
       end
 
       repo = Git.init(@project.to_s)
+      repo.config('user.name', 'who')
+      repo.config('user.email', 'who@where.com')
       repo.add('.')
       repo.commit('Initial commit')
 
-
-      @gemspec  = build_jeweler_gemspec
+      @gemspec = build_jeweler_gemspec
       @gemspec.set_jeweler_defaults(@project, @project)
     end
 
-    should "populate files from git excluding ignored and .gitignore" do
+    should 'populate files from git excluding ignored and .gitignore' do
       assert_equal %w(Rakefile lib/example.rb), @gemspec.files.sort
     end
   end
 
-  context "there are some files and is setup for git and working in a sub directory" do
+  context 'there are some files and is setup for git and working in a sub directory' do
     setup do
       @subproject = File.join(@project, 'subproject')
       @project.file 'Rakefile'
@@ -206,32 +206,33 @@ class TestSpecification < Test::Unit::TestCase
       end
 
       repo = Git.init(@project.to_s)
+      repo.config('user.name', 'who')
+      repo.config('user.email', 'who@where.com')
       repo.add('.')
       repo.commit('Initial commit')
 
-      @gemspec  = build_jeweler_gemspec
+      @gemspec = build_jeweler_gemspec
       @gemspec.set_jeweler_defaults(@subproject, @project)
     end
 
-    should "populate files from git relative to sub directory" do
+    should 'populate files from git relative to sub directory' do
       assert_equal %w(lib/subproject_example.rb README).sort, @gemspec.files.sort
     end
   end
 
-  context "there are some files and is not setup for git" do
+  context 'there are some files and is not setup for git' do
     setup do
       @project.file 'Rakefile'
       @project.directory('lib') do |lib|
         lib.file 'example.rb'
       end
 
-      @gemspec  = build_jeweler_gemspec
+      @gemspec = build_jeweler_gemspec
       @gemspec.set_jeweler_defaults(@project, @project)
     end
 
-    should "not populate files" do
+    should 'not populate files' do
       assert_equal [], @gemspec.files.sort
     end
   end
-
 end

data/test/jeweler/test_tasks.rb

@@ -6,8 +6,8 @@ class TestTasks < Test::Unit::TestCase
 
   context 'instantiating Jeweler::Tasks' do
     setup do
-      @gemspec_building_block = lambda {|gemspec|}
-      @tasks = Jeweler::Tasks.new &@gemspec_building_block
+      @gemspec_building_block = ->(gemspec) {}
+      @tasks = Jeweler::Tasks.new(&@gemspec_building_block)
     end
 
     teardown do
@@ -45,6 +45,5 @@ class TestTasks < Test::Unit::TestCase
       @tasks = Jeweler::Tasks.new { |s| spec = s }
       assert_not_nil @tasks.jeweler.gemspec
     end
-
   end
 end