jetstream_bridge 1.7.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0e0d3ee00b372ffe54ceca93b81a7c573385f6b85f16f584f15e8c5eef82cd44
-  data.tar.gz: b56fa1bc39e3b598719bced5b0be60172cd953214bee399c00341fd1f2d00906
+  metadata.gz: 601869d9b83276fd0e3b6a249dafc1bb7a749ffe6aade556077b60b95eb24124
+  data.tar.gz: b7ea75cdabb21f5f71d5ff447cd4a449c470a56ff6a3723737895c1cfa260bbc
 SHA512:
-  metadata.gz: 342b6b3431d3768b843060402ededa4dcca39100c1d0c005153a3ea4f758a9ab6aff9a09e5d608444acbb332766cfb926f3c1555afb8d9df882cfcdb7a8b405f
-  data.tar.gz: eb257f387a461444121cb304c36e9fa3ce13062c81a8bc43c0cda4e6f6c706c2efa8cc7a4cf3fdfc721cedeab1d11f0ca8bb00e943644c01575d051f5e143c19
+  metadata.gz: 4de9e146864e60fda36d68380e7bf5485d317d599c689d2594e719c1f71f73da3667d43add5e646289a2e5dc8f4dc93495b2f615b99d90c120d4674684b415fe
+  data.tar.gz: 4b4f148a4dea6c38c108f84f07bb179e601faf8aec06f01cbf495a6b645e14dc11ce805d69ab7c91dbd747966f6f44866d19a9b429e347617fa06e208b159c8c

data/.rubocop.yml

@@ -5,10 +5,6 @@ plugins:
   - rubocop-performance
   - rubocop-packaging
 
-# If you keep a generated TODO, uncomment:
-# inherit_from:
-#   - .rubocop_todo.yml
-
 AllCops:
   NewCops: enable
   TargetRubyVersion: 2.7   # match gemspec minimum to avoid false positives

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    jetstream_bridge (1.7.0)
+    jetstream_bridge (1.9.0)
       activerecord (>= 6.0)
       activesupport (>= 6.0)
       nats-pure (~> 2.4)
@@ -142,8 +142,6 @@ GEM
       racc (~> 1.4)
     nokogiri (1.18.7-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.7-x86_64-linux-gnu)
-      racc (~> 1.4)
     parallel (1.27.0)
     parser (3.3.9.0)
       ast (~> 2.4.1)

data/lib/jetstream_bridge/models/inbox_event.rb

@@ -3,62 +3,74 @@
 begin
   require 'active_record'
 rescue LoadError
-  # No-op; shim below if AR missing.
+  # No-op; shim defined below.
 end
 
 module JetstreamBridge
-  # Default Inbox model when `use_inbox` is enabled.
-  # Prefers event_id, but can fall back to (stream, stream_seq).
   if defined?(ActiveRecord::Base)
     class InboxEvent < ActiveRecord::Base
       self.table_name = 'jetstream_inbox_events'
 
       class << self
-        def column?(name) = column_names.include?(name.to_s)
+        # Safe column presence check that never boots a connection during class load.
+        def has_column?(name)
+          return false unless ar_connected?
+          connection.schema_cache.columns_hash(table_name).key?(name.to_s)
+        rescue ActiveRecord::ConnectionNotEstablished, ActiveRecord::NoDatabaseError
+          false
+        end
 
-        def attribute_json?(name)
-          return false unless respond_to?(:attribute_types) && attribute_types.key?(name.to_s)
-          attribute_types[name.to_s].to_s.downcase.include?('json')
+        def ar_connected?
+          ActiveRecord::Base.connected? && connection_pool.active_connection?
+        rescue
+          false
         end
       end
 
-      if column?(:payload)
-        serialize :payload, coder: JSON unless attribute_json?(:payload)
-      end
-      if column?(:headers)
-        serialize :headers, coder: JSON unless attribute_json?(:headers)
-      end
+      # ---- Validations (NO with_options; guard everything with procs) ----
 
-      if column?(:event_id)
-        validates :event_id, presence: true, uniqueness: true
-      elsif column?(:stream_seq)
-        validates :stream_seq, presence: true
-        validates :stream, presence: true, if: -> { self.class.column?(:stream) }
-        if column?(:stream)
-          validates :stream_seq, uniqueness: { scope: :stream }
-        else
-          validates :stream_seq, uniqueness: true
-        end
-      end
+      # Preferred dedupe key
+      validates :event_id,
+                presence: true,
+                uniqueness: true,
+                if: -> { self.class.has_column?(:event_id) }
 
-      validates :subject, presence: true, if: -> { self.class.column?(:subject) }
+      # Fallback to (stream, stream_seq) when event_id column not present
+      validates :stream_seq,
+                presence: true,
+                if: -> { !self.class.has_column?(:event_id) && self.class.has_column?(:stream_seq) }
 
-      if self.class.column?(:status)
-        STATUSES = %w[received processing processed failed].freeze
-        validates :status, inclusion: { in: STATUSES }
-      end
+      validates :stream_seq,
+                uniqueness: { scope: :stream },
+                if: -> {
+                  !self.class.has_column?(:event_id) &&
+                    self.class.has_column?(:stream_seq) &&
+                    self.class.has_column?(:stream)
+                }
 
-      scope :processed, -> { where(status: 'processed') }, if: -> { column?(:status) }
+      validates :stream_seq,
+                uniqueness: true,
+                if: -> {
+                  !self.class.has_column?(:event_id) &&
+                    self.class.has_column?(:stream_seq) &&
+                    !self.class.has_column?(:stream)
+                }
 
+      validates :subject,
+                presence: true,
+                if: -> { self.class.has_column?(:subject) }
+
+      # ---- Defaults that do not require schema at load time ----
       before_validation do
-        self.status      ||= 'received' if self.class.column?(:status) && status.blank?
-        self.received_at ||= Time.now.utc if self.class.column?(:received_at) && received_at.blank?
+        self.status      ||= 'received' if self.class.has_column?(:status) && status.blank?
+        self.received_at ||= Time.now.utc if self.class.has_column?(:received_at) && received_at.blank?
       end
 
+      # ---- Helpers ----
       def processed?
-        if self.class.column?(:processed_at)
+        if self.class.has_column?(:processed_at)
           processed_at.present?
-        elsif self.class.column?(:status)
+        elsif self.class.has_column?(:status)
           status == 'processed'
         else
           false
@@ -75,21 +87,20 @@ module JetstreamBridge
       end
     end
   else
+    # Shim: loud failure if AR isn't present but someone calls the model.
     class InboxEvent
       class << self
         def method_missing(method_name, *_args, &_block)
           raise_missing_ar!('Inbox', method_name)
         end
-
-        def respond_to_missing?(_name, _priv = false) = false
+        def respond_to_missing?(_m, _p = false) = false
 
         private
-
         def raise_missing_ar!(which, method_name)
           raise(
             "#{which} requires ActiveRecord (tried to call ##{method_name}). " \
               'Enable `use_inbox` only in apps with ActiveRecord, or add ' \
-              '`gem "activerecord"` to your Gemfile.'
+              '`gem \"activerecord\"` to your Gemfile.'
           )
         end
       end

data/lib/jetstream_bridge/models/outbox_event.rb

@@ -3,80 +3,82 @@
 begin
   require 'active_record'
 rescue LoadError
-  # No-op; we provide a shim below if AR is missing.
+  # No-op; shim defined below.
 end
 
 module JetstreamBridge
-  # Default Outbox model when `use_outbox` is enabled.
-  # Works with event-centric columns and stays compatible with legacy resource_* fields.
   if defined?(ActiveRecord::Base)
     class OutboxEvent < ActiveRecord::Base
       self.table_name = 'jetstream_outbox_events'
 
       class << self
-        def column?(name) = column_names.include?(name.to_s)
+        # Safe column presence check that never boots a connection during class load.
+        def has_column?(name)
+          return false unless ar_connected?
+          connection.schema_cache.columns_hash(table_name).key?(name.to_s)
+        rescue ActiveRecord::ConnectionNotEstablished, ActiveRecord::NoDatabaseError
+          false
+        end
 
-        def attribute_json?(name)
-          return false unless respond_to?(:attribute_types) && attribute_types.key?(name.to_s)
-          attribute_types[name.to_s].to_s.downcase.include?('json')
+        def ar_connected?
+          # Avoid creating a connection; rescue if pool isn't set yet.
+          ActiveRecord::Base.connected? && connection_pool.active_connection?
+        rescue
+          false
         end
       end
 
-      # JSON casting fallback if column is text
-      if column?(:payload)
-        serialize :payload, coder: JSON unless attribute_json?(:payload)
-      end
-      if column?(:headers)
-        serialize :headers, coder: JSON unless attribute_json?(:headers)
-      end
+      # ---- Validations guarded by safe schema checks (no with_options) ----
+      validates :payload,
+                presence: true,
+                if: -> { self.class.has_column?(:payload) }
 
-      # Validations (guarded by column existence)
-      validates :payload, presence: true, if: -> { self.class.column?(:payload) }
+      # Preferred path when event_id exists
+      validates :event_id,
+                presence: true,
+                uniqueness: true,
+                if: -> { self.class.has_column?(:event_id) }
 
-      if self.class.column?(:event_id)
-        validates :event_id, presence: true, uniqueness: true
-      else
-        validates :resource_type, presence: true, if: -> { self.class.column?(:resource_type) }
-        validates :resource_id,   presence: true, if: -> { self.class.column?(:resource_id) }
-        validates :event_type,    presence: true, if: -> { self.class.column?(:event_type) }
-      end
+      # Fallback legacy fields when event_id is absent
+      validates :resource_type,
+                presence: true,
+                if: -> { !self.class.has_column?(:event_id) && self.class.has_column?(:resource_type) }
 
-      validates :subject, presence: true, if: -> { self.class.column?(:subject) }
+      validates :resource_id,
+                presence: true,
+                if: -> { !self.class.has_column?(:event_id) && self.class.has_column?(:resource_id) }
 
-      if self.class.column?(:status)
-        STATUSES = %w[pending publishing sent failed].freeze
-        validates :status, inclusion: { in: STATUSES }
-      end
+      validates :event_type,
+                presence: true,
+                if: -> { !self.class.has_column?(:event_id) && self.class.has_column?(:event_type) }
 
-      if self.class.column?(:attempts)
-        validates :attempts, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
-      end
+      validates :subject,
+                presence: true,
+                if: -> { self.class.has_column?(:subject) }
 
-      # Scopes (optional)
-      scope :pending,       -> { where(status: 'pending') },        if: -> { column?(:status) }
-      scope :publishing,    -> { where(status: 'publishing') },     if: -> { column?(:status) }
-      scope :failed,        -> { where(status: 'failed') },         if: -> { column?(:status) }
-      scope :sent,          -> { where(status: 'sent') },           if: -> { column?(:status) }
-      scope :ready_to_send, -> { where(status: %w[pending failed]) }, if: -> { column?(:status) }
+      validates :attempts,
+                numericality: { only_integer: true, greater_than_or_equal_to: 0 },
+                if: -> { self.class.has_column?(:attempts) }
 
+      # ---- Defaults that do not require schema at load time ----
       before_validation do
         now = Time.now.utc
-        self.status     ||= 'pending' if self.class.column?(:status)     && status.blank?
-        self.enqueued_at ||= now      if self.class.column?(:enqueued_at) && enqueued_at.blank?
-        self.attempts     = 0         if self.class.column?(:attempts)   && attempts.nil?
+        self.status      ||= 'pending' if self.class.has_column?(:status)      && status.blank?
+        self.enqueued_at ||= now        if self.class.has_column?(:enqueued_at) && enqueued_at.blank?
+        self.attempts      = 0          if self.class.has_column?(:attempts)   && attempts.nil?
       end
 
-      # Helpers (no-ops if columns missing)
+      # ---- Helpers ----
       def mark_sent!
         now = Time.now.utc
-        self.status  = 'sent' if self.class.column?(:status)
-        self.sent_at = now    if self.class.column?(:sent_at)
+        self.status  = 'sent' if self.class.has_column?(:status)
+        self.sent_at = now    if self.class.has_column?(:sent_at)
         save!
       end
 
       def mark_failed!(err_msg)
-        self.status     = 'failed' if self.class.column?(:status)
-        self.last_error = err_msg  if self.class.column?(:last_error)
+        self.status     = 'failed' if self.class.has_column?(:status)
+        self.last_error = err_msg  if self.class.has_column?(:last_error)
         save!
       end
 
@@ -90,14 +92,14 @@ module JetstreamBridge
       end
     end
   else
-    # Shim: friendly error if AR is not available.
+    # Shim: loud failure if AR isn't present but someone calls the model.
     class OutboxEvent
       class << self
         def method_missing(method_name, *_args, &_block)
           raise_missing_ar!('Outbox', method_name)
         end
 
-        def respond_to_missing?(_name, _priv = false) = false
+        def respond_to_missing?(_m, _p = false) = false
 
         private
 

data/lib/jetstream_bridge/railtie.rb

@@ -1,10 +1,35 @@
 # frozen_string_literal: true
 
-require 'rails/railtie'
-
+# lib/jetstream_bridge/railtie.rb
 module JetstreamBridge
-  # Railtie for JetstreamBridge.
   class Railtie < ::Rails::Railtie
+    initializer 'jetstream_bridge.defer_model_tweaks' do
+      ActiveSupport.on_load(:active_record) do
+        ActiveSupport::Reloader.to_prepare do
+          # Skip if not connected (e.g., non-DB rake tasks)
+          begin
+            next unless ActiveRecord::Base.connected?
+          rescue StandardError
+            next
+          end
+
+          [JetstreamBridge::OutboxEvent, JetstreamBridge::InboxEvent].each do |klass|
+            next unless klass.table_exists?
+
+            %w[payload headers].each do |attr|
+              next unless klass.columns_hash.key?(attr)
+
+              # Only add serialize if the column is not JSON/JSONB
+              type = klass.type_for_attribute(attr)
+              klass.serialize attr.to_sym, coder: JSON unless type&.json?
+            end
+          rescue ActiveRecord::StatementInvalid, ActiveRecord::ConnectionNotEstablished
+            # Ignore in tasks/environments without DB
+          end
+        end
+      end
+    end
+
     rake_tasks do
       load File.expand_path('tasks/install.rake', __dir__)
     end

data/lib/jetstream_bridge/version.rb

@@ -4,5 +4,5 @@
 #
 # Version constant for the gem.
 module JetstreamBridge
-  VERSION = '1.7.0'
+  VERSION = '1.9.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jetstream_bridge
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Mike Attara