jets 4.0.10 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8612274c29e1e3f75b05e46d4d6e47571abc9b3dbd76322486a2cb6626c0f5a
-  data.tar.gz: 9282f2d3543c0b9a02718e8078a276797104f1798d65d8a6617d08210c08361e
+  metadata.gz: 54e94ceb6d67976943a212a5ccceb71bb3e7bd6c6928775c0e7b824be127e42d
+  data.tar.gz: cab6dba2a8108c047daec4706e15d226e0e7f4eb46e9b6f2617465ea186b451e
 SHA512:
-  metadata.gz: dd5f0ef934488eadaa573f00f693687eb352d18d46bffd927b5d3afaebc5010fcf0d04ef6622bc38af05501aa7d9eea4dccbdca8bc6d2ba64f25bb8ec88cc818
-  data.tar.gz: b661cc6ec392586322e2cf0f0cec81d186b9522545e9fb63f9335035411e8bb7937431da73614f44c963ddbb7d7582c4a5978226f5eaf9d7398d52b686ba5271
+  metadata.gz: c050d7738b47e826403bc383baa0b2db251246b3d3dc359135e8e1039f8404448021477b38fbfab57f2be1cd09f7ffe8aa925cff70e313a96e61735f46f4fee2
+  data.tar.gz: 152c89e1b3e9d124f63687181f48c13ef09e3140062665a6b11baf9a99e830869cd7c8df46a2e1e8e59c58bc08bbb76d6430d235fd296ed176bcf0628890531a

data/.gitignore

@@ -7,6 +7,7 @@
 _yardoc
 coverage
 doc/
+docs/
 InstalledFiles
 lib/bundler/man
 pkg
@@ -15,10 +16,13 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+node_modules
 
 .codebuild/definitions
 /html
 /demo
 Gemfile.lock
-spec/fixtures/apps/franky/dynamodb/migrate
+spec/fixtures/demo/dynamodb/migrate
+spec/fixtures/demo/public/assets
 spec/fixtures/project/handlers
+yarn.lock

data/CHANGELOG.md

@@ -3,6 +3,58 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/).
 
+## [5.0.0] - 2023-12-05
+Single Lambda Function for Controllers
+* For controllers, a single Lambda function is deployed going forward.
+* APIGW serves as proxy endpoint for requests to the single Lambda function. Techniquely, there are 2 APIGW endpoints.
+* Jobs and other classes still create a discrete lambda function per Ruby method.
+
+Jets Engines support
+* Jets Engines closely resemble Rails engines.
+* Use as many Rails middlewares as possible
+
+Jets Controllers are "ActionController and ActionView compatible."
+* View Scope has first-class citizens access to Jets Controller instances.
+* Breaking Change: `resources :posts` and `delete` route method routes to controller `destroy` method like rails instead of `delete` method.
+
+Jets Controllers now support:
+* around filters
+* cache control and etag caching support
+* content security policy
+* cookies support via actionpack
+* flash support
+* forgery protection improvements
+* importmap support
+* i18n support
+
+New Jets CLI structure that
+* Close to Rails CLI structure
+
+Jets Pro support
+* deploys, release history, rollback support
+* use jets-api gem
+
+Refactor CloudFormation Builders
+* Use CamelCase properties internally
+* Short name template filenames and class names without the _builder.
+* Fully qualify LambdaFunction logical id.
+
+Misc
+* Remove afterburner turbo and mega mode to prepare for container-based Rails support.
+* Autoloaders refactor. gem (Jets internal), main (user app), once (user app)
+* CORS via with middleware only.
+* Improve ActionMailer integration. Improve preview support.
+* logger active support logger and tagged logging support
+* dynamodb event conventional table namespace
+* enable iot rule by default bug fix
+* create named route methods for all CRUD actions
+* Jets.cache support
+
+Breaking changes:
+* Pass request.headers straight without downcase. IE: `X-Amzn-Trace-Id`. Introduce request.downcase_headers instead.
+* Jets.config.prewarm.concurrency option removed.
+* dynomite decoupling and integration improvements
+
 ## [4.0.10] - 2023-12-04
 - [#678](https://github.com/boltops-tools/jets/pull/678) handle option method or http_method from route state
 
@@ -28,6 +80,7 @@ This project *loosely tries* to adhere to [Semantic Versioning](http://semver.or
 
 ## [4.0.3] - 2023-08-03
 - [#657](https://github.com/boltops-tools/jets/pull/657) [Fix] ApiGateway for local Middleware: fix query_string_parameters
+Breaking Changes:
 
 ## [4.0.2] - 2023-08-03
 - [#660](https://github.com/boltops-tools/jets/pull/660) Fix prewarming

data/Gemfile

@@ -4,11 +4,7 @@ source "https://rubygems.org"
 gemspec
 
 # required here for specs
-# TODO: Only require webpacker in Gemfile of project if possible.
-# Need both because of jets/application.rb and jets/webpacker/middleware_setup.rb
 group :development, :test do
   gem "mysql2", "~> 0.5.2"
-  gem "dynomite"
-  gem "jetpacker"
-  gem "rspec_junit_formatter"
+  gem "dynomite", "~> 2.0.0"
 end

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2021 Tung Nguyen
+Copyright (c) Tung Nguyen
 
 MIT License
 

data/README.md

@@ -16,12 +16,13 @@ Please **watch/star** this repo to help grow and support the project.
 
 ## What is Ruby on Jets?
 
-Jets is a Ruby Serverless Framework.  Jets allows you to create serverless applications with a beautiful language: Ruby.  It includes everything required to build an application and deploy it to AWS Lambda.
+Jets is a Ruby Serverless Framework. Jets allows you to create serverless applications with a beautiful language: Ruby. It includes everything required to build and deploy an application to AWS Lambda.
 
-It is key to understand AWS Lambda and API Gateway to understand Jets conceptually.  Jets maps your code to Lambda functions and API Gateway resources.
+Understanding AWS Lambda and API Gateway is key to understanding Jets conceptually. Jets map your code to Lambda functions and other AWS Resources like API Gateway and Event Rules.
 
-* **AWS Lambda** is Functions as a Service. It allows you to upload and run functions without worrying about the underlying infrastructure.
+* **AWS Lambda** is functions as a service. It allows you to upload and run functions without worrying about the underlying infrastructure.
 * **API Gateway** is the routing layer for Lambda. It is used to route REST URL endpoints to Lambda functions.
+* **EventBridge Rules** are events as a service. You can automatically run Lambda functions triggered from AWS services. You decide what events to catch and how to react to them.
 
 The official documentation is at [Ruby on Jets](http://rubyonjets.com).
 
@@ -42,14 +43,14 @@ end
 
 Here's the function in the Lambda console:
 
-![Code Example in AWS Lambda console](https://raw.githubusercontent.com/tongueroo/jets/master/docs/img/docs/jets-simple-lambda-function-console.png)
+![Code Example in AWS Lambda console](https://img.boltops.com/tools/jets/readme/simple-lambda-function.png)
 
 
-Though simple functions are supported by Jets, they do not add much value as other ways to write Ruby code with Jets. Classes like [Controllers](http://rubyonjets.com/docs/controllers/) and [Jobs](http://rubyonjets.com/docs/jobs/) add many conveniences and are more powerful to use. We’ll cover them next.
+Though simple functions are supported by Jets, they do not add as much value as other ways to write Ruby code with Jets. Classes like [Controllers](http://rubyonjets.com/docs/controllers/) and [Jobs](http://rubyonjets.com/docs/jobs/) add many conveniences and are more powerful to use. We’ll cover them next.
 
 ### Jets Controllers
 
-A Jets controller handles a web request and renders a response.  Here's an example:
+A Jets controller handles a web request and renders a response. Here's an example:
 
 app/controllers/posts_controller.rb:
 
@@ -69,11 +70,9 @@ class PostsController < ApplicationController
 end
 ```
 
-Helper methods like `params` provide the parameters from the API Gateway event. The `render` method renders a Lambda Proxy structure back that API Gateway understands.
+Helper methods like `params` provide the parameters from the API Gateway event. The `render` method returns a Lambda Proxy structure that API Gateway understands.
 
-Jets creates Lambda functions for each public method in your controller. Here they are in the Lambda console:
-
-![Lambda Functions for each public method in AWS Console](https://raw.githubusercontent.com/tongueroo/jets/master/docs/img/docs/demo-lambda-functions-controller.png)
+Jets creates single Lambda functions to handle your Jets Controller requests. The Lambda Function handler is a shim that routes to your controller action.
 
 ### Jets Routing
 
@@ -83,23 +82,14 @@ config/routes.rb:
 
 ```ruby
 Jets.application.routes.draw do
-  get  "posts", to: "posts#index"
-  get  "posts/new", to: "posts#new"
-  get  "posts/:id", to: "posts#show"
-  post "posts", to: "posts#create"
-  get  "posts/:id/edit", to: "posts#edit"
-  put  "posts", to: "posts#update"
-  delete  "posts", to: "posts#delete"
-
-  resources :comments # expands to the RESTful routes above
-
+  resources :posts
   any "posts/hot", to: "posts#hot" # GET, POST, PUT, etc request all work
 end
 ```
 
 The `routes.rb` gets translated to API Gateway resources:
 
-![API Gateway Resources generated from routes in AWS console](https://raw.githubusercontent.com/tongueroo/jets/master/docs/img/quick-start/demo-api-gateway.png)
+![API Gateway Resources generated from routes in AWS console](https://img.boltops.com/tools/jets/readme/apigw.png)
 
 Test your API Gateway endpoints with curl or postman. Note, replace the URL endpoint with the one that is created:
 
@@ -111,7 +101,7 @@ Test your API Gateway endpoints with curl or postman. Note, replace the URL endp
 
 ### Jets Jobs
 
-A Jets job handles asynchronous background jobs performed outside of the web request/response cycle. Here's an example:
+A Jets job handles asynchronous background jobs outside the web request/response cycle. Here's an example:
 
 app/jobs/hard_job.rb:
 
@@ -129,9 +119,13 @@ class HardJob < ApplicationJob
 end
 ```
 
-`HardJob#dig` runs every 10 hours and `HardJob#lift` runs every 12 hours.  The `rate` and `cron` methods created CloudWatch Event Rules. Example:
+![Jets Jobs in AWS Lambda Console](https://img.boltops.com/tools/jets/readme/jets-jobs.png)
+
+`HardJob#dig` runs every 10 hours, and `HardJob#lift` runs every 12 hours. The `rate` and `cron` methods created CloudWatch Event Rules. Example:
+
+![CloudWatch Event Rules in AWS Console](https://img.boltops.com/tools/jets/readme/jets-jobs-event-rules.png)
 
-![CloudWatch Event Rules in AWS Console](https://raw.githubusercontent.com/tongueroo/jets/master/docs/img/docs/demo-job-cloudwatch-rule.png)
+This simple example uses Scheduled Events. There are many more possibilities, see the [Events Docs](https://docs.rubyonjets.com/docs/events/).
 
 ### Jets Deployment
 
@@ -141,29 +135,19 @@ You can test your application with a local server that mimics API Gateway: [Jets
 
 After deployment, you can test the Lambda functions with the AWS Lambda console or the CLI.
 
-### AWS Lambda Console
-
-![Lambda Console](https://s3.amazonaws.com/boltops-demo/images/screenshots/lambda-console-posts-controller-index.png)
-
 ### Live Demos
 
 Here are some demos of Jets applications:
 
 * [Quintessential CRUD Jets app](https://demo.rubyonjets.com/)
 * [API Demo](https://api.demo.rubyonjets.com/)
-* [Jets Afterburner: Easy Rails Support](https://afterburner.demo.rubyonjets.com/)
-* [Mega Mode: Jets and Rails Combined](https://mega.demo.rubyonjets.com/)
 * [Image Upload with CarrierWave](https://upload.demo.rubyonjets.com/)
 
-Please feel free to add your own example to the [jets-examples](https://github.com/tongueroo/jets-examples) repo.
-
-### Rails Support
-
-[Jets Afterburner Mode](http://rubyonjets.com/docs/rails-support/) provides Rails support with little effort.  This allows you to run a Rails application on AWS Lambda. Also here's a Tutorial Blog Post: [Jets Afterburner: Rails Support](https://blog.boltops.com/2018/12/21/jets-afterburner-serverless-rails-on-aws-lambda-in-5-minutes).
+Please feel free to add your examples to the [rubyonjets/examples](https://github.com/rubyonjets/examples) repo.
 
 ### More Info
 
-For more documentation, check out the official docs: [Ruby on Jets](http://rubyonjets.com/).  Here's a list of useful links:
+For more documentation, check out the official docs: [Ruby on Jets](http://rubyonjets.com/). Here's a list of useful links:
 
 * [Quick Start](http://rubyonjets.com/quick-start/)
 * [Local Jets Server](http://rubyonjets.com/docs/local-server/)

data/Rakefile

@@ -8,10 +8,11 @@ task :default => :spec
 RSpec::Core::RakeTask.new
 
 require_relative "lib/jets"
+
 desc "Generates cli reference docs as markdown"
 task :docs do
-  Jets::Autoloaders.once.eager_load
-  Jets::Commands::Markdown::Creator.create_all
+  require "cli_markdown_jets"
+  CliMarkdown::Creator.new.create_all
 end
 
 # Thanks: https://docs.ruby-lang.org/en/2.1.0/RDoc/Task.html
@@ -21,4 +22,3 @@ require 'jets/rdoc'
 RDoc::Task.new do |rdoc|
   rdoc.options += Jets::Rdoc.options
 end
-

data/engines/internal/app/controllers/jets/application_controller.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+class Jets::ApplicationController < Jets::Controller::Base # :nodoc:
+  prepend_view_path File.expand_path("../../../app/views", __dir__)
+  layout "application"
+
+  before_action :disable_content_security_policy_nonce!
+
+  content_security_policy do |policy|
+    policy.script_src :self, :unsafe_inline
+    policy.style_src :self, :unsafe_inline
+  end
+
+  private
+    def require_local!
+      unless local_request?
+        render html: "<p>For security purposes, this information is only available to local requests.</p>".html_safe, status: :forbidden
+      end
+    end
+
+    def local_request?
+      Jets.application.config.consider_all_requests_local || request.local?
+    end
+
+    def disable_content_security_policy_nonce!
+      request.content_security_policy_nonce_generator = nil
+    end
+end

data/engines/internal/app/controllers/jets/bare_controller.rb

@@ -0,0 +1,6 @@
+# Parent class for MountController
+class Jets::BareController < Jets::Controller::Base
+  layout false
+  abstract!
+  skip_forgery_protection
+end

data/engines/internal/app/controllers/jets/health_controller.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module Jets
+  # Built-in Health Check Endpoint
+  #
+  # \Jets also comes with a built-in health check endpoint that is reachable at
+  # the +/up+ path. This endpoint will return a 200 status code if the app has
+  # booted with no exceptions, and a 500 status code otherwise.
+  #
+  # In production, many applications are required to report their status upstream,
+  # whether it's to an uptime monitor that will page an engineer when things go
+  # wrong, or a load balancer or Kubernetes controller used to determine a pod's
+  # health. This health check is designed to be a one-size fits all that will work
+  # in many situations.
+  #
+  # While any newly generated \Jets applications will have the health check at
+  # +/up+, you can configure the path to be anything you'd like in your
+  # <tt>"config/routes.rb"</tt>:
+  #
+  #   Jets.application.routes.draw do
+  #     get "healthz" => "jets/health#show", as: :jets_health_check
+  #   end
+  #
+  # The health check will now be accessible via the +/healthz+ path.
+  #
+  # NOTE: This endpoint does not reflect the status of all of your application's
+  # dependencies, such as the database or redis cluster. Replace
+  # <tt>"jets/health#show"</tt> with your own controller action if you have
+  # application specific needs.
+  #
+  # Think carefully about what you want to check as it can lead to situations
+  # where your application is being restarted due to a third-party service going
+  # bad. Ideally, you should design your application to handle those outages
+  # gracefully.
+  class HealthController < Jets::Controller::Base
+    rescue_from(Exception) { render_down }
+
+    def show
+      render_up
+    end
+
+    private
+      def render_up
+        render html: html_status(color: "green")
+      end
+
+      def render_down
+        render html: html_status(color: "red"), status: 500
+      end
+
+      def html_status(color:)
+        %(<!DOCTYPE html><html><body style="background-color: #{color}"></body></html>).html_safe
+      end
+  end
+end

data/engines/internal/app/controllers/jets/info_controller.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+class Jets::InfoController < Jets::ApplicationController # :nodoc:
+  prepend_view_path ActionDispatch::DebugView::RESCUES_TEMPLATE_PATH
+  layout -> { request.xhr? ? false : "application" }
+
+  before_action :require_local!
+
+  def index
+    redirect_to action: :routes
+  end
+
+  def properties
+    @info = Jets::Info.to_html
+    @page_title = "Properties"
+  end
+
+  def routes
+    if path = params[:path]
+      path = URI::DEFAULT_PARSER.escape path
+      normalized_path = with_leading_slash path
+      render json: {
+        exact: match_route { |it| it.match normalized_path },
+        fuzzy: match_route { |it| it.spec.to_s.match path }
+      }
+    else
+      @routes_table = routes_table
+      @page_title = "Routes"
+    end
+  end
+
+  private
+    def routes_table
+      text = Jets::Router::Help.new(format: "markdown").text
+      Kramdown::Document.new(text).to_html
+    end
+
+    def match_route
+      _routes.routes.filter_map { |route| route.path.spec.to_s if yield route.path }
+    end
+
+    def with_leading_slash(path)
+      ("/" + path).squeeze("/")
+    end
+end

data/{lib/jets → engines}/internal/app/controllers/jets/mailers_controller.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
 
 class Jets::MailersController < Jets::Controller::Base # :nodoc:
+  around_action :set_locale, only: :preview
   before_action :find_preview, only: [:preview]
-  before_action :set_locale, only: [:preview]
-  # TODO: allow multiple actions
-  # before_action :find_preview, :set_locale, only: :preview
+  before_action :require_local!, unless: :show_previews?
 
-  # TODO: add helper_method support
-  # helper_method :part_query, :locale_query
+  helper_method :part_query, :locale_query
 
-  # TODO: content_security_policy
-  # content_security_policy(false)
+  content_security_policy(false)
 
   def index
     @previews = ActionMailer::Preview.all
@@ -20,25 +17,26 @@ class Jets::MailersController < Jets::Controller::Base # :nodoc:
   def preview
     if params[:path] == @preview.preview_name
       @page_title = "Mailer Previews for #{@preview.preview_name}"
-      render :mailer
+      render action: "mailer"
     else
       @email_action = File.basename(params[:path])
 
       if @preview.email_exists?(@email_action)
+        @page_title = "Mailer Preview for #{@preview.preview_name}##{@email_action}"
         @email = @preview.call(@email_action, params)
 
         if params[:part]
           part_type = Mime::Type.lookup(params[:part])
 
           if part = find_part(part_type)
-            response.headers["Content-Type"] = params[:part]
+            response.content_type = part_type
             render plain: part.respond_to?(:decoded) ? part.decoded : part
           else
             raise AbstractController::ActionNotFound, "Email part '#{part_type}' not found in #{@preview.name}##{@email_action}"
           end
         else
-          @part = find_preferred_part(Mime[:html], Mime[:text])
-          render :email, layout: false, formats: %w[html]
+          @part = find_preferred_part(request.format, Mime[:html], Mime[:text])
+          render action: "email", layout: false, formats: [:html]
         end
       else
         raise AbstractController::ActionNotFound, "Email '#{@email_action}' not found in #{@preview.name}"
@@ -53,7 +51,7 @@ class Jets::MailersController < Jets::Controller::Base # :nodoc:
 
     def find_preview # :doc:
       candidates = []
-      params[:path].to_s.scan(%r{/|$}) { candidates << $` } # ` # hack to fix syntax highlighting
+      params[:path].to_s.scan(%r{/|$}) { candidates << $` }
       preview = candidates.detect { |candidate| ActionMailer::Preview.exists?(candidate) }
 
       if preview
@@ -91,7 +89,7 @@ class Jets::MailersController < Jets::Controller::Base # :nodoc:
       request.query_parameters.merge(locale: locale).to_query
     end
 
-    def set_locale
-      I18n.locale = params[:locale] || I18n.default_locale
+    def set_locale(&block)
+      I18n.with_locale(params[:locale] || I18n.default_locale, &block)
     end
 end

data/{lib/jets → engines}/internal/app/controllers/jets/mount_controller.rb

@@ -15,11 +15,8 @@ class Jets::MountController < Jets::BareController
 
     status, headers, io = mount_class.call(env)
     body = read_body(io)
-    render(
-      status: status,
-      headers: headers,
-      body: body,
-    )
+    self.headers.merge!(headers)
+    render body: body, status: status
   end
 
 private
@@ -32,15 +29,14 @@ private
     result.join
   end
 
-  # Locally Jets::Router::Finder gets called twice because it also gets called in Jets::Controller::Middleware::Local
-  # On Lambda, Jets::Router::Finder only gets called once.
-  # TODO: Maybe add caching improvement.
+  # Locally Jets::Router::Matcher gets called in Jets::Controller::Middleware::Mimic
+  # On Lambda, Jets::Router::Matcher in handlers.
   def find_route
-    Jets::Router::Finder.new(event["path"], "ANY").run
+    Jets::Router::Matcher.new.find_by_request(request, "ANY")
   end
 
   def build_env(path)
-    env = Jets::Controller::Rack::Env.new(event, context, adapter: true).convert
+    env = Jets::Controller::RackAdapter::Env.new(event, context, adapter: true).convert
     # remap path info
     mount_at = mount_at(path)
     path_info = env["PATH_INFO"]

data/{lib/jets → engines}/internal/app/controllers/jets/public_controller.rb

@@ -3,7 +3,6 @@ require "mini_mime"
 
 class Jets::PublicController < Jets::Controller::Base
   layout false
-  internal true
 
   def show
     catchall = params[:catchall].blank? ? 'index.html' : params[:catchall]
@@ -25,7 +24,12 @@ class Jets::PublicController < Jets::Controller::Base
         render file: catchall_path, content_type: content_type
       end
     else
-      render file: "#{public_path}/404", status: 404
+      not_found_path = "#{public_path}/404.html"
+      if File.exist?(not_found_path)
+        render file: not_found_path, status: 404
+      else
+        render plain: "404 Not Found", status: 404
+      end
     end
   end
 end

data/engines/internal/app/controllers/jets/welcome_controller.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class Jets::WelcomeController < Jets::ApplicationController # :nodoc:
+  skip_forgery_protection
+  layout false
+
+  def index
+  end
+end

data/{lib/jets → engines}/internal/app/functions/jets/base_path.rb

@@ -3,7 +3,8 @@ begin
   # When require bundler/setup fails, AWS Lambda won't be able to load base_path_mapping
   # So we'll require base_path_mapping within begin/rescue block so that it does not also
   # fail the entire lambda function.
-  require 'jets/internal/app/functions/jets/base_path_mapping'
+  # require 'jets/internal/app/functions/jets/base_path_mapping'
+  require_relative "base_path_mapping"
 rescue Exception => e
   # Note: rescue LoadError is not enough in AWS Lambda environment
   # Actual exceptions:

data/{lib/jets → engines}/internal/app/functions/jets/base_path_mapping.rb

@@ -66,6 +66,7 @@ class BasePathMapping
     }
     puts "BasePathMapping delete options #{options.inspect}"
     apigateway.delete_base_path_mapping(options)
+    wait_for_delete
     puts "BasePathMapping delete complete"
   # https://github.com/tongueroo/jets/issues/255
   # Used to return: Aws::APIGateway::Errors::NotFoundException
@@ -75,6 +76,24 @@ class BasePathMapping
     raise(e) unless fail_silently
   end
 
+  # Wait for deletion to complete
+  # Otherwise, CloudFormation continues too fast during a `jets delete`
+  # and the initially fails deletion. CloudFormaton then retries until it's successfully.
+  # The stack ultimately finishes deleting successfully but the error messages
+  # are confusing to the user.
+  def wait_for_delete
+    loop do
+      resp = apigateway.get_base_path_mapping(
+        domain_name: domain_name,
+        base_path: base_path.empty? ? '(none)' : base_path,
+      )
+      break if resp.nil? || resp.empty?
+      sleep(5)
+    end
+  rescue Aws::APIGateway::Errors::NotFoundException
+    nil
+  end
+
   def create
     puts "BasePathMapping create"
     options = {
@@ -113,8 +132,8 @@ class BasePathMapping
     raise(e)
   end
 
-  def deployment_stack
-    @deployment_stack ||= cfn.describe_stacks(stack_name: @event['StackId']).stacks.first
+  def mapping_stack
+    @mapping_stack ||= cfn.describe_stacks(stack_name: @event['StackId']).stacks.first
   end
 
   def rest_api_id
@@ -130,7 +149,8 @@ class BasePathMapping
   end
 
   def parameter_value(parameter_key)
-    param = deployment_stack[:parameters].find { |p| p.parameter_key == parameter_key }
+    puts "mapping_stack #{mapping_stack.inspect}"
+    param = mapping_stack[:parameters].find { |p| p.parameter_key == parameter_key }
     param&.parameter_value # possible for this to be nil when removing the config: IE: config.domain.name = nil
   end
 
@@ -140,7 +160,7 @@ class BasePathMapping
   end
 
   def parent_stack_name
-    deployment_stack[:root_id]
+    mapping_stack[:root_id]
   end
 
   def apigateway
@@ -166,6 +186,6 @@ end
 
 if __FILE__ == $0
   event = JSON.load(File.read(ARGV[0]))
-  context = nil # stub out
-  BasePathMapping.new(event, context).update
+  stage_name = 'dev' # change to test
+  BasePathMapping.new(event, stage_name).update
 end