jets 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6885ae6e6c06e0dc4815590b04ddc1e7e969d214529bdc4ba50491d8bc9a1c6d
-  data.tar.gz: 619992a70dfef925eaccbd72f0d8b75755fd7be95633b34195230b5af1c7a9d3
+  metadata.gz: fffc1bee1f24ec886725f284f26c2876833048efa0596536155b87fddd38bce3
+  data.tar.gz: 32493191db6f88d33d95a7927e5723ef85b949eb511f59089b39df0e8352b064
 SHA512:
-  metadata.gz: 20d3ea20af1a36c7faf4d224350b15fcbbb7892469e2976e129746a7768b6f10e500791ed5c4076beebad09e2db03a456e03ebaee7077fe95c7fdf5925348629
-  data.tar.gz: 1372624f0be64e02884e0524abcfadefcc1a76d644e28b77b4d8566e4330e64bf14e28b7f676b49ac923aefbacd11fb58b7b6155e301dee7990a59badef52cf2
+  metadata.gz: 75655e94fc346815891d7c0f5825272c3f247442930ab16e3418f5fb0b3856c5ae32560469137f94138f3f2b9ea313186d3d9c09af6c09d5672ecb882d3d3c11
+  data.tar.gz: 026c25491b0762085122a7e45b649d4b36d2a3c9ff51ea791c769ba4ae64e30c083946c2f775a254405bb977055829cdbc2836366d29b9ee823494b06030b781

data/CHANGELOG.md

@@ -3,12 +3,24 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/), even before v1.0.
 
+## [1.5.2]
+- #138 from patchkit-net/feature/before_action_chain_break Change before_action behavior: allow chain break
+- #139 from patchkit-net/bugfix/spec-gem-files-dir Fix jets.gemspec files listing method
+- #140 from patchkit-net/feature/config-logger Add configurable Jets.application.config.logger
+- Change before_action behavior: When any before action renders or redirects, the filter chain
+  is halted, and action code is not executed. This allows before_action to act as guards.
+- Fix jets.gemspec how git command is executed to list files. The listing no longer needs to be done
+  from the jets root directory. This change enables including Jets as local bundler gem.
+- Add Jets.application.config.logger field to enable custom logger instance to
+  be configured in config/environments/*.rb files.
+- Fix scaffold ajax redirect url
+
 ## [1.5.1]
 - #137 from tongueroo/gems-check bypass gems check exit for custom lambda layers
 
 ## [1.5.0]
 - #135 from tongueroo/remove-rails-constant Remove Rails Constant
-- #136 from tongueroo/routes-namespace routes namespace support (ghost release, not documented yet on purpose)
+- #136 from tongueroo/routes-namespace routes namespace support
 
 ## [1.4.11]
 - #133 from tongueroo/custom-layer add custom lambda layer support

data/Gemfile.lock

@@ -11,7 +11,7 @@ GIT
 PATH
   remote: .
   specs:
-    jets (1.5.1)
+    jets (1.5.2)
       activerecord (>= 5.2.1)
       activesupport (>= 5.2.1)
       aws-sdk-apigateway
@@ -76,7 +76,7 @@ GEM
     aws-sdk-cloudwatchlogs (1.12.0)
       aws-sdk-core (~> 3, >= 3.39.0)
       aws-sigv4 (~> 1.0)
-    aws-sdk-core (3.44.2)
+    aws-sdk-core (3.45.0)
       aws-eventstream (~> 1.0)
       aws-partitions (~> 1.0)
       aws-sigv4 (~> 1.0)
@@ -90,7 +90,7 @@ GEM
     aws-sdk-lambda (1.16.0)
       aws-sdk-core (~> 3, >= 3.39.0)
       aws-sigv4 (~> 1.0)
-    aws-sdk-s3 (1.30.0)
+    aws-sdk-s3 (1.30.1)
       aws-sdk-core (~> 3, >= 3.39.0)
       aws-sdk-kms (~> 1)
       aws-sigv4 (~> 1.0)
@@ -108,7 +108,7 @@ GEM
     crass (1.0.4)
     diff-lcs (1.3)
     dotenv (2.6.0)
-    dynomite (1.1.1)
+    dynomite (1.2.0)
       activesupport
       aws-sdk-dynamodb
     erubi (1.8.0)

data/jets.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.rdoc_options += Jets::Rdoc.options
 
   vendor_files       = Dir.glob("vendor/**/*")
-  gem_files          = `git ls-files -z`.split("\x0").reject do |f|
+  gem_files          = `git -C "#{File.dirname(__FILE__)}" ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features|docs)/})
   end
   spec.files         = gem_files + vendor_files

data/lib/jets/application.rb

@@ -35,6 +35,7 @@ class Jets::Application
     config.cors = true
     config.autoload_paths = default_autoload_paths
     config.extra_autoload_paths = []
+    config.logger = Jets::Logger.new($stderr)
 
     # function properties defaults
     config.function = ActiveSupport::OrderedOptions.new

data/lib/jets/commands/templates/skeleton/config/application.rb.tt

@@ -58,4 +58,9 @@ Jets.application.configure do
   # us-east-1 EDGE endpoint
   # config.domain.cert_arn = "arn:aws:acm:us-east-1:112233445566:certificate/d68472ba-04f8-45ba-b9db-14f839d57123"
   # config.domain.endpoint_type = "EDGE"
+
+  # By default logger needs to log to $stderr for CloudWatch to receive Lambda messages, but for
+  # local testing environment you may want to log these messages to 'test.log' file to keep your
+  # testing suite output readable.
+  # config.logger = Jets::Logger.new($strerr)
 end

data/lib/jets/controller/base.rb

@@ -37,10 +37,14 @@ class Jets::Controller
       t1 = Time.now
       log_info_start
 
-      run_before_actions
-      send(@meth)
-      triplet = ensure_render
-      run_after_actions
+      if run_before_actions(break_if: -> { @rendered })
+        send(@meth)
+        triplet = ensure_render
+        run_after_actions
+      else
+        Jets.logger.info "Filter chain halted as #{@last_callback_name} rendered or redirected"
+        triplet = ensure_render
+      end
 
       took = Time.now - t1
       status = triplet[0]

data/lib/jets/controller/callbacks.rb

@@ -20,8 +20,9 @@ class Jets::Controller
 
     # Instance Methods
     # define run_before_actions and run_after_actions
+    # returns true if all actions were run, false if break_if condition yielded `true`
     [:before, :after].each do |type|
-      define_method "run_#{type}_actions" do
+      define_method "run_#{type}_actions" do |break_if: nil|
         called_method = @meth.to_sym
         callbacks = self.class.send("#{type}_actions")
         callbacks.each do |array|
@@ -36,7 +37,11 @@ class Jets::Controller
           else
             send(callback)
           end
+          @last_callback_name = callback
+
+          return false if !break_if.nil? && break_if.call
         end
+        true
       end
     end
   end # ClassOptions

data/lib/jets/core.rb

@@ -42,7 +42,7 @@ module Jets::Core
   memoize :build_root
 
   def logger
-    Jets::Logger.new($stderr)
+    Jets.application.config.logger
   end
   memoize :logger
 

data/lib/jets/generator/templates/rails/scaffold_controller/controller.rb

@@ -30,7 +30,7 @@ class <%= controller_class_name %>Controller < ApplicationController
 
     if @<%= orm_instance.save %>
       if request.xhr?
-        render json: {success: true, location: url_for("/<%= plural_table_name %>/#@{<%= singular_table_name %>.id}")}
+        render json: {success: true, location: url_for("/<%= plural_table_name %>/#{@<%= singular_table_name %>.id}")}
       else
         redirect_to "/<%= plural_table_name %>/#{@<%= singular_table_name %>.id}"
       end
@@ -43,7 +43,7 @@ class <%= controller_class_name %>Controller < ApplicationController
   def update
     if @<%= orm_instance.update("#{singular_table_name}_params") %>
       if request.xhr?
-        render json: {success: true, location: url_for("/<%= plural_table_name %>/#@{<%= singular_table_name %>.id}")}
+        render json: {success: true, location: url_for("/<%= plural_table_name %>/#{@<%= singular_table_name %>.id}")}
       else
         redirect_to "/<%= plural_table_name %>/#{@<%= singular_table_name %>.id}"
       end

data/lib/jets/version.rb

@@ -1,3 +1,3 @@
 module Jets
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jets
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-11 00:00:00.000000000 Z
+date: 2019-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord