jets-gems 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24939370b906b38f2a866ef99ef40d0dae0b24ad8e4b123f109aebdddc509cb0
-  data.tar.gz: d46de1b1dd659bf4d4a17e2bfa806ab19d71efb9c7d60de029c2b0f4d381ae96
+  metadata.gz: e3900daa6e68d0711a454fd08be5d54fda92c5e708487adb6ce4858d28eed650
+  data.tar.gz: f91d1570dd62554d97ed3829cd921341f37581341146aef51c1927fa4752c5a9
 SHA512:
-  metadata.gz: 1ece2839d612ee13f68675d849e1b593534afd5bbfaa3c38f0f228ce4ce07e417fe3cce47e231cadbfd9ff3bde3b319bde08df42ca3f234c7b686eb6d57beefc
-  data.tar.gz: 011fa4f8ff8357f51fd2f94b3332ba2ba069b1feb8e3fd887acbd65d5e2fb48c17f5ac064fa256e27d2ff012972c6c7e19c997add9845873d50857b401427a89
+  metadata.gz: 8882ef6371603fd9e87b3baccd182e39598f04d0039a21f62cdfcd52cfa7152d0c895eb903cf7381f96f84c73f3b2bb1e499252c9c17a69bbfdd79872736f7b1
+  data.tar.gz: 52c29cd14d0ee088172cde2d74c8a76b821fb21c2425ac02c8f23e84746e9e2976bd386a27933a2079602c392617c965e66073c9cfe91b9429f9769c9700c460

data/CHANGELOG.md

@@ -3,6 +3,9 @@
 All notable changes to this project will be documented in this file.
 This project *loosely tries* to adhere to [Semantic Versioning](http://semver.org/).
 
+## [0.2.2]
+- #3 fix for afterburner mode, change option to use_gemspec
+
 ## [0.2.1]
 - #2 improve compiled gem detection
 

data/lib/jets/gems/check.rb

@@ -119,12 +119,61 @@ EOL
     #     * Went to selective checking approach with `cli: true` option. This helped gather more data.
     #       * jets deploy - compiled_gem_paths
     #       * jets gems:check - gemspec_compiled_gems
-    #     * Going back to compiled_gem_paths with.
+    #     * Going back to compiled_gem_paths with:
     #       * Using the `weird_gem?` check to filter out gems removed by bundler. Note: Only happens with specific versions of json.
-    #       * Removed compiled_gem_paths and compiled_gem_paths methods. Can get it from git history if needed again.
+    #     * Keeping compiled_gem_paths for Jets Afterburner mode. Default to gemspec_compiled_gems otherwise
+    #
     #
     def compiled_gems
-      gemspec_compiled_gems
+      # @use_gemspec option  finds compile gems with Gem::Specification
+      # The normal build process does not use this and checks the file system.
+      # So @use_gemspec is only used for this command:
+      #
+      #   jets gems:check
+      #
+      # This is because it seems like some gems like json are remove and screws things up.
+      # We'll filter out for the json gem as a hacky workaround, unsure if there are more
+      # gems though that exhibit this behavior.
+      if @options[:use_gemspec] == false
+        # Afterburner mode
+        compiled_gems = compiled_gem_paths.map { |p| gem_name_from_path(p) }.uniq
+        # Double check that the gems are also in the gemspec list since that
+        # one is scoped to Bundler and will only included gems used in the project.
+        # This handles the possiblity of stale gems leftover from previous builds
+        # in the cache.
+        # TODO: figure out if we need
+        # compiled_gems.select { |g| gemspec_compiled_gems.include?(g) }
+      else
+        # default when use_gemspec not set
+        #
+        #     jets deploy
+        #     jets gems:check
+        #
+        gemspec_compiled_gems
+      end
+    end
+
+    # Use pre-compiled gem because the gem could have development header shared
+    # object file dependencies.  The shared dependencies are packaged up as part
+    # of the pre-compiled gem so it is available in the Lambda execution environment.
+    #
+    # Example paths:
+    # Macosx:
+    #   opt/ruby/gems/2.5.0/extensions/x86_64-darwin-16/2.5.0-static/nokogiri-1.8.1
+    #   opt/ruby/gems/2.5.0/extensions/x86_64-darwin-16/2.5.0-static/byebug-9.1.0
+    # Official AWS Lambda Linux AMI:
+    #   opt/ruby/gems/2.5.0/extensions/x86_64-linux/2.5.0-static/nokogiri-1.8.1
+    # Circleci Ubuntu based Linux:
+    #   opt/ruby/gems/2.5.0/extensions/x86_64-linux/2.5.0/pg-0.21.0
+    def compiled_gem_paths
+      Dir.glob("#{Jets.build_root}/stage/opt/ruby/gems/*/extensions/**/**/*.{so,bundle}")
+    end
+
+    # Input: opt/ruby/gems/2.5.0/extensions/x86_64-darwin-16/2.5.0-static/byebug-9.1.0
+    # Output: byebug-9.1.0
+    def gem_name_from_path(path)
+      regexp = %r{opt/ruby/gems/\d+\.\d+\.\d+/extensions/.*?/.*?/(.*?)/}
+      path.match(regexp)[1] # gem_name
     end
 
     # So can also check for compiled gems with Gem::Specification

data/lib/jets/gems/version.rb

@@ -1,5 +1,5 @@
 module Jets
   module Gems
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jets-gems
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Tung Nguyen