jetpacker 0.1.0 → 0.2.0

data/test/dev_server_runner_test.rb

@@ -0,0 +1,51 @@
+require "test_helper"
+require "webpacker/dev_server_runner"
+
+class DevServerRunnerTest < Webpacker::Test
+  def setup
+    @original_node_env, ENV["NODE_ENV"] = ENV["NODE_ENV"], "development"
+    @original_rails_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "development"
+  end
+
+  def teardown
+    ENV["NODE_ENV"] = @original_node_env
+    ENV["RAILS_ENV"] = @original_rails_env
+  end
+
+  def test_run_cmd_via_node_modules
+    cmd = ["#{test_app_path}/node_modules/.bin/webpack-dev-server", "--config", "#{test_app_path}/config/webpack/development.js"]
+
+    verify_command(cmd, use_node_modules: true)
+  end
+
+  def test_run_cmd_via_yarn
+    cmd = ["yarn", "webpack-dev-server", "--config", "#{test_app_path}/config/webpack/development.js"]
+
+    verify_command(cmd, use_node_modules: false)
+  end
+
+  private
+    def test_app_path
+      File.expand_path("test_app", __dir__)
+    end
+
+    def verify_command(cmd, use_node_modules: true)
+      cwd = Dir.pwd
+      Dir.chdir(test_app_path)
+
+      klass = Webpacker::DevServerRunner
+      instance = klass.new([])
+      mock = Minitest::Mock.new
+      mock.expect(:call, nil, [{}, *cmd])
+
+      klass.stub(:new, instance) do
+        instance.stub(:node_modules_bin_exist?, use_node_modules) do
+          Kernel.stub(:exec, mock) { klass.run([]) }
+        end
+      end
+
+      mock.verify
+    ensure
+      Dir.chdir(cwd)
+    end
+end

data/test/dev_server_test.rb

@@ -0,0 +1,47 @@
+require "test_helper"
+
+class DevServerTest < Webpacker::Test
+  def test_running?
+    refute Webpacker.dev_server.running?
+  end
+
+  def test_host
+    with_rails_env("development") do
+      assert_equal Webpacker.dev_server.host, "localhost"
+    end
+  end
+
+  def test_port
+    with_rails_env("development") do
+      assert_equal Webpacker.dev_server.port, 3035
+    end
+  end
+
+  def test_https?
+    with_rails_env("development") do
+      assert_equal Webpacker.dev_server.https?, false
+    end
+  end
+
+  def test_protocol
+    with_rails_env("development") do
+      assert_equal Webpacker.dev_server.protocol, "http"
+    end
+  end
+
+  def test_host_with_port
+    with_rails_env("development") do
+      assert_equal Webpacker.dev_server.host_with_port, "localhost:3035"
+    end
+  end
+
+  def test_pretty?
+    with_rails_env("development") do
+      refute Webpacker.dev_server.pretty?
+    end
+  end
+
+  def test_default_env_prefix
+    assert_equal Webpacker::DevServer::DEFAULT_ENV_PREFIX, "WEBPACKER_DEV_SERVER"
+  end
+end

data/test/env_test.rb

@@ -0,0 +1,23 @@
+require "test_helper"
+
+class EnvTest < Webpacker::Test
+  def test_current
+    assert_equal Webpacker.env, Rails.env
+  end
+
+  def test_custom_without_config
+    with_rails_env("foo") do
+      assert_equal Webpacker.env, "production"
+    end
+  end
+
+  def test_custom_with_config
+    with_rails_env("staging") do
+      assert_equal Webpacker.env, "staging"
+    end
+  end
+
+  def test_default
+    assert_equal Webpacker::Env::DEFAULT, "production"
+  end
+end

data/test/helper_test.rb

@@ -0,0 +1,142 @@
+require "test_helper"
+
+class HelperTest < ActionView::TestCase
+  tests Webpacker::Helper
+
+  attr_reader :request
+
+  def setup
+    @request = Class.new do
+      def send_early_hints(links) end
+      def base_url
+        "https://example.com"
+      end
+    end.new
+  end
+
+  def test_asset_pack_path
+    assert_equal "/packs/bootstrap-300631c4f0e0f9c865bc.js", asset_pack_path("bootstrap.js")
+    assert_equal "/packs/bootstrap-c38deda30895059837cf.css", asset_pack_path("bootstrap.css")
+
+    Webpacker.config.stub :extract_css?, false do
+      assert_nil asset_pack_path("bootstrap.css")
+      assert_equal "/packs/application-k344a6d59eef8632c9d1.png", asset_pack_path("application.png")
+    end
+  end
+
+  def test_asset_pack_url
+    assert_equal "https://example.com/packs/bootstrap-300631c4f0e0f9c865bc.js", asset_pack_url("bootstrap.js")
+    assert_equal "https://example.com/packs/bootstrap-c38deda30895059837cf.css", asset_pack_url("bootstrap.css")
+
+    Webpacker.config.stub :extract_css?, false do
+      assert_nil asset_pack_path("bootstrap.css")
+      assert_equal "https://example.com/packs/application-k344a6d59eef8632c9d1.png", asset_pack_url("application.png")
+    end
+  end
+
+  def test_image_pack_tag
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/application-k344a6d59eef8632c9d1.png\" width=\"16\" height=\"10\" />",
+      image_pack_tag("application.png", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("image.jpg", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("media/images/image.jpg", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("nested/image.jpg", size: "16x10", alt: "Edit Entry")
+    assert_equal \
+      "<img alt=\"Edit Entry\" src=\"/packs/media/images/nested/image-c38deda30895059837cf.jpg\" width=\"16\" height=\"10\" />",
+      image_pack_tag("media/images/nested/image.jpg", size: "16x10", alt: "Edit Entry")
+  end
+
+  def test_favicon_pack_tag
+    assert_equal \
+      "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/application-k344a6d59eef8632c9d1.png\" />",
+      favicon_pack_tag("application.png", rel: "apple-touch-icon", type: "image/png")
+    assert_equal \
+      "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/media/images/mb-icon-c38deda30895059837cf.png\" />",
+      favicon_pack_tag("mb-icon.png", rel: "apple-touch-icon", type: "image/png")
+    assert_equal \
+      "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/media/images/mb-icon-c38deda30895059837cf.png\" />",
+      favicon_pack_tag("media/images/mb-icon.png", rel: "apple-touch-icon", type: "image/png")
+    assert_equal \
+      "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/media/images/nested/mb-icon-c38deda30895059837cf.png\" />",
+      favicon_pack_tag("nested/mb-icon.png", rel: "apple-touch-icon", type: "image/png")
+    assert_equal \
+      "<link rel=\"apple-touch-icon\" type=\"image/png\" href=\"/packs/media/images/nested/mb-icon-c38deda30895059837cf.png\" />",
+      favicon_pack_tag("media/images/nested/mb-icon.png", rel: "apple-touch-icon", type: "image/png")
+  end
+
+  def test_javascript_pack_tag
+    assert_equal \
+      %(<script src="/packs/bootstrap-300631c4f0e0f9c865bc.js"></script>),
+      javascript_pack_tag("bootstrap.js")
+  end
+
+  def test_javascript_pack_tag_symbol
+    assert_equal \
+      %(<script src="/packs/bootstrap-300631c4f0e0f9c865bc.js"></script>),
+      javascript_pack_tag(:bootstrap)
+  end
+
+  def test_javascript_pack_tag_splat
+    assert_equal \
+      %(<script src="/packs/bootstrap-300631c4f0e0f9c865bc.js" defer="defer"></script>\n) +
+        %(<script src="/packs/application-k344a6d59eef8632c9d1.js" defer="defer"></script>),
+      javascript_pack_tag("bootstrap.js", "application.js", defer: true)
+  end
+
+  def test_javascript_pack_tag_split_chunks
+    assert_equal \
+      %(<script src="/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js"></script>\n) +
+        %(<script src="/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js"></script>\n) +
+        %(<script src="/packs/application-k344a6d59eef8632c9d1.js"></script>),
+      javascript_packs_with_chunks_tag("application")
+  end
+
+  def test_preload_pack_asset
+    if self.class.method_defined?(:preload_link_tag)
+      assert_equal \
+        %(<link rel="preload" href="/packs/fonts/fa-regular-400-944fb546bd7018b07190a32244f67dc9.woff2" as="font" type="font/woff2" crossorigin="anonymous">),
+        preload_pack_asset("fonts/fa-regular-400.woff2")
+    else
+      error = assert_raises do
+        preload_pack_asset("fonts/fa-regular-400.woff2")
+      end
+
+      assert_equal \
+        "You need Rails >= 5.2 to use this tag.",
+        error.message
+    end
+  end
+
+  def test_stylesheet_pack_tag_split_chunks
+    assert_equal \
+      %(<link rel="stylesheet" media="screen" href="/packs/1-c20632e7baf2c81200d3.chunk.css" />\n) +
+        %(<link rel="stylesheet" media="screen" href="/packs/application-k344a6d59eef8632c9d1.chunk.css" />\n) +
+        %(<link rel="stylesheet" media="screen" href="/packs/hello_stimulus-k344a6d59eef8632c9d1.chunk.css" />),
+      stylesheet_packs_with_chunks_tag("application", "hello_stimulus")
+  end
+
+  def test_stylesheet_pack_tag
+    assert_equal \
+      %(<link rel="stylesheet" media="screen" href="/packs/bootstrap-c38deda30895059837cf.css" />),
+      stylesheet_pack_tag("bootstrap.css")
+  end
+
+  def test_stylesheet_pack_tag_symbol
+    assert_equal \
+      %(<link rel="stylesheet" media="screen" href="/packs/bootstrap-c38deda30895059837cf.css" />),
+      stylesheet_pack_tag(:bootstrap)
+  end
+
+  def test_stylesheet_pack_tag_splat
+    assert_equal \
+      %(<link rel="stylesheet" media="all" href="/packs/bootstrap-c38deda30895059837cf.css" />\n) +
+        %(<link rel="stylesheet" media="all" href="/packs/application-dd6b1cd38bfa093df600.css" />),
+      stylesheet_pack_tag("bootstrap.css", "application.css", media: "all")
+  end
+end

data/test/manifest_test.rb

@@ -0,0 +1,42 @@
+require "test_helper"
+
+class ManifestTest < Minitest::Test
+  def test_lookup_exception!
+    manifest_path = File.expand_path File.join(File.dirname(__FILE__), "test_app/public/packs", "manifest.json").to_s
+    asset_file = "calendar.js"
+
+    Webpacker.config.stub :compile?, false do
+      error = assert_raises Webpacker::Manifest::MissingEntryError do
+        Webpacker.manifest.lookup!(asset_file)
+      end
+
+      assert_match "Webpacker can't find #{asset_file} in #{manifest_path}", error.message
+    end
+  end
+
+  def test_lookup_success!
+    assert_equal Webpacker.manifest.lookup!("bootstrap.js"), "/packs/bootstrap-300631c4f0e0f9c865bc.js"
+  end
+
+  def test_lookup_nil
+    assert_nil Webpacker.manifest.lookup("foo.js")
+  end
+
+  def test_lookup_chunks_nil
+    assert_nil Webpacker.manifest.lookup_pack_with_chunks("foo.js")
+  end
+
+  def test_lookup_success
+    assert_equal Webpacker.manifest.lookup("bootstrap.js"), "/packs/bootstrap-300631c4f0e0f9c865bc.js"
+  end
+
+  def test_lookup_entrypoint
+    application_entrypoints = [
+      "/packs/vendors~application~bootstrap-c20632e7baf2c81200d3.chunk.js",
+      "/packs/vendors~application-e55f2aae30c07fb6d82a.chunk.js",
+      "/packs/application-k344a6d59eef8632c9d1.js"
+    ]
+
+    assert_equal Webpacker.manifest.lookup_pack_with_chunks!("application", type: :javascript), application_entrypoints
+  end
+end

data/test/rake_tasks_test.rb

@@ -0,0 +1,69 @@
+require "test_helper"
+
+class RakeTasksTest < Minitest::Test
+  def test_rake_tasks
+    output = Dir.chdir(test_app_path) { `rake -T` }
+    assert_includes output, "webpacker"
+    assert_includes output, "webpacker:check_binstubs"
+    assert_includes output, "webpacker:check_node"
+    assert_includes output, "webpacker:check_yarn"
+    assert_includes output, "webpacker:clean"
+    assert_includes output, "webpacker:clobber"
+    assert_includes output, "webpacker:compile"
+    assert_includes output, "webpacker:install"
+    assert_includes output, "webpacker:install:angular"
+    assert_includes output, "webpacker:install:coffee"
+    assert_includes output, "webpacker:install:elm"
+    assert_includes output, "webpacker:install:erb"
+    assert_includes output, "webpacker:install:react"
+    assert_includes output, "webpacker:install:svelte"
+    assert_includes output, "webpacker:install:stimulus"
+    assert_includes output, "webpacker:install:typescript"
+    assert_includes output, "webpacker:install:vue"
+    assert_includes output, "webpacker:verify_install"
+  end
+
+  def test_rake_task_webpacker_check_binstubs
+    output = Dir.chdir(test_app_path) { `rake webpacker:check_binstubs 2>&1` }
+    refute_includes output, "webpack binstubs not found."
+  end
+
+  def test_rake_webpacker_yarn_install_in_non_production_environments
+    assert_includes test_app_dev_dependencies, "right-pad"
+
+    Webpacker.with_node_env("test") do
+      Dir.chdir(test_app_path) do
+        `bundle exec rake webpacker:yarn_install`
+      end
+    end
+
+    assert_includes installed_node_module_names, "right-pad",
+                    "Expected dev dependencies to be installed"
+  end
+
+  def test_rake_webpacker_yarn_install_in_production_environment
+    Webpacker.with_node_env("production") do
+      Dir.chdir(test_app_path) do
+        `bundle exec rake webpacker:yarn_install`
+      end
+    end
+
+    refute_includes installed_node_module_names, "right-pad",
+                    "Expected only production dependencies to be installed"
+  end
+
+  private
+    def test_app_path
+      File.expand_path("test_app", __dir__)
+    end
+
+    def test_app_dev_dependencies
+      package_json = File.expand_path("package.json", test_app_path)
+      JSON.parse(File.read(package_json))["devDependencies"]
+    end
+
+    def installed_node_module_names
+      node_modules_path = File.expand_path("node_modules", test_app_path)
+      Dir.chdir(node_modules_path) { Dir.glob("*") }
+    end
+end

data/test/test_app/Rakefile

@@ -0,0 +1,3 @@
+require_relative "config/application"
+
+Rails.application.load_tasks

data/test/test_app/app/javascript/packs/application.js

@@ -0,0 +1,10 @@
+/* eslint no-console:0 */
+// This file is automatically compiled by Webpack, along with any other files
+// present in this directory. You're encouraged to place your actual application logic in
+// a relevant structure within app/javascript and only use these pack files to reference
+// that code so it'll be compiled.
+//
+// To reference this file, add <%= javascript_pack_tag 'application' %> to the appropriate
+// layout file, like app/views/layouts/application.html.erb
+
+console.log('Hello World from Webpacker')

data/test/test_app/bin/webpack

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
+ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require "bundler/setup"
+
+require "webpacker"
+require "webpacker/webpack_runner"
+Webpacker::WebpackRunner.run(ARGV)

data/test/test_app/bin/webpack-dev-server

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+ENV["RAILS_ENV"] ||= ENV["RACK_ENV"] || "development"
+ENV["NODE_ENV"] ||= ENV["RAILS_ENV"]
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+require "bundler/setup"
+
+require "webpacker"
+require "webpacker/dev_server_runner"
+Webpacker::DevServerRunner.run(ARGV)

data/test/test_app/config.ru

@@ -0,0 +1,5 @@
+# This file allows the `Rails.root` to be correctly determined.
+
+require_relative "config/environment"
+
+run Rails.application

data/test/test_app/config/application.rb

@@ -0,0 +1,12 @@
+require "action_controller/railtie"
+require "action_view/railtie"
+require "webpacker"
+
+module TestApp
+  class Application < ::Rails::Application
+    config.secret_key_base = "abcdef"
+    config.eager_load = true
+    config.webpacker.check_yarn_integrity = false
+    config.active_support.test_order = :sorted
+  end
+end