jenkins_pipeline_builder 1.6.0 → 1.10.0

data/spec/lib/jenkins_pipeline_builder/extensions/publishers_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 describe 'publishers' do
   after :each do
@@ -48,16 +48,6 @@ describe 'publishers' do
       expect(additional_properties_value.first.content).to match ''
     end
 
-    it 'populates branch' do
-      params = { publishers: { sonar_result: { branch: 'test' } } }
-
-      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
-
-      sonar_nodes = @n_xml.root.children.first.children
-      branch = sonar_nodes.select { |node| node.name == 'branch' }
-      expect(branch.first.content).to match 'test'
-    end
-
     it 'populates maven installation name' do
       params = { publishers: { sonar_result: { maven_installation_name: 'test' } } }
 
@@ -427,6 +417,33 @@ describe 'publishers' do
     end
   end
 
+  context 'google_chat' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'google-chat-notification' => '0' }
+      )
+    end
+    it 'generates a configuration' do
+      params = { publishers: { google_chat: {} } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      publisher = @n_xml.root.children.first
+      expect(publisher.name).to match 'io.cnaik.GoogleChatNotification'
+      children = publisher.children.map(&:name)
+      expect(children).to include 'url'
+      expect(children).to include 'message'
+      expect(children).to include 'notifyAborted'
+      expect(children).to include 'notifyFailure'
+      expect(children).to include 'notifyNotBuilt'
+      expect(children).to include 'notifySuccess'
+      expect(children).to include 'notifyUnstable'
+      expect(children).to include 'notifyBackToNormal'
+      expect(children).to include 'suppressInfoLoggers'
+      expect(children).to include 'sameThreadNotification'
+    end
+  end
+
   context 'coverage_result' do
     it 'generates a configuration'
   end

data/spec/lib/jenkins_pipeline_builder/extensions/registered_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 WRAPPERS = {
   ansicolor: ['0'],
   artifactory: ['0'],
@@ -27,6 +27,7 @@ PUBLISHERS = {
   git: ['0'],
   github_pr_coverage_status_reporter: ['0'],
   groovy_postbuild: ['0'],
+  google_chat: ['0'],
   hipchat: ['0', '0.1.9', '2.0.0'],
   html_publisher: ['0'],
   junit_result: ['0'],
@@ -69,6 +70,7 @@ JOB_ATTRIBUTES = {
   hipchat: ['0', '2.0.0'],
   inject_env_vars_pre_scm: ['0'],
   parameters: ['0'],
+  google_chat: ['0'],
   shared_workspace: ['0'],
   prepare_environment: ['0'],
   priority: ['0'],

data/spec/lib/jenkins_pipeline_builder/extensions/triggers_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 describe 'triggers' do
   after :each do

data/spec/lib/jenkins_pipeline_builder/extensions/wrappers_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../spec_helper', __FILE__)
+require File.expand_path('../spec_helper', __dir__)
 
 describe 'wrappers' do
   after :each do

data/spec/lib/jenkins_pipeline_builder/extensions_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::Extension do
   subject(:extension) { JenkinsPipelineBuilder::Extension.new }

data/spec/lib/jenkins_pipeline_builder/fixtures/generator_tests/pullrequest_pipeline/project.yaml

@@ -5,6 +5,7 @@
     github_site: 'https://github.com'
     git_org: 'testorg'
     git_repo_name: 'generator_tests'
+    git_branch: 'master'
 
 - project:
     name: PullRequest

data/spec/lib/jenkins_pipeline_builder/generator_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::Generator do
   before :all do
@@ -89,31 +89,52 @@ describe JenkinsPipelineBuilder::Generator do
       expect(errors).to be_empty
     end
 
-    it 'produces no errors while creating pipeline TemplatePipeline' do
-      errors = bootstrap(fixture_path('template_pipeline'), 'TemplatePipeline')
-      expect(errors).to be_empty
-    end
+    context 'when creating pipeline templates' do
+      before(:each) do
+        tar_path = File.join(__dir__, 'fixtures/generator_tests/template_pipeline/jobs.tar.gz')
+        parsed_url = URI.parse('https://www.test.com')
+        file_contents = Zlib::GzipReader.new(File.open(tar_path)).read
+        file_object = double
+        allow(URI).to receive(:parse).and_return(parsed_url)
+        allow(parsed_url).to receive(:open).and_yield('A String')
+        allow(Zlib::GzipReader).to receive(:new).and_return(file_object)
+        allow(file_object).to receive(:read).and_return(file_contents)
+      end
 
-    it 'produces no errors while creating pipeline TemplatePipeline_nested' do
-      errors = bootstrap(fixture_path('template_pipeline_nested'), 'TemplatePipeline_nested')
-      expect(errors).to be_empty
-    end
+      it 'produces no errors while creating pipeline TemplatePipeline' do
+        errors = bootstrap(fixture_path('template_pipeline'), 'TemplatePipeline')
+        expect(errors).to be_empty
+      end
 
-    it 'loads extensions in remote dependencies' do
-      errors = bootstrap(fixture_path('template_pipeline'), 'TemplatePipeline')
-      expect(errors).to be_empty
-      expect(@generator.module_registry.registry[:job][:wrappers].keys).to include :test_wrapper
-      @generator.module_registry.registry[:job][:wrappers].delete(:test_wrapper)
-    end
+      it 'overrides the remote dependencies with local ones' do
+        errors = bootstrap(fixture_path('local_override/remote_and_local'), 'TemplatePipeline')
+        expect(errors).to be_empty
+        expect(@generator.job_collection.collection['{{name}}-10'][:value][:description]).to eq('Overridden stuff')
+      end
 
-    it 'overrides the remote dependencies with local ones' do
-      errors = bootstrap(fixture_path('local_override/remote_and_local'), 'TemplatePipeline')
-      expect(errors).to be_empty
-      expect(@generator.job_collection.collection['{{name}}-10'][:value][:description]).to eq('Overridden stuff')
-    end
+      it 'loads extensions in remote dependencies' do
+        errors = bootstrap(fixture_path('template_pipeline'), 'TemplatePipeline')
+        expect(errors).to be_empty
+        expect(@generator.module_registry.registry[:job][:wrappers].keys).to include :test_wrapper
+        @generator.module_registry.registry[:job][:wrappers].delete(:test_wrapper)
+      end
+
+      it 'fails to override when there are duplicate local items' do
+        expect { bootstrap(fixture_path('local_override/all_local'), 'TemplatePipeline') }.to raise_error(StandardError)
+      end
 
-    it 'fails to override when there are duplicate local items' do
-      expect { bootstrap(fixture_path('local_override/all_local'), 'TemplatePipeline') }.to raise_error(StandardError)
+      it 'produces no errors while creating pipeline TemplatePipeline_nested' do
+        tar_path = File.join(__dir__, 'fixtures/generator_tests/template_pipeline_nested/jobs.tar.gz')
+        parsed_url = URI.parse('https://www.test.com')
+        file_contents = Zlib::GzipReader.new(File.open(tar_path)).read
+        file_object = double
+        allow(URI).to receive(:parse).and_return(parsed_url)
+        allow(parsed_url).to receive(:open).and_yield('A String')
+        allow(Zlib::GzipReader).to receive(:new).and_return(file_object)
+        allow(file_object).to receive(:read).and_return(file_contents)
+        errors = bootstrap(fixture_path('template_pipeline_nested'), 'TemplatePipeline_nested')
+        expect(errors).to be_empty
+      end
     end
 
     # Things to check for:
@@ -133,7 +154,10 @@ describe JenkinsPipelineBuilder::Generator do
       JenkinsPipelineBuilder.registry.registry[:job][:scm_params].clear_installed_version
     end
 
-    let(:path) { File.expand_path('../fixtures/generator_tests/pullrequest_pipeline', __FILE__) }
+    let(:pr_master) { { number: 1, base: 'master' } }
+    let(:pr_not_master) { { number: 2, base: 'not-master' } }
+    let(:open_prs) { [pr_master, pr_not_master] }
+    let(:path) { File.expand_path('fixtures/generator_tests/pullrequest_pipeline', __dir__) }
     it 'produces no errors while creating pipeline PullRequest' do
       job_name = 'PullRequest'
       pr_generator = double('pr_generator')
@@ -145,7 +169,7 @@ describe JenkinsPipelineBuilder::Generator do
         .and_return(pr_generator)
       expect(pr_generator).to receive(:delete_closed_prs)
       expect(pr_generator).to receive(:convert!)
-      expect(pr_generator).to receive(:open_prs).and_return [1]
+      expect(pr_generator).to receive(:open_prs).and_return [pr_master]
       success = @generator.pull_request(path, job_name)
       expect(success).to be_truthy
     end
@@ -161,7 +185,7 @@ describe JenkinsPipelineBuilder::Generator do
         .and_return(pr_generator)
       expect(pr_generator).to receive(:delete_closed_prs)
       expect(pr_generator).to receive(:convert!).twice
-      expect(pr_generator).to receive(:open_prs).and_return [1, 2]
+      expect(pr_generator).to receive(:open_prs).and_return open_prs
       expect(@generator.pull_request(path, job_name)).to be_truthy
     end
 
@@ -175,13 +199,33 @@ describe JenkinsPipelineBuilder::Generator do
                              git_repo_name: 'generator_tests'))
         .and_return(pr_generator)
       expect(pr_generator).to receive(:delete_closed_prs)
-      allow(pr_generator).to receive(:convert!) do |job_collection, pr|
-        job_collection.defaults[:value][:application_name] = "testapp-PR#{pr}"
+      allow(pr_generator).to receive(:convert!) do |job_collection, pr_number|
+        job_collection.defaults[:value][:application_name] = "testapp-PR#{pr_number}"
       end
-      expect(pr_generator).to receive(:open_prs).and_return [1, 2]
+      expect(pr_generator).to receive(:open_prs).and_return open_prs
       expect(@generator.pull_request(path, job_name)).to be_truthy
       expect(@generator.job_collection.projects.first[:settings][:application_name]).to eq 'testapp-PR2'
     end
+
+    it 'correctly creates jobs only for the base branch' do
+      job_name = 'PullRequest'
+      pr_generator = double('pr_generator')
+      expect(JenkinsPipelineBuilder::PullRequestGenerator).to receive(:new)
+        .with(hash_including(
+                application_name: 'testapp',
+                github_site: 'https://github.com',
+                git_org: 'testorg',
+                git_repo_name: 'generator_tests'
+              )).and_return(pr_generator)
+
+      expect(pr_generator).to receive(:open_prs).and_return open_prs
+      expect(pr_generator).to receive(:delete_closed_prs)
+      expect(pr_generator).to receive(:convert!)
+        .with(instance_of(JenkinsPipelineBuilder::JobCollection), pr_master[:number])
+        .once
+
+      expect(@generator.pull_request(path, job_name, true)).to be_truthy
+    end
     # Things to check for
     # Fail - no PR job type found
     # Encounters failure during build process
@@ -204,26 +248,26 @@ describe JenkinsPipelineBuilder::Generator do
     end
 
     it 'loads a yaml collection from a path' do
-      path = File.expand_path('../fixtures/generator_tests/test_yaml_files', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/test_yaml_files', __dir__)
       @generator.job_collection.load_from_path path
     end
     it 'loads a json collection from a path' do
-      path = File.expand_path('../fixtures/generator_tests/test_json_files', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/test_json_files', __dir__)
       @generator.job_collection.load_from_path path
     end
     it 'loads both yaml and json files from a path' do
-      path = File.expand_path('../fixtures/generator_tests/test_combo_files', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/test_combo_files', __dir__)
       @generator.job_collection.load_from_path path
     end
 
     it 'errors when reading a bad yaml file' do
-      path = File.expand_path('../fixtures/generator_tests/test_bad_yaml_files', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/test_bad_yaml_files', __dir__)
       expect { @generator.job_collection.load_from_path path }.to raise_error(
         CustomErrors::ParseError, /There was an error while parsing a file/
       )
     end
     it 'errors when reading a bad json file' do
-      path = File.expand_path('../fixtures/generator_tests/test_bad_json_files', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/test_bad_json_files', __dir__)
       expect { @generator.job_collection.load_from_path path }.to raise_error(
         CustomErrors::ParseError, /There was an error while parsing a file/
       )
@@ -235,7 +279,7 @@ describe JenkinsPipelineBuilder::Generator do
       allow(JenkinsPipelineBuilder).to receive(:debug).and_return true
       job_name = 'test_job'
       body = ''
-      test_path = File.expand_path('../fixtures/generator_tests', __FILE__)
+      test_path = File.expand_path('fixtures/generator_tests', __dir__)
       File.open("#{test_path}/#{job_name}.xml", 'r') do |f|
         f.each_line do |line|
           body << line
@@ -251,7 +295,7 @@ describe JenkinsPipelineBuilder::Generator do
 
   describe '#projects' do
     it 'returns a list of projects' do
-      path = File.expand_path('../fixtures/generator_tests/multi_project', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/multi_project', __dir__)
       expect(@generator.projects(path)).to eq %w[SamplePipeline1 SamplePipeline2 SamplePipeline3]
     end
   end
@@ -269,9 +313,19 @@ describe JenkinsPipelineBuilder::Generator do
         File.delete(file_path) if File.exist?(file_path)
       end
     end
+
     it 'generates xml and saves to disk without sending jobs to the server' do
+      tar_path = File.join(__dir__, 'fixtures/generator_tests/template_pipeline_nested/jobs.tar.gz')
+      parsed_url = URI.parse('https://www.test.com')
+      file_contents = Zlib::GzipReader.new(File.open(tar_path)).read
+      file_object = double
+      allow(URI).to receive(:parse).and_return(parsed_url)
+      allow(parsed_url).to receive(:open).and_yield('A String')
+      allow(Zlib::GzipReader).to receive(:new).and_return(file_object)
+      allow(file_object).to receive(:read).and_return(file_contents)
+
       job_name = 'TemplatePipeline'
-      path = File.expand_path('../fixtures/generator_tests/template_pipeline', __FILE__)
+      path = File.expand_path('fixtures/generator_tests/template_pipeline', __dir__)
       errors = @generator.file(path, job_name)
       expect(errors).to be_empty
       expect(File.exist?("out/xml/#{job_name}-10.xml")).to be true

data/spec/lib/jenkins_pipeline_builder/job_collection_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::JobCollection do
   before :all do
@@ -21,7 +21,7 @@ describe JenkinsPipelineBuilder::JobCollection do
 
   context '#load_from_path' do
     before :all do
-      path = File.expand_path('../fixtures/job_collection/', __FILE__)
+      path = File.expand_path('fixtures/job_collection', __dir__)
       described_class.new.load_from_path path
     end
 

data/spec/lib/jenkins_pipeline_builder/job_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::Job do
   before :all do

data/spec/lib/jenkins_pipeline_builder/module_registry_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::ModuleRegistry do
   after :each do

data/spec/lib/jenkins_pipeline_builder/promotion_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::Promotion do
   before :all do

data/spec/lib/jenkins_pipeline_builder/pull_request_generator_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 require 'json'
 
 describe JenkinsPipelineBuilder::PullRequestGenerator do
@@ -8,7 +8,7 @@ describe JenkinsPipelineBuilder::PullRequestGenerator do
   let(:git_repo_name) { 'git_repo' }
   let(:prs) { (1..10).map { |n| "#{application_name}-PR#{n}" } }
   let(:closed_prs) { (1..6).map { |n| "#{application_name}-PR#{n}" } }
-  let(:open_prs_json) { (7..10).map { |n| { number: n } }.to_json }
+  let(:open_prs_json) { (7..10).map { |n| { number: n, base: { ref: 'master' } } }.to_json }
   let(:url) { "#{github_site}/api/v3/repos/#{git_org}/#{git_repo_name}/pulls" }
   let(:params) do
     {
@@ -91,41 +91,41 @@ describe JenkinsPipelineBuilder::PullRequestGenerator do
         .to_return(status: 200, body: open_prs_json, headers: {})
     end
 
+    let(:pr_number) { 8 }
+
     it 'converts the job application name' do
       collection = job_collection.clone
-      subject.convert! collection, 8
-      expect(collection.defaults[:value][:application_name]).to eq "#{application_name}-PR8"
+      subject.convert! collection, pr_number
+      expect(collection.defaults[:value][:application_name]).to eq "#{application_name}-PR#{pr_number}"
     end
 
     it 'provides the PR number to the job settings' do
       collection = job_collection.clone
-      subject.convert! collection, 8
-      expect(collection.defaults[:value][:pull_request_number]).to eq '8'
+      subject.convert! collection, pr_number
+      expect(collection.defaults[:value][:pull_request_number]).to eq pr_number.to_s
     end
 
     it 'overrides the git params' do
-      pr = 8
       collection = job_collection.clone
-      subject.convert! collection, pr
+      subject.convert! collection, pr_number
       expect(collection.jobs.first[:value]).to eq(
-        scm_branch: "origin/pr/#{pr}/head",
+        scm_branch: "origin/pr/#{pr_number}/head",
         scm_params: {
-          refspec: "refs/pull/#{pr}/head:refs/remotes/origin/pr/#{pr}/head",
-          changelog_to_branch: { remote: 'origin', branch: "pr/#{pr}/head" },
+          refspec: "refs/pull/#{pr_number}/head:refs/remotes/origin/pr/#{pr_number}/head",
+          changelog_to_branch: { remote: 'origin', branch: "pr/#{pr_number}/head" },
           random: 'foo'
         }
       )
     end
 
     it 'does not override extra params' do
-      pr = 8
       collection = job_collection.clone
-      subject.convert! collection, pr
+      subject.convert! collection, pr_number
       expect(collection.jobs.first[:value]).to eq(
-        scm_branch: "origin/pr/#{pr}/head",
+        scm_branch: "origin/pr/#{pr_number}/head",
         scm_params: {
-          refspec: "refs/pull/#{pr}/head:refs/remotes/origin/pr/#{pr}/head",
-          changelog_to_branch: { remote: 'origin', branch: "pr/#{pr}/head" },
+          refspec: "refs/pull/#{pr_number}/head:refs/remotes/origin/pr/#{pr_number}/head",
+          changelog_to_branch: { remote: 'origin', branch: "pr/#{pr_number}/head" },
           random: 'foo'
         }
       )

data/spec/lib/jenkins_pipeline_builder/spec_helper.rb

@@ -6,7 +6,7 @@ require 'simplecov-rcov'
 require 'webmock/rspec'
 require 'equivalent-xml'
 
-require File.expand_path('../../../../lib/jenkins_pipeline_builder', __FILE__)
+require File.expand_path('../../../lib/jenkins_pipeline_builder', __dir__)
 
 RSpec::Matchers.define :have_min_version do |version|
   match do |base|

data/spec/lib/jenkins_pipeline_builder/utils_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::Utils do
   let(:utils) { JenkinsPipelineBuilder::Utils }

data/spec/lib/jenkins_pipeline_builder/view_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../spec_helper', __FILE__)
+require File.expand_path('spec_helper', __dir__)
 
 describe JenkinsPipelineBuilder::View do
   before(:all) do
@@ -12,7 +12,7 @@ describe JenkinsPipelineBuilder::View do
     generator = JenkinsPipelineBuilder.generator
     @view = JenkinsPipelineBuilder::View.new(generator)
   end
-  let(:path) { File.expand_path('../fixtures/view_test/', __FILE__) }
+  let(:path) { File.expand_path('fixtures/view_test', __dir__) }
   let(:view) { { name: 'view', parent_view: 'ParentView', type: 'categorizedView', description: 'ViewTest', regex: 'ViewTest.*', groupingRules: [{ groupRegex: 'ViewTest-1.*', namingRule: '1. Commit Stage' }] } }
 
   describe '#generate' do