jenkins_pipeline_builder 0.15.4 → 0.16.0

data/lib/jenkins_pipeline_builder/module_registry.rb

@@ -19,7 +19,6 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.
 #
-
 module JenkinsPipelineBuilder
   class ModuleRegistry
     attr_accessor :registry, :registered_modules
@@ -52,7 +51,9 @@ module JenkinsPipelineBuilder
         builders: '//builders',
         publishers: '//publishers',
         wrappers: '//buildWrappers',
-        triggers: '//triggers'
+        triggers: '//triggers',
+        build_steps: '//buildSteps',
+        promotion_conditions: '//conditions'
       }
     end
 
@@ -77,7 +78,6 @@ module JenkinsPipelineBuilder
     def get_by_path_collection(path, registry)
       item = registry[path.shift.to_sym]
       return item if path.count == 0
-
       get_by_path_collection(path, item)
     end
 
@@ -90,7 +90,7 @@ module JenkinsPipelineBuilder
       params.each do |key, value|
         next unless registry.is_a? Hash
         unless registry.key? key
-          raise "!!!! could not find key #{key} !!!!" if strict
+          raise TypeError, "!!!! could not find key #{key} !!!!" if strict
           next
         end
         reg_value = registry[key]

data/lib/jenkins_pipeline_builder/promotion.rb

@@ -0,0 +1,82 @@
+#
+# Copyright (c) 2014 Constant Contact
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+#
+
+module JenkinsPipelineBuilder
+  class Promotion
+    def initialize(generator)
+      @generator = generator
+      @client = generator.client
+      @logger = @client.logger
+    end
+
+    def create(params, job_name)
+      success, payload = prom_to_xml(params)
+      return success, payload unless success
+      xml = payload
+      return local_output(xml) if JenkinsPipelineBuilder.debug || JenkinsPipelineBuilder.file_mode
+
+      @client.get_config(get_process_path(job_name, params[:name]))
+      @client.post_config(set_process_path(job_name, params[:name]), xml)
+    rescue JenkinsApi::Exceptions::NotFound
+      @client.post_config(init_process_path(job_name, params[:name]), xml)
+    end
+
+    def prom_to_xml(params)
+      builder = Nokogiri::XML::Builder.new do |xml|
+        xml.send('hudson.plugins.promoted__builds.PromotionProcess', 'plugin' => 'promoted-builds@2.27') do
+          xml.buildSteps
+          xml.conditions
+        end
+      end
+      @n_xml = builder.doc
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+      [true, @n_xml.to_xml]
+    end
+
+    def local_output(xml)
+      JenkinsPipelineBuilder.logger.info 'Will create promotion'
+      JenkinsPipelineBuilder.logger.info xml.to_s if @debug
+      xml.to_s if @debug
+      FileUtils.mkdir_p(out_dir) unless File.exist?(out_dir)
+      File.open("#{out_dir}/promotion_debug.xml", 'w') { |f| f.write xml }
+      xml
+    end
+
+    def out_dir
+      'out/xml'
+    end
+
+    private
+
+    def init_process_path(job_name, process_name)
+      "/job/#{URI.encode job_name}/promotion/createProcess?name=#{URI.encode process_name}"
+    end
+
+    def set_process_path(job_name, process_name)
+      "/job/#{URI.encode job_name}/promotion/process/#{URI.encode process_name}/config.xml"
+    end
+
+    def get_process_path(job_name, process_name)
+      "/job/#{URI.encode job_name}/promotion/process/#{URI.encode process_name}"
+    end
+  end
+end

data/lib/jenkins_pipeline_builder/utils.rb

@@ -40,6 +40,12 @@ module JenkinsPipelineBuilder
       end
     end
 
+    def self.symbolize_with_empty_hash!(array_of_maybe_str)
+      array_of_maybe_str.map! do |maybe_str|
+        maybe_str.is_a?(String) ? { maybe_str.to_sym => {} } : maybe_str
+      end
+    end
+
     def self.hash_merge!(old_hash, new_hash)
       old_hash.merge!(new_hash) do |_key, old, new|
         if old.is_a?(Hash) && new.is_a?(Hash)

data/lib/jenkins_pipeline_builder/version.rb

@@ -21,5 +21,5 @@
 #
 
 module JenkinsPipelineBuilder
-  VERSION = '0.15.4'.freeze
+  VERSION = '0.16.0'.freeze
 end

data/lib/jenkins_pipeline_builder/view.rb

@@ -72,10 +72,7 @@ module JenkinsPipelineBuilder
       create_base_view(params[:name], params[:type], params[:parent_view])
       @logger.debug "Creating a #{params[:type]} view with params: #{params.inspect}"
 
-      if JenkinsPipelineBuilder.debug
-        # pp post_params(params)
-        return
-      end
+      return if JenkinsPipelineBuilder.debug
 
       view_path = params[:parent_view].nil? ? '' : "/view/#{params[:parent_view]}"
       view_path += "/view/#{params[:name]}/configSubmit"

data/spec/lib/jenkins_pipeline_builder/extensions/build_steps_spec.rb

@@ -0,0 +1,198 @@
+require File.expand_path('../../spec_helper', __FILE__)
+
+describe 'build_steps' do
+  after :each do
+    JenkinsPipelineBuilder.registry.clear_versions
+  end
+
+  before :all do
+    JenkinsPipelineBuilder.credentials = {
+      server_ip: '127.0.0.1',
+      server_port: 8080,
+      username: 'username',
+      password: 'password',
+      log_location: '/dev/null'
+    }
+  end
+
+  before :each do
+    builder = Nokogiri::XML::Builder.new { |xml| xml.buildSteps }
+    @n_xml = builder.doc
+  end
+
+  after :each do |example|
+    name = example.description.tr ' ', '_'
+    require 'fileutils'
+    FileUtils.mkdir_p 'out/xml'
+    File.open("./out/xml/build_steps_#{name}.xml", 'w') { |f| @n_xml.write_xml_to f }
+  end
+
+  context 'generic' do
+    it 'can register a build_step' do
+      result = build_step do
+        name :test_generic
+        plugin_id :foo
+        xml do
+          foo :bar
+        end
+      end
+      JenkinsPipelineBuilder.registry.registry[:job][:build_steps].delete :test_generic
+      expect(result).to be true
+    end
+
+    it 'fails to register an invalid build_step' do
+      result = build_step do
+        name :test_generic
+      end
+      JenkinsPipelineBuilder.registry.registry[:job][:build_steps].delete :test_generic
+      expect(result).to be false
+    end
+  end
+
+  context 'triggered_jobs' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31', 'parameterized-trigger' => '20.0' }
+      )
+    end
+
+    it 'generates a configuration with standard defaults' do
+      params = { build_steps: { triggered_job:
+               { name: 'ReleaseBuild' } } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      xml_from_jenkins = parse_expectation_xml(
+        "<buildSteps>
+          <hudson.plugins.parameterizedtrigger.TriggerBuilder plugin='parameterized-trigger@2.31'>
+            <configs>
+              <hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig>
+                <configs class='empty-list' />
+                <projects>ReleaseBuild</projects>
+                <condition>ALWAYS</condition>
+                <triggerWithNoParameters>false</triggerWithNoParameters>
+                <block>
+                  <buildStepFailureThreshold>
+                    <name>FAILURE</name>
+                    <ordinal>2</ordinal>
+                    <color>RED</color>
+                    <completeBuild>true</completeBuild>
+                  </buildStepFailureThreshold>
+                  <unstableThreshold>
+                    <name>UNSTABLE</name>
+                    <ordinal>1</ordinal>
+                    <color>YELLOW</color>
+                    <completeBuild>true</completeBuild>
+                  </unstableThreshold>
+                  <failureThreshold>
+                    <name>FAILURE</name>
+                    <ordinal>2</ordinal>
+                    <color>RED</color>
+                    <completeBuild>true</completeBuild>
+                  </failureThreshold>
+                </block>
+                <buildAllNodesWithLabel>false</buildAllNodesWithLabel>
+              </hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig>
+            </configs>
+          </hudson.plugins.parameterizedtrigger.TriggerBuilder>
+        </buildSteps>"
+      )
+
+      expect(@n_xml).to be_equivalent_to(xml_from_jenkins)
+    end
+
+    it 'generates no block conditions when set to false' do
+      params = { build_steps: { triggered_job:
+               { name: 'ReleaseBuild', block_condition: false } } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      xml_from_jenkins = parse_expectation_xml(
+        "<buildSteps>
+          <hudson.plugins.parameterizedtrigger.TriggerBuilder plugin='parameterized-trigger@2.31'>
+            <configs>
+              <hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig>
+              <configs class='empty-list'/>
+              <projects>ReleaseBuild</projects>
+              <condition>ALWAYS</condition>
+              <triggerWithNoParameters>false</triggerWithNoParameters>
+              <buildAllNodesWithLabel>false</buildAllNodesWithLabel>
+            </hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig>
+            </configs>
+          </hudson.plugins.parameterizedtrigger.TriggerBuilder>
+        </buildSteps>"
+      )
+
+      expect(@n_xml).to be_equivalent_to(xml_from_jenkins)
+    end
+
+    it 'generates build state with current parameters' do
+      params = { build_steps: { triggered_job:
+               { name: 'ReleaseBuild', build_parameters: [:current] } } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at_xpath("//buildSteps/
+        hudson.plugins.parameterizedtrigger.TriggerBuilder/
+        configs/
+        hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig/
+        configs/
+        hudson.plugins.parameterizedtrigger.CurrentBuildParameters"))
+        .not_to equal(nil)
+    end
+
+    it 'generates build state with predefined parameters' do
+      params = { build_steps: { triggered_job:
+               { name: 'ReleaseBuild', build_parameters: [[:predefined, { x: 1, 'y' => 2 }]] } } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at_xpath("//buildSteps/
+        hudson.plugins.parameterizedtrigger.TriggerBuilder/
+        configs/
+        hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig/
+        configs/
+        hudson.plugins.parameterizedtrigger.PredefinedBuildParameters/
+        properties").text)
+        .to eq('X=1 Y=2')
+    end
+
+    it 'generates build state with file parameters' do
+      params = { build_steps: { triggered_job:
+               { name: 'ReleaseBuild', build_parameters: [[:file, '/usr/local/params']] } } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at_xpath("//buildSteps/
+        hudson.plugins.parameterizedtrigger.TriggerBuilder/
+        configs/
+        hudson.plugins.parameterizedtrigger.BlockableBuildTriggerConfig/
+        configs/
+        hudson.plugins.parameterizedtrigger.FileBuildParameters/
+        propertiesFile").text)
+        .to eq('/usr/local/params')
+    end
+  end
+
+  context 'keep_builds_forever' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates the keep_builds_forever tag' do
+      params = { build_steps: { keep_builds_forever: true } }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at_xpath("//buildSteps/
+        hudson.plugins.promoted__builds.KeepBuildForeverAction"))
+        .to_not eq(nil)
+    end
+  end
+end

data/spec/lib/jenkins_pipeline_builder/extensions/builders_spec.rb

@@ -55,11 +55,10 @@ describe 'builders' do
         list_installed: { 'jenkins-multijob-plugin' => '20.0' }
       )
     end
+
     it 'generates a configuration' do
       params = { builders: { multi_job: { phases: { foo: { jobs: [{ name: 'foo' }] } } } } }
-
       JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
-
       builder = @n_xml.root.children.first
       expect(builder.name).to match 'com.tikal.jenkins.plugins.multijob.MultiJobBuilder'
     end
@@ -115,7 +114,6 @@ describe 'builders' do
 
     context 'step failure threshold' do
       let(:params) { { builders: { blocking_downstream: { fail: 'FAILURE' } } } }
-
       it 'generates a configuration' do
         expect(@n_xml.root.css('buildStepFailureThreshold').first).to_not be_nil
         expect(@n_xml.root.css('buildStepFailureThreshold').first.css('color').first.text).to eq 'RED'

data/spec/lib/jenkins_pipeline_builder/extensions/job_attributes_spec.rb

@@ -144,6 +144,69 @@ describe 'job_attributes' do
     end
   end
 
+  context 'block_when_downstream_building' do
+    it 'sets blockBuildWhenDownstreamBuilding' do
+      params = { block_when_downstream_building: 'true' }
+
+      builder = Nokogiri::XML::Builder.new do |xml|
+        xml.send('hudson.plugins.promoted__builds.PromotionProcess', 'plugin' => 'promoted-builds@2.27')
+      end
+      @n_xml = builder.doc
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml.at('blockBuildWhenDownstreamBuilding')).to be_truthy
+      expect(@n_xml.at('blockBuildWhenDownstreamBuilding').content).to eq 'true'
+    end
+  end
+
+  context 'block_when_upstream_building' do
+    it 'sets blockBuildWhenUpstreamBuilding' do
+      params = { block_when_upstream_building: 'true' }
+
+      builder = Nokogiri::XML::Builder.new do |xml|
+        xml.send('hudson.plugins.promoted__builds.PromotionProcess', 'plugin' => 'promoted-builds@2.27')
+      end
+      @n_xml = builder.doc
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml.at('blockBuildWhenUpstreamBuilding')).to be_truthy
+      expect(@n_xml.at('blockBuildWhenUpstreamBuilding').content).to eq 'true'
+    end
+  end
+
+  context 'is_visible' do
+    it 'sets isVisible' do
+      params = { is_visible: 'true' }
+
+      builder = Nokogiri::XML::Builder.new do |xml|
+        xml.send('hudson.plugins.promoted__builds.PromotionProcess', 'plugin' => 'promoted-builds@2.27')
+      end
+      @n_xml = builder.doc
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml.at('isVisible')).to be_truthy
+    end
+  end
+
+  context 'promotion_icon' do
+    it 'sets the promotion_icon' do
+      params = { promotion_icon: 'gold-e' }
+
+      builder = Nokogiri::XML::Builder.new do |xml|
+        xml.send('hudson.plugins.promoted__builds.PromotionProcess', 'plugin' => 'promoted-builds@2.27')
+      end
+      @n_xml = builder.doc
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml.at('icon')).to be_truthy
+      expect(@n_xml.at('icon').content).to eq 'star-gold-e'
+    end
+  end
+
   context 'scm params' do
     before :each do
       builder = Nokogiri::XML::Builder.new { |xml| xml.scm }

data/spec/lib/jenkins_pipeline_builder/extensions/promotion_conditions_spec.rb

@@ -0,0 +1,281 @@
+require File.expand_path('../../spec_helper', __FILE__)
+
+describe 'promotion_conditions' do
+  after :each do
+    JenkinsPipelineBuilder.registry.clear_versions
+  end
+
+  before :all do
+    JenkinsPipelineBuilder.credentials = {
+      server_ip: '127.0.0.1',
+      server_port: 8080,
+      username: 'username',
+      password: 'password',
+      log_location: '/dev/null'
+    }
+  end
+
+  before :each do
+    condition = Nokogiri::XML::Builder.new { |xml| xml.conditions }
+    @n_xml = condition.doc
+  end
+
+  after :each do |example|
+    name = example.description.tr ' ', '_'
+    require 'fileutils'
+    FileUtils.mkdir_p 'out/xml'
+    File.open("./out/xml/conditions_#{name}.xml", 'w') { |f| @n_xml.write_xml_to f }
+  end
+
+  context 'generic' do
+    it 'can register a condition' do
+      result = promotion_condition do
+        name :test_generic
+        plugin_id :foo
+        xml do
+          foo :bar
+        end
+      end
+      JenkinsPipelineBuilder.registry.registry[:job][:promotion_conditions].delete :test_generic
+      expect(result).to be true
+    end
+
+    it 'fails to register an invalid condition' do
+      result = promotion_condition do
+        name :test_generic
+      end
+      JenkinsPipelineBuilder.registry.registry[:job][:promotion_conditions].delete :test_generic
+      expect(result).to be false
+    end
+  end
+
+  context 'type: manual' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates manual given parameter' do
+      params = { promotion_conditions:
+              [{ manual: { users: 'unauthorized' } }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ManualCondition/users')
+        .text)
+        .to eq('unauthorized')
+    end
+
+    it 'generates manual defaults' do
+      params = { promotion_conditions:
+              [{ manual: {} }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ManualCondition/users')
+        .text)
+        .to eq('')
+    end
+  end
+
+  context 'type: self_promotion' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates a self promotion given parameters' do
+      params = { promotion_conditions:
+              [{ self_promotion:
+               { even_if_unstable: false } }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.SelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('false')
+    end
+
+    it 'generates a self promotion defaults' do
+      params = { promotion_conditions: [{ self_promotion: {} }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.SelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+    end
+  end
+
+  context 'type: parameterized_self_promotion' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates a parameterized self promotion given parameters' do
+      params = { promotion_conditions:
+              [{ parameterized_self_promotion:
+               { parameter_name: 'SOME_ENV_CHAR', parameter_value: false, even_if_unstable: false } }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterName')
+        .text)
+        .to eq('SOME_ENV_CHAR')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterValue')
+        .text)
+        .to eq('false')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('false')
+    end
+
+    it 'generates a parameterized self promotion defaults' do
+      params = { promotion_conditions:
+              [{ parameterized_self_promotion: {} }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterName')
+        .text)
+        .to eq('')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterValue')
+        .text).to eq('true')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+    end
+  end
+
+  context 'type: downstream_pass' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates a downstream pass configuration given parameters' do
+      params = { promotion_conditions:
+              [downstream_pass:
+               { jobs: 'Worst-Commit-Ever', even_if_unstable: true }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/jobs')
+        .text)
+        .to eq('Worst-Commit-Ever')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+    end
+
+    it 'generates a downstream pass defaults' do
+      params = { promotion_conditions:
+              [downstream_pass: {}] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/jobs')
+        .text)
+        .to eq('{{Example}}-Commit')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+    end
+  end
+
+  context 'type: upstream_promotion' do
+    before :each do
+      allow(JenkinsPipelineBuilder.client).to receive(:plugin).and_return double(
+        list_installed: { 'promoted-builds' => '2.31' }
+      )
+    end
+
+    it 'generates a upstream promotion parameters' do
+      params = { promotion_conditions:
+              [upstream_promotion:
+               { promotion_name: 'Never-Promotes' }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.UpstreamPromotionCondition/promotionName')
+        .text)
+        .to eq('Never-Promotes')
+    end
+
+    it 'generates a upstream promotion defaults' do
+      params = { promotion_conditions:
+              [upstream_promotion: {}] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.UpstreamPromotionCondition/promotionName')
+        .text)
+        .to eq('01. Staging Promotion')
+    end
+
+    it 'generates all condition defaults given no parameters' do
+      params = { promotion_conditions:
+              [{ manual: {} },
+               { self_promotion: {} },
+               { parameterized_self_promotion: {} },
+               { downstream_pass: {} },
+               { upstream_promotion: {} }] }
+
+      JenkinsPipelineBuilder.registry.traverse_registry_path('job', params, @n_xml)
+
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ManualCondition/users')
+        .text)
+        .to eq('')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.SelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterName')
+        .text)
+        .to eq('')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/parameterValue')
+        .text)
+        .to eq('true')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.ParameterizedSelfPromotionCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/jobs')
+        .text)
+        .to eq('{{Example}}-Commit')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.DownstreamPassCondition/evenIfUnstable')
+        .text)
+        .to eq('true')
+      expect(@n_xml
+        .at('//hudson.plugins.promoted__builds.conditions.UpstreamPromotionCondition/promotionName')
+        .text)
+        .to eq('01. Staging Promotion')
+    end
+  end
+end