jekyll_picture_tag 1.11.0 → 2.0.0

data/lib/jekyll_picture_tag/parsers.rb

@@ -0,0 +1,5 @@
+require_relative 'parsers/arg_splitter'
+require_relative 'parsers/configuration'
+require_relative 'parsers/html_attributes'
+require_relative 'parsers/preset'
+require_relative 'parsers/tag_parser'

data/lib/jekyll_picture_tag/{instructions → parsers}/arg_splitter.rb

@@ -1,5 +1,5 @@
 module PictureTag
-  module Instructions
+  module Parsers
     # This class takes in the arguments passed to the liquid tag, and splits it
     # up into 'words' (correctly handling quotes and backslash escapes.)
     #

data/lib/jekyll_picture_tag/parsers/configuration.rb

@@ -0,0 +1,28 @@
+module PictureTag
+  module Parsers
+    # Global config (big picture). loads jekyll data/config files, and the j-p-t
+    # defaults from included yml files.
+    class Configuration
+      # returns jekyll's configuration (picture is a subset)
+      def [](key)
+        content[key]
+      end
+
+      private
+
+      def content
+        @content ||= setting_merge(DEFAULT_CONFIG, PictureTag.site.config)
+      end
+
+      def setting_merge(default, jekyll)
+        jekyll.merge default do |_key, config_setting, default_setting|
+          if default_setting.respond_to? :merge
+            setting_merge(default_setting, config_setting)
+          else
+            config_setting
+          end
+        end
+      end
+    end
+  end
+end

data/lib/jekyll_picture_tag/{instructions → parsers}/html_attributes.rb

@@ -1,5 +1,5 @@
 module PictureTag
-  module Instructions
+  module Parsers
     # Handles HTML attributes, sourced from configuration and the liquid tag,
     # sent to various elements.
     # Stored as a hash, with string keys.

data/lib/jekyll_picture_tag/parsers/preset.rb

@@ -0,0 +1,43 @@
+module PictureTag
+  module Parsers
+    # Handles the specific tag image set to construct.
+    class Preset
+      attr_reader :name
+
+      def initialize(name)
+        @name = name
+      end
+
+      def [](key)
+        content[key]
+      end
+
+      protected
+
+      def content
+        @content ||= DEFAULT_PRESET.merge settings
+      end
+
+      private
+
+      def settings
+        PictureTag.site.data.dig('picture', 'presets', name) ||
+          STOCK_PRESETS[name] ||
+          no_preset
+      end
+
+      def no_preset
+        unless name == 'default'
+          Utils.warning(
+            <<~HEREDOC
+              Preset "#{name}" not found in #{PictureTag.config['data_dir']}/picture.yml
+              under 'presets' key, or in stock presets. Using default values."
+            HEREDOC
+          )
+        end
+
+        {}
+      end
+    end
+  end
+end

data/lib/jekyll_picture_tag/{instructions → parsers}/tag_parser.rb

@@ -1,5 +1,5 @@
 module PictureTag
-  module Instructions
+  module Parsers
     # Tag Parsing Responsibilities:
     #
     #  {% picture mypreset a.jpg 3:2 mobile: b.jpg --alt "Alt" --link "/" %}
@@ -9,17 +9,16 @@ module PictureTag
     # string), hands them to ArgSplitter (which breaks them up into an array of
     # words), extracts the preset name (if present), source image name(s),
     # associated media queries (if present), and image-related arguments such as
-    # crop and gravity. HTML attributes are handed off to its respective class
+    # crop and keep. HTML attributes are handed off to its respective class
     # (as 'leftovers')
     #
     # Media presets and source names are stored as arrays in their correct
-    # orders. Gravities and geometries are stored in a hash, keyed by their
+    # orders. Crop settings are stored in a hash, keyed by their
     # relevant media presets. Note that the base image will have a media preset
     # of nil, which is a perfectly fine hash key.
-    #
     class TagParser
-      attr_reader :preset_name, :source_names, :media_presets, :gravities,
-                  :geometries, :leftovers
+      attr_reader :preset_name, :source_names, :media_presets, :keep,
+                  :crop, :leftovers
 
       def initialize(raw_params)
         @raw_params = raw_params
@@ -27,8 +26,8 @@ module PictureTag
 
         @media_presets = []
         @source_names = []
-        @geometries = {}
-        @gravities = {}
+        @keep = {}
+        @crop = {}
 
         parse_params
       end
@@ -51,14 +50,18 @@ module PictureTag
       end
 
       def parse_param(param)
+        # Media query, i.e. 'mobile:'
         if param.match?(/[\w\-]+:$/)
           add_media_source
 
-        elsif Utils::GRAVITIES.include?(param.downcase)
-          @gravities[@media_presets.last] = @params.shift
+        # Smartcrop interestingness setting. We label it 'keep', since it
+        # determines what to keep when cropping.
+        elsif %w[none centre center entropy attention].include?(param.downcase)
+          @keep[@media_presets.last] = @params.shift
 
-        elsif param.match?(Utils::GEOMETRY_REGEX)
-          @geometries[@media_presets.last] = @params.shift
+        # Aspect ratio, i.e. '16:9'
+        elsif param.match?(/\A\d+:\d+\z/)
+          @crop[@media_presets.last] = @params.shift
 
         else
           raise_error(param)

data/lib/jekyll_picture_tag/router.rb

@@ -1,115 +1,57 @@
 module PictureTag
   # The rest of the application doesn't care where the instruction logic
-  # resides. The following module 'routes' method calls to the right place, so
-  # the rest of the application can just call 'PictureTag.(some method)'
-
-  # At first I thought I'd do some sweet dynamic metaprogramming here, but it
-  # ended up complicated and clever, rather than convenient and understandable.
-  # This way is not strictly DRY, but it's straightforward and readable. If it
-  # gets big, I'll refactor.
+  # resides. This module 'routes' method calls to the right place, so
+  # information consumers can just call 'PictureTag.(some method)'
+  #
+  # This is accomplished with a bit of metaprogramming, which is hopefully not
+  # unnecessarily clever or complicated. Missing methods are converted to class
+  # names, which are looked up under the Instructions module namespace.
+  #
+  # Instantiated Instructions are stored in a hash, keyed by method name.
   module Router
-    attr_accessor :instructions, :context
-
-    # Context forwarding
-
-    # Global site data
-    def site
-      @context.registers[:site]
-    end
-
-    # Page which tag is called from
-    def page
-      @context.registers[:page]
-    end
-
-    # Instructions forwarding
-
-    def config
-      @instructions.config
-    end
-
-    def preset
-      @instructions.preset
-    end
-
-    def media_presets
-      @instructions.media_presets
-    end
-
-    def html_attributes
-      @instructions.html_attributes
-    end
-
-    def output_class
-      @instructions.output_class
-    end
+    # These two attributes encompass everything passed in by Jekyll.
+    attr_accessor :raw_params, :context
 
-    def source_images
-      @instructions.source_images
+    def method_missing(method_name, *args)
+      if instruction_exists?(method_name)
+        instruction(method_name).value(*args)
+      else
+        super
+      end
     end
 
-    def crop(media = nil)
-      @instructions.crop(media)
+    def respond_to_missing?(method_name, *args)
+      instruction_exists?(method_name) || super
     end
 
-    def gravity(media = nil)
-      @instructions.gravity(media)
+    # Required at least for testing; instructions are persisted between tags
+    # otherwise.
+    def clear_instructions
+      instructions.clear
     end
 
-    # Config Forwarding
-
-    def source_dir
-      config.source_dir
-    end
-
-    def dest_dir
-      config.dest_dir
-    end
-
-    def continue_on_missing?
-      config.continue_on_missing?
-    end
-
-    def cdn?
-      config.cdn?
-    end
-
-    def pconfig
-      config.pconfig
-    end
-
-    def disabled?
-      config.disabled?
-    end
-
-    def fast_build?
-      config.fast_build?
-    end
-
-    # Preset forwarding
-
-    def widths(media)
-      preset.widths(media)
-    end
+    private
 
-    def formats
-      preset.formats
+    def instruction(method_name)
+      instructions[method_name] ||= instruction_class(method_name).new
     end
 
-    def fallback_format
-      preset.fallback_format
+    def instructions
+      @instructions ||= {}
     end
 
-    def fallback_width
-      preset.fallback_width
+    def instruction_exists?(method_name)
+      Object.const_defined? instruction_class_name(method_name.to_sym)
     end
 
-    def nomarkdown?
-      preset.nomarkdown?
+    # Class names can't contain question marks, so we strip them.
+    def instruction_class(method_name)
+      Object.const_get instruction_class_name(method_name)
     end
 
-    def quality(format)
-      preset.quality(format)
+    def instruction_class_name(method_name)
+      'PictureTag::Instructions::' +
+        Utils.titleize(method_name.to_s.delete_suffix('?'))
     end
   end
 end

data/lib/jekyll_picture_tag/srcsets/basic.rb

@@ -53,11 +53,11 @@ module PictureTag
       end
 
       def width_attribute
-        files.first.source_width.to_s
+        source_image.width.to_s
       end
 
       def height_attribute
-        files.first.source_height.to_s
+        source_image.height.to_s
       end
 
       private
@@ -86,11 +86,7 @@ module PictureTag
       end
 
       def source_width
-        @source_width ||= if PictureTag.crop(@media)
-                            target_files.first.source_width
-                          else
-                            @source_image.width
-                          end
+        source_image.width
       end
 
       def target_files
@@ -112,9 +108,7 @@ module PictureTag
         GeneratedImage.new(
           source_file: @source_image,
           width: width,
-          format: @input_format,
-          crop: PictureTag.crop(@media),
-          gravity: PictureTag.gravity(@media)
+          format: @input_format
         )
       end
     end

data/lib/jekyll_picture_tag/utils.rb

@@ -2,28 +2,10 @@ module PictureTag
   # This is a little module to hold logic that doesn't fit other places. If it
   # starts getting big, refactor.
   module Utils
-    # These are valid ImageMagick gravity arguments (relevant to our use
-    # case):
-    GRAVITIES =
-      %w[center
-         north
-         northeast
-         east
-         southeast
-         south
-         southwest
-         west
-         northwest].freeze
-
-    # This is an attempt to recognize valid imagemagick geometry arguments
-    # with regex. It only tries to match values which don't preserve aspect
-    # ratio, as they're the ones people might actually need here.
-    GEOMETRY_REGEX = /\A\d*%?[x:]?\d*[%!]?([+-]\d+){,2}\Z/i.freeze
-
     class << self
       # Configure Jekyll to keep our generated files
       def keep_files
-        dest_dir = PictureTag.config['picture']['output']
+        dest_dir = PictureTag.pconfig['output']
 
         # Chop a slash off the end, if it's there. Doesn't work otherwise.
         dest_dir = dest_dir[0..-2] if dest_dir =~ %r{/\z}
@@ -35,7 +17,7 @@ module PictureTag
 
       # Print a warning to the console
       def warning(message)
-        return if PictureTag.config['picture']['suppress_warnings']
+        return if PictureTag.pconfig['suppress_warnings']
 
         warn 'Jekyll Picture Tag Warning: '.yellow + message
       end
@@ -63,6 +45,28 @@ module PictureTag
       def titleize(input)
         input.split('_').map(&:capitalize).join
       end
+
+      def snakeize(input)
+        input.scan(/[A-Z][a-z]+/).map(&:downcase).join('_')
+      end
+
+      # Linear interpolator. Pass it 2 values in the x array, 2 values
+      # in the y array, and an x value, returns a y value.
+      def interpolate(xvals, yvals, xval)
+        xvals.map!(&:to_f)
+        yvals.map!(&:to_f)
+
+        # Slope
+        m = (yvals.last - yvals.first) / (xvals.last - xvals.first)
+        # Value of y when x=0
+        b = yvals.first - (m * xvals.first)
+        # y = mx + b
+        (m * xval) + b
+      end
+
+      def aspect_float(width, height)
+        width.to_f / height
+      end
     end
   end
 end

data/lib/jekyll_picture_tag/version.rb

@@ -1,3 +1,3 @@
 module PictureTag
-  VERSION = '1.11.0'.freeze
+  VERSION = '2.0.0'.freeze
 end

data/readme.md

@@ -1,5 +1,9 @@
+![Logo](docs/logo.svg)
+
 # Jekyll Picture Tag
 
+![Tests & Formatting](https://github.com/rbuchberger/jekyll_picture_tag/workflows/Tests%20&%20Formatting/badge.svg)
+
 **Responsive Images done correctly.**
 
 It's simple to throw a photo on a page and call it a day, but doing justice to users on all
@@ -24,7 +28,7 @@ different image entirely.
 
 **Developer Sanity:** If you want to serve multiple images in multiple formats and resolutions, you
 have a litany of markup to write and a big pile of images to generate and organize. Jekyll Picture
-Tag is your responsive images minion - give it simple instructions and it'll handle the rest. 
+Tag is your responsive images minion - give it simple instructions and it'll handle the rest.
 
 ## Features
 
@@ -39,24 +43,22 @@ https://rbuchberger.github.io/jekyll_picture_tag/
 
 ## Changelog:
 
-https://rbuchberger.github.io/jekyll_picture_tag/releases
+https://rbuchberger.github.io/jekyll_picture_tag/devs/releases
 
-Latest versions: 
+Recent releases:
 
-* 1.10.1 July 2, 2020
-  * Bugfix for erroneously regenerated images
-* 1.10.2 July 6, 2020
-  * Bugfix for fallback image files not actually getting generated
-* 1.11.0 July 27, 2020
-  * **Width and height attribute support!** Begone, page reflow.
-  * Cache image information between builds
-  * Change image naming format. This update will trigger all images to be regenerated, so you may
-    want to delete your generated images folder beforehand.
+* 1.14.0 January 10, 2021
+  * Gracefully handle empty tag arguments.
+  * Re-add metadata stripping. I removed it inadvertently when refactoring; now
+    there's a test and a setting to turn it off.
+  * Respect Jekyll's `--disable-disk-cache` argument.
+  * Add baseurl configuration, allowing increased plugin support (such as I18n via `jekyll-multiple-languages-plugin`)
+  * Tooling & test suite maintenance and improvements.
 
 ## Help Wanted
 
 Writing code is only part of the job; often the harder part is knowing what needs to be changed. Any
 and all feedback is greatly appreciated, especially in regards to documentation. What are your pain
 points? See the [contributing
-guidelines](https://rbuchberger.github.io/jekyll_picture_tag/contributing), or the
+guidelines](https://rbuchberger.github.io/jekyll_picture_tag/devs/contributing), or the
 [issues](https://github.com/rbuchberger/jekyll_picture_tag/issues) page for more.