jekyll_picture_tag 1.10.1 → 1.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8139b8ad99ab1d17326fa0a36b19660211d2eeaaf2f013bde294e5c0fd985d1
-  data.tar.gz: f1b4e609115cd6a27c7438a5bffe7bd954ad193f21c87e5e6804b4d3c4261338
+  metadata.gz: 33725ceaf2682e1c8396ecf949d606efa6f4e3dcc7097802bdc9524ef492cff2
+  data.tar.gz: 837d3c4e04e0b859953024e99aff1a685c7cd4a85fe36b012a1ef5f025e11257
 SHA512:
-  metadata.gz: c5a51b1438f0dcdd3ccd00925208e56fe740762451cc9c60603204a044595525f44e47285e2b6bc7b9f2f99c644b2d98fd0401f6639a58163cd1334b22a6cd95
-  data.tar.gz: fb823ff0aef8a29989495663e3d108add494609e9c7956865d379fb8a5b05aa79e9a66fb504f073ae204631b3b9dd9a502fc3a13763d6b9d3e6af5384d70c470
+  metadata.gz: 2de1f6a51c96750a389c8f5885dcfa80e5cb5cd9a50570e8e9a4e81ad2a987766165499bc6825eec5f10c9817994e230c5289ae6a570dedd8b5e874ee9f91595
+  data.tar.gz: 17cc0a355f08dc1bb6418148264feeb47010faf29ad3597f789443c504d8574fa069a77e83c3968569f3b5ab7217905bc4bf19322f6f5c25acde3f549db76a81

data/.envrc

@@ -0,0 +1,2 @@
+# if you run bundle install --binstubs, you won't have to use bundle exec all the time.
+export PATH=$(git rev-parse --show-toplevel)/bin:$PATH

data/.github/workflows/code-checks.yml

@@ -0,0 +1,43 @@
+name: 'Tests & Formatting'
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+  schedule:
+    # Run weekly; github deletes caches that haven't been used in a week.
+    - cron: '0 0 * * 0'
+
+jobs:
+  checks:
+    runs-on: ubuntu-latest
+    env:
+      imagemagick_version: 7.0.10-46
+
+    steps:
+
+      - name: Install system dependencies
+        run: sudo apt install build-essential libxml2-dev libjpeg-dev libwebp-dev libpng-dev libopenjp2-7-dev
+
+      - name: Checkout repo
+        uses: actions/checkout@v2
+
+      - uses: actions/cache@v2
+        with:
+          path: imagemagick
+          key: imagick1-${{ env.imagemagick_version }}
+
+      - name: Install imagemagick
+        run: bash install_imagemagick.sh
+
+      # Version taken from .ruby-version file.
+      # Also runs bundle install.
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
+
+      - run: bundle exec rake test
+
+      - run: bundle exec rubocop

data/.gitignore

@@ -1,4 +1,5 @@
 /.bundle/
+/docs/.bundle/
 /.yardoc
 /Gemfile.lock
 /_yardoc/
@@ -13,3 +14,5 @@ jekyll-picture-tag.iml
 /docs/_site/
 /docs/.jekyll-cache/
 /docs/.sass-cache/
+/bin/
+/docs/bin/

data/.rubocop.yml

@@ -1,2 +1,32 @@
+# Exclude unimportant files
+require:
+  - rubocop-minitest
+  - rubocop-rake
+
+AllCops:
+  NewCops: enable
+  Include:
+    - 'lib/**/*.rb'
+    - 'test/**/*.rb'
+    - 'Gemfile'
+    - 'Rakefile'
+    - '*.gemspec'
+
+  Exclude:
+    - '**/.bundle/*'
+    - '**/.git/*'
+    - '**/.github/*'
+    - '**/bin/**/*'
+    - '**/coverage/**/*'
+    - '**/docs/**/*'
+    - '**/imagemagick/*'
+    - '**/pkg/**/*'
+    - '**/vendor/**/*'
+
+
+# Disabled Cops
 Style/FrozenStringLiteralComment:
   Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.5.8

data/docs/.envrc

@@ -0,0 +1,2 @@
+# if you run bundle install --binstubs, you won't have to use bundle exec all the time.
+export PATH=$(git rev-parse --show-toplevel)/docs/bin:$PATH

data/docs/Gemfile

@@ -1,4 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'github-pages', group: :jekyll_plugins
-gem 'jekyll-theme-slate'
+group :jekyll_plugins do
+  gem 'github-pages'
+  gem 'jekyll-rtd-theme'
+end

data/docs/Gemfile.lock

@@ -1,7 +1,7 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3)
+    activesupport (6.0.3.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -28,12 +28,12 @@ GEM
     execjs (2.7.0)
     faraday (1.0.1)
       multipart-post (>= 1.2, < 3)
-    ffi (1.12.2)
+    ffi (1.13.1)
     forwardable-extended (2.6.0)
     gemoji (3.0.1)
-    github-pages (204)
+    github-pages (206)
       github-pages-health-check (= 1.16.1)
-      jekyll (= 3.8.5)
+      jekyll (= 3.8.7)
       jekyll-avatar (= 0.7.0)
       jekyll-coffeescript (= 1.1.1)
       jekyll-commonmark-ghpages (= 0.1.6)
@@ -72,7 +72,7 @@ GEM
       mercenary (~> 0.3)
       minima (= 2.5.1)
       nokogiri (>= 1.10.4, < 2.0)
-      rouge (= 3.13.0)
+      rouge (= 3.19.0)
       terminal-table (~> 1.4)
     github-pages-health-check (1.16.1)
       addressable (~> 2.3)
@@ -80,13 +80,13 @@ GEM
       octokit (~> 4.0)
       public_suffix (~> 3.0)
       typhoeus (~> 1.3)
-    html-pipeline (2.12.3)
+    html-pipeline (2.13.0)
       activesupport (>= 2)
       nokogiri (>= 1.4)
     http_parser.rb (0.6.0)
     i18n (0.9.5)
       concurrent-ruby (~> 1.0)
-    jekyll (3.8.5)
+    jekyll (3.8.7)
       addressable (~> 2.4)
       colorator (~> 1.0)
       em-websocket (~> 0.5)
@@ -136,6 +136,8 @@ GEM
       addressable (~> 2.0)
       jekyll (>= 3.5, < 5.0)
       rubyzip (>= 1.3.0)
+    jekyll-rtd-theme (0.1.6)
+      github-pages (~> 206)
     jekyll-sass-converter (1.5.2)
       sass (~> 3.4)
     jekyll-seo-tag (2.6.1)
@@ -202,9 +204,9 @@ GEM
       jekyll (>= 3.5, < 5.0)
       jekyll-feed (~> 0.9)
       jekyll-seo-tag (~> 2.1)
-    minitest (5.14.0)
+    minitest (5.14.1)
     multipart-post (2.1.1)
-    nokogiri (1.10.9)
+    nokogiri (1.10.10)
       mini_portile2 (~> 2.4.0)
     octokit (4.18.0)
       faraday (>= 0.9)
@@ -215,7 +217,7 @@ GEM
     rb-fsevent (0.10.4)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
-    rouge (3.13.0)
+    rouge (3.19.0)
     ruby-enum (0.8.0)
       i18n
     rubyzip (2.3.0)
@@ -236,14 +238,14 @@ GEM
     tzinfo (1.2.7)
       thread_safe (~> 0.1)
     unicode-display_width (1.7.0)
-    zeitwerk (2.3.0)
+    zeitwerk (2.4.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   github-pages
-  jekyll-theme-slate
+  jekyll-rtd-theme
 
 BUNDLED WITH
    2.1.4

data/docs/_config.yml

@@ -1,13 +1,9 @@
-theme: jekyll-theme-slate
+remote_theme: rundocs/jekyll-rtd-theme
+
 title: Jekyll Picture Tag
+description: Images for Jekyll, done correctly.
+lang: en-US
 
-url: ''
 baseurl: '/jekyll_picture_tag'
-
-defaults:
-  - 
-    scope: 
-      path: ''
-    values:
-      layout: directory
-  
+readme_index: 
+  with_frontmatter: true

data/docs/devs/contributing/code.md

@@ -0,0 +1,46 @@
+---
+sort: 4
+---
+
+# Code
+
+## Guidelines
+
+* Generally, go for straightforward and readable rather than terse and clever. I'm not actually a
+  very good programmer; I need simple code that's easy to understand.
+
+* Refactoring is welcome, especially in the name of the previous point.
+
+* I'm very reluctant to introduce breaking changes to configuration settings. This rule isn't
+  absolute, but I'm not going to do it without a good reason.
+
+* Don't disable cops without strong justification.
+
+* I generally try to write tests before writing code, especially when fixing bugs. This
+  gives us some confidence that what we think we're testing and what we're actually testing aren't
+  too different.
+
+## Hard rules
+
+These aren't the rules for submitting a pull request, these are the rules for merging into master.
+I'm thrilled to receive any help at all, and I'm more than happy to help with meeting these
+criteria:
+
+* Liquid tag syntax can only be extended; no breaking changes. I'm not willing to force
+  users to dig through their entire site and change every picture tag in order to update to the
+  latest version.
+
+* Maintain "no configuration required" - a new user must be able to add JPT to their gemfile, bundle
+  install, and start writing picture tags in their site without touching a yml file.
+
+* 100% test coverage (Meaning that when running the unit and integration tests together, every line
+  of code in the `lib` folder must run at least once.)
+
+* No failing tests
+
+* No rubocop warnings
+
+## Thanks!
+
+As I said, don't let any of the rules & guidelines scare you away. They're the rules for merging
+into master, not submitting a pull request. I'm thrilled to receive any help at all.

data/docs/devs/contributing/docs.md

@@ -0,0 +1,31 @@
+---
+sort: 2
+---
+
+# Docs
+
+The docs are a mini-project in the docs folder. They don't have a dedicated git repository, but they
+do have their own Gemfile. They run on Github Pages, which is based on Jekyll.
+
+The format is simple; markdown files with a few lines of metadata at the top, organized into
+subdirectories. We're using the [jekyll-rtd-theme](https://jekyll-rtd-theme.rundocs.io/).
+
+You can preview as you edit; first the setup:
+
+``` sh
+$ git clone git@github.com:rbuchberger/jekyll_picture_tag.git # if you haven't already
+$ cd jekyll_picture_tag/docs
+$ direnv allow # (optional)
+$ bundle install --binstubs # --binstubs is optional.
+```
+
+If you use direnv or add `docs/bin` to your `PATH` another way, the `--binstubs` flag allows you to
+skip `bundle exec`.
+
+To preview:
+
+``` sh
+$ jekyll serve --livereload # (prefix with `bundle exec` if necessary)
+```
+
+* In a web browser, navigate to `localhost:4000/jekyll_picture_tag/`

data/docs/devs/contributing/index.md

@@ -0,0 +1,15 @@
+---
+---
+# Contributing
+
+Bug reports, feature requests, and feedback are very welcome, either through
+github issues or via email: robert@buchberger.cc 
+
+Pull requests are encouraged! I'm happy to answer questions and provide
+assistance along the way.  Don't let any of the recommendations/requests in this
+guide stop you from submitting one.
+
+I think one of the biggest opportunities for improvement in this plugin is its
+documentation. I'd really love help here, and all you need to know is markdown.
+
+{% include list.liquid %}

data/docs/devs/contributing/setup.md

@@ -0,0 +1,33 @@
+---
+sort: 1
+---
+
+## Setup
+
+I use [asdf](https://github.com/asdf-vm/asdf) and [direnv](https://direnv.net/) (via
+[asdf-direnv](https://github.com/asdf-community/asdf-direnv)). They add convenience, but they aren't
+required by any means.
+
+### With asdf & direnv:
+
+```sh
+$ git clone git@github.com:rbuchberger/jekyll_picture_tag.git
+$ cd jekyll_picture_tag
+$ direnv allow
+$ asdf install
+$ bundle install --binstubs
+```
+
+### Without asdf & direnv
+
+```sh
+$ git clone git@github.com:rbuchberger/jekyll_picture_tag.git
+$ cd jekyll_picture_tag
+# Install the correct version of ruby, with the bundler gem.
+$ bundle install
+```
+
+* The currently targeted ruby version can be found in the `.ruby-version` file in the project root;
+  ensure your version manager of choice knows about it.
+* If you add the project's `bin/` folder to your path, and run `bundle install --binstubs`, you won't
+  have to use `bundle exec` for `rake` commands and such.

data/docs/devs/contributing/testing.md

@@ -0,0 +1,34 @@
+---
+sort: 3
+---
+
+# Tests
+
+The primary way to run these checks is `rake`:
+
+| rake command                | function                        |
+|-----------------------------|---------------------------------|
+| `rake unit`                 | Unit tests only                 |
+| `rake integration`          | Integration tests only          |
+| `rake test`                 | Both unit and integration tests |
+| `rake rubocop`              | Check code formatting           |
+| `rake rubocop:auto_correct` | Fix rubocop issues, if possible |
+| `rake`                      | Run all checks                  |
+
+* Ignore the mini_magick `method redefined` warnings (unless you know how to fix them?) 
+* Depending on your environment, you may need to prefix all rake commands with `bundle exec`
+* Simplecov is set up -- you'll get a measurement of coverage in the test output and a nice report
+  in the `coverage` directory.
+* The tests use the `/tmp/` directory directly, which I'm pretty sure means it won't work on
+  Windows. This is fixable, so if that gets in your way just ask.
+
+### Docker
+
+The tests use some features of ImageMagick 7 which are not supported by version 6. If it's
+inconvenient to install version 7, the following commands will build and run the tests in a docker
+container:
+
+```bash
+$ docker build . -t jpt
+$ docker run -t jpt
+```

data/docs/devs/index.md

@@ -0,0 +1,7 @@
+---
+sort: 2
+---
+
+# Development
+
+{% include list.liquid %}

data/docs/{releases.md → devs/releases.md}

@@ -1,7 +1,32 @@
 ---
 ---
 # Release History
-
+* 1.14.0 January 10, 2021
+  * Gracefully handle empty tag arguments.
+  * Re-add metadata stripping. I removed it inadvertently when refactoring; now
+    there's a test and a setting to turn it off.
+  * Respect Jekyll's `--disable-disk-cache` argument.
+  * Add baseurl configuration, allowing increased plugin support (such as I18n via `jekyll-multiple-languages-plugin`)
+  * Tooling & test suite maintenance and improvements.
+* 1.13.0 November 23, 2020
+  * Add image quality interpolation; allows for variable image quality based on image size.
+  * Bugfix: Perform format, resize, and quality changes simultaneously rather than individually.
+    * Allows for actual lossless webp: simply set quality to 100.
+    * Improves fresh (no cached images) build times by ~15%
+    * Fix problems with poor image quality.
+* 1.12.0 July 30, 2020
+  * Documentation overhaul. Now with 87% less scrolling!
+  * Rename `markup_presets` and `media_presets` to `presets` and
+    `media_queries`. The old names were bad and caused confusion. The old names
+    will continue to work until the next major version is released.
+* 1.11.0 July 27, 2020
+  * **Width and height attribute support!** Begone, page reflow.
+  * Cache image information between builds
+  * Change image naming format. This update will trigger all images to be
+    regenerated, so you may want to delete your generated images folder
+    beforehand.
+* 1.10.2 July 6, 2020
+  * Bugfix for fallback image files not actually getting generated
 * 1.10.1 July 2, 2020
   * Bugfix for erroneously regenerated images
 * 1.10.0 May 11, 2020
@@ -11,41 +36,44 @@
 * 1.9.0 Feb 2, 2020
   * Add `fast_build` global setting
   * Add `disabled` global setting
-  * Reduce unnecessary disk IO; sites with many source images should see build times improve when
-    no new images need to be generated.
-  * Add support for empty attributes; specifically so best-practice for decorative images (`alt=""`)
-    is possible.
+  * Reduce unnecessary disk IO; sites with many source images should see build
+  times improve when no new images need to be generated.
+  * Add support for empty attributes; specifically so best-practice for
+    decorative images (`alt=""`) is possible.
 * 1.8.0 Nov 25, 2019
   * Add `data_sizes` setting for the `data_` family of output formats.
 * 1.7.1 Nov 14, 2019
   * Fix some HTML attribute related bugs
   * Add a few items to the FAQ
 * 1.7.0 Aug 12, 2019
-  * Add support for setting generated image quality, either generally or specific to given
-    formats.
+  * Add support for setting generated image quality, either generally or
+    specific to given formats.
   * Add support for spaces and other url-encoded characters in filenames
-  * Documentation restructure - Moved it out of the wiki, into the `docs` folder.
+  * Documentation restructure - Moved it out of the wiki, into the `docs`
+    folder.
   * Bugfix: Fallback image width will now be checked against source image width.
   * Bugfix: Minor fix to nomarkdown wrapper output
-  * link_source will now target the base source image, rather than finding the biggest one.
+  * link_source will now target the base source image, rather than finding the
+    biggest one.
   * Remove fastimage dependency, add addressable dependency.
-  * Moderately significant refactoring and code cleanup 
+  * Moderately significant refactoring and code cleanup
   * Decent set of tests added
 * 1.6.0 Jul  2, 2019:
   * Missing Preset warning respects `data_dir` setting
   * Add `continue_on_missing` option
-* 1.5.0 Jun 26, 2019: 
+* 1.5.0 Jun 26, 2019:
   * better `{::nomarkdown}` necessity detection
   * allow user to override `{::nomarkdown}` autodetection
 * 1.4.0 Jun 26, 2019:
-  * Rename gem from `jekyll-picture-tag` to `jekyll_picture_tag`, allowing us to use rubygems again.
+  * Rename gem from `jekyll-picture-tag` to `jekyll_picture_tag`, allowing us to
+    use rubygems again.
   * Add new output format: `naked_srcset`.
 * 1.3.1 Jun 21, 2019: Bugfix
 * 1.3.0 Jun  7, 2019:
   * Initial compatibility with Jekyll 4.0
   * bugfixes
-  * change to generated image naming-- The first build after this update will be longer, and you
-    might want to clear out your generated images.
+  * change to generated image naming-- The first build after this update will be
+    longer, and you might want to clear out your generated images.
 * 1.2.0 Feb  9, 2019:
   * Add nomarkdown fix
   * noscript option
@@ -56,7 +84,8 @@
   * auto-orient images before stripping metadata
 * 1.0.2 Jan 18, 2019: Fix ruby version specification
 * 1.0.1 Jan 13, 2019: Added ruby version checking
-* **1.0.0** Nov 27, 2018: Rewrite from the ground up. See the [migration guide]({{ site.baseurl }}/migration).
+* **1.0.0** Nov 27, 2018: Rewrite from the ground up. See the
+* [migration guide]({{ site.baseurl }}/users/notes/migration).
 * 0.2.2 Aug  2, 2013: Bugfixes
 * 0.2.1 Jul 17, 2013: Refactor again, add Liquid parsing.
 * 0.2.0 Jul 14, 2013: Rewrite code base, bring in line with Jekyll Image Tag.