jekyll_img 0.2.9 → 0.2.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2fceb334580b84bf7a4238093ab6fb718d1b5fc84a087b1f554764be2ddae477
-  data.tar.gz: b0a489a01ee502e0bb4c6006610a8d82faf3561086fa4f57ce752158e0b9770a
+  metadata.gz: 6665da5a9ea0fb8a14413e6bbcb177802b4419ead9470bdc3bbacdee5fafce73
+  data.tar.gz: 055d42f74d2c6361672132652779eb2a3a05e01d1e6d706932f03248ff9dca84
 SHA512:
-  metadata.gz: 14a147fe5e8ee74caffa3c4919d31fc28389ed9c4d5571357fc4797f1efaba10960eb2cefe9a3ebc68a85e76a339acdc9916d1191df11a2f9d1381412fff085a
-  data.tar.gz: 9e7b3b29ea91638fd8f54e5320c9fc14ceef0456057cbd40d7b1d5e9c6803cfa65a01c7c76567e147be5cefcf270ce9721c328e65944b8c873ae63591956a180
+  metadata.gz: f4196b6105ee1f9c449440d9d134ef63db4196d839257bc1e333214c414785cacb9bef906074adbf532b470aa85e7df48a0231d8c556b3b54137b9a9b1233a20
+  data.tar.gz: d6585eb0051f441eaa9d00aec48e05e4a23e34045843feeb2e2d6a2255c6439229ce99c8c532deade048726af4b60d441d4c88521f30ab7b731cfcf4f013d4c2

data/.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   # - rubocop-jekyll
   - rubocop-md
   - rubocop-performance
@@ -64,6 +64,9 @@ Metrics/PerceivedComplexity:
 Naming/FileName:
   Exclude:
     - Rakefile
+    - Gemfile
+    - README.md
+    - CHANGELOG.md
 
 Naming/MemoizedInstanceVariableName:
   Enabled: false
@@ -86,6 +89,9 @@ Style/Documentation:
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Style/OneClassPerFile:
+  Enabled: false
+
 Style/StringConcatenation:
   Exclude:
     - spec/**/*

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Change Log
 
+## 0.2.11 /2026-09-11
+
+Not fixed yet:
+
+* Fixed bug related to max-width percentage specification
+
+## 0.2.10 /2026-07-04
+
+* Pry is no longer a production dependency
+
 ## 0.2.9 / 2025-05-19
 
 * `max-width` option added.
@@ -36,7 +46,7 @@
 * Corrected `README.md#Configuration` and fixed demo `_config.yml`
   so they correctly specify error handling for this plugin:
 
-  ```ruby
+  ```yaml
   img:
     die_on_img_error: false
     pry_on_img_error: false

data/README.md

@@ -345,7 +345,7 @@ end
 And then execute:
 
 ```shell
-$ bundle
+$ bundle install
 ```
 
 

data/lib/img_builder.rb

@@ -84,8 +84,9 @@ class ImgBuilder
   end
 
   def generate_wrapper
-    classes = ("imgWrapper #{@props.img_display} #{@props.align} #{@props.attr_size_class} " +
-              "#{@props.attr_max_width_class} #{@props.wrapper_class}").squish
+    classes = "imgWrapper #{@props.img_display} #{@props.align} #{@props.attr_size_class} " \
+              "#{@props.attr_max_width_class} #{@props.wrapper_class}"
+    classes = classes.squish
     styles = "#{@props.attr_width_style} #{@props.attr_max_width_style} #{@props.wrapper_style}".squish
     <<~END_HTML.remove_blank_lines
       <div class='#{classes}' style='#{styles}'>

data/lib/img_props.rb

@@ -9,8 +9,8 @@ class ImgProperties
                 :id, :img_display, :lazy, :local_src, :max_width, :nofollow, :priority, :src, :size, :style,
                 :target, :title, :url, :wrapper_class, :wrapper_style
 
-  SIZES = %w[eighthsize fullsize halfsize initial quartersize].freeze
-  UNITS = %w[Q ch cm em dvh dvw ex in lh lvh lvw mm pc px pt rem rlh svh svw vb vh vi vmax vmin vw %].freeze
+  SIZES = %w[eighthsize fullsize halfsize initial quartersize].freeze unless const_defined?(:SIZES)
+  UNITS = %w[Q ch cm em dvh dvw ex in lh lvh lvw mm pc px pt rem rlh svh svw vb vh vi vmax vmin vw %].freeze unless const_defined?(:UNITS)
 
   def attr_alt
     "alt='#{@alt}'" if @alt
@@ -29,16 +29,19 @@ class ImgProperties
     " rel='nofollow'" if @nofollow
   end
 
+  # FIXME: this method does not work when max-width is specified as a % or a unit such as 15em
+  # @return class name: max_fullsize, max_halfsize, max_quartersize
   def attr_max_width_class
     return nil if @max_width == false || @max_width.nil? || max_width_unit_specified?
 
-    unless SIZES.include?(@max_width)
+    unless SIZES.include?(@max_width) || @max_width.end_with?('%')
       msg = "'#{@max_width}' is not a recognized size; must be one of #{SIZES.join(', ')}, or an explicit unit."
       raise Jekyll::ImgError, msg
     end
-    "max_#{@max_width}"
+    "max_#{@max_width}" # FIXME: this only works with fullsize, halfsize, quartersize and not % or units
   end
 
+  # FIXME: this method does not work when width is specified as a unit such as 15em
   def attr_size_class
     return nil if @size == false || @size.nil? || size_unit_specified?
 
@@ -50,7 +53,11 @@ class ImgProperties
   end
 
   def attr_style_img
-    "style='width: 100%; #{@style}'".squish
+    if size_unit_specified?
+      "width: #{@size};"
+    else
+      "style='width: 100%; #{@style}'".squish
+    end
   end
 
   def attr_target

data/lib/jekyll_img/version.rb

@@ -1,3 +1,3 @@
 module JekyllImgVersion
-  VERSION = '0.2.9'.freeze
+  VERSION = '0.2.11'.freeze
 end

data/lib/jekyll_img.rb

@@ -1,6 +1,5 @@
 require 'jekyll_plugin_support'
 require 'helper/jekyll_plugin_helper'
-require 'pry'
 require_relative 'img_builder'
 require_relative 'img_props'
 require_relative 'source'

data/lib/source.rb

@@ -41,7 +41,7 @@ class Source
     return result unless result.end_with? '.webp' # we know @path will be a webp after this
 
     files = sorted_files
-    return files[0] if files.count == 1
+    return files[0] if files.one?
 
     files.each do |filename|
       ext = File.extname filename

data/spec/img_builder_spec.rb

@@ -3,33 +3,43 @@ require_relative '../lib/img_builder'
 require_relative '../lib/img_props'
 require_relative '../lib/source'
 
-# Test ImgProperties
+class ImgTest
+  attr_accessor :page, :cite, :url
+
+  def initialize
+    @page = { 'path' => 'mypage.html' }
+    @cite = 'this is a cite'
+    @url  = 'http://localhost:4001/mypage.html'
+  end
+end
+
 class ImgPropertiesTest
   RSpec.describe ImgBuilder do
     Dir.chdir("demo")
     props = ImgProperties.new
     props.src = '/assets/images/jekyll.webp'
-    builder = described_class.new(props)
+    img = ImgTest.new
+    builder = described_class.new(img, props)
 
     it 'generates sources' do
       actual = builder.source.generate
-      desired = [
+      expected = [
         '<source srcset="/assets/images/jekyll.webp" type="image/webp">',
         '<source srcset="/assets/images/jekyll.png" type="image/png">'
       ]
-      expect(actual).to match_array(desired)
+      expect(actual).to match_array(expected)
     end
 
     it 'generates a figcaption' do
-      desired = <<~END_STRING
+      expected = <<~END_STRING
         <figcaption class='imgFigCaption '>
         </figcaption>
       END_STRING
-      expect(builder.generate_figcaption).to match_ignoring_whitespace(desired)
+      expect(builder.generate_figcaption).to match_ignoring_whitespace(expected)
     end
 
     it 'generates a picture' do
-      desired = <<~END_DESIRED
+      expected = <<~END_DESIRED
         <picture class='imgPicture'>
           <source srcset="/assets/images/jekyll.webp" type="image/webp">
           <source srcset="/assets/images/jekyll.png" type="image/png">
@@ -40,12 +50,12 @@ class ImgPropertiesTest
         </picture>
       END_DESIRED
       actual = builder.generate_picture
-      expect(actual).to match_ignoring_whitespace(desired)
+      expect(actual).to match_ignoring_whitespace(expected)
     end
 
     it 'generates a default img' do
-      desired = <<~END_IMG
-        <div class='imgWrapper imgFlex' style=' '>
+      expected = <<~END_IMG
+        <div class='imgWrapper imgFlex' style=''>
           <picture class='imgPicture'>
             <source srcset="/assets/images/jekyll.webp" type="image/webp">
             <source srcset="/assets/images/jekyll.png" type="image/png">
@@ -58,13 +68,13 @@ class ImgPropertiesTest
       END_IMG
 
       actual = builder.generate_wrapper
-      expect(actual).to match_ignoring_whitespace(desired)
+      expect(actual).to match_ignoring_whitespace(expected)
     end
 
     it 'generates an img wrapper with size and caption' do
       props.caption = 'This is a caption'
       props.size = '123px'
-      builder = described_class.new(props)
+      builder = described_class.new(img, props)
 
       caption = <<~END_CAPTION
         <figcaption class='imgFigCaption '>
@@ -72,8 +82,8 @@ class ImgPropertiesTest
         </figcaption>
       END_CAPTION
 
-      desired = <<~END_IMG
-        <div class='imgWrapper imgBlock' style='width: 123px; '>
+      expected = <<~END_IMG
+        <div class='imgWrapper imgBlock' style='width: 123px;'>
           <figure>
             <picture class='imgPicture'>
               <source srcset="/assets/images/jekyll.webp" type="image/webp">
@@ -91,7 +101,7 @@ class ImgPropertiesTest
       END_IMG
 
       actual = builder.generate_wrapper
-      expect(actual).to match_ignoring_whitespace(desired)
+      expect(actual).to match_ignoring_whitespace(expected)
     end
   end
 end

data/spec/img_props_spec.rb

@@ -71,30 +71,83 @@ class ImgPropertiesTest
       props.size = 'initial'
       expect(props.attr_size_class).to eq('initial')
 
+      props.target = 'moon'
+      expect(props.attr_target).to eq(" target='moon'")
+
+      props.title = 'The End'
+      expect(props.attr_title).to eq("title='The End'")
+
       props.size = '100px'
+      props.caption = 'A caption'
       expect(props.attr_size_class).to be_nil
-      expect(props.attr_style_img).to eq("style='width: 100%; '")
       expect(props.attr_width_style).to eq('width: 100px;')
+    end
+
+    it 'generates widths' do
+      props = described_class.new
+
+      props.size = '100px'
+      expect(props.attr_size_class).to be_nil
+      expect(props.attr_style_img).to eq('width: 100px;')
+      expect(props.attr_width_style).to eq('width: 100px;')
+
+      props.size = '100em'
+      expect(props.attr_size_class).to be_nil
+      expect(props.attr_style_img).to eq('width: 100em;')
+      expect(props.attr_width_style).to eq('width: 100em;')
 
       props.size = '10%'
       expect(props.attr_size_class).to be_nil
       expect(props.attr_width_style).to eq('width: 10%;')
-      expect(props.attr_style_img).to eq("style='width: 100%; '")
+      expect(props.attr_style_img).to eq('width: 10%;')
 
       props.size = 'fullsize'
       expect(props.attr_size_class).to eq('fullsize')
       expect(props.attr_width_style).to be_nil
 
-      props.target = 'moon'
-      expect(props.attr_target).to eq(" target='moon'")
+      props.size = 'halfsize'
+      expect(props.attr_size_class).to eq('halfsize')
+      expect(props.attr_width_style).to be_nil
 
-      props.title = 'The End'
-      expect(props.attr_title).to eq("title='The End'")
+      props.size = 'quartersize'
+      expect(props.attr_size_class).to eq('quartersize')
+      expect(props.attr_width_style).to be_nil
 
-      props.size = '100px'
-      props.caption = 'A caption'
-      expect(props.attr_size_class).to be_nil
-      expect(props.attr_width_style).to eq('width: 100px;')
+      props.size = 'eighthsize'
+      expect(props.attr_size_class).to eq('eighthsize')
+      expect(props.attr_width_style).to be_nil
+    end
+
+    it 'generates max_widths' do
+      props = described_class.new
+
+      props.max_width = '100px'
+      expect(props.attr_max_width_class).to be_nil
+      expect(props.attr_max_width_style).to eq('max-width: 100px;')
+
+      props.max_width = '100em'
+      expect(props.attr_max_width_class).to be_nil
+      expect(props.attr_max_width_style).to eq('max-width: 100em;')
+
+      props.max_width = '10%'
+      expect(props.attr_max_width_class).to be_nil
+      expect(props.attr_max_width_style).to eq('max-width: 10%;')
+
+      props.max_width = 'fullsize'
+      expect(props.attr_max_width_class).to eq('max_fullsize')
+      expect(props.attr_max_width_style).to be_nil
+
+      props.max_width = 'halfsize'
+      expect(props.attr_max_width_class).to eq('max_halfsize')
+      expect(props.attr_max_width_style).to be_nil
+
+      props.max_width = 'quartersize'
+      expect(props.attr_max_width_class).to eq('max_quartersize')
+      expect(props.attr_max_width_style).to be_nil
+
+      props.max_width = 'eighthsize'
+      expect(props.attr_max_width_class).to eq('max_eighthsize')
+      expect(props.attr_max_width_style).to be_nil
     end
   end
 end

data/spec/jekyll_img_spec.rb

@@ -5,7 +5,7 @@ require 'jekyll_plugin_support'
 require 'rspec/match_ignoring_whitespace'
 require_relative '../lib/jekyll_img'
 
-Registers = Struct.new(:page, :site) unless defined? :Registers
+Registers = Struct.new(:page, :site) unless defined? Registers
 
 # Mock for Collections
 class Collections
@@ -56,7 +56,7 @@ class MyTest
       )
     end
 
-    xit 'has no cite or url' do
+    it 'has no cite or url', skip: 'unfinished' do
       helper.reinitialize('src="./blah.webp"')
       img = described_class.send(
         :new,

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@ require_relative '../lib/jekyll_img'
 
 RSpec.configure do |config|
   config.filter_run_when_matching focus: true
-  config.order = 'random'
+  # config.order = 'random'
 
   # See https://relishapp.com/rspec/rspec-core/docs/command-line/only-failures
   config.example_status_persistence_file_path = 'spec/status_persistence.txt'

data/spec/status_persistence.txt

@@ -3,11 +3,13 @@ example_id                      | status | run_time        |
 ./spec/img_builder_spec.rb[1:1] | failed | 14.37 seconds   |
 ./spec/img_builder_spec.rb[1:2] | failed | 0.01498 seconds |
 ./spec/img_builder_spec.rb[1:3] | failed | 0.00093 seconds |
-./spec/img_props_spec.rb[1:1]   | passed | 0.00393 seconds |
-./spec/img_props_spec.rb[1:2]   | passed | 0.00006 seconds |
-./spec/img_props_spec.rb[1:3]   | passed | 0.00673 seconds |
-./spec/img_props_spec.rb[1:4]   | passed | 4.65 seconds    |
-./spec/img_props_spec.rb[1:5]   | passed | 0.00009 seconds |
+./spec/img_props_spec.rb[1:1]   | passed | 0.00174 seconds |
+./spec/img_props_spec.rb[1:2]   | passed | 0.00005 seconds |
+./spec/img_props_spec.rb[1:3]   | passed | 0.00189 seconds |
+./spec/img_props_spec.rb[1:4]   | passed | 0.00126 seconds |
+./spec/img_props_spec.rb[1:5]   | passed | 0.00006 seconds |
+./spec/img_props_spec.rb[1:6]   | passed | 0.00005 seconds |
+./spec/img_props_spec.rb[1:7]   | passed | 0.00005 seconds |
 ./spec/jekyll_img_spec.rb[1:1]  | failed | 40.84 seconds   |
 ./spec/source_spec.rb[1:1]      | passed | 0.00089 seconds |
 ./spec/source_spec.rb[1:2]      | passed | 0.0045 seconds  |

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jekyll_img
 version: !ruby/object:Gem::Version
-  version: 0.2.9
+  version: 0.2.11
 platform: ruby
 authors:
 - Mike Slinn
@@ -101,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.1
+rubygems_version: 4.0.21
 specification_version: 4
 summary: Provides a Jekyll tag that generates images.
 test_files: