jekyll-newsletter 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc734232e2002863e8a8694c868891049df398dd693da584bc39a06186ba43b2
-  data.tar.gz: b23c45c69ba80a683242be81c9202c7bae7ddbea69c4ea16fa8c88e45449d795
+  metadata.gz: ef3265eb0c0fb1640bdc076e51e2ed8ad5fda5e8c9e021ee45fd1bc26f542471
+  data.tar.gz: ec57058138e12defed971cfe4b4321185ad2081bb34646169831613c9c719248
 SHA512:
-  metadata.gz: 1d854e382af7883b83406a77cf79e4f098f0c0363b17eb126ee055c8be702232e55044d8781c79e03b0e28ef2796fc358548e23cd179e96e0f996ecf6b373f00
-  data.tar.gz: '08b6efbcad1a32452ce4c03a833bcd37aff8101710a8b8907548e79135c7edc605362623c06df0a67de04a2a8c708997baff1dd8a896c4a5731ece08d6f7740c'
+  metadata.gz: f25e08ce0d21d726eb3c5cbf661f464bb60bb3808c792ab58f92560224d2feaa71dcfea739871a11885bb4ade0bb06a61f8a115d69d4f52996e3d33c18f51733
+  data.tar.gz: 315178839fa98e294c55bcc20a0bff685e51fdb0e0ea8be6acb01e967be16f6697db79fd5d7c1391ba9dca7e6fe5b02ae022749915ba24cb5c2b949ea8989067

data/README.md

@@ -41,9 +41,25 @@ Environment variables:
 ```bash
 JEKYLL_NEWSLETTER_USERNAME # Defaults to From address
 JEKYLL_NEWSLETTER_PASSWORD
+JEKYLL_NEWSLETTER_TO # If it's a secret address
 JEKYLL_ENV=production # Anything else will just output the email
 ```
 
+The `to` option can be a single address or an array.
+For `JEKYLL_NEWSLETTER_TO` to have multiple addresses, use
+a comma-separated list.
+
+```yaml
+newsletter:
+  to:
+  - some@addre.ss
+  - another@o.ne
+```
+
+```bash
+JEKYLL_NEWSLETTER_TO=some@addre.ss,another@o.ne
+```
+
 ## Storage
 
 To keep track of which posts have already been sent, this plugin can use

data/lib/jekyll/newsletter.rb

@@ -25,7 +25,7 @@ module Jekyll
 
       return false unless mail.deliver
 
-      Jekyll.logger.info "Newsletter sent"
+      Jekyll.logger.info 'Newsletter sent'
 
       cache[key_for_post(post)] = Time.now if production?
 
@@ -38,7 +38,7 @@ module Jekyll
     def post
       @post ||= site.to_liquid['site']['posts'].find do |post|
         !cache[key_for_post(post)]
-      rescue
+      rescue StandardError
         # When the post isn't in the cache
         true
       end
@@ -48,7 +48,7 @@ module Jekyll
       @mail ||= begin
         mail = Mail.new
         mail.from      = config[:from]
-        mail.to        = [config[:to]].flatten
+        mail.to        = config[:to]
         mail.subject   = post.data['title']
         mail.html_part = post.content
         # TODO: We don't have access to Markdown on post_write because
@@ -63,13 +63,19 @@ module Jekyll
     end
 
     def config
-      @config ||= Jekyll::Utils.deep_merge_hashes(CONFIG, (site.config['newsletter'] || {}).transform_keys(&:to_sym)).tap do |config|
+      @config ||= Jekyll::Utils.deep_merge_hashes(CONFIG,
+                                                  (site.config['newsletter'] || {}).transform_keys(&:to_sym)).tap do |config|
+
+        config[:to] = [config[:to]].flatten
+        config[:to].concat(ENV['JEKYLL_NEWSLETTER_TO']&.split(',')&.map(&:strip) || [])
+        config[:to].compact!
+
         %i[to from].each do |o|
-          raise Jekyll::Errors::InvalidConfigurationError, "Missing `newsletter.#{o}` in _config.yml" if config[o].nil?
+          raise Jekyll::Errors::InvalidConfigurationError, "Missing `newsletter.#{o}` in _config.yml" if config[o].nil? || config[o].empty?
         end
 
         config[:delivery_method] = config[:delivery_method].to_sym
-        config[:options].transform_keys! &:to_sym
+        config[:options].transform_keys!(&:to_sym)
         config[:options][:user_name] ||= config[:from].scan(/<([^>]+)>/)&.flatten&.first || config[:from]
         config[:delivery_method] = :logger unless production?
       end.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jekyll-newsletter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - f
@@ -28,44 +28,44 @@ dependencies:
   name: mail
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.7'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '0.14'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.12'
 description: Picks the latest post and sends it by email
 email:
 - f@sutty.nl