jekyll-minibundle 2.2.0 → 3.0.0

data/lib/jekyll/minibundle/mini_stamp_tag.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'cgi/util'
 require 'jekyll/minibundle/files'
 require 'jekyll/minibundle/asset_file_registry'
@@ -63,7 +65,7 @@ module Jekyll::Minibundle
 
     def parse_structure(args)
       ::SafeYAML.load(args)
-    rescue => e
+    rescue StandardError => e
       raise ArgumentError, "Failed parsing ministamp tag argument syntax as YAML: #{args.inspect}. Cause: #{e}"
     end
 

data/lib/jekyll/minibundle/stamp_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'jekyll/minibundle/files'
 require 'jekyll/minibundle/asset_file_properties'
 require 'jekyll/minibundle/asset_stamp'
@@ -13,7 +15,9 @@ module Jekyll::Minibundle
     def initialize(site, asset_source_path, asset_destination_path)
       @site = site
       @asset_source_path = File.join(@site.source, asset_source_path)
+
       raise ArgumentError, "Stamp source file does not exist: #{@asset_source_path}" unless File.file?(@asset_source_path)
+
       @asset_destination_dir = File.dirname(asset_destination_path)
       @asset_destination_extension = File.extname(asset_destination_path)
       @asset_destination_filename_prefix = File.basename(asset_destination_path)[0..-(@asset_destination_extension.size + 1)]

data/lib/jekyll/minibundle/variable_template.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'strscan'
 
 module Jekyll::Minibundle
   class VariableTemplate
-    OPEN_TAG = '{{'.freeze
-    CLOSE_TAG = '}}'.freeze
-    ESCAPE_CHAR = '\\'.freeze
+    OPEN_TAG = '{{'
+    CLOSE_TAG = '}}'
+    ESCAPE_CHAR = '\\'
 
     def initialize(interpolation)
       instance_eval("def render(variables) #{interpolation} end", __FILE__, __LINE__)
@@ -15,9 +17,10 @@ module Jekyll::Minibundle
     end
 
     class SyntaxError < ArgumentError
-      CURSOR = '@'.freeze
+      CURSOR = '@'
 
       def initialize(message, template, position)
+        super()
         @message = message
         @template = template
         @position = position
@@ -27,15 +30,14 @@ module Jekyll::Minibundle
         template_before_pos = @template[0, @position]
         template_after_pos = @template[@position..-1]
 
-        <<-END
-#{@message} at position #{@position} in template (position highlighted with "#{CURSOR}"):
-#{template_before_pos}#{CURSOR}#{template_after_pos}
-        END
+        <<~MESSAGE
+          #{@message} at position #{@position} in template (position highlighted with "#{CURSOR}"):
+          #{template_before_pos}#{CURSOR}#{template_after_pos}
+        MESSAGE
       end
     end
 
     module Parser
-      # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def self.parse(template)
         raise ArgumentError, 'Nil template' if template.nil?
 
@@ -61,7 +63,9 @@ module Jekyll::Minibundle
             tokens << Token.text(text_buffer)
             text_buffer = ''
             close_match = scanner.scan_until(close_regex)
+
             raise SyntaxError.new(%{Missing closing tag ("#{CLOSE_TAG}") for variable opening tag ("#{OPEN_TAG}")}, template, scanner.charpos) unless close_match
+
             tokens << Token.variable(close_match[0..-(CLOSE_TAG.size + 1)].strip)
           end
 
@@ -73,7 +77,6 @@ module Jekyll::Minibundle
 
         tokens
       end
-      # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
       def self.make_escape_sequence_regexp
         escape_chars = (OPEN_TAG + CLOSE_TAG).chars.uniq
@@ -82,7 +85,7 @@ module Jekyll::Minibundle
       end
 
       def self.make_escape_sequence_or_open_tag_regexp
-        @_escape_sequence_or_open_tag_regexp ||=
+        @_make_escape_sequence_or_open_tag_regexp ||=
           begin
             regexp = [make_escape_sequence_regexp.join('|'), Regexp.escape(OPEN_TAG)].map { |p| "(#{p})" }.join('|')
             Regexp.compile(regexp)
@@ -90,7 +93,7 @@ module Jekyll::Minibundle
       end
 
       def self.make_close_tag_regexp
-        @_close_tag_regexp ||= Regexp.compile(Regexp.escape(CLOSE_TAG))
+        @_make_close_tag_regexp ||= Regexp.compile(Regexp.escape(CLOSE_TAG))
       end
     end
 

data/lib/jekyll/minibundle/variable_template_registry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'jekyll/minibundle/variable_template'
 
 module Jekyll::Minibundle

data/lib/jekyll/minibundle/version.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Jekyll
   module Minibundle
-    VERSION = '2.2.0'.freeze
+    VERSION = '3.0.0'
   end
 end

data/test/fixture/site/_bin/remove_comments

@@ -1,3 +1,4 @@
 #!/usr/bin/env sh
 
 grep -v '/\*'
+exit 0

data/test/fixture/site/_bin/with_count

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 filename = ARGV.first
 

data/test/fixture/site/_config.yml

@@ -1,2 +1,3 @@
-gems: ['jekyll/minibundle']
+plugins:
+  - jekyll/minibundle
 safe: false

data/test/integration/minibundle_development_mode_test.rb

@@ -1,12 +1,14 @@
-require 'support/test_case'
-require 'support/fixture_config'
+# frozen_string_literal: true
+
+require_relative '../support/test_case'
+require_relative '../support/fixture_config'
 
 module Jekyll::Minibundle::Test
   class MinibundleDevelopmentModeTest < TestCase
     include FixtureConfig
 
-    CSS_ASSET_DESTINATION_PATHS = %w{reset common}.map { |f| File.join(CSS_BUNDLE_DESTINATION_PATH, "#{f}.css") }
-    JS_ASSET_DESTINATION_PATHS = %w{dependency app}.map { |f| File.join(JS_BUNDLE_DESTINATION_PATH, "#{f}.js") }
+    CSS_ASSET_DESTINATION_PATHS = %w[reset common].map { |f| File.join(CSS_BUNDLE_DESTINATION_PATH, "#{f}.css") }
+    JS_ASSET_DESTINATION_PATHS = %w[dependency app].map { |f| File.join(JS_BUNDLE_DESTINATION_PATH, "#{f}.js") }
 
     def test_css_assets_have_tags_in_configured_order
       with_precompiled_site(:development) do
@@ -23,7 +25,7 @@ module Jekyll::Minibundle::Test
     def test_css_assets_have_configured_attributes
       with_precompiled_site(:development) do
         elements = find_css_elements_from_index.map { |el| [el['id'], el['media']] }.uniq
-        assert_equal([['my-styles', 'projection']], elements)
+        assert_equal([%w[my-styles projection]], elements)
       end
     end
 
@@ -78,15 +80,15 @@ module Jekyll::Minibundle::Test
         destination = destination_path(JS_BUNDLE_DESTINATION_PATH, 'app.js')
         org_mtime = file_mtime_of(destination)
 
-        match_snippet = <<-END
+        match_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
-        END
+        LIQUID
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts2
-        END
+        LIQUID
 
         ensure_file_mtime_changes do
           FileUtils.mv(source_path('_assets/scripts'), source_path('_assets/scripts2'))
@@ -105,16 +107,16 @@ module Jekyll::Minibundle::Test
 
         org_mtime = file_mtime_of(destination_path(JS_BUNDLE_DESTINATION_PATH, 'dependency.js'))
 
-        match_snippet = <<-END
+        match_snippet = <<-YAML
     assets:
       - dependency
       - app
-        END
+        YAML
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-YAML
     assets:
       - dependency
-        END
+        YAML
 
         ensure_file_mtime_changes do
           find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
@@ -227,19 +229,19 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: '{{ site.baseurl }}/'
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle js %}',
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     baseurl: {{ site.baseurl }}/js
-          END
+          LIQUID
         )
 
         generate_site(:development)
@@ -259,17 +261,17 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: /ignored
     destination_baseurl: {{ site.cdn_baseurl }}css/
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           /    #{Regexp.escape('{% minibundle js %}')}.*#{Regexp.escape('{% endminibundle %}')}/m,
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: static
@@ -279,7 +281,7 @@ module Jekyll::Minibundle::Test
       - dependency
       - app
     {% endminibundle %}
-          END
+          LIQUID
         )
 
         generate_site(:development)
@@ -367,10 +369,10 @@ module Jekyll::Minibundle::Test
           find_and_gsub_in_file(
             source_path('_layouts/default.html'),
             '    {% minibundle js %}',
-            <<-END
+            <<-LIQUID
     {% minibundle js %}
     baseurl: /js-root
-            END
+            LIQUID
           )
         end
 
@@ -392,10 +394,10 @@ module Jekyll::Minibundle::Test
           find_and_gsub_in_file(
             source_path('_layouts/default.html'),
             '    {% minibundle js %}',
-            <<-END
+            <<-LIQUID
     {% minibundle js %}
     destination_baseurl: /js-root/
-            END
+            LIQUID
           )
         end
 
@@ -422,6 +424,90 @@ module Jekyll::Minibundle::Test
       end
     end
 
+    def test_empty_asset_sources_produces_no_destination_assets
+      with_site_dir do
+        match_snippet = <<-YAML
+    assets:
+      - dependency
+      - app
+        YAML
+
+        replacement_snippet = <<-YAML
+    assets: []
+        YAML
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        generate_site(:development)
+
+        assert_empty([], find_js_paths_from_index)
+      end
+    end
+
+    def test_allows_relative_paths_in_asset_source_files
+      with_site_dir do
+        match_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets/scripts
+    destination_path: assets/site
+    assets:
+      - dependency
+      - app
+        LIQUID
+
+        replacement_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets
+    destination_path: assets/site
+    assets:
+      - scripts/dependencies/one
+      - ../_app
+        LIQUID
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        FileUtils.mkdir('_assets/scripts/dependencies')
+        FileUtils.mv(source_path('_assets/scripts/dependency.js'), source_path('_assets/scripts/dependencies/one.js'))
+        FileUtils.mv(source_path('_assets/scripts/app.js'), source_path('_app.js'))
+
+        generate_site(:development)
+
+        assert_equal(['assets/site/scripts/dependencies/one.js', 'assets/site/../_app.js'], find_js_paths_from_index)
+        assert(File.file?(destination_path('assets/site/scripts/dependencies/one.js')))
+        assert(File.file?(destination_path('assets/_app.js')))
+      end
+    end
+
+    def test_allows_root_dir_as_source_dir
+      with_site_dir do
+        match_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets/scripts
+    destination_path: assets/site
+    assets:
+      - dependency
+      - app
+        LIQUID
+
+        replacement_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: .
+    destination_path: assets/site
+    assets:
+      - _assets/scripts/dependency
+      - _assets/scripts/app
+        LIQUID
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        generate_site(:development)
+
+        assert_equal(%w[dependency app].map { |p| File.join(JS_BUNDLE_DESTINATION_PATH, '_assets/scripts', "#{p}.js") }, find_js_paths_from_index)
+        assert(File.file?(destination_path(File.join(JS_BUNDLE_DESTINATION_PATH, '_assets/scripts/dependency.js'))))
+        assert(File.file?(destination_path(File.join(JS_BUNDLE_DESTINATION_PATH, '_assets/scripts/app.js'))))
+      end
+    end
+
     private
 
     def find_css_elements_from_index
@@ -450,17 +536,17 @@ module Jekyll::Minibundle::Test
     end
 
     def change_destination_path_in_minibundle_block(from, to)
-      match_snippet = <<-END
+      match_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: #{from}
-      END
+      LIQUID
 
-      replacement_snippet = <<-END
+      replacement_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: #{to}
-      END
+      LIQUID
 
       find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
     end

data/test/integration/minibundle_production_mode_test.rb

@@ -1,5 +1,8 @@
-require 'support/test_case'
-require 'support/fixture_config'
+# frozen_string_literal: true
+
+require_relative '../support/test_case'
+require_relative '../support/fixture_config'
+require 'digest/md5'
 
 module Jekyll::Minibundle::Test
   class MinibundleProductionModeTest < TestCase
@@ -68,7 +71,7 @@ module Jekyll::Minibundle::Test
 
     def test_minifies_css_asset_bundle
       with_precompiled_site(:production) do
-        source_contents_size = source_assets_size(CSS_BUNDLE_SOURCE_DIR, %w{reset common}, 'css')
+        source_contents_size = source_assets_size(CSS_BUNDLE_SOURCE_DIR, %w[reset common], 'css')
         destination_contents_size = File.read(destination_path(CSS_BUNDLE_DESTINATION_FINGERPRINT_PATH)).size
         assert_operator(destination_contents_size, :<, source_contents_size)
       end
@@ -76,7 +79,7 @@ module Jekyll::Minibundle::Test
 
     def test_minifies_js_asset_bundle
       with_precompiled_site(:production) do
-        source_contents_size = source_assets_size(JS_BUNDLE_SOURCE_DIR, %w{dependency app}, 'js')
+        source_contents_size = source_assets_size(JS_BUNDLE_SOURCE_DIR, %w[dependency app], 'js')
         destination_contents_size = File.read(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)).size
         assert_operator(destination_contents_size, :<, source_contents_size)
       end
@@ -120,15 +123,15 @@ module Jekyll::Minibundle::Test
 
         org_mtime = file_mtime_of(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH))
 
-        match_snippet = <<-END
+        match_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
-        END
+        LIQUID
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts2
-        END
+        LIQUID
 
         ensure_file_mtime_changes do
           FileUtils.mv(source_path('_assets/scripts'), source_path('_assets/scripts2'))
@@ -149,16 +152,16 @@ module Jekyll::Minibundle::Test
 
         assert(File.file?(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)))
 
-        match_snippet = <<-END
+        match_snippet = <<-YAML
     assets:
       - dependency
       - app
-        END
+        YAML
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-YAML
     assets:
       - dependency
-        END
+        YAML
 
         ensure_file_mtime_changes do
           find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
@@ -183,16 +186,16 @@ module Jekyll::Minibundle::Test
 
         assert(File.file?(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)))
 
-        match_snippet = <<-END
+        match_snippet = <<-YAML
     assets:
       - dependency
       - app
-        END
+        YAML
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-YAML
     assets:
       - dependency
-        END
+        YAML
 
         old_tempfiles = find_tempfiles('*.js') - other_tempfiles
 
@@ -290,14 +293,14 @@ module Jekyll::Minibundle::Test
         destination = destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)
         org_mtime = file_mtime_of(destination)
 
-        match_snippet = <<-END
+        match_snippet = <<-LIQUID
     {% minibundle js %}
-        END
+        LIQUID
 
-        replacement_snippet = <<-END
+        replacement_snippet = <<-LIQUID
     {% minibundle js %}
     minifier_cmd: #{minifier_cmd_to_remove_comments_and_count}
-        END
+        LIQUID
 
         ensure_file_mtime_changes do
           find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
@@ -351,19 +354,19 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: '{{ site.baseurl }}/'
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle js %}',
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     baseurl: {{ site.baseurl }}/js
-          END
+          LIQUID
         )
 
         generate_site(:production)
@@ -381,19 +384,19 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: .
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle js %}',
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     baseurl: .
-          END
+          LIQUID
         )
 
         generate_site(:production)
@@ -419,19 +422,19 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: ./
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle js %}',
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     baseurl: ./
-          END
+          LIQUID
         )
 
         generate_site(:production)
@@ -503,17 +506,17 @@ module Jekyll::Minibundle::Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           '    {% minibundle css %}',
-          <<-END
+          <<-LIQUID
     {% minibundle css %}
     baseurl: /ignored
     destination_baseurl: {{ site.cdn_baseurl }}css/
-          END
+          LIQUID
         )
 
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           /    #{Regexp.escape('{% minibundle js %}')}.*#{Regexp.escape('{% endminibundle %}')}/m,
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: static
@@ -523,7 +526,7 @@ module Jekyll::Minibundle::Test
       - dependency
       - app
     {% endminibundle %}
-          END
+          LIQUID
         )
 
         generate_site(:production)
@@ -618,10 +621,10 @@ module Jekyll::Minibundle::Test
           find_and_gsub_in_file(
             source_path('_layouts/default.html'),
             '    {% minibundle js %}',
-            <<-END
+            <<-LIQUID
     {% minibundle js %}
     baseurl: /js-root
-            END
+            LIQUID
           )
         end
 
@@ -646,10 +649,10 @@ module Jekyll::Minibundle::Test
           find_and_gsub_in_file(
             source_path('_layouts/default.html'),
             '    {% minibundle js %}',
-            <<-END
+            <<-LIQUID
     {% minibundle js %}
     destination_baseurl: /root/
-            END
+            LIQUID
           )
         end
 
@@ -693,27 +696,27 @@ module Jekyll::Minibundle::Test
 
     def test_minifier_command_in_local_block_overrides_command_from_environment
       with_site_dir do
-        IO.write('test.html', <<-END)
----
-layout: override
-title: Test
----
-        END
-
-        IO.write('_layouts/override.html', <<-END)
-<!DOCTYPE html>
-<html>
-  <body>
-    {% minibundle js %}
-    source_dir: _assets/scripts
-    destination_path: assets/deps
-    assets:
-      - dependency
-    minifier_cmd: #{minifier_cmd_to_remove_comments_and_count('minifier_cmd_local_count')}
-    {% endminibundle %}
-  </body>
-</html>
-        END
+        IO.write('test.html', <<~YAML)
+          ---
+          layout: override
+          title: Test
+          ---
+        YAML
+
+        IO.write('_layouts/override.html', <<~LIQUID)
+          <!DOCTYPE html>
+          <html>
+            <body>
+              {% minibundle js %}
+              source_dir: _assets/scripts
+              destination_path: assets/deps
+              assets:
+                - dependency
+              minifier_cmd: #{minifier_cmd_to_remove_comments_and_count('minifier_cmd_local_count')}
+              {% endminibundle %}
+            </body>
+          </html>
+        LIQUID
 
         generate_site(:production, minifier_cmd_js: minifier_cmd_to_remove_comments_and_count('minifier_cmd_global_count'))
 
@@ -739,7 +742,7 @@ title: Test
         find_and_gsub_in_file(
           source_path('_layouts/default.html'),
           /    #{Regexp.escape('{% minibundle js %}')}.*#{Regexp.escape('{% endminibundle %}')}/m,
-          <<-END
+          <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: 'dst">'
@@ -749,17 +752,102 @@ title: Test
     attributes:
       test: '"/><br>'
     {% endminibundle %}
-          END
+          LIQUID
         )
 
         generate_site(:production)
 
-        assert(File.file?(destination_path(%{dst">-#{JS_BUNDLE_FINGERPRINT}.js})))
-        assert_equal(%{dst">-#{JS_BUNDLE_FINGERPRINT}.js}, find_js_path_from_index)
+        assert(File.file?(destination_path(%(dst">-#{JS_BUNDLE_FINGERPRINT}.js))))
+        assert_equal(%(dst">-#{JS_BUNDLE_FINGERPRINT}.js), find_js_path_from_index)
         assert_equal('"/><br>', find_js_element_from_index['test'])
       end
     end
 
+    def test_empty_asset_sources_produces_empty_bundle
+      with_site_dir do
+        match_snippet = <<-YAML
+    assets:
+      - dependency
+      - app
+        YAML
+
+        replacement_snippet = <<-YAML
+    assets: []
+        YAML
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        generate_site(:production)
+
+        destination = "assets/site-#{Digest::MD5.hexdigest('')}.js"
+
+        assert_equal(destination, find_js_path_from_index)
+        assert(File.file?(destination_path(destination)))
+      end
+    end
+
+    def test_allows_relative_paths_in_asset_source_files
+      with_site_dir do
+        match_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets/scripts
+    destination_path: assets/site
+    assets:
+      - dependency
+      - app
+        LIQUID
+
+        replacement_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets
+    destination_path: assets/site
+    assets:
+      - scripts/dependencies/one
+      - ../_app
+        LIQUID
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        FileUtils.mkdir('_assets/scripts/dependencies')
+        FileUtils.mv(source_path('_assets/scripts/dependency.js'), source_path('_assets/scripts/dependencies/one.js'))
+        FileUtils.mv(source_path('_assets/scripts/app.js'), source_path('_app.js'))
+
+        generate_site(:production)
+
+        assert_equal(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH, find_js_path_from_index)
+        assert(File.file?(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)))
+      end
+    end
+
+    def test_allows_root_dir_as_source_dir
+      with_site_dir do
+        match_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: _assets/scripts
+    destination_path: assets/site
+    assets:
+      - dependency
+      - app
+        LIQUID
+
+        replacement_snippet = <<-LIQUID
+    {% minibundle js %}
+    source_dir: .
+    destination_path: assets/site
+    assets:
+      - _assets/scripts/dependency
+      - _assets/scripts/app
+        LIQUID
+
+        find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
+
+        generate_site(:production)
+
+        assert_equal(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH, find_js_path_from_index)
+        assert(File.file?(destination_path(JS_BUNDLE_DESTINATION_FINGERPRINT_PATH)))
+      end
+    end
+
     private
 
     def find_css_element_from_index
@@ -790,17 +878,17 @@ title: Test
     end
 
     def change_destination_path_in_minibundle_block(from, to)
-      match_snippet = <<-END
+      match_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: #{from}
-      END
+      LIQUID
 
-      replacement_snippet = <<-END
+      replacement_snippet = <<-LIQUID
     {% minibundle js %}
     source_dir: _assets/scripts
     destination_path: #{to}
-      END
+      LIQUID
 
       find_and_gsub_in_file(source_path('_layouts/default.html'), match_snippet, replacement_snippet)
     end