jekyll-link-decorator 1.0.3 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0f9b808eb1a08ff1ec662bbe580907599e65a41f0841dcd1fc00afd753b4964
-  data.tar.gz: f013b30a4b34f9da6e30ff10f5d305513f2b2b7a8ef675ff3630a665ce069e58
+  metadata.gz: 619db9eef6ac8d8df96816793e684628c919b41447b01b3378035d927df5500d
+  data.tar.gz: 69048aacba831a96a6234cd29075b1056840ac75486c872ea82a6cfabc6b3ebe
 SHA512:
-  metadata.gz: 1c3f7778766e27f923060547092f58a3632e46caacb21aeaa0a6c027465ef3c6fd3cf17064379cbe00c10c608a4f2c91c195096816be71bcdd40551a4e21475d
-  data.tar.gz: 97643a1ee4b81a731e9b7f23341f30f38db54de807c94fe54322413e20877e4c675d36863dcd9f69471942706b504c401280977786148c5dd04d77313e40c131
+  metadata.gz: 5c3123e6476a23b53171051a05cbafc6e936d945a62ae9738c9248469bd46e3fd6511bea3b4d5aa7b88e4a0e40551a42e6c42024006e4050a8f563d45dd72d86
+  data.tar.gz: 4204292972a14bf0c734c713bd2ab1dde5c65216239ef1c79ce67d2fbd297c44aa286a637bbebc89cc762efe16ea1d933ad4b19e4cce8349e52069267ff67b75

data/lib/jekyll-link-decorator.rb

@@ -52,6 +52,14 @@
 
 require 'nokogiri'
 
+EXISTING_ICON_SELECTORS = [
+  'i[class*="fa-external-link"]',
+  'i[class*="up-right-from-square"]',
+  'svg[data-icon="external-link"]',
+  'svg[data-icon="up-right-from-square"]',
+  'svg[data-icon="arrow-up-right-from-square"]'
+].freeze
+
 module Jekyll
   module Converters
     # This custom converter applies specific CSS classes to <a> tags
@@ -59,6 +67,11 @@ module Jekyll
     # buttons, all done via Nokogiri's powerful CSS selectors.
     # It also adds external-link icons for cross-domain external links.
     class LinkDecorator < Jekyll::Converters::Markdown
+      DEFAULT_LINK_CLASSES = 'link link-offset-3 link-offset-3-hover link-underline-primary ' \
+                             'link-underline-opacity-0 link-underline-opacity-100-hover'
+      DEFAULT_ALERT_CLASSES = 'alert-link'
+      DEFAULT_EXTERNAL_LINK_ICON = true
+
       def self.name
         'LinkDecorator'
       end
@@ -84,28 +97,24 @@ module Jekyll
       # - Link domain is different from site.url domain
       # - Link doesn't already have an external-link icon child
       def is_external_different_domain_link?(link, site_domain)
-        href = link['href'].to_s
+        return false unless absolute_different_domain?(link, site_domain)
+        return false if EXISTING_ICON_SELECTORS.any? { |sel| link.css(sel).any? }
+
+        true
+      end
 
-        # Check if it's an absolute URL with http/https
+      # Returns true when href is an absolute http(s) URL pointing to a domain
+      # different from site_domain. Shared guard used by both domain-check methods.
+      def absolute_different_domain?(link, site_domain)
+        href = link['href'].to_s
         return false unless %r{^https?://}.match?(href)
 
-        # Extract domain from the link
         link_domain = extract_domain(href)
-
-        # Check if domains are different
         return false if link_domain == site_domain || link_domain.empty?
 
-        # Check if an icon has already been added (avoid duplicates)
-        # Check for both new icons (fa-external-link) and old icons
-        # (fa-external-link-alt, fa-up-right-from-square, etc.)
-        return false if link.css('i[class*="fa-external-link"]').any?
-        return false if link.css('i[class*="up-right-from-square"]').any?
-        return false if link.css('svg[data-icon="external-link"]').any?
-        return false if link.css('svg[data-icon="up-right-from-square"]').any?
-        return false if link.css('svg[data-icon="arrow-up-right-from-square"]').any?
-
         true
       end
+      private :absolute_different_domain?
 
       # Determine if a link points to an external domain
       # Returns true if:
@@ -120,16 +129,7 @@ module Jekyll
         # Relative URLs (starting with / or ../) are internal links
         return false if %r{^(/|\.\.)}.match?(href)
 
-        # Check if it's an absolute URL with http/https
-        return false unless %r{^https?://}.match?(href)
-
-        # Extract domain from the link
-        link_domain = extract_domain(href)
-
-        # Check if domains are different
-        return false if link_domain == site_domain || link_domain.empty?
-
-        true
+        absolute_different_domain?(link, site_domain)
       end
 
       # Add target="_blank" to external cross-domain links
@@ -175,6 +175,10 @@ module Jekyll
 
       def convert(content)
         html = super
+        decorate_html(html)
+      end
+
+      def decorate_html(html)
         enabled = @config.key?('with_link_decorator') ? @config['with_link_decorator'] : true
         config = @config['with_link_decorator_data'] || {}
 
@@ -206,9 +210,8 @@ module Jekyll
 
       # Apply CSS classes to links based on their context (alert or default)
       def apply_link_styles(doc, config)
-        default_classes = config.fetch('default_link_classes',
-                                       'link link-offset-3 link-offset-3-hover link-underline-primary link-underline-opacity-0 link-underline-opacity-100-hover')
-        alert_classes = config.fetch('alert_link_classes', 'alert-link')
+        default_classes = config.fetch('default_link_classes', DEFAULT_LINK_CLASSES)
+        alert_classes   = config.fetch('alert_link_classes',   DEFAULT_ALERT_CLASSES)
 
         # Apply alert classes to links inside p.alert
         doc.css('p.alert a:not(.btn)').each do |link|
@@ -246,7 +249,7 @@ module Jekyll
 
       # Add external-link icon to cross-domain external links
       def add_external_icon(link, site_domain, config, doc)
-        external_link_icon = config.fetch('external_link_icon', true)
+        external_link_icon = config.fetch('external_link_icon', DEFAULT_EXTERNAL_LINK_ICON)
 
         return unless external_link_icon
         return unless is_external_different_domain_link?(link, site_domain)
@@ -257,4 +260,19 @@ module Jekyll
       end
     end
   end
+
+  module Filters
+    # Liquid filter that applies link decoration to already-converted HTML.
+    # Use after the markdownify filter to decorate links in YAML data fields:
+    #   {{ data.message | markdownify | decorate_links }}
+    module LinkDecoratorFilter
+      def decorate_links(html)
+        site = @context.registers[:site]
+        decorator = Jekyll::Converters::LinkDecorator.new(site.config)
+        decorator.decorate_html(html)
+      end
+    end
+  end
 end
+
+Liquid::Template.register_filter(Jekyll::Filters::LinkDecoratorFilter)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jekyll-link-decorator
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.1.1
 platform: ruby
 authors:
 - ReleaseBot
@@ -53,30 +53,30 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: '13.1'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -147,6 +147,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.26'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement