jekyll-ical-tag 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 56b34cd54ee295b4125928f2d1c0ab010fc73073f013afcd485d3f94f2f7d1e7
-  data.tar.gz: 6c04c4593314888e2f9f4dfbf13f9b3bd980d0739d5661bbf41243d1d8834cc8
+  metadata.gz: 91c6e8bb4e6260b727de3f135494c7abe007d6136cb62d959ba142e885727964
+  data.tar.gz: 4f21845ffef36b8004af8d408d65fc4da36f342826032a397564662806388d3f
 SHA512:
-  metadata.gz: 69a6fd90da57c3b2b2a26065f83d4197d82e8e8fcba655acaba83485e56dd26a23dfda4b5353491027146045f740649ce01897552e9a433292fe45f9b88aa0bc
-  data.tar.gz: dbdbb209e8fdfed7653383ffac23c45b00579a4384789c8e11d01110de3f62fe92dae6701eb8dd231e8ab4f4d48a1979f563474b22895b1b5388b8d148004b2f
+  metadata.gz: 7616ae73da4c128dd77b3538d593f2961f260f06928164ca5b1ffa2c05999f1573203a38cdc065762452466a3e4c70cdcff405fc589d98959495e45d37be79b7
+  data.tar.gz: e2322a1d26c1f695e4e2b7031ff35be8804074f8d0b224f7c35ef81ee4e4c9559982cd7ba373f917fce8dcfe911444841a06916a53676c73aff2f238f3b7e35f

data/bin/rspec

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rspec' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rspec-core", "rspec")

data/lib/jekyll-ical-tag.rb

@@ -6,15 +6,18 @@ require "jekyll-ical-tag/version"
 
 module Jekyll
   class IcalTag < Liquid::Block
-    require_relative "jekyll-ical-tag/event"
-    require_relative "jekyll-ical-tag/calendar_parser"
+    require_relative "jekyll-ical-tag/calendar_feed_coordinator"
+    require_relative "jekyll-ical-tag/calendar_fetcher"
     require_relative "jekyll-ical-tag/calendar_limiter"
+    require_relative "jekyll-ical-tag/calendar_parser"
+    require_relative "jekyll-ical-tag/event"
 
     include Convertible
 
     def initialize(tag_name, markup, parse_context)
       super
       @markup = markup
+      @attributes = {}
 
       scan_attributes!
       set_limit!
@@ -31,22 +34,11 @@ module Jekyll
       result = []
 
       context.stack do
-        url = get_dereferenced_url(context) ||
-              @url
-
-        raise "No URL provided or in innapropriate form '#{url}'" unless is_valid_url?(url)
-
-        puts "Fetching #{url}"
+        url = get_dereferenced_url(context) || @url
 
-        parser = CalendarParser.new(url)
-        parser = CalendarLimiter.new(parser, only: @only)
-        parser = CalendarLimiter.new(parser, reverse: @reverse)
-        parser = CalendarLimiter.new(parser, before_date: @before_date)
-        parser = CalendarLimiter.new(parser, after_date: @after_date)
-        parser = CalendarLimiter.new(parser, limit: @limit)
-
-        events = parser.events
-        length = events.length
+        calendar_feed_coordinator = CalendarFeedCoordinator.new(url: url)
+        events = calendar_feed_coordinator.events
+        event_count = events.length
 
         events.each_with_index do |event, index|
           # Init
@@ -69,32 +61,15 @@ module Jekyll
           context["event"]["end_time"] = context["event"]["dtend"]
           context["event"]["start_time"] = context["event"]["dtstart"]
 
-          # Ensure all event values are utf8 encoded strings
-          # Ensure times (from dates)
-          # Ensure present
-          context["event"].transform_values! do |value|
-            v = case value
-              when String, Icalendar::Values::Text
-                value.force_encoding("UTF-8")
-              when Date, Icalendar::Values::DateTime
-                value.to_time
-              when Icalendar::Values::Uri
-                value.to_s
-              else
-                value
-              end
-            v.presence
-          end
-
           context["forloop"] = {
             "name" => "ical",
-            "length" => length,
+            "length" => event_count,
             "index" => index + 1,
             "index0" => index,
-            "rindex" => length - index,
-            "rindex0" => length - index - 1,
+            "rindex" => event_count - index,
+            "rindex0" => event_count - index - 1,
             "first" => (index == 0),
-            "last" => (index == length - 1),
+            "last" => (index == event_count - 1),
           }
 
           result << nodelist.map do |n|
@@ -112,10 +87,6 @@ module Jekyll
 
     private
 
-    def is_valid_url?(url)
-      !!(url =~ URI::regexp)
-    end
-
     def get_dereferenced_url(context)
       return unless context.key?(@url)
 
@@ -123,7 +94,6 @@ module Jekyll
     end
 
     def scan_attributes!
-      @attributes = {}
       @markup.scan(Liquid::TagAttributes) do |key, value|
         @attributes[key] = value
       end
@@ -147,10 +117,11 @@ module Jekyll
       only_past = @attributes["only_past"] == "true"
 
       raise "Set only_future OR only_past, not both" if only_future && only_past
-      @only = case
-        when only_future
+
+      @only =
+        if only_future
           :future
-        when only_past
+        elsif only_past
           :past
         else
           :all
@@ -158,21 +129,19 @@ module Jekyll
     end
 
     def set_before_date!
-      @before_date = begin
-          if @attributes["before_date"]
-            Time.parse(@attributes["before_date"])
-          end
-        rescue => e
+      @before_date =
+        begin
+          Time.parse(@attributes["before_date"])
+        rescue
           nil
         end
     end
 
     def set_after_date!
-      @after_date = begin
-          if @attributes["after_date"]
-            Time.parse(@attributes["after_date"])
-          end
-        rescue => e
+      @after_date =
+        begin
+          Time.parse(@attributes["after_date"])
+        rescue
           nil
         end
     end

data/lib/jekyll-ical-tag/calendar_feed_coordinator.rb

@@ -0,0 +1,43 @@
+# encoding: utf-8
+# frozen_string_literal: true
+
+require "cgi"
+require "api_cache"
+
+module Jekyll
+  class IcalTag
+    class CalendarFeedCoordinator
+      def initialize(url:, only: nil, reverse: nil, before_date: nil, after_date: nil, limit: nil)
+        @url = url
+        @only = only
+        @reverse = reverse
+        @before_date = before_date
+        @after_date = after_date
+        @limit = limit
+      end
+
+      def events
+        parser.events
+      end
+
+      private
+
+      attr_reader :url, :only, :reverse, :before_date, :after_date, :limit
+
+      def raw_ical
+        @raw_ical ||= CalendarFetcher.new(url).fetch
+      end
+
+      def parser
+        @parser ||= begin
+          parser = CalendarParser.new(raw_ical)
+          parser = CalendarLimiter.new(parser, only: only)
+          parser = CalendarLimiter.new(parser, reverse: reverse)
+          parser = CalendarLimiter.new(parser, before_date: before_date)
+          parser = CalendarLimiter.new(parser, after_date: after_date)
+          CalendarLimiter.new(parser, limit: limit)
+        end
+      end
+    end
+  end
+end

data/lib/jekyll-ical-tag/calendar_fetcher.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+# frozen_string_literal: true
+
+require "cgi"
+require "api_cache"
+
+module Jekyll
+  class IcalTag
+    class CalendarFetcher
+      def initialize(url)
+        @url = CGI.unescape(url)
+
+        raise "No URL provided or in innapropriate form '#{url}'" unless is_valid_url?
+      end
+
+      def fetch
+        puts "Fetching #{url}"
+        @fetch ||= APICache.get(url)
+      end
+
+      private
+
+      attr_reader :url
+
+      def is_valid_url?
+        !!(url =~ URI::regexp)
+      end
+    end
+  end
+end

data/lib/jekyll-ical-tag/calendar_parser.rb

@@ -8,22 +8,19 @@ require "icalendar"
 module Jekyll
   class IcalTag
     class CalendarParser
-      def initialize(url)
-        @url = URI.unescape(url)
+      def initialize(raw_feed)
+        @raw_feed = raw_feed
       end
 
       def events
-        @events ||= begin
-          Icalendar::Event.parse(ics_feed)
-                          .sort { |e1, e2| e1.dtstart <=> e2.dtstart }
-                          .map { |e| Jekyll::IcalTag::Event.new(e) }
-        end
+        @events ||= parsed_feed.sort { |event1, event2| event1.dtstart <=> event2.dtstart }
+                               .map { |event| Jekyll::IcalTag::Event.new(event) }
       end
 
       private
 
-      def ics_feed
-        @ics_feed ||= APICache.get(@url)
+      def parsed_feed
+        Icalendar::Event.parse(@raw_feed)
       end
     end
   end

data/lib/jekyll-ical-tag/event.rb

@@ -37,25 +37,46 @@ module Jekyll
 
       def all_properties
         @props ||= begin
-            props = {}
+          props = {}
 
-            # RFC 5545 Properties
-            event.class.properties.each do |property|
-              props[property] = event.property(property)
-            end
+          # RFC 5545 Properties
+          event.class.properties.each do |property|
+            props[property] = event.property(property)
+          end
+
+          # custom properties
+          props = props.merge(event.custom_properties)
 
-            # custom properties
-            props = props.merge(event.custom_properties)
+          # Ensure all event values are utf8 encoded strings
+          # Ensure times (from dates)
+          # Ensure present
+          props.transform_values! do |value|
+            new_value =
+              case value
+              when String, Icalendar::Values::Text
+                value.force_encoding("UTF-8")
+              when Date, Icalendar::Values::DateTime
+                value.to_time
+              when Icalendar::Values::Uri
+                value.to_s
+              else
+                value
+              end
 
-            props
+            new_value.presence
           end
+
+          props
+        end
       end
 
       def simple_html_description
         @simple_html_description ||= begin
-            description&.clone.tap do |d|
+            description&.clone.tap do |description|
+              description = description.join("\n") if description.is_a?(Icalendar::Values::Array)
+
               description_urls.each do |url|
-                d.force_encoding("UTF-8").gsub! url, %(<a href='#{url}'>#{url}</a>)
+                description.force_encoding("UTF-8").gsub! url, %(<a href='#{url}'>#{url}</a>)
               end
             end
           end

data/lib/jekyll-ical-tag/version.rb

@@ -2,6 +2,6 @@
 
 module Jekyll
   class IcalTag < Liquid::Block
-    VERSION = "1.2.4"
+    VERSION = "1.2.5"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jekyll-ical-tag
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Ricky Chilcott
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-10 00:00:00.000000000 Z
+date: 2020-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jekyll
@@ -107,8 +107,11 @@ files:
 - README.md
 - _plugins/ical_tag.rb
 - bin/build-and-publish-gem
+- bin/rspec
 - jekyll-ical-tag.gemspec
 - lib/jekyll-ical-tag.rb
+- lib/jekyll-ical-tag/calendar_feed_coordinator.rb
+- lib/jekyll-ical-tag/calendar_fetcher.rb
 - lib/jekyll-ical-tag/calendar_limiter.rb
 - lib/jekyll-ical-tag/calendar_parser.rb
 - lib/jekyll-ical-tag/event.rb