jekyll-auto-thumbnails 2.0.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d593b4ae0f39bd0020f6656a021327666afa8ee4776a2147d36ce3f8283a1840
-  data.tar.gz: af035e37d27382e9a8d1d15b20ea14e3a0994f2fe1d1ff312c09b4dac924829f
+  metadata.gz: 3f0fec7cfa3ac45d704dcce4f97edc9e71311df06174f99dd24c3231d1675589
+  data.tar.gz: edc7920b2ff080b42728ead47fee4fcec02d9892979156127c85fba3661844d2
 SHA512:
-  metadata.gz: 89945f98a6e83a64ec2d4f20b96e827d4e408ffdda0f3340da9e99086ef156ef146a6617db1f3cb1ba7de8f34d4790f47783924fc3e02afb5e1f9a9c90506d33
-  data.tar.gz: 0b0a29fc0985c1a1930f2b1a644ed574fb4abae81fe52f0722b0a329c2731020e7cc915b7fdf8155b63e1767f2227ac409a5e2697152648d61cdca6816f59582
+  metadata.gz: 06b2ed4d1aa33f8f4a978e7679688daf25ffdc31fd4d0f8ca3f09eb79aa121920ee76a017750b5e2eda9d5ed5d5970e3106fd7dc1620e8e818960c012227d2f9
+  data.tar.gz: 837a87b1c64202fe40cd163081e9c03ee36c9289796b6c3bd90a9694e42d19c8408ce666401860c729cf5b942512ad5b2695f595b15f57c2530a2002c70906e2

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [2.1.0](https://github.com/Texarkanine/jekyll-auto-thumbnails/compare/v2.0.1...v2.1.0) (2026-07-19)
+
+
+### Features
+
+* **test:** add Mutant mutation testing with RSpec ([#50](https://github.com/Texarkanine/jekyll-auto-thumbnails/issues/50)) ([42f4de6](https://github.com/Texarkanine/jekyll-auto-thumbnails/commit/42f4de6cd4740a05d7acfa4b57c01350e7054d95))
+
+
+### Bug Fixes
+
+* **deps:** bump nokogiri from 1.19.3 to 1.19.4 in the production-deps group ([#42](https://github.com/Texarkanine/jekyll-auto-thumbnails/issues/42)) ([0e41fd2](https://github.com/Texarkanine/jekyll-auto-thumbnails/commit/0e41fd2f3c6c475d77ca53e73be90ff4bf536ec7))
+* **deps:** bump nokogiri in the production-deps group ([0e41fd2](https://github.com/Texarkanine/jekyll-auto-thumbnails/commit/0e41fd2f3c6c475d77ca53e73be90ff4bf536ec7))
+
 ## [2.0.1](https://github.com/Texarkanine/jekyll-auto-thumbnails/compare/v2.0.0...v2.0.1) (2026-05-14)
 
 

data/jekyll-auto-thumbnails.gemspec

@@ -35,11 +35,13 @@ Gem::Specification.new do |spec|
   spec.add_dependency "nokogiri", "~> 1.15"
 
   # Development dependencies
+  spec.add_development_dependency "mutant", "~> 0.16"
+  spec.add_development_dependency "mutant-rspec", "~> 0.16"
   spec.add_development_dependency "rake", "~> 13.3"
   spec.add_development_dependency "rspec", "~> 3.13"
   spec.add_development_dependency "rubocop", "~> 1.81"
   spec.add_development_dependency "rubocop-rake", "~> 0.7"
   spec.add_development_dependency "rubocop-rspec", "~> 3.8"
-  spec.add_development_dependency "simplecov", "~> 0.22"
-  spec.add_development_dependency "simplecov-cobertura", "~> 3.1"
+  spec.add_development_dependency "simplecov", "~> 1.0"
+  spec.add_development_dependency "simplecov-cobertura", "~> 4.0"
 end

data/lib/jekyll-auto-thumbnails/configuration.rb

@@ -19,7 +19,11 @@ module JekyllAutoThumbnails
       @enabled = config_hash.fetch("enabled", true)
       @max_width = parse_dimension(config_hash["max_width"])
       @max_height = parse_dimension(config_hash["max_height"])
-      @quality = parse_quality(config_hash.fetch("quality", 85))
+      @quality = if config_hash.key?("quality")
+                   parse_quality(config_hash.fetch("quality"))
+                 else
+                   85
+                 end
       @parser = parse_parser(config_hash.fetch("parser", "html5"))
       @cache_dir = File.join(site.source, ".jekyll-cache", "jekyll-auto-thumbnails")
     end
@@ -39,7 +43,7 @@ module JekyllAutoThumbnails
     # @return [Integer, nil] positive integer or nil
     def parse_dimension(value)
       val = value.to_i
-      val.positive? ? val : nil
+      val if val.positive?
     end
 
     # Parse quality value (0-100)
@@ -63,7 +67,7 @@ module JekyllAutoThumbnails
     # @return [Symbol] :html4 or :html5
     # @raise [ArgumentError] for invalid values or JRuby + :html5
     def parse_parser(value)
-      unless value.is_a?(String)
+      unless value.instance_of?(String)
         raise ArgumentError,
               "auto_thumbnails: parser must be a string (\"html4\" or \"html5\"); got #{value.inspect}"
       end

data/lib/jekyll-auto-thumbnails/digest_calculator.rb

@@ -13,7 +13,7 @@ module JekyllAutoThumbnails
     # @return [String] first 6 characters of MD5 hex digest
     # @raise [Errno::ENOENT] if file doesn't exist
     def self.short_digest(file_path)
-      Digest::MD5.file(file_path).hexdigest[0...6]
+      Digest::MD5.file(file_path).hexdigest.byteslice(0, 6)
     end
   end
 end

data/lib/jekyll-auto-thumbnails/generator.rb

@@ -72,9 +72,7 @@ module JekyllAutoThumbnails
     # @param ext [String] file extension
     # @return [String] thumbnail filename
     def build_thumbnail_filename(basename, digest, width, height, ext)
-      width_str = width || ""
-      height_str = height || ""
-      "#{basename}_thumb-#{digest}-#{width_str}x#{height_str}#{ext}"
+      "#{basename}_thumb-#{digest}-#{width}x#{height}#{ext}"
     end
 
     private
@@ -111,9 +109,7 @@ module JekyllAutoThumbnails
     # @param height [Integer, nil] target height
     # @return [String] geometry string (e.g., "400x300>")
     def build_geometry(width, height)
-      width_str = width || ""
-      height_str = height || ""
-      "#{width_str}x#{height_str}>"
+      "#{width}x#{height}>"
     end
 
     # Check if quality parameter needed for image format

data/lib/jekyll-auto-thumbnails/hooks.rb

@@ -97,7 +97,7 @@ module JekyllAutoThumbnails
         cached_path = File.join(config.cache_dir, thumb_filename)
 
         # Build destination path in _site preserving directory structure
-        dest_path = File.join(site.dest, thumb_url.sub(%r{^/}, ""))
+        dest_path = File.join(site.dest, thumb_url)
         dest_dir = File.dirname(dest_path)
 
         FileUtils.mkdir_p(dest_dir)
@@ -128,8 +128,6 @@ module JekyllAutoThumbnails
       modified = false
       doc.css("article img").each do |img|
         src = img["src"]
-        next unless src
-
         thumb_url = url_map[src]
         next unless thumb_url
 
@@ -148,8 +146,6 @@ module JekyllAutoThumbnails
       ext = File.extname(doc.path || doc.url || "").downcase
       [".html", ".htm", ".md", ".markdown"].include?(ext)
     end
-
-    private_class_method :replace_urls, :html_document?
   end
 end
 

data/lib/jekyll-auto-thumbnails/html_parser.rb

@@ -14,8 +14,6 @@ module JekyllAutoThumbnails
   # users who depended on libxml2's serialization quirks (notably the
   # injected `<meta http-equiv="Content-Type">`).
   module HtmlParser
-    module_function
-
     # Parse an HTML string with the selected parser.
     #
     # @param html [String] HTML source
@@ -25,7 +23,7 @@ module JekyllAutoThumbnails
     # @raise [NameError] if :html5 is requested under JRuby (should be
     #   prevented by Configuration validation; this is a belt-and-suspenders
     #   guard)
-    def parse(html, parser)
+    def self.parse(html, parser)
       case parser
       when :html5
         Nokogiri::HTML5.parse(html)

data/lib/jekyll-auto-thumbnails/imagemagick_wrapper.rb

@@ -25,10 +25,8 @@ module JekyllAutoThumbnails
       case detect_version
       when :v7
         %w[magick convert]
-      when :v6
-        ["convert"]
       else
-        ["convert"] # Default fallback (will fail if not available)
+        ["convert"] # v6 and unavailable fallback (will fail if not available)
       end
     end
 
@@ -39,10 +37,8 @@ module JekyllAutoThumbnails
       case detect_version
       when :v7
         %w[magick identify]
-      when :v6
-        ["identify"]
       else
-        ["identify"] # Default fallback (will fail if not available)
+        ["identify"] # v6 and unavailable fallback (will fail if not available)
       end
     end
 
@@ -68,9 +64,7 @@ module JekyllAutoThumbnails
     #
     # @return [Symbol] :v6, :v7, or :none
     def self.detect_version
-      return @detected_version if defined?(@detected_version) && @detected_version
-
-      @detected_version = if command_exists?("magick")
+      @detect_version ||= if command_exists?("magick")
                             :v7
                           elsif command_exists?("convert")
                             :v6
@@ -79,6 +73,16 @@ module JekyllAutoThumbnails
                           end
     end
 
+    # Clear the memoized result of {.detect_version}.
+    #
+    # Intended for tests that mutate PATH between examples so detection can
+    # be re-probed through the public API rather than via reflection.
+    #
+    # @return [void]
+    def self.reset_detection_cache!
+      @detect_version = nil
+    end
+
     # Check if a command exists in PATH
     #
     # @param cmd [String] command name

data/lib/jekyll-auto-thumbnails/registry.rb

@@ -17,17 +17,11 @@ module JekyllAutoThumbnails
     # @param width [Integer, nil] required width
     # @param height [Integer, nil] required height
     def register(url, width, height)
-      existing = @entries[url]
-
-      @entries[url] = if existing
-                        # Update to max dimensions
-                        {
-                          width: [existing[:width], width].compact.max,
-                          height: [existing[:height], height].compact.max
-                        }
-                      else
-                        { width: width, height: height }
-                      end
+      previous = @entries[url]
+      @entries[url] = {
+        width: [previous&.dig(:width), width].compact.max,
+        height: [previous&.dig(:height), height].compact.max
+      }
     end
 
     # Check if image is registered
@@ -43,7 +37,7 @@ module JekyllAutoThumbnails
     # @param url [String] image URL
     # @return [Hash, nil] {width:, height:} or nil if not registered
     def requirements_for(url)
-      @entries[url]&.dup
+      @entries[url].dup
     end
 
     # Get all registered entries

data/lib/jekyll-auto-thumbnails/scanner.rb

@@ -28,20 +28,12 @@ module JekyllAutoThumbnails
         height = parse_dimension(img["height"])
 
         if width || height
-          # Explicitly sized - calculate missing dimension if needed
-          if site_source && (width.nil? || height.nil?)
-            Jekyll.logger.debug "AutoThumbnails:", "Calculating dimensions for #{src} (#{width}x#{height})"
-            width, height = calculate_dimensions(src, width, height, site_source)
-            Jekyll.logger.debug "AutoThumbnails:", "Calculated: #{width}x#{height}"
-          end
+          # Only identify for aspect-ratio fill when a dimension is missing
+          width, height = calculate_dimensions(src, width, height, site_source) if site_source && (!width || !height)
 
           # Skip if dimensions match original (no thumbnail needed)
-          if site_source && dimensions_match_original?(src, width, height, site_source)
-            Jekyll.logger.debug "AutoThumbnails:", "Skipping #{src} - dimensions match original"
-            next
-          end
+          next if site_source && dimensions_match_original?(src, width, height, site_source)
 
-          Jekyll.logger.debug "AutoThumbnails:", "Registering #{src} at #{width}x#{height}"
           registry.register(src, width, height)
         elsif site_source && (config.max_width || config.max_height)
           # Unsized but max config exists - check actual dimensions
@@ -61,7 +53,7 @@ module JekyllAutoThumbnails
       return unless file_path && File.exist?(file_path)
 
       actual_width, actual_height = image_dimensions(file_path)
-      return unless actual_width && actual_height
+      return unless actual_height
 
       # Check if exceeds max dimensions
       exceeds_width = config.max_width && actual_width > config.max_width
@@ -82,10 +74,10 @@ module JekyllAutoThumbnails
       # Use [0] to get only first frame (important for animated GIFs)
       # Wrapper handles both ImageMagick v6 and v7
       output, status = ImageMagickWrapper.execute_identify("-format", "%wx%h", "#{file_path}[0]")
-      return nil unless status.success? && !output.strip.empty?
+      return nil unless status.success?
 
-      width, height = output.strip.split("x").map(&:to_i)
-      [width, height]
+      match = output.match(/\A\s*(\d+)x(\d+)\s*\z/)
+      [Integer(match[1]), Integer(match[2])]
     rescue StandardError
       nil
     end
@@ -102,7 +94,7 @@ module JekyllAutoThumbnails
       return [width, height] unless file_path && File.exist?(file_path)
 
       actual_width, actual_height = image_dimensions(file_path)
-      return [width, height] unless actual_width && actual_height
+      return [width, height] unless actual_height
 
       # Calculate missing dimension preserving aspect ratio
       if width && !height
@@ -123,13 +115,11 @@ module JekyllAutoThumbnails
     # @param value [String, nil] attribute value
     # @return [Integer, nil] parsed integer or nil
     def self.parse_dimension(value)
-      return nil if value.nil? || value.empty?
-
       # Strip non-numeric characters (e.g., "300px" -> 300)
       numeric = value.to_s.gsub(/[^\d]/, "")
       return nil if numeric.empty?
 
-      numeric.to_i
+      Integer(numeric)
     end
 
     # Check if requested dimensions match original dimensions
@@ -144,12 +134,8 @@ module JekyllAutoThumbnails
       return false unless file_path && File.exist?(file_path)
 
       actual_width, actual_height = image_dimensions(file_path)
-      return false unless actual_width && actual_height
 
       width == actual_width && height == actual_height
     end
-
-    private_class_method :check_and_register_oversized, :calculate_dimensions, :parse_dimension,
-                         :dimensions_match_original?
   end
 end

data/lib/jekyll-auto-thumbnails/url_resolver.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "pathname"
+
 module JekyllAutoThumbnails
   # URL resolution and path handling
   #
@@ -23,13 +25,8 @@ module JekyllAutoThumbnails
       return nil if external?(url)
       return url if url.start_with?("/")
 
-      # Relative path - resolve against base_dir
-      # Remove ./ prefix if present
-      cleaned_url = url.sub(%r{^\./}, "")
-
       # Join with base_dir and normalize
-      require "pathname"
-      Pathname.new(File.join(base_dir, cleaned_url)).cleanpath.to_s
+      Pathname.new(File.join(base_dir, url)).cleanpath.to_s
     end
 
     # Convert site-relative URL to filesystem path
@@ -40,9 +37,7 @@ module JekyllAutoThumbnails
     def self.to_filesystem_path(url, site_source)
       return nil if external?(url)
 
-      # Strip leading slash and join with site source
-      cleaned_url = url.sub(%r{^/}, "")
-      File.join(site_source, cleaned_url)
+      File.join(site_source, url)
     end
   end
 end

data/lib/jekyll-auto-thumbnails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module JekyllAutoThumbnails
-  VERSION = "2.0.1"
+  VERSION = "2.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: jekyll-auto-thumbnails
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Texarkanine
@@ -43,6 +43,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.15'
+- !ruby/object:Gem::Dependency
+  name: mutant
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+- !ruby/object:Gem::Dependency
+  name: mutant-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.16'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -119,28 +147,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: simplecov-cobertura
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '4.0'
 description: Jekyll plugin that automatically generates and serves optimized image
   thumbnails for faster page loads.
 email: