jeff 1.5.0 → 1.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: adbc3ba7741d6e6a2c3189261d378a7cb656c96d
-  data.tar.gz: d5bd6f51e1f17d0e9b930ef0caef33e1f2f3da97
+  metadata.gz: e56219825bbd4da3c47178de856aba8eca07b70c
+  data.tar.gz: a37925b3fde9585ad1a35e6a59c98fb8ed4228c9
 SHA512:
-  metadata.gz: 6ac54c0f6fb21fcc6809a84ee58df5f90e1b2ea34b31bb16a2cf33f376b12849e39ac1507475b5f06699cc4b9cd890ff3da935374e2b8f319681a72aaca46282
-  data.tar.gz: 4cf3385e17a3803ff09d0faed83ea476a6c54da32636162adee8bdb6c82a3316cf6ae64c8f53ea11f11a63222571074fc0c20e85d8a7d1e52ae0bfe5b662c14e
+  metadata.gz: d144d64748dd0321029ce01897094144dd39b5000ecebe2109c76ba6775ecfcf1584b46f7d0adc53e0b4a2ff92ecb384e2d76021dc08980cbfab8142fe0898c6
+  data.tar.gz: 2b94f90719cd9db8e1fa6a1a17271fec14cc41af9d70377decfb4d18dc5226c96507828539a748f74b6c94185af7c4e7048416e5a1dbb4b2105b2b78f2851fe5

data/lib/jeff.rb

@@ -135,14 +135,8 @@ module Jeff
         options.store(:method, :#{method})
         add_md5_digest options
         sign options
-
-        begin
-          connection.request(options)
-        rescue Excon::Errors::RequestURITooLong
-          raise if options[:body] || options[:method] != :post
-          move_query_to_body options
-          retry
-        end
+        #{"move_query_to_body options" if method == "post"}
+        connection.request(options)
       end
     DEF
   end
@@ -178,6 +172,8 @@ module Jeff
   end
 
   def move_query_to_body(options)
+    return if options[:body]
+
     options[:headers] ||= {}
     options[:headers].store("Content-Type", "application/x-www-form-urlencoded")
     options.store(:body, options.delete(:query))

data/lib/jeff/version.rb

@@ -1,3 +1,3 @@
 module Jeff
-  VERSION = "1.5.0"
+  VERSION = "1.5.1"
 end

data/test/test_jeff.rb

@@ -104,21 +104,31 @@ class TestJeffInAction < Minitest::Test
     refute_empty @client.post(body: "foo", mock: true).body
   end
 
-  def test_moves_query_to_body_if_uri_is_too_long
+  def test_moves_query_to_body_if_post
     Excon.stub({}) do |request_params|
-      { status: request_params[:query] ? 414 : 200 }
+      { body: request_params[:body] }
     end
 
     res = @client.post(query: { foo: "bar" }, mock: true)
-    assert_equal 200, res.status
+    assert_includes res.body, "foo=bar"
+  end
 
-    assert_raises(Excon::Errors::RequestURITooLong) do
-      @client.post(query: { foo: "bar" }, body: "baz", mock: true)
+  def test_does_not_move_query_to_body_if_body_is_set
+    Excon.stub({}) do |request_params|
+      { body: request_params[:body] }
     end
 
-    assert_raises(Excon::Errors::RequestURITooLong) do
-      @client.get(query: { foo: "bar" }, mock: true)
+    res = @client.post(query: { foo: "bar" }, body: "baz", mock: true)
+    assert_equal "baz", res.body
+  end
+
+  def test_does_not_move_query_to_body_if_not_post
+    Excon.stub({}) do |request_params|
+      { body: request_params[:body] }
     end
+
+    res = @client.get(query: { foo: "bar" }, mock: true)
+    assert_nil res.body
   end
 
   def test_gets_from_an_actual_endpoint

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jeff
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
 platform: ruby
 authors:
 - Hakan Ensari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-15 00:00:00.000000000 Z
+date: 2015-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -91,9 +91,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: An AWS client
 test_files:
 - test/test_jeff.rb
+has_rdoc: