jeff 1.5.0 → 1.5.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: adbc3ba7741d6e6a2c3189261d378a7cb656c96d
4
- data.tar.gz: d5bd6f51e1f17d0e9b930ef0caef33e1f2f3da97
3
+ metadata.gz: e56219825bbd4da3c47178de856aba8eca07b70c
4
+ data.tar.gz: a37925b3fde9585ad1a35e6a59c98fb8ed4228c9
5
5
  SHA512:
6
- metadata.gz: 6ac54c0f6fb21fcc6809a84ee58df5f90e1b2ea34b31bb16a2cf33f376b12849e39ac1507475b5f06699cc4b9cd890ff3da935374e2b8f319681a72aaca46282
7
- data.tar.gz: 4cf3385e17a3803ff09d0faed83ea476a6c54da32636162adee8bdb6c82a3316cf6ae64c8f53ea11f11a63222571074fc0c20e85d8a7d1e52ae0bfe5b662c14e
6
+ metadata.gz: d144d64748dd0321029ce01897094144dd39b5000ecebe2109c76ba6775ecfcf1584b46f7d0adc53e0b4a2ff92ecb384e2d76021dc08980cbfab8142fe0898c6
7
+ data.tar.gz: 2b94f90719cd9db8e1fa6a1a17271fec14cc41af9d70377decfb4d18dc5226c96507828539a748f74b6c94185af7c4e7048416e5a1dbb4b2105b2b78f2851fe5
data/lib/jeff.rb CHANGED
@@ -135,14 +135,8 @@ module Jeff
135
135
  options.store(:method, :#{method})
136
136
  add_md5_digest options
137
137
  sign options
138
-
139
- begin
140
- connection.request(options)
141
- rescue Excon::Errors::RequestURITooLong
142
- raise if options[:body] || options[:method] != :post
143
- move_query_to_body options
144
- retry
145
- end
138
+ #{"move_query_to_body options" if method == "post"}
139
+ connection.request(options)
146
140
  end
147
141
  DEF
148
142
  end
@@ -178,6 +172,8 @@ module Jeff
178
172
  end
179
173
 
180
174
  def move_query_to_body(options)
175
+ return if options[:body]
176
+
181
177
  options[:headers] ||= {}
182
178
  options[:headers].store("Content-Type", "application/x-www-form-urlencoded")
183
179
  options.store(:body, options.delete(:query))
data/lib/jeff/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Jeff
2
- VERSION = "1.5.0"
2
+ VERSION = "1.5.1"
3
3
  end
data/test/test_jeff.rb CHANGED
@@ -104,21 +104,31 @@ class TestJeffInAction < Minitest::Test
104
104
  refute_empty @client.post(body: "foo", mock: true).body
105
105
  end
106
106
 
107
- def test_moves_query_to_body_if_uri_is_too_long
107
+ def test_moves_query_to_body_if_post
108
108
  Excon.stub({}) do |request_params|
109
- { status: request_params[:query] ? 414 : 200 }
109
+ { body: request_params[:body] }
110
110
  end
111
111
 
112
112
  res = @client.post(query: { foo: "bar" }, mock: true)
113
- assert_equal 200, res.status
113
+ assert_includes res.body, "foo=bar"
114
+ end
114
115
 
115
- assert_raises(Excon::Errors::RequestURITooLong) do
116
- @client.post(query: { foo: "bar" }, body: "baz", mock: true)
116
+ def test_does_not_move_query_to_body_if_body_is_set
117
+ Excon.stub({}) do |request_params|
118
+ { body: request_params[:body] }
117
119
  end
118
120
 
119
- assert_raises(Excon::Errors::RequestURITooLong) do
120
- @client.get(query: { foo: "bar" }, mock: true)
121
+ res = @client.post(query: { foo: "bar" }, body: "baz", mock: true)
122
+ assert_equal "baz", res.body
123
+ end
124
+
125
+ def test_does_not_move_query_to_body_if_not_post
126
+ Excon.stub({}) do |request_params|
127
+ { body: request_params[:body] }
121
128
  end
129
+
130
+ res = @client.get(query: { foo: "bar" }, mock: true)
131
+ assert_nil res.body
122
132
  end
123
133
 
124
134
  def test_gets_from_an_actual_endpoint
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: jeff
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.5.0
4
+ version: 1.5.1
5
5
  platform: ruby
6
6
  authors:
7
7
  - Hakan Ensari
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2015-07-15 00:00:00.000000000 Z
11
+ date: 2015-09-12 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: excon
@@ -91,9 +91,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
91
91
  version: '0'
92
92
  requirements: []
93
93
  rubyforge_project:
94
- rubygems_version: 2.4.5
94
+ rubygems_version: 2.4.5.1
95
95
  signing_key:
96
96
  specification_version: 4
97
97
  summary: An AWS client
98
98
  test_files:
99
99
  - test/test_jeff.rb
100
+ has_rdoc: