jchupp-is_paranoid 0.3.0 → 0.4.0

data/README.textile

@@ -45,7 +45,7 @@ Now our automobiles are now soft-deleteable.
   Automobile.count # => 1
 </pre>
 
-One thing to note, destroying is always undo-able, but deleting is not.
+One thing to note, destroying is always undo-able, but deleting is not.  This is a behavior difference between acts_as_paranoid and is_paranoid.
 
 <pre>
   Automobile.destroy_all
@@ -76,9 +76,18 @@ h3. Specifying alternate rules for what should be considered destroyed
 
 These two models share the same table, but when we are finding Pirates, we're only interested in those that are alive.  To break it down, we specify :alive as our field to check, false as what the model field should be marked at when destroyed and true to what the field should be if they're not destroyed.  DeadPirates are specified as the opposite.  Check out the specs if you're still confused.
 
-h3. Note:
+h3. Note about validates_uniqueness_of:
 
-validates_uniqueness_of does not ignore items marked with a deleted_at flag.  This is a behavior difference between is_paranoid and acts_as_paranoid.  I'm going to treat this as a bug until I get a chance to make it an optional feature.  Be aware of it.
+validates_uniqueness_of does not, by default, ignore items marked with a deleted_at (or other field name) flag.  This is a behavior difference between is_paranoid and acts_as_paranoid.  You can overcome this by specifying the field name you are using to mark destroyed items as your scope.  Example:
+
+<pre>
+  class Android < ActiveRecord::Base
+    validates_uniqueness_of :name, :scope => :deleted_at
+    is_paranoid
+  end
+</pre>
+
+And now the validates_uniqueness_of will ignore items that are destroyed.
 
 h3. and you may ask yourself, where does that highway go to?
 

data/VERSION.yml

@@ -1,4 +1,4 @@
 --- 
-:minor: 3
+:minor: 4
 :patch: 0
 :major: 0

data/spec/is_paranoid_spec.rb

@@ -1,6 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 class Person < ActiveRecord::Base
+  validates_uniqueness_of :name
   has_many :androids, :foreign_key => :owner_id, :dependent => :destroy
 end
 
@@ -9,11 +10,18 @@ class Android < ActiveRecord::Base
   is_paranoid
 end
 
+class AndroidWithScopedUniqueness < ActiveRecord::Base
+  set_table_name :androids
+  validates_uniqueness_of :name, :scope => :deleted_at
+  is_paranoid
+end
+
 class NoCalculation < ActiveRecord::Base
   is_paranoid
 end
 
 class Ninja < ActiveRecord::Base
+  validates_uniqueness_of :name, :scope => :visible
   is_paranoid :field => [:visible, false, true]
 end
 
@@ -106,13 +114,20 @@ describe Android do
     Android.average_with_destroyed('id').should == (@r2d2.id + @c3p0.id) / 2.0
   end
 
-  # Note:  this isn't necessarily ideal, this just serves to demostrate
-  # how it currently works
-  it "should not ignore deleted items in validation checks" do
+  it "should not ignore deleted items in validation checks unless scoped" do
+    # Androids are not validates_uniqueness_of scoped
     @r2d2.destroy
     lambda{
       Android.create!(:name => 'R2D2')
     }.should raise_error(ActiveRecord::RecordInvalid)
+
+    lambda{
+      # creating shouldn't raise an error
+      another_r2d2 = AndroidWithScopedUniqueness.create!(:name => 'R2D2')
+      # neither should destroying the second incarnation since the
+      # validates_uniqueness_of is only applied on create
+      another_r2d2.destroy
+    }.should_not raise_error
   end
   
   it "should allow specifying alternate fields and field values" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: jchupp-is_paranoid
 version: !ruby/object:Gem::Version 
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Jeffrey Chupp
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-03-28 00:00:00 -07:00
+date: 2009-03-29 00:00:00 -07:00
 default_executable: 
 dependencies: []