java-checkstyle 1.0.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ad85bf5e1460d22ac17dd08317e6801b92fbcaae
-  data.tar.gz: 6d4c62ae05eff0f2e5150f5e6e0e3efd19d91ef3
+  metadata.gz: 154702209a4a34056e341763612d8f2b579621fd
+  data.tar.gz: 7178106c9490089b1faef4a9671696c7d8aa5879
 SHA512:
-  metadata.gz: a24b8da42d1504e3a8eafe2900abed91541e94294c711440fc82c61dd3bfb86e56e814c008d7771b27680625a44d7584d73617553bb0e9677c51cd822a7a51ec
-  data.tar.gz: 32eb221333fc952a32a3a64f2f281c7b93315795f6120c854e2fd8c3d18a24647a45693e6dfea44cdd2ac263d361099a1f66b28bc7a2f31085d54f8f88ee1db3
+  metadata.gz: 5b1aef329a6b13a031f155e6b394ae106f92b231eceac65f8a590245ccbf97d61501ba0cd5e8b5a0444699139343c07f1e2d0340695a1e0d3ca292543a147b75
+  data.tar.gz: 807414b774d3914b0eb26dbc9eb94af927885b7c123cefd42daeb35a2f8458731ac46f9f99f00ec380b993dd19222cabae624a937d59b0b75e64d43c586daedd

data/lib/plugins/{pre-commit → pre_commit}/checks/checkstyle.rb

@@ -1,4 +1,4 @@
-require 'pre-commit/checks/plugin'
+require 'pre-commit/checks/shell'
 require_relative '../message/extractor'
 require_relative '../message/formatter'
 require_relative '../support/path'
@@ -10,8 +10,8 @@ module PreCommit
     #
     # It provides a java checkstyle validation using checkstyle.jar
     # for details see:
-    # lib/pre-commit/support/checkstyle
-    class Checkstyle < Plugin
+    # lib/pre_commit/support/checkstyle
+    class Checkstyle < Shell
       ##
       # Function called after pre-commit execution
       # this method receive the +staged_files+ from git

data/lib/plugins/{pre-commit → pre_commit}/support/path.rb

@@ -1,7 +1,7 @@
 module Support
   ##
   # Responsible for provide relative paths to support files
-  # Files located under: /lib/plugin/pre-commit/support/checkstyle*
+  # Files located under: /lib/plugin/pre_commit/support/checkstyle*
   module Path
     ##
     # Return support path relative to a given +file+

data/lib/{pre-commit → pre_commit}/checkstyle/version.rb

@@ -13,6 +13,6 @@ module PreCommit
   #
   # Main file: checks/checkstyle.rb
   module Checkstyle
-    VERSION = '1.0.5'.freeze
+    VERSION = '1.1.0'.freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: java-checkstyle
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.1.0
 platform: ruby
 authors:
 - Allen Madsen
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-14 00:00:00.000000000 Z
+date: 2017-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pre-commit
@@ -111,37 +111,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".codeclimate.yml"
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
-- DETAILED_TUTORIAL.md
-- Gemfile
-- LICENSE.txt
-- README.md
-- Rakefile
-- demo.png
-- java-checkstyle.gemspec
-- lib/plugins/pre-commit/checks/checkstyle.rb
-- lib/plugins/pre-commit/domain/bad_file.rb
-- lib/plugins/pre-commit/domain/checkstyle.rb
-- lib/plugins/pre-commit/message/extractor.rb
-- lib/plugins/pre-commit/message/formatter.rb
-- lib/plugins/pre-commit/support/path.rb
-- lib/pre-commit/checkstyle/version.rb
+- lib/plugins/pre_commit/checks/checkstyle.rb
+- lib/plugins/pre_commit/domain/bad_file.rb
+- lib/plugins/pre_commit/domain/checkstyle.rb
+- lib/plugins/pre_commit/message/extractor.rb
+- lib/plugins/pre_commit/message/formatter.rb
+- lib/plugins/pre_commit/support/path.rb
+- lib/pre_commit/checkstyle/version.rb
 - lib/resources/checkstyle/checkstyle-6.11-all.jar
 - lib/resources/checkstyle/google_checks.xml
-- readmedemo.png
-- spec/fixtures/bad.java
-- spec/fixtures/bad2.java
-- spec/fixtures/good.java
-- spec/fixtures/output_one_bad_file.log
-- spec/fixtures/output_two_bad_files.log
-- spec/fixtures/sun_checks.xml
-- spec/plugins/pre_commit/checks/checkstyle_spec.rb
-- spec/plugins/pre_commit/message/extractor_spec.rb
-- spec/plugins/pre_commit/message/formatter_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/CristianOliveira/java-checkstyle
 licenses:
 - MIT
@@ -162,18 +140,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Checkstyle linter plugin for pre-commit
-test_files:
-- spec/fixtures/bad.java
-- spec/fixtures/bad2.java
-- spec/fixtures/good.java
-- spec/fixtures/output_one_bad_file.log
-- spec/fixtures/output_two_bad_files.log
-- spec/fixtures/sun_checks.xml
-- spec/plugins/pre_commit/checks/checkstyle_spec.rb
-- spec/plugins/pre_commit/message/extractor_spec.rb
-- spec/plugins/pre_commit/message/formatter_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.codeclimate.yml

@@ -1,2 +0,0 @@
-languages:
-  Ruby: true

data/.gitignore

@@ -1,17 +0,0 @@
-*.gem
-*.rbc
-.bundle
-.config
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp

data/.rspec

@@ -1,2 +0,0 @@
---format documentation
---color

data/.travis.yml

@@ -1,9 +0,0 @@
-language: ruby
-rvm:
-  - 2.2.0
-  - 2.3.0
-  - jruby-9.1.0.0
-
-script:
-  - rake
-  - bundle exec rubocop lib/*

data/DETAILED_TUTORIAL.md

@@ -1,102 +0,0 @@
-### Java - Pre-Commit Checkstyle
-
-## Detailed Installation Guide
-
-This is a detailed version to install this useful hook.
-
-# Let`s do it!
-
-First install and setup the check in pre-commit:
-### Pre-Commit Checkstyle
-Install the gem
-
-    $ gem install pre-commit
-
-### Install the Java-checkstyle gem
-
-Add this line to your application's Gemfile:
-
-    gem 'java-checkstyle'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install java-checkstyle
-
-Now your pre-commit hook has been installed.
-
-## Using in your project
-
-Create your project folder and start a git repository
-
-```bash
-mkdir awesome_project
-cd awesome_project
-git init
-```
-**Install the hook for this repository**
-
-Use the pre-commit command to generate a stub pre-commit hook
-```bash
-# Inside of your project with git
-pre-commit install
-```
-This creates a .git/hooks/pre-commit script which will check your git config and run checks that are enabled.
-
-**Enable the java checkstyle checks**
-
-``` bash
-pre-commit enable git checks checkstyle
-```
-
-OR
-
-``` bash
-pre-commit enable yaml checks checkstyle
-```
-
-Then the pre commmit has been configured! For this your repository.
-
-## Let`s test it!
-Create a new java code with some style errors see: [Google checkstyle guide](http://google.github.io/styleguide/javaguide.html)
-
-```java
-class HelloWorld
-{
-  public static void main(String[] args)
-  {
-    System.out.println("Hello World!");
-  }
-}
-```
-Then add it and try commit
-``` bash
-git add .
-git commit -m "Time's up, let's do this! Leeeeeeeeeeeeeroy Jjjjjjenkinsss!!"
-```
-
-Still don`t know our hero Leroy Jenkis? Oh man! see [here](https://www.youtube.com/watch?v=LkCNJRfSZBU)
-
-![My awesome change has been catch. Oh boy!](https://raw.githubusercontent.com/CristianOliveiraDaRosa/java-checkstyle/master/demo.png)
-
----
-## Installing with RVM
-
-If you are using rvm you need to install pre-commit into the ```default``` gemset, because it does not use the ```current``` environment
-
-    $ rvm default do gem install pre-commit
-
-Alternatively you can configure pre-commit to use the ```current``` rvm gemset
-
-    $ git config pre-commit.ruby "rvm `rvm current` do ruby"
-
-More details about this part see on:
-[pre-commit](https://github.com/jish/pre-commit)
-
-## Authors:
- - Allen Madsen (Original Version 0.0.1)
- - Alex Rocha
- - Cristian Oliveira

data/Gemfile

@@ -1,12 +0,0 @@
-source 'https://rubygems.org'
-
-# Specify your gem's dependencies in pre-commit-checkstyle.gemspec
-gemspec
-gem 'crack'
-
-group :test do
-  gem "simplecov"
-  gem "codeclimate-test-reporter", require: nil
-  gem 'rubocop', require: false
-  # gem 'byebug' not add as default it is not compatible with ruby 2 >= version
-end

data/LICENSE.txt

@@ -1,22 +0,0 @@
-Copyright (c) 2014 Allen Madsen
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.md

@@ -1,93 +0,0 @@
-## Java - Pre-Commit Checkstyle
-[![Gem Version](https://badge.fury.io/rb/java-checkstyle.svg)](https://badge.fury.io/rb/java-checkstyle)
-[![Build Status](https://travis-ci.org/cristianoliveira/java-checkstyle.svg)](https://travis-ci.org/CristianOliveiraDaRosa/java-checkstyle)
-[![Code Climate](https://codeclimate.com/github/cristianoliveira/java-checkstyle/badges/gpa.svg)](https://codeclimate.com/github/cristianoliveira/java-checkstyle)
-[![Test Coverage](https://codeclimate.com/github/cristianoliveira/java-checkstyle/badges/coverage.svg)](https://codeclimate.com/github/cristianoliveira/java-checkstyle/coverage)
-
-Useful git pre-commit hook for linting Java code.
-
-It uses as default [The Google Style Guide](https://google.github.io/styleguide/javaguide.html)
-and the famous [Checkstyle](http://checkstyle.sourceforge.net/) linter as a plugin for [pre-commit](https://github.com/jish/pre-commit).
-
-## Demo
-
-![My awesome change has been catch. Oh boy!](https://raw.githubusercontent.com/cristianoliveira/java-checkstyle/master/readmedemo.png)
-[Don't you know who is Leeroy Jenkins?](https://www.youtube.com/watch?v=mLyOj_QD4a4)
-
-## Installation
-
-First install the gems.
-#### Pre-Commit Checkstyle
-
-    gem install pre-commit
-
-#### Java Checkstyle Plugin
-
-    gem install java-checkstyle
-
-##### (optional) If you use RVM
-Take a look here [Install with RVM](https://github.com/jish/pre-commit#rvm)
-
-### Configuring
-Use the pre-commit command to generate a stub pre-commit hook.
-Inside folder of your git repo:
-
-```bash
-pre-commit install
-```
-
-It will create a .git/hooks/pre-commit script which will check your git config and run checks that are enabled.
-
-#### Enabling checks
-
-``` bash
-pre-commit enable git checks checkstyle
-```
-
-### Result
-Every time you try to commit some java code with style errors it will validate
-for you ensuring that your code will be always awesome.
-
----
-#### Detailed version to install.
-Still don't work? Try the detailed version [here](https://github.com/cristianoliveira/java-checkstyle/blob/master/DETAILED_TUTORIAL.md)
-
----
-
-## Checkstyle Guide
-
-It uses as default [The Google Style Guide](https://google.github.io/styleguide/javaguide.html).
-
-## Tests
-Running tests with rspec
-
-Make sure you have been executed:
-```bash
-bundle install
-```
-Then run:
-
-```bash
-rspec
-```
-
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
-
-#### Codeclimate
-Before push, make sure you have been executed rubocop
-``` bash
-rubocop lib/*
-```
-
-*Pull request should have Unit Tests*
-
-## Authors:
- - Allen Madsen (Original Version 0.0.1)
- - Alex Rocha
- - Cristian Oliveira

data/Rakefile

@@ -1,6 +0,0 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
-
-RSpec::Core::RakeTask.new(:spec)
-
-task :default => :spec

data/java-checkstyle.gemspec

@@ -1,28 +0,0 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require './lib/pre-commit/checkstyle/version.rb'
-
-Gem::Specification.new do |spec|
-  spec.name          = "java-checkstyle"
-  spec.version       = PreCommit::Checkstyle::VERSION
-  spec.authors       = ["Allen Madsen", "Cristian Oliveira", "Alex Rocha"]
-  spec.email         = ["blatyo@gmail.com", "contato@cristianoliveira.com.br", "alex.rochas@yahoo.com.br"]
-  spec.summary       = %q{Checkstyle linter plugin for pre-commit}
-  spec.description   = %q{Checkstyle linter plugin for pre-commit. Useful for linting Java code.}
-  spec.homepage      = "https://github.com/CristianOliveira/java-checkstyle"
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency('pre-commit', '~> 0.26')
-  spec.add_dependency('crack', '~> 0.4.2')
-
-  spec.add_development_dependency("bundler", "~> 1.5")
-  spec.add_development_dependency("rake", '~> 10.4', '>= 10.4.2')
-  spec.add_development_dependency('rspec', '~> 3.3.0')
-  spec.add_development_dependency('rubocop', '~> 0.34.2')
-end

data/spec/fixtures/bad.java

@@ -1,5 +0,0 @@
-class hello {
-  public static void main(String[] args) {
-    System.out.println("Hello World!");
-  }
-}

data/spec/fixtures/bad2.java

@@ -1,6 +0,0 @@
-class HelloWorld
-{
-  public static void main(String[] args) {
-    System.out.println("Hello World!");
-  }
-}

data/spec/fixtures/good.java

@@ -1,23 +0,0 @@
-/**
- * Typical hello world example.
- * It has a good style.
- */
-final class Good {
-  /**
-   * Prevent class from being instantiated.
-   *
-   * @throws AssertionError if some smart guy try.
-   */
-  public Good() {
-    throw new AssertionError("Instantiating utility class...");
-  }
-
-  /**
-   * Prints Hello World!
-   *
-   * @param args Command line arguments.
-   */
-  public static void main(final String[] args) {
-    System.out.println("Hello World!");
-  }
-}

data/spec/fixtures/output_one_bad_file.log

@@ -1,8 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-  <checkstyle version="6.11">
-     <file name="/Users/cristianoliveira/work/java-checkstyle/spec/fixtures/bad.java">
-       <error line="1" severity="error" message="some error message" source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"/>
-       <error line="11" column= "1 " severity= "warning" message="some error message" source="com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck"/>
-    </file>
-  </checkstyle>
-Checkstyle ends with 4 errors.

data/spec/fixtures/output_two_bad_files.log

@@ -1,12 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-  <checkstyle version="6.11">
-     <file name="/Users/cristianoliveira/work/java-checkstyle/spec/fixtures/bad.java">
-       <error line="1" severity="error" message="some error message" source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"/>
-       <error line="11" column= "1 " severity= "warning" message="some error message" source="com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck"/>
-    </file>
-    <file name="/Users/cristianoliveira/work/java-checkstyle/spec/fixtures/bad2.java">
-       <error line="2 " column= "3 " severity= "error" message="some error message" source= "com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck "/>
-       <error line="2 " column= "27 " severity= "error" message="some error message" source= "com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck "/>
-    </file>
-  </checkstyle>
-Checkstyle ends with 4 errors.

data/spec/fixtures/sun_checks.xml

@@ -1,177 +0,0 @@
-<?xml version="1.0"?>
-<!DOCTYPE module PUBLIC
-          "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
-          "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
-
-<!--
-
-  Checkstyle configuration that checks the sun coding conventions from:
-
-    - the Java Language Specification at
-      http://java.sun.com/docs/books/jls/second_edition/html/index.html
-
-    - the Sun Code Conventions at http://java.sun.com/docs/codeconv/
-
-    - the Javadoc guidelines at
-      http://java.sun.com/j2se/javadoc/writingdoccomments/index.html
-
-    - the JDK Api documentation http://java.sun.com/j2se/docs/api/index.html
-
-    - some best practices
-
-  Checkstyle is very configurable. Be sure to read the documentation at
-  http://checkstyle.sf.net (or in your downloaded distribution).
-
-  Most Checks are configurable, be sure to consult the documentation.
-
-  To completely disable a check, just comment it out or delete it from the file.
-
-  Finally, it is worth reading the documentation.
-
--->
-
-<module name="Checker">
-    <!--
-        If you set the basedir property below, then all reported file
-        names will be relative to the specified directory. See
-        http://checkstyle.sourceforge.net/5.x/config.html#Checker
-
-        <property name="basedir" value="${basedir}"/>
-    -->
-
-    <!-- Checks that a package-info.java file exists for each package.     -->
-    <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage -->
-    <!-- <module name="JavadocPackage"/> -->
-
-    <!-- Checks whether files end with a new line.                        -->
-    <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
-    <module name="NewlineAtEndOfFile"/>
-
-    <!-- Checks that property files contain the same keys.         -->
-    <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
-    <module name="Translation"/>
-
-    <!-- Checks for Size Violations.                    -->
-    <!-- See http://checkstyle.sf.net/config_sizes.html -->
-    <module name="FileLength"/>
-
-    <!-- Checks for whitespace                               -->
-    <!-- See http://checkstyle.sf.net/config_whitespace.html -->
-    <module name="FileTabCharacter"/>
-
-    <!-- Miscellaneous other checks.                   -->
-    <!-- See http://checkstyle.sf.net/config_misc.html -->
-    <module name="RegexpSingleline">
-       <property name="format" value="\s+$"/>
-       <property name="minimum" value="0"/>
-       <property name="maximum" value="0"/>
-       <property name="message" value="Line has trailing spaces."/>
-    </module>
-
-    <!-- Checks for Headers                                -->
-    <!-- See http://checkstyle.sf.net/config_header.html   -->
-    <!-- <module name="Header"> -->
-    <!--   <property name="headerFile" value="${checkstyle.header.file}"/> -->
-    <!--   <property name="fileExtensions" value="java"/> -->
-    <!-- </module> -->
-
-    <module name="TreeWalker">
-
-        <!-- Checks for Javadoc comments.                     -->
-        <!-- See http://checkstyle.sf.net/config_javadoc.html -->
-        <module name="JavadocMethod"/>
-        <module name="JavadocType"/>
-        <module name="JavadocVariable"/>
-        <module name="JavadocStyle"/>
-
-
-        <!-- Checks for Naming Conventions.                  -->
-        <!-- See http://checkstyle.sf.net/config_naming.html -->
-        <module name="ConstantName"/>
-        <module name="LocalFinalVariableName"/>
-        <module name="LocalVariableName"/>
-        <module name="MemberName"/>
-        <module name="MethodName"/>
-        <module name="PackageName"/>
-        <module name="ParameterName"/>
-        <module name="StaticVariableName"/>
-        <module name="TypeName"/>
-
-
-        <!-- Checks for imports                              -->
-        <!-- See http://checkstyle.sf.net/config_import.html -->
-        <module name="AvoidStarImport"/>
-        <module name="IllegalImport"/> <!-- defaults to sun.* packages -->
-        <module name="RedundantImport"/>
-        <module name="UnusedImports"/>
-
-
-        <!-- Checks for Size Violations.                    -->
-        <!-- See http://checkstyle.sf.net/config_sizes.html -->
-        <module name="LineLength"/>
-        <module name="MethodLength"/>
-        <module name="ParameterNumber"/>
-
-
-        <!-- Checks for whitespace                               -->
-        <!-- See http://checkstyle.sf.net/config_whitespace.html -->
-        <module name="EmptyForIteratorPad"/>
-        <module name="GenericWhitespace"/>
-        <module name="MethodParamPad"/>
-        <module name="NoWhitespaceAfter"/>
-        <module name="NoWhitespaceBefore"/>
-        <module name="OperatorWrap"/>
-        <module name="ParenPad"/>
-        <module name="TypecastParenPad"/>
-        <module name="WhitespaceAfter"/>
-        <module name="WhitespaceAround"/>
-
-
-        <!-- Modifier Checks                                    -->
-        <!-- See http://checkstyle.sf.net/config_modifiers.html -->
-        <module name="ModifierOrder"/>
-        <module name="RedundantModifier"/>
-
-
-        <!-- Checks for blocks. You know, those {}'s         -->
-        <!-- See http://checkstyle.sf.net/config_blocks.html -->
-        <module name="AvoidNestedBlocks"/>
-        <module name="EmptyBlock"/>
-        <module name="LeftCurly"/>
-        <module name="NeedBraces"/>
-        <module name="RightCurly"/>
-
-
-        <!-- Checks for common coding problems               -->
-        <!-- See http://checkstyle.sf.net/config_coding.html -->
-        <module name="AvoidInlineConditionals"/>
-        <module name="EmptyStatement"/>
-        <module name="EqualsHashCode"/>
-        <module name="HiddenField"/>
-        <module name="IllegalInstantiation"/>
-        <module name="InnerAssignment"/>
-        <module name="MagicNumber"/>
-        <module name="MissingSwitchDefault"/>
-        <!--<module name="RedundantThrows"/>-->
-        <module name="SimplifyBooleanExpression"/>
-        <module name="SimplifyBooleanReturn"/>
-
-        <!-- Checks for class design                         -->
-        <!-- See http://checkstyle.sf.net/config_design.html -->
-        <module name="DesignForExtension"/>
-        <module name="FinalClass"/>
-        <module name="HideUtilityClassConstructor"/>
-        <module name="InterfaceIsType"/>
-        <module name="VisibilityModifier"/>
-
-
-        <!-- Miscellaneous other checks.                   -->
-        <!-- See http://checkstyle.sf.net/config_misc.html -->
-        <module name="ArrayTypeStyle"/>
-        <module name="FinalParameters"/>
-        <module name="TodoComment"/>
-        <module name="UpperEll"/>
-
-    </module>
-
-</module>

data/spec/plugins/pre_commit/checks/checkstyle_spec.rb

@@ -1,49 +0,0 @@
-require 'spec_helper'
-require 'plugins/pre-commit/checks/checkstyle'
-
-describe PreCommit::Checks::Checkstyle do
-  let(:config) {double(PreCommit::Configuration, get: '')}
-  let(:check) {PreCommit::Checks::Checkstyle.new(nil, config, [])}
-
-  it "succeds if nothing changed" do
-    expect(check.call([])).to be_nil
-  end
-
-  it "succeeds for good code" do
-    files = [fixture_file('Good.java')]
-    expect(check.call(files)).to be_nil
-  end
-
-  it "should fail for bad formatted code" do
-    file = fixture_file("bad.java")
-
-    result = check.call([file])
-
-    expect(result).to include "File errors: #{file}"
-    expect(result).to include "line: 1: error:"
-    expect(result).to include "line: 1:7 error:"
-  end
-
-  it "should accept multiple fails" do
-    # given
-    file = fixture_file("bad.java")
-    file2 = fixture_file("bad2.java")
-
-    # when
-    result = check.call([file, file2])
-
-    # then
-    expect(result).to include "File errors: #{file}"
-    expect(result).to include "File errors: #{file2}"
-  end
-
-  it "should accept custom checkstyle" do
-    # given
-    ENV["CHECKSTYLE_CONFIG"] = "sun_checks.xml"
-    files = [fixture_file('bad.java')]
-    # when
-    result = check.call(files)
-    # then
-    expect(result).to_not be_nil
-  end
-end

data/spec/plugins/pre_commit/message/extractor_spec.rb

@@ -1,103 +0,0 @@
-require 'spec_helper'
-require 'plugins/pre-commit/message/extractor'
-require 'plugins/pre-commit/domain/checkstyle'
-require 'plugins/pre-commit/domain/bad_file'
-
-##
-# Tests for PreCommit::Message::Extractor
-describe PreCommit::Message::Extractor do
-  let(:extractor) { PreCommit::Message::Extractor.new }
-
-  context "When nil output" do
-    it "should be good" do
-      expect( extractor.extract(nil) ).to be_good
-    end
-  end
-
-  context "When empty output" do
-    it "should be good" do
-      expect( extractor.extract('') ).to be_good
-    end
-  end
-
-  context "When has one bad file" do
-    # given
-    let(:output) { IO.read(fixture_file("output_one_bad_file.log")) }
-
-    # when
-    before { @checkstyle = extractor.extract(output) }
-
-    # then
-    it "should not be good" do
-      expect( @checkstyle ).to_not be_good
-    end
-
-    it "should contain one single file" do
-      expect( @checkstyle.bad_files ).to be_a Array
-    end
-
-    it "should contain its errors" do
-      expect( @checkstyle.bad_files[0].errors.size ).to be 2
-    end
-
-    it "should extract error details" do
-      expect( @checkstyle.bad_files[0].errors ).to eq(
-        [
-          {
-            "line"=>"1",
-            "severity"=>"error",
-            "message"=>"some error message",
-            "source"=>"com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"
-          },
-          {
-            "line" => "11",
-            "column" => "1 ",
-            "severity" => "warning",
-            "message" => "some error message",
-            "source" => "com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck"
-          }
-        ]
-      )
-    end
-  end
-
-  context "When has multiple bad files" do
-    # given
-    let(:output) { IO.read(fixture_file("output_two_bad_files.log")) }
-
-    # when
-    before { @checkstyle = extractor.extract output }
-
-    # then
-    it "should not be good" do
-      expect( @checkstyle ).to_not be_good
-    end
-
-    it "should extract multiple files" do
-      expect( @checkstyle.bad_files ).to be_a Array
-    end
-
-    it "should extract their errors" do
-      expect( @checkstyle.bad_files[0].errors.size ).to be 2
-      expect( @checkstyle.bad_files[1].errors.size ).to be 2
-    end
-
-    it "should extract error details" do
-      expect( @checkstyle.bad_files[0].errors ).to eq ([
-          {
-            "line"=>"1",
-            "severity"=>"error",
-            "message"=>"some error message",
-            "source"=>"com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"
-          },
-          {
-            "line" => "11",
-            "column" => "1 ",
-            "severity" => "warning",
-            "message" => "some error message",
-            "source" => "com.puppycrawl.tools.checkstyle.checks.design.HideUtilityClassConstructorCheck"
-          }
-      ])
-    end
-  end
-end

data/spec/plugins/pre_commit/message/formatter_spec.rb

@@ -1,62 +0,0 @@
-require 'spec_helper'
-require 'plugins/pre-commit/message/formatter'
-require 'plugins/pre-commit/domain/checkstyle'
-require 'plugins/pre-commit/domain/bad_file'
-
-##
-# Tests for PreCommit::Message::Formatter
-describe PreCommit::Message::Formatter do
-  let(:formatter) { PreCommit::Message::Formatter.new }
-
-  let(:file_error) {
-    Domain::BadFile.new('/some/path/file_name.java',
-    [{
-      "line"=>"1",
-      "severity"=>"error",
-      "message"=>"some error message",
-      "source"=>"com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"
-    }])
-  }
-
-  let(:file_error_2) {
-    Domain::BadFile.new('/some/path/file_name2.java',
-    [{
-      "line"=>"11",
-      "column"=>"40",
-      "severity"=>"error",
-      "message"=>"some error message",
-      "source"=>"com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocTypeCheck"
-    }])
-  }
-
-  context "When has empty input" do
-    it {expect{ formatter.format(nil) }.to raise_error(ArgumentError)}
-  end
-
-  context "When has no errors" do
-    let(:good) { Domain::Checkstyle.good }
-    it { expect(formatter.format(good)).to be_nil }
-  end
-
-  context "When has one file" do
-    let(:errors) { Domain::Checkstyle.new( [ file_error ] ) }
-
-    before { @formatted_output = formatter.format(errors)}
-
-    it{ expect( @formatted_output ).to include "File errors: /some/path/file_name.java"}
-    it{ expect( @formatted_output ).to include "  line: 1: error: some error message"}
-  end
-
-  context "When has more than one file" do
-    let(:errors) do
-      Domain::Checkstyle.new( [ file_error, file_error_2 ] )
-    end
-
-    before { @formatted_output = formatter.format(errors) }
-
-    it{ expect( @formatted_output ).to include "File errors: /some/path/file_name.java"}
-    it{ expect( @formatted_output ).to include "  line: 1: error: some error message"}
-    it{ expect( @formatted_output ).to include "File errors: /some/path/file_name2.java"}
-    it{ expect( @formatted_output ).to include "  line: 11:40 error: some error message"}
-  end
-end

data/spec/spec_helper.rb

@@ -1,22 +0,0 @@
-require "simplecov"
-SimpleCov.start
-
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
-
-require 'pre-commit'
-
-RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
-  config.run_all_when_everything_filtered = true
-  config.filter_run :focus
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = 'random'
-end
-
-def fixture_file(file)
-  File.expand_path("../fixtures/#{file}", __FILE__)
-end