jar-dependencies 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b2a5716a45be706871dee379b8460a7262605db5
-  data.tar.gz: 05b060c6a93a43062308daae49a2957be4ac3765
+SHA256:
+  metadata.gz: 5ed2b7bd13ae484338aaef4125ab50b17b1dbc8a0fd6e500ce921c39cf96bd7f
+  data.tar.gz: 34391061cd322aa0579d279ee76f8dfb55db94d49ef94aaca35a6fea1446c181
 SHA512:
-  metadata.gz: 6282cb6b2a56ef60f6110a47c0faecd95ce601a04691a4f2d244f5c073c9275b9612606f4b3793bee32b71222c809acc6088452b4dc1c4f338185d4977c9ab5b
-  data.tar.gz: ec8b9752bdaa207faa85dfcdf192d7a0bdedda927ecab72ec581705efea679edff1d2e9a4c8075c1682f68b897cb576ed367f8e14d03fc55ee80d43146671ce2
+  metadata.gz: 77ab2eca8481c94b314c5e6b418e80a99c022b7ff1feba933935fb455ecf785a8f75bfc9dd5daf2637f7eae9b50fd9dabf92e81a9b667f7800d89df01227ffe4
+  data.tar.gz: ee83286d324b89d784fc8ff06b764cf867e90df6dca4f03556703beff0ec7bf9c3ce5f5564f03798cce7921f997cb5f00cdf4f6cbbed53fb703981d9c4c0b517

data/Mavenfile

@@ -1,8 +1,8 @@
-#-*- mode: ruby -*-
+# frozen_string_literal: true
 
 gemfile
 
-plugin_repository id: :maven_gems, url: 'mavengem:https://rubygems.org'
+plugin_repository id: :mavengems, url: 'mavengem:https://rubygems.org'
 
 jruby_plugin(:minitest, minispecDirectory: 'specs/*_spec.rb') do
   execute_goals(:spec)
@@ -17,13 +17,12 @@ ruby_maven = gemfile_profile.dependencies.detect do |d|
   d.artifact_id == 'ruby-maven'
 end
 
-properties('jruby.versions' => ['1.7.12', '1.7.25', '${jruby.version}'].join(','),
-           'jruby.modes' => ['1.9', '2.0', '2.2'].join(','),
+properties('jruby.versions' => ['${jruby.version}'].join(','),
            # just lock the version
-           'bundler.version' => '1.10.6',
+           'bundler.version' => '2.5.11',
            'ruby-maven.version' => ruby_maven.version,
-           'jruby.version' => '9.0.5.0',
-           'jruby.plugins.version' => '1.1.3',
+           'jruby.version' => '9.4.8.0',
+           'jruby.plugins.version' => '3.0.2',
            'push.skip' => true)
 
 plugin :invoker, '1.8' do
@@ -37,7 +36,6 @@ plugin :invoker, '1.8' do
                 cloneProjectsTo: '${project.build.directory}',
                 properties: { 'jar-dependencies.version' => '${project.version}',
                               # use an old jruby with old ruby-maven here
-                              'jruby.old-version' => '1.7.20',
                               'jruby.version' => '${jruby.version}',
                               'jruby.plugins.version' => '${jruby.plugins.version}',
                               'bundler.version' => '${bundler.version}',
@@ -59,5 +57,3 @@ profile id: :release do
     default_goal :deploy
   end
 end
-
-# vim: syntax=Ruby

data/Rakefile

@@ -1,7 +1,12 @@
-#-*- mode: ruby -*-
+# frozen_string_literal: true
 
 task default: [:specs]
 
+require 'bundler/gem_tasks'
+require 'rubocop/rake_task'
+
+RuboCop::RakeTask.new
+
 desc 'run specs'
 task :specs do
   $LOAD_PATH << 'specs'
@@ -10,24 +15,3 @@ task :specs do
     require File.basename(f.sub(/.rb$/, ''))
   end
 end
-
-task :headers do
-  require 'copyright_header'
-
-  s = Gem::Specification.load(Dir['*gemspec'].first)
-
-  args = {
-    license: s.license,
-    copyright_software: s.name,
-    copyright_software_description: s.description,
-    copyright_holders: s.authors,
-    copyright_years: [Time.now.year],
-    add_path: 'lib',
-    output_dir: './'
-  }
-
-  command_line = CopyrightHeader::CommandLine.new(args)
-  command_line.execute
-end
-
-# vim: syntax=Ruby

data/Readme.md

@@ -47,7 +47,7 @@ during installation.
 
 If you do not want to vendor jars into a gem then **jar-dependency** gem can vendor
 them when you install the gem. In that case do not use
-`Jars::JarInstaller.install_jars` from the above rake tasks.
+`Jars::Installer.install_jars` from the above rake tasks.
 
 **NOTE**: Recent JRuby comes with **jar-dependencies** as default gem, for older
 versions for the feature to work you need to gem install **jar-dependencies** first
@@ -172,7 +172,7 @@ Or, with maven debug enabled
     JARS_DEBUG=true bundle install
     JARS_DEBUG=true gem install some_gem
 
-The maven command line which gets printed needs maven-3.3.x and the
+The maven command line which gets printed needs maven-3.9.x and the
 ruby DSL extension for maven:
 [https://github.com/takari/polyglot-maven#configuration](polyglot-maven
 configuration) where ```${maven.multiModuleProjectDirectory}``` is
@@ -216,3 +216,8 @@ Or a few days ago an issue for rake-compile [https://github.com/luislavena/rake-
 
 With JRuby 9000 it is the right time to get jar dependencies "right" - the current situation is like the time before bundler for gems.
 
+# Developing
+
+You must have the latest ruby-maven installed in your local JRuby.
+
+./mvnw install will build the gem and run integration tests

data/{bin → exe}/lock_jars

@@ -1,4 +1,6 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
+
 require 'jar_dependencies'
 require 'optparse'
 options = {}
@@ -25,11 +27,14 @@ optparse = OptionParser.new do |opts|
     options[:tree] = t
   end
 
-  opts.on('-u', '--update JAR_COORDINATE', 'Resolves given dependency and use  latest version. JAR_COORDINATE is either artifact_id or group_id:artifact_id') do |u|
+  opts.on('-u', '--update JAR_COORDINATE',
+          'Resolves given dependency and use latest version. ' \
+          'JAR_COORDINATE is either artifact_id or group_id:artifact_id') do |u|
     options[:update] = u
   end
 
-  opts.on('--vendor-dir DIRECTORY', 'Vendor directory where to copy the installed jars.', 'add this directory to $LOAD_PATH or set JARS_HOME respectively.') do |dir|
+  opts.on('--vendor-dir DIRECTORY', 'Vendor directory where to copy the installed jars.' \
+                                    'add this directory to $LOAD_PATH or set JARS_HOME respectively.') do |dir|
     options[:vendor_dir] = dir
   end
 

data/jar-dependencies.gemspec

@@ -1,47 +1,47 @@
-#-*- mode: ruby -*-
+# frozen_string_literal: true
+
+require_relative 'lib/jars/version'
 
 Gem::Specification.new do |s|
   s.name = 'jar-dependencies'
 
-  path = File.expand_path('lib/jars/version.rb', File.dirname(__FILE__))
-  s.version = File.read(path).match(/\s*VERSION\s*=\s*['"](.*)['"]/)[1]
+  s.version = Jars::VERSION
 
   s.author = 'christian meier'
   s.email = ['mkristian@web.de']
   s.summary = 'manage jar dependencies for gems'
   s.homepage = 'https://github.com/mkristian/jar-dependencies'
 
-  s.bindir = 'bin'
-  LOCK_JARS = 'lock_jars'.freeze
-  s.executables = [LOCK_JARS]
+  s.bindir = 'exe'
+  s.executables = [lock_jars = 'lock_jars']
 
   s.license = 'MIT'
 
-  s.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR).select do |file|
-    file =~ /^lib\// ||
-      %w[Mavenfile Rakefile].include?(file) ||
-      ['Readme.md', 'jar-dependencies.gemspec', 'MIT-LICENSE'].include?(file)
-  end
+  s.files = Dir['{lib}/**/*'] + %w[Mavenfile Rakefile Readme.md jar-dependencies.gemspec MIT-LICENSE]
 
-  s.description = 'manage jar dependencies for gems and keep track which jar was already loaded using maven artifact coordinates. it warns on version conflicts and loads only ONE jar assuming the first one is compatible to the second one otherwise your project needs to lock down the right version by providing a Jars.lock file.'
+  s.description = <<~TEXT
+    manage jar dependencies for gems and keep track which jar was already
+    loaded using maven artifact coordinates. it warns on version conflicts and
+    loads only ONE jar assuming the first one is compatible to the second one
+    otherwise your project needs to lock down the right version by providing a
+    Jars.lock file.
+  TEXT
 
-  s.add_development_dependency 'minitest', '~> 5.3'
-  s.add_development_dependency 'pry'
-  s.add_development_dependency 'rake', '~> 10.2'
-  RUBY_MAVEN_VERSION = '~> 3.3.11'.freeze
-  s.add_development_dependency 'ruby-maven', RUBY_MAVEN_VERSION
+  s.required_ruby_version = '>= 2.6'
 
-  s.post_install_message = <<EOF
+  s.add_development_dependency 'minitest', '~> 5.10'
+  s.add_development_dependency 'ruby-maven', ruby_maven_version = '~> 3.9'
 
-if you want to use the executable #{LOCK_JARS} then install ruby-maven gem before using #{LOCK_JARS}
+  s.post_install_message = <<~TEXT
 
-  $ gem install ruby-maven -v '#{RUBY_MAVEN_VERSION}'
+    if you want to use the executable #{lock_jars} then install ruby-maven gem before using #{lock_jars}
 
-or add it as a development dependency to your Gemfile
+      $ gem install ruby-maven -v '#{ruby_maven_version}'
 
-   gem 'ruby-maven', '#{RUBY_MAVEN_VERSION}'
+    or add it as a development dependency to your Gemfile
 
-EOF
-end
+       gem 'ruby-maven', '#{ruby_maven_version}'
 
-# vim: syntax=Ruby
+  TEXT
+  s.metadata['rubygems_mfa_required'] = 'true'
+end

data/lib/jar-dependencies.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Copyright (C) 2014 Christian Meier
 #

data/lib/jar_dependencies.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Copyright (C) 2014 Christian Meier
 #
@@ -21,41 +23,44 @@
 
 module Jars
   unless defined? Jars::SKIP_LOCK
-    MAVEN_SETTINGS = 'JARS_MAVEN_SETTINGS'.freeze
-    LOCAL_MAVEN_REPO = 'JARS_LOCAL_MAVEN_REPO'.freeze
+    MAVEN_SETTINGS = 'JARS_MAVEN_SETTINGS'
+    LOCAL_MAVEN_REPO = 'JARS_LOCAL_MAVEN_REPO'
     # lock file to use
-    LOCK = 'JARS_LOCK'.freeze
+    LOCK = 'JARS_LOCK'
     # where the locally stored jars are search for or stored
-    HOME = 'JARS_HOME'.freeze
+    HOME = 'JARS_HOME'
     # skip the gem post install hook
-    SKIP = 'JARS_SKIP'.freeze
+    SKIP = 'JARS_SKIP'
     # skip Jars.lock mainly to run lock_jars
-    SKIP_LOCK = 'JARS_SKIP_LOCK'.freeze
+    SKIP_LOCK = 'JARS_SKIP_LOCK'
     # do not require any jars if set to false
-    REQUIRE = 'JARS_REQUIRE'.freeze
+    REQUIRE = 'JARS_REQUIRE'
     # @private
-    NO_REQUIRE = 'JARS_NO_REQUIRE'.freeze
+    NO_REQUIRE = 'JARS_NO_REQUIRE'
     # no more warnings on conflict. this still requires jars but will
     # not warn. it is needed to load jars from (default) gems which
     # do contribute to any dependency manager (maven, gradle, jbundler)
-    QUIET = 'JARS_QUIET'.freeze
+    QUIET = 'JARS_QUIET'
     # show maven output
-    VERBOSE = 'JARS_VERBOSE'.freeze
+    VERBOSE = 'JARS_VERBOSE'
     # maven debug
-    DEBUG = 'JARS_DEBUG'.freeze
+    DEBUG = 'JARS_DEBUG'
     # vendor jars inside gem when installing gem
-    VENDOR = 'JARS_VENDOR'.freeze
+    VENDOR = 'JARS_VENDOR'
     # string used when the version is unknown
     UNKNOWN = 'unknown'
   end
 
   autoload :MavenSettings, 'jars/maven_settings'
 
+  @jars_lock = false
+  @jars = {}
+
   class << self
-    def lock_down(debug = false, verbose = false, options = {})
+    def lock_down(debug: false, verbose: false, **kwargs)
       ENV[SKIP_LOCK] = 'true'
       require 'jars/lock_down' # do this lazy to keep things clean
-      Jars::LockDown.new(debug, verbose).lock_down(options)
+      Jars::LockDown.new(debug, verbose).lock_down(**kwargs)
     ensure
       ENV[SKIP_LOCK] = nil
     end
@@ -63,8 +68,11 @@ module Jars
     if defined? JRUBY_VERSION
       def to_prop(key)
         key = key.tr('_', '.')
-        ENV_JAVA[(key.downcase!; key)] ||
-          ENV[(key.tr!('.', '_'); key.upcase!; key)]
+        ENV_JAVA[(key.downcase!
+                  key)] ||
+          ENV[(key.tr!('.', '_')
+               key.upcase!
+               key)]
       end
     else
       def to_prop(key)
@@ -74,6 +82,7 @@ module Jars
 
     def to_boolean(key)
       return nil if (prop = to_prop(key)).nil?
+
       prop.empty? || prop.eql?('true')
     end
 
@@ -82,7 +91,6 @@ module Jars
     end
 
     def require?
-      @require = nil unless instance_variable_defined?(:@require)
       if @require.nil?
         if (require = to_boolean(REQUIRE)).nil?
           no_require = to_boolean(NO_REQUIRE)
@@ -96,16 +104,16 @@ module Jars
     attr_writer :require
 
     def quiet?
-      (@silent ||= false) || to_boolean(QUIET)
+      @quiet = to_boolean(QUIET) if @quiet.nil?
+      @quiet
     end
 
-    def jarfile
-      ENV['JARFILE'] || ENV_JAVA['jarfile'] || ENV['JBUNDLER_JARFILE'] || ENV_JAVA['jbundler.jarfile'] || 'Jarfile'
+    def no_more_warnings
+      @quiet = true
     end
 
-    # @deprecated
-    def no_require?
-      !require?
+    def jarfile
+      ENV['JARFILE'] || ENV_JAVA['jarfile'] || ENV['JBUNDLER_JARFILE'] || ENV_JAVA['jbundler.jarfile'] || 'Jarfile'
     end
 
     def verbose?
@@ -120,10 +128,6 @@ module Jars
       to_boolean(VENDOR)
     end
 
-    def no_more_warnings
-      @silent = true
-    end
-
     def freeze_loading
       self.require = false
     end
@@ -137,18 +141,20 @@ module Jars
     end
 
     def jars_lock_from_class_loader
-      if to_prop(LOCK).nil? && defined?(JRUBY_VERSION)
-        if JRuby::Util.respond_to?(:class_loader_resources)
-          JRuby::Util.class_loader_resources('Jars.lock')
-        else; require 'jruby'
-          JRuby.runtime.jruby_class_loader.get_resources('Jars.lock').collect(&:to_s)
-        end
+      return unless to_prop(LOCK).nil? && defined?(JRUBY_VERSION)
+
+      if JRuby::Util.respond_to?(:class_loader_resources)
+        JRuby::Util.class_loader_resources('Jars.lock')
+      else
+        require 'jruby'
+        JRuby.runtime.jruby_class_loader.get_resources('Jars.lock').collect(&:to_s)
       end
     end
 
     def lock_path(basedir = nil)
       deps = lock
       return deps if File.exist?(deps)
+
       basedir ||= '.'
       ['.', 'jars', 'vendor/jars'].each do |dir|
         file = File.join(basedir, dir, lock)
@@ -158,9 +164,13 @@ module Jars
     end
 
     def reset
-      instance_variables.each { |var| instance_variable_set(var, nil) }
+      instance_variables.each do |var|
+        next if var == :@jars_lock
+
+        instance_variable_set(var, nil)
+      end
       Jars::MavenSettings.reset
-      (@@jars ||= {}).clear
+      @jars = {}
     end
 
     def maven_local_settings
@@ -180,21 +190,21 @@ module Jars
     end
 
     def local_maven_repo
-      @_local_maven_repo ||= absolute(to_prop(LOCAL_MAVEN_REPO)) ||
-                             detect_local_repository(maven_local_settings) ||
-                             detect_local_repository(maven_user_settings) ||
-                             detect_local_repository(maven_global_settings) ||
-                             File.join(user_home, '.m2', 'repository')
+      @local_maven_repo ||= absolute(to_prop(LOCAL_MAVEN_REPO)) ||
+                            detect_local_repository(maven_local_settings) ||
+                            detect_local_repository(maven_user_settings) ||
+                            detect_local_repository(maven_global_settings) ||
+                            File.join(user_home, '.m2', 'repository')
     end
 
     def home
-      absolute(to_prop(HOME)) || local_maven_repo
+      @home ||= absolute(to_prop(HOME)) || local_maven_repo
     end
 
     def require_jars_lock!(scope = :runtime)
       urls = jars_lock_from_class_loader
       if urls && !urls.empty?
-        @@jars_lock = true
+        @jars_lock = true
         # funny error during spec where it tries to load it again
         # and finds it as gem instead of the LOAD_PATH
         require 'jars/classpath' unless defined? Jars::Classpath
@@ -202,6 +212,7 @@ module Jars
         while done != urls
           urls.each do |url|
             next if done.member?(url)
+
             Jars.debug { "--- load jars from uri #{url}" }
             classpath = Jars::Classpath.new(nil, "uri:#{url}")
             classpath.require(scope)
@@ -210,9 +221,9 @@ module Jars
           urls = jars_lock_from_class_loader
         end
         no_more_warnings
-      elsif jars_lock = Jars.lock_path
+      elsif (jars_lock = Jars.lock_path)
         Jars.debug { "--- load jars from #{jars_lock}" }
-        @@jars_lock = jars_lock
+        @jars_lock = jars_lock
         # funny error during spec where it tries to load it again
         # and finds it as gem instead of the LOAD_PATH
         require 'jars/classpath' unless defined? Jars::Classpath
@@ -221,8 +232,7 @@ module Jars
         no_more_warnings
       end
       Jars.debug do
-        @@jars ||= {}
-        loaded = @@jars.collect { |k, v| "#{k}:#{v}" }
+        loaded = @jars.collect { |k, v| "#{k}:#{v}" }
         "--- loaded jars ---\n\t#{loaded.join("\n\t")}"
       end
     end
@@ -232,8 +242,8 @@ module Jars
       when Symbol
         require_jars_lock!(options)
       when Hash
-        @_jars_home = options[:jars_home]
-        @_jars_lock = options[:jars_lock]
+        @home = options[:jars_home]
+        @jars_lock = options[:jars_lock]
         require_jars_lock!(options[:scope] || :runtime)
       else
         require_jars_lock!
@@ -241,25 +251,23 @@ module Jars
     end
 
     def require_jars_lock
-      @@jars_lock ||= false
-      unless @@jars_lock
-        require_jars_lock!
-        @@jars_lock ||= true
-      end
+      return if @jars_lock
+
+      require_jars_lock!
+      @jars_lock ||= true # rubocop:disable Naming/MemoizedInstanceVariableName
     end
 
     def mark_as_required(group_id, artifact_id, *classifier_version)
       require_jar_with_block(group_id, artifact_id, *classifier_version) do
+        # ignore
       end
     end
 
-    def require_jar(group_id, artifact_id, *classifier_version, &block)
+    def require_jar(group_id, artifact_id, *classifier_version)
       require_jars_lock unless skip_lock?
       if classifier_version.empty? && block_given?
-        classifier_version = [block.call].compact
-        if classifier_version.empty?
-          return mark_as_required(group_id, artifact_id, UNKNOWN) || false
-        end
+        classifier_version = [yield].compact
+        return mark_as_required(group_id, artifact_id, UNKNOWN) || false if classifier_version.empty?
       end
       require_jar_with_block(group_id, artifact_id, *classifier_version) do |gid, aid, version, classifier|
         do_require(gid, aid, version, classifier)
@@ -281,9 +289,7 @@ module Jars
     def user_home
       ENV['HOME'] || begin
         user_home = Dir.home if Dir.respond_to?(:home)
-        unless user_home
-          user_home = ENV_JAVA['user.home'] if Object.const_defined?(:ENV_JAVA)
-        end
+        user_home = ENV_JAVA['user.home'] if !user_home && Object.const_defined?(:ENV_JAVA)
         user_home
       end
     end
@@ -294,19 +300,18 @@ module Jars
       version = classifier_version[-1]
       classifier = classifier_version[-2]
 
-      @@jars ||= {}
-      coordinate = "#{group_id}:#{artifact_id}"
+      coordinate = +"#{group_id}:#{artifact_id}"
       coordinate << ":#{classifier}" if classifier
-      if @@jars.key? coordinate
-        if @@jars[coordinate] == version
+      if @jars.key? coordinate
+        if @jars[coordinate] == version
           false
         else
-          @@jars[coordinate] # version of already registered jar
+          @jars[coordinate] # version of already registered jar
         end
       else
         yield group_id, artifact_id, version, classifier
-        @@jars[coordinate] = version
-        return true
+        @jars[coordinate] = version
+        true
       end
     end
 
@@ -315,7 +320,7 @@ module Jars
 
       doc = File.read(settings)
       # TODO: filter out xml comments
-      local_repo = doc.sub(/<\/localRepository>.*/m, '').sub(/.*<localRepository>/m, '')
+      local_repo = doc.sub(%r{</localRepository>.*}m, '').sub(/.*<localRepository>/m, '')
       # replace maven like system properties embedded into the string
       local_repo.gsub!(/\$\{[a-zA-Z.]+\}/) do |a|
         ENV_JAVA[a[2..-2]] || a
@@ -328,7 +333,7 @@ module Jars
     end
 
     def to_jar(group_id, artifact_id, version, classifier = nil)
-      file = String.new("#{group_id.tr('.', '/')}/#{artifact_id}/#{version}/#{artifact_id}-#{version}")
+      file = +"#{group_id.tr('.', '/')}/#{artifact_id}/#{version}/#{artifact_id}-#{version}"
       file << "-#{classifier}" if classifier
       file << '.jar'
       file
@@ -336,34 +341,36 @@ module Jars
 
     def do_require(*args)
       jar = to_jar(*args)
-      local = File.join(Dir.pwd, 'jars', jar)
-      vendor = File.join(Dir.pwd, 'vendor', 'jars', jar)
-      file = File.join(home, jar)
-      # use jar from local repository if exists
-      if File.exist?(file)
-        require file
-      # use jar from PWD/jars if exists
-      elsif File.exist?(local)
-        require local
       # use jar from PWD/vendor/jars if exists
-      elsif File.exist?(vendor)
+      if File.exist?(vendor = File.join(Dir.pwd, 'vendor', 'jars', jar))
         require vendor
+      # use jar from PWD/jars if exists
+      elsif File.exist?(local = File.join(Dir.pwd, 'jars', jar))
+        require local
+      # use jar from local repository if exists
+      elsif File.exist?(file = File.join(home, jar))
+        require file
       else
         # otherwise try to find it on the load path
         require jar
       end
     rescue LoadError => e
-      raise "\n\n\tyou might need to reinstall the gem which depends on the missing jar or in case there is Jars.lock then resolve the jars with `lock_jars` command\n\n" + e.message + ' (LoadError)'
+      raise "\n\n\tyou might need to reinstall the gem which depends on the " \
+            'missing jar or in case there is Jars.lock then resolve the jars with ' \
+            "`lock_jars` command\n\n#{e.message} (LoadError)"
     end
-  end # class << self
+  end
 end
 
 def require_jar(*args, &block)
   return nil unless Jars.require?
+
   result = Jars.require_jar(*args, &block)
   if result.is_a? String
-    args << (block.call || Jars::UNKNOWN) if args.size == 2 && block_given?
-    Jars.warn { "--- jar coordinate #{args[0..-2].join(':')} already loaded with version #{result} - omit version #{args[-1]}" }
+    args << (yield || Jars::UNKNOWN) if args.size == 2 && block
+    Jars.warn do
+      "--- jar coordinate #{args[0..-2].join(':')} already loaded with version #{result} - omit version #{args[-1]}"
+    end
     Jars.debug { "    try to load from #{caller.join("\n\t")}" }
     return false
   end

data/lib/jar_install_post_install_hook.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #
 # Copyright (C) 2014 Christian Meier
 #

data/lib/jars/attach_jars_pom.rb

@@ -1,13 +1,17 @@
+# frozen_string_literal: true
+
 # this file is maven DSL
 
-(0..10_000).each do |i|
+10_000.times do |i|
   coord = ENV_JAVA["jars.#{i}"]
   break unless coord
+
   artifact = Maven::Tools::Artifact.from_coordinate(coord)
   exclusions = []
-  (0..10_000).each do |j|
+  10_000.times do |j|
     exclusion = ENV_JAVA["jars.#{i}.exclusions.#{j}"]
     break unless exclusion
+
     exclusions << exclusion
   end
   scope = ENV_JAVA["jars.#{i}.scope"]

data/lib/jars/classpath.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'jars/maven_exec'
 require 'jars/lock'
 require 'fileutils'
@@ -38,15 +40,11 @@ module Jars
         deps = Jars.lock_path(mvn.basedir)
         @deps = deps if deps && File.exist?(deps)
       end
-      if @deps
-        @deps
-      else
-        resolve_dependencies
-      end
+      @deps || resolve_dependencies
     end
     private :dependencies_list
 
-    DEPENDENCY_LIST = 'dependencies.list'.freeze
+    DEPENDENCY_LIST = 'dependencies.list'
     def resolve_dependencies
       basedir = workdir('pkg') || workdir('target') || workdir('')
       deps = File.join(basedir, DEPENDENCY_LIST)
@@ -63,10 +61,10 @@ module Jars
           require_jar(*jar.gacv)
         end
       end
-      if scope.nil? || scope == :runtime
-        process(:provided) do |jar|
-          Jars.mark_as_required(*jar.gacv)
-        end
+      return unless scope.nil? || scope == :runtime
+
+      process(:provided) do |jar|
+        Jars.mark_as_required(*jar.gacv)
       end
     end