jar-dependencies 0.3.11 → 0.3.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 21c3aa63524ec5c3364e055712810d559e4e5cf4
-  data.tar.gz: 6d4d4532738f38c7f10b5c1997edc11854bc6a21
+  metadata.gz: f4108689beca71246730298b652ff1f257b632c9
+  data.tar.gz: 9ce8d4bbd9b198e10b7071d02a796ce7076f436c
 SHA512:
-  metadata.gz: 42f48de83b2c779e9b7c4b6597ccf0ea4759a44b3071f644cec82635863ff14f62bd63cb54762f561972c4bd9b6901fb2fbb4c319bfd6b4ee050b70210935636
-  data.tar.gz: 0d6b8b37fdf3332cac18da6aaf39af048f3ce3c2b5aca0051e2088c54b7ebe2a1d7efe71c5c02d928a78707685dc78f61f24e83f0616b6509ccd11e61d9f7cf5
+  metadata.gz: 2f72239c3d9d03f10841d27023b54c1dd55f04242ba9162eb7c362c412b014cc167ad231d359ffe5b57be3218c85b5e258c50cb3e224ddb41f006ba1ab3b7c0e
+  data.tar.gz: f2225f1fd6d20a70ebc7ea9835b56c84307554d177df49d5751b99ebd2f5ecb26d2abca5b1aa7ee3baea4330393811c0e78ef36548aa79ba52853238039bb852

data/Mavenfile

@@ -2,9 +2,9 @@
 
 gemfile
 
-plugin_repository :id => :maven_gems, :url => 'mavengem:https://rubygems.org'
+plugin_repository id: :maven_gems, url: 'mavengem:https://rubygems.org'
 
-jruby_plugin( :minitest, :minispecDirectory => "specs/*_spec.rb" ) do
+jruby_plugin(:minitest, minispecDirectory: 'specs/*_spec.rb') do
   execute_goals(:spec)
   gem 'ruby-maven', '${ruby-maven.version}'
 end
@@ -17,51 +17,47 @@ ruby_maven = gemfile_profile.dependencies.detect do |d|
   d.artifact_id == 'ruby-maven'
 end
 
-properties( 'jruby.versions' => ['1.7.12', '1.7.25', '9.0.5.0', '${jruby.version}'
-                                ].join(','),
-            'jruby.modes' => ['1.9', '2.0', '2.2'].join(','),
-            # just lock the version
-            'bundler.version' => '1.10.6',
-            'ruby-maven.version' => ruby_maven.version,
-            'jruby.version' => '9.1.8.0',
-            'jruby.plugins.version' => '1.1.3',
-            'push.skip' => true  )
+properties('jruby.versions' => ['1.7.12', '1.7.25', '${jruby.version}'].join(','),
+           'jruby.modes' => ['1.9', '2.0', '2.2'].join(','),
+           # just lock the version
+           'bundler.version' => '1.10.6',
+           'ruby-maven.version' => ruby_maven.version,
+           'jruby.version' => '9.0.5.0',
+           'jruby.plugins.version' => '1.1.3',
+           'push.skip' => true)
 
 plugin :invoker, '1.8' do
-  execute_goals( :install, :run,
-                 :id => 'integration-tests',
-                 :projectsDirectory => 'integration',
-                 :streamLogs => true,
-                 :goals => ['install'],
-                 :preBuildHookScript => 'setup.bsh',
-                 :postBuildHookScript => 'verify.bsh',
-                 :cloneProjectsTo => '${project.build.directory}',
-                 :properties => { 'jar-dependencies.version' => '${project.version}',
-                   # use an old jruby with old ruby-maven here
-                   'jruby.old-version' => '1.7.20',
-                   'jruby.version' => '${jruby.version}',
-                   'jruby.plugins.version' => '${jruby.plugins.version}',
-                   'bundler.version' => '${bundler.version}',
-                   'ruby-maven.version' => '${ruby-maven.version}' })
+  execute_goals(:install, :run,
+                id: 'integration-tests',
+                projectsDirectory: 'integration',
+                streamLogs: true,
+                goals: ['install'],
+                preBuildHookScript: 'setup.bsh',
+                postBuildHookScript: 'verify.bsh',
+                cloneProjectsTo: '${project.build.directory}',
+                properties: { 'jar-dependencies.version' => '${project.version}',
+                              # use an old jruby with old ruby-maven here
+                              'jruby.old-version' => '1.7.20',
+                              'jruby.version' => '${jruby.version}',
+                              'jruby.plugins.version' => '${jruby.plugins.version}',
+                              'bundler.version' => '${bundler.version}',
+                              'ruby-maven.version' => '${ruby-maven.version}' })
 end
 
 distribution_management do
-  repository :id => :ossrh, :url => 'https://oss.sonatype.org/service/local/staging/deploy/maven2/'
+  repository id: :ossrh, url: 'https://oss.sonatype.org/service/local/staging/deploy/maven2/'
 end
 
-profile :id => :skip do
-
- properties 'maven.test.skip' => true, 'invoker.skip' => true
-
+profile id: :skip do
+  properties 'maven.test.skip' => true, 'invoker.skip' => true
 end
 
-profile :id => :release do
+profile id: :release do
   properties 'maven.test.skip' => true, 'invoker.skip' => true, 'push.skip' => false
 
   build do
     default_goal :deploy
   end
-
 end
 
 # vim: syntax=Ruby

data/Rakefile

@@ -1,32 +1,32 @@
 #-*- mode: ruby -*-
 
-task :default => [ :specs ]
+task default: [:specs]
 
 desc 'run specs'
 task :specs do
-  $LOAD_PATH << "specs"
+  $LOAD_PATH << 'specs'
 
-  Dir['specs/*_spec.rb'].each do |f| 
-    require File.basename( f.sub(/.rb$/, '' ) )
+  Dir['specs/*_spec.rb'].each do |f|
+    require File.basename(f.sub(/.rb$/, ''))
   end
 end
 
 task :headers do
   require 'copyright_header'
 
-  s = Gem::Specification.load( Dir["*gemspec"].first )
+  s = Gem::Specification.load(Dir['*gemspec'].first)
 
   args = {
-    :license => s.license, 
-    :copyright_software => s.name,
-    :copyright_software_description => s.description,
-    :copyright_holders => s.authors,
-    :copyright_years => [Time.now.year],
-    :add_path => "lib",
-    :output_dir => './'
+    license: s.license,
+    copyright_software: s.name,
+    copyright_software_description: s.description,
+    copyright_holders: s.authors,
+    copyright_years: [Time.now.year],
+    add_path: 'lib',
+    output_dir: './'
   }
 
-  command_line = CopyrightHeader::CommandLine.new( args )
+  command_line = CopyrightHeader::CommandLine.new(args)
   command_line.execute
 end
 

data/Readme.md

@@ -1,7 +1,7 @@
 # jar-dependencies #
 
-* [![Build Status](https://secure.travis-ci.org/mkristian/jar-dependencies.png)](http://travis-ci.org/mkristian/jar-dependencies)
-* [![Code Climate](https://codeclimate.com/github/mkristian/jar-dependencies.png)](https://codeclimate.com/github/mkristian/jar-dependencies)
+* [![Build Status](https://secure.travis-ci.org/mkristian/jar-dependencies.svg)](http://travis-ci.org/mkristian/jar-dependencies)
+* [![Code Climate](https://codeclimate.com/github/mkristian/jar-dependencies.svg)](https://codeclimate.com/github/mkristian/jar-dependencies)
 
 add gem dependencies for jar files to ruby gems.
 
@@ -185,22 +185,22 @@ your current directory.
 <td>ENV</td><td>java system property</td><td>default</td><td>description</td>
 </tr>
 <tr>
-<td>`JARS_DEBUG`</td><td>jars.debug</td><td>false</td><td>if set to true it will produce lots of debug out (maven -X switch)</td>
+<td><tt>JARS_DEBUG</tt></td><td>jars.debug</td><td>false</td><td>if set to true it will produce lots of debug out (maven -X switch)</td>
 </tr>
 <tr>
-<td>`JARS_VERBOSE`</td><td>jars.verbose</td><td>false</td><td>if set to true it will produce some extra output</td>
+<td><tt>JARS_VERBOSE</tt></td><td>jars.verbose</td><td>false</td><td>if set to true it will produce some extra output</td>
 </tr>
 <tr>
-<td>`JARS_HOME`</td><td>jars.home</td><td>$HOME/.m2/repository</td><td>filesystem location where to store the jar files and some metadata</td>
+<td><tt>JARS_HOME</tt></td><td>jars.home</td><td>$HOME/.m2/repository</td><td>filesystem location where to store the jar files and some metadata</td>
 </tr>
 <tr>
-<td>`JARS_MAVEN_SETTINGS`</td><td>jars.maven.settings</td><td>$HOME/.m2/settings.xml</td><td>setting.xml for maven to use</td>
+<td><tt>JARS_MAVEN_SETTINGS</tt></td><td>jars.maven.settings</td><td>$HOME/.m2/settings.xml</td><td>setting.xml for maven to use</td>
 </tr>
 <tr>
-<td>`JARS_VENDOR`</td><td>jars.vendor</td><td>true</td><td>set to true means that the jars will be stored in JARS_HOME only</td>
+<td><tt>JARS_VENDOR</tt></td><td>jars.vendor</td><td>true</td><td>set to true means that the jars will be stored in JARS_HOME only</td>
 </tr>
 <tr>
-<td>`JARS_SKIP`</td><td>jars.skip</td><td>true</td><td>do **NOT** install jar dependencies at all</td>
+<td><tt>JARS_SKIP</tt></td><td>jars.skip</td><td>true</td><td>do **NOT** install jar dependencies at all</td>
 </tr>
 </table>
 

data/bin/lock_jars

@@ -1,9 +1,8 @@
 #!/usr/bin/env ruby
 require 'jar_dependencies'
-require 'optparse' 
-options = {}  
-optparse = OptionParser.new do|opts| 
-
+require 'optparse'
+options = {}
+optparse = OptionParser.new do |opts|
   opts.banner = "Usage: #{File.basename(__FILE__)} [options]"
 
   opts.separator ''
@@ -15,35 +14,35 @@ optparse = OptionParser.new do|opts|
   opts.separator 'Options:'
   opts.separator ''
 
-  opts.on( '-v', '--verbose', 'Output more information' ) do |t|
+  opts.on('-v', '--verbose', 'Output more information') do |t|
     options[:verbose] = t
   end
 
-  opts.on( '-d', '--debug', 'Output debug information' ) do |t|
+  opts.on('-d', '--debug', 'Output debug information') do |t|
     options[:debug] = t
   end
 
-  opts.on( '-f', '--force', 'Force creation of Jars.lock' ) do |t|
+  opts.on('-f', '--force', 'Force creation of Jars.lock') do |t|
     options[:force] = t
   end
 
-  opts.on( '-t', '--tree', 'Show dependency tree' ) do |t|
+  opts.on('-t', '--tree', 'Show dependency tree') do |t|
     options[:tree] = t
   end
 
-  opts.on( '-u', '--update JAR_COORDINATE', 'Resolves given dependency and use  latest version. JAR_COORDINATE is either artifact_id or group_id:artifact_id' ) do |u|
+  opts.on('-u', '--update JAR_COORDINATE', 'Resolves given dependency and use  latest version. JAR_COORDINATE is either artifact_id or group_id:artifact_id') do |u|
     options[:update] = u
   end
 
-  opts.on( '--vendor-dir DIRECTORY', 'Vendor directory where to copy the installed jars.', 'add this directory to $LOAD_PATH or set JARS_HOME respectively.' ) do |dir|
+  opts.on('--vendor-dir DIRECTORY', 'Vendor directory where to copy the installed jars.', 'add this directory to $LOAD_PATH or set JARS_HOME respectively.') do |dir|
     options[:vendor_dir] = dir
   end
 
-  opts.on( '-h', '--help', 'Display this screen' ) do
+  opts.on('-h', '--help', 'Display this screen') do
     puts opts
     exit
   end
 end
 optparse.parse!
 
-Jars.lock_down( options[:debug], options[:verbose], options )
+Jars.lock_down(options[:debug], options[:verbose], options)

data/jar-dependencies.gemspec

@@ -4,37 +4,37 @@ Gem::Specification.new do |s|
   s.name = 'jar-dependencies'
 
   path = File.expand_path('lib/jars/version.rb', File.dirname(__FILE__))
-  s.version = File.read(path).match( /\s*VERSION\s*=\s*['"](.*)['"]/ )[1]
-  
+  s.version = File.read(path).match(/\s*VERSION\s*=\s*['"](.*)['"]/)[1]
+
   s.author = 'christian meier'
-  s.email = [ 'mkristian@web.de' ]
+  s.email = ['mkristian@web.de']
   s.summary = 'manage jar dependencies for gems'
   s.homepage = 'https://github.com/mkristian/jar-dependencies'
 
-  s.bindir = "bin"
-  LOCK_JARS = 'lock_jars'
+  s.bindir = 'bin'
+  LOCK_JARS = 'lock_jars'.freeze
   s.executables = [LOCK_JARS]
 
   s.license = 'MIT'
 
-  s.files = `git ls-files`.split($/).select do |file|
+  s.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR).select do |file|
     file =~ /^lib\// ||
-    [ 'Mavenfile', 'Rakefile' ].include?(file) ||
-    [ 'Readme.md', 'jar-dependencies.gemspec', 'MIT-LICENSE' ].include?(file)
+      %w[Mavenfile Rakefile].include?(file) ||
+      ['Readme.md', 'jar-dependencies.gemspec', 'MIT-LICENSE'].include?(file)
   end
 
   s.description = 'manage jar dependencies for gems and keep track which jar was already loaded using maven artifact coordinates. it warns on version conflicts and loads only ONE jar assuming the first one is compatible to the second one otherwise your project needs to lock down the right version by providing a Jars.lock file.'
 
   s.add_development_dependency 'minitest', '~> 5.3'
   s.add_development_dependency 'rake', '~> 10.2'
-  RUBY_MAVEN_VERSION = '~> 3.3.11'
+  RUBY_MAVEN_VERSION = '~> 3.3.11'.freeze
   s.add_development_dependency 'ruby-maven', RUBY_MAVEN_VERSION
 
   s.post_install_message = <<EOF
 
-if you want to use the executable #{LOCK_JARS} then install ruby-maven gem before using #{LOCK_JARS} 
+if you want to use the executable #{LOCK_JARS} then install ruby-maven gem before using #{LOCK_JARS}
 
-   $ gem install ruby-maven -v '#{RUBY_MAVEN_VERSION}'
+  $ gem install ruby-maven -v '#{RUBY_MAVEN_VERSION}'
 
 or add it as a development dependency to your Gemfile
 

data/lib/jar_dependencies.rb

@@ -50,42 +50,41 @@ module Jars
   autoload :MavenSettings, 'jars/maven_settings'
 
   class << self
-
-    def lock_down( debug = false, verbose = false, options = {} )
-      ENV[ SKIP_LOCK ] = 'true'
+    def lock_down(debug = false, verbose = false, options = {})
+      ENV[SKIP_LOCK] = 'true'
       require 'jars/lock_down' # do this lazy to keep things clean
-      Jars::LockDown.new( debug, verbose ).lock_down( options )
+      Jars::LockDown.new(debug, verbose).lock_down(options)
     ensure
-      ENV[ SKIP_LOCK ] = nil
+      ENV[SKIP_LOCK] = nil
     end
 
     if defined? JRUBY_VERSION
-      def to_prop( key )
-        key = key.gsub( '_', '.' )
-        ENV_JAVA[ ( key.downcase!; key ) ] ||
-          ENV[ ( key.gsub!( '.', '_' ); key.upcase!; key ) ]
+      def to_prop(key)
+        key = key.tr('_', '.')
+        ENV_JAVA[(key.downcase!; key)] ||
+          ENV[(key.tr!('.', '_'); key.upcase!; key)]
       end
     else
-      def to_prop( key )
-        ENV[ key.gsub( '.', '_' ).upcase ]
+      def to_prop(key)
+        ENV[key.tr('.', '_').upcase]
       end
     end
 
-    def to_boolean( key )
-      return nil if ( prop = to_prop( key ) ).nil?
+    def to_boolean(key)
+      return nil if (prop = to_prop(key)).nil?
       prop.empty? || prop.eql?('true')
     end
 
     def skip?
-      to_boolean( SKIP )
+      to_boolean(SKIP)
     end
 
     def require?
       @require = nil unless instance_variable_defined?(:@require)
       if @require.nil?
-        if ( require = to_boolean( REQUIRE ) ).nil?
-          no_require = to_boolean( NO_REQUIRE )
-          @require = no_require.nil? ? true : ! no_require
+        if (require = to_boolean(REQUIRE)).nil?
+          no_require = to_boolean(NO_REQUIRE)
+          @require = no_require.nil? ? true : !no_require
         else
           @require = require
         end
@@ -95,26 +94,28 @@ module Jars
     attr_writer :require
 
     def quiet?
-      ( @silent ||= false ) || to_boolean( QUIET )
+      (@silent ||= false) || to_boolean(QUIET)
     end
 
     def jarfile
-      ENV[ 'JARFILE' ] || ENV_JAVA[ 'jarfile' ] || ENV[ 'JBUNDLER_JARFILE' ] || ENV_JAVA[ 'jbundler.jarfile' ] || 'Jarfile'
+      ENV['JARFILE'] || ENV_JAVA['jarfile'] || ENV['JBUNDLER_JARFILE'] || ENV_JAVA['jbundler.jarfile'] || 'Jarfile'
     end
 
     # @deprecated
-    def no_require?; ! require? end
+    def no_require?
+      !require?
+    end
 
     def verbose?
-      to_boolean( VERBOSE )
+      to_boolean(VERBOSE)
     end
 
     def debug?
-      to_boolean( DEBUG )
+      to_boolean(DEBUG)
     end
 
     def vendor?
-      to_boolean( VENDOR )
+      to_boolean(VENDOR)
     end
 
     def no_more_warnings
@@ -126,28 +127,26 @@ module Jars
     end
 
     def skip_lock?
-      to_prop( SKIP_LOCK ) || false
+      to_prop(SKIP_LOCK) || false
     end
 
     def lock
-      to_prop( LOCK ) || 'Jars.lock'
+      to_prop(LOCK) || 'Jars.lock'
     end
 
     def jars_lock_from_class_loader
-      if to_prop( LOCK ).nil? && defined?(JRUBY_VERSION)
-        JRuby.runtime.jruby_class_loader.get_resources( 'Jars.lock' ).collect do |url|
-          url.to_s
-        end
+      if to_prop(LOCK).nil? && defined?(JRUBY_VERSION)
+        JRuby.runtime.jruby_class_loader.get_resources('Jars.lock').collect(&:to_s)
       end
     end
 
-    def lock_path( basedir = nil )
-      deps = self.lock
-      return deps if File.exists?( deps )
+    def lock_path(basedir = nil)
+      deps = lock
+      return deps if File.exist?(deps)
       basedir ||= '.'
-      [ '.', 'jars', 'vendor/jars' ].each do |dir|
-        file = File.join( basedir, dir, self.lock )
-        return file if File.exists?( file )
+      ['.', 'jars', 'vendor/jars'].each do |dir|
+        file = File.join(basedir, dir, lock)
+        return file if File.exist?(file)
       end
       nil
     end
@@ -155,7 +154,7 @@ module Jars
     def reset
       instance_variables.each { |var| instance_variable_set(var, nil) }
       Jars::MavenSettings.reset
-      ( @@jars ||= {} ).clear
+      (@@jars ||= {}).clear
     end
 
     def maven_local_settings
@@ -179,29 +178,28 @@ module Jars
                              detect_local_repository(maven_local_settings) ||
                              detect_local_repository(maven_user_settings) ||
                              detect_local_repository(maven_global_settings) ||
-                             File.join( user_home, '.m2', 'repository' )
+                             File.join(user_home, '.m2', 'repository')
     end
 
     def home
       absolute(to_prop(HOME)) || local_maven_repo
     end
 
-    def require_jars_lock!( scope = :runtime )
+    def require_jars_lock!(scope = :runtime)
       urls = jars_lock_from_class_loader
-      if urls and urls.size > 0
+      if urls && !urls.empty?
         @@jars_lock = true
         # funny error during spec where it tries to load it again
         # and finds it as gem instead of the LOAD_PATH
         require 'jars/classpath' unless defined? Jars::Classpath
         done = []
-        while done != urls do
+        while done != urls
           urls.each do |url|
-            unless done.member?( url )
-              Jars.debug { "--- load jars from uri #{url}" }
-              classpath = Jars::Classpath.new( nil, "uri:#{url}" )
-              classpath.require( scope )
-              done << url
-            end
+            next if done.member?(url)
+            Jars.debug { "--- load jars from uri #{url}" }
+            classpath = Jars::Classpath.new(nil, "uri:#{url}")
+            classpath.require(scope)
+            done << url
           end
           urls = jars_lock_from_class_loader
         end
@@ -212,25 +210,25 @@ module Jars
         # funny error during spec where it tries to load it again
         # and finds it as gem instead of the LOAD_PATH
         require 'jars/classpath' unless defined? Jars::Classpath
-        classpath = Jars::Classpath.new( nil, jars_lock )
-        classpath.require( scope )
+        classpath = Jars::Classpath.new(nil, jars_lock)
+        classpath.require(scope)
         no_more_warnings
       end
-      Jars.debug {
+      Jars.debug do
         @@jars ||= {}
-        loaded = @@jars.collect{ |k,v| "#{k}:#{v}" }
+        loaded = @@jars.collect { |k, v| "#{k}:#{v}" }
         "--- loaded jars ---\n\t#{loaded.join("\n\t")}"
-      }
+      end
     end
 
-    def setup( options = nil )
+    def setup(options = nil)
       case options
       when Symbol
-        require_jars_lock!( options )
+        require_jars_lock!(options)
       when Hash
         @_jars_home = options[:jars_home]
         @_jars_lock = options[:jars_lock]
-        require_jars_lock!( options[:scope] || :runtime )
+        require_jars_lock!(options[:scope] || :runtime)
       else
         require_jars_lock!
       end
@@ -244,35 +242,35 @@ module Jars
       end
     end
 
-    def mark_as_required( group_id, artifact_id, *classifier_version )
-      require_jar_with_block( group_id, artifact_id, *classifier_version ) do
+    def mark_as_required(group_id, artifact_id, *classifier_version)
+      require_jar_with_block(group_id, artifact_id, *classifier_version) do
       end
     end
 
-    def require_jar( group_id, artifact_id, *classifier_version )
+    def require_jar(group_id, artifact_id, *classifier_version)
       require_jars_lock unless skip_lock?
-      require_jar_with_block( group_id, artifact_id, *classifier_version ) do |gid, aid, version, classifier|
-        do_require( gid, aid, version, classifier )
+      require_jar_with_block(group_id, artifact_id, *classifier_version) do |gid, aid, version, classifier|
+        do_require(gid, aid, version, classifier)
       end
     end
 
-    def warn(msg = nil, &block)
-      Kernel.warn(msg || block.call) unless quiet? and not verbose?
+    def warn(msg = nil)
+      Kernel.warn(msg || yield) unless quiet? && !verbose?
     end
 
-    def debug(msg = nil, &block)
-      Kernel.warn(msg || block.call) if verbose?
+    def debug(msg = nil)
+      Kernel.warn(msg || yield) if verbose?
     end
 
-    def absolute( file )
-      File.expand_path( file ) if file
+    def absolute(file)
+      File.expand_path(file) if file
     end
 
     def user_home
-      ENV[ 'HOME' ] || begin
+      ENV['HOME'] || begin
         user_home = Dir.home if Dir.respond_to?(:home)
         unless user_home
-          user_home = ENV_JAVA[ 'user.home' ] if Object.const_defined?(:ENV_JAVA)
+          user_home = ENV_JAVA['user.home'] if Object.const_defined?(:ENV_JAVA)
         end
         user_home
       end
@@ -280,22 +278,22 @@ module Jars
 
     private
 
-    def require_jar_with_block( group_id, artifact_id, *classifier_version )
-      version = classifier_version[ -1 ]
-      classifier = classifier_version[ -2 ]
+    def require_jar_with_block(group_id, artifact_id, *classifier_version)
+      version = classifier_version[-1]
+      classifier = classifier_version[-2]
 
       @@jars ||= {}
       coordinate = "#{group_id}:#{artifact_id}"
       coordinate << ":#{classifier}" if classifier
       if @@jars.key? coordinate
-        if @@jars[ coordinate ] == version
+        if @@jars[coordinate] == version
           false
         else
-          @@jars[ coordinate ] # version of already registered jar
+          @@jars[coordinate] # version of already registered jar
         end
       else
         yield group_id, artifact_id, version, classifier
-        @@jars[ coordinate ] = version
+        @@jars[coordinate] = version
         return true
       end
     end
@@ -303,60 +301,56 @@ module Jars
     def detect_local_repository(settings)
       return nil unless settings
 
-      doc = File.read( settings )
-      # TODO filter out xml comments
-      local_repo = doc.sub( /<\/localRepository>.*/m, '' ).sub( /.*<localRepository>/m, '' )
+      doc = File.read(settings)
+      # TODO: filter out xml comments
+      local_repo = doc.sub(/<\/localRepository>.*/m, '').sub(/.*<localRepository>/m, '')
       # replace maven like system properties embedded into the string
-      local_repo.gsub!( /\$\{[a-zA-Z.]+\}/ ) do |a|
-        ENV_JAVA[ a[2..-2] ] || a
-      end
-      if local_repo.empty? or not File.exists?( local_repo )
-        local_repo = nil
+      local_repo.gsub!(/\$\{[a-zA-Z.]+\}/) do |a|
+        ENV_JAVA[a[2..-2]] || a
       end
+      local_repo = nil if local_repo.empty? || !File.exist?(local_repo)
       local_repo
     rescue
       Jars.warn { "error reading or parsing #{settings}" }
       nil
     end
 
-    def to_jar( group_id, artifact_id, version, classifier = nil )
-      file = String.new("#{group_id.gsub( '.', '/' )}/#{artifact_id}/#{version}/#{artifact_id}-#{version}")
+    def to_jar(group_id, artifact_id, version, classifier = nil)
+      file = String.new("#{group_id.tr('.', '/')}/#{artifact_id}/#{version}/#{artifact_id}-#{version}")
       file << "-#{classifier}" if classifier
       file << '.jar'
       file
     end
 
-    def do_require( *args )
-      jar = to_jar( *args )
-      local = File.join( Dir.pwd, 'jars', jar )
-      vendor = File.join( Dir.pwd, 'vendor', 'jars', jar )
-      file = File.join( home, jar )
+    def do_require(*args)
+      jar = to_jar(*args)
+      local = File.join(Dir.pwd, 'jars', jar)
+      vendor = File.join(Dir.pwd, 'vendor', 'jars', jar)
+      file = File.join(home, jar)
       # use jar from local repository if exists
-      if File.exists?( file )
+      if File.exist?(file)
         require file
       # use jar from PWD/jars if exists
-      elsif File.exists?( local )
+      elsif File.exist?(local)
         require local
       # use jar from PWD/vendor/jars if exists
-      elsif File.exists?( vendor )
+      elsif File.exist?(vendor)
         require vendor
       else
         # otherwise try to find it on the load path
         require jar
       end
     rescue LoadError => e
-      raise "\n\n\tyou might need to reinstall the gem which depends on the missing jar or in case there is Jars.lock then resolve the jars with `lock_jars` command\n\n" + e.message + " (LoadError)"
+      raise "\n\n\tyou might need to reinstall the gem which depends on the missing jar or in case there is Jars.lock then resolve the jars with `lock_jars` command\n\n" + e.message + ' (LoadError)'
     end
-
   end # class << self
-
 end
 
-def require_jar( *args )
+def require_jar(*args)
   return nil unless Jars.require?
-  result = Jars.require_jar( *args )
+  result = Jars.require_jar(*args)
   if result.is_a? String
-    Jars.warn { "--- jar coordinate #{args[0..-2].join( ':' )} already loaded with version #{result} - omit version #{args[-1]}" }
+    Jars.warn { "--- jar coordinate #{args[0..-2].join(':')} already loaded with version #{result} - omit version #{args[-1]}" }
     Jars.debug { "    try to load from #{caller.join("\n\t")}" }
     return false
   end