jan 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ebad61806458a86c36f94a97d38b74ccb93f45c4
-  data.tar.gz: 7724c79d26b5bdb8a4154d0a809f29f21a858cc7
+  metadata.gz: 783fb22083cdee79514404d9dfce2db04e3f98f4
+  data.tar.gz: 53bbdb8e75c9d5bfb0503908bda34c4260ba0af0
 SHA512:
-  metadata.gz: 053b3a6c5784718be8f10a6d79f9e14af43fa6974ce34547f86defb8f4c735a185f40a5e20e89c22b8ff340970e277ee5b86752d7667299cf6d623c52c78ceda
-  data.tar.gz: 28adbb792d78c7152dcf1daf6bb6f7bd8afc4fa45bd628808616881fab69cb298675d0f268a4f24d7286b3c46632f2a2d9ee23876e2cdf7b84981a54aca7d34a
+  metadata.gz: ec3814c7ebb6239c3fd3fe08988150719e71b55e5335627030d175cfb20b8f32d7a4ed59f42e2513a1271e991c33ce4fa2038663bff15c6f94bd883991b00a47
+  data.tar.gz: 2ce916f461b1c40cdfaf22461da46a57abd53a7ffa5bf2f18a9d6a417a79902ea1e3c402f77bad79c93d5a63d3148727021313a15e2f85908046573316b294cf

data/README.md

@@ -37,6 +37,15 @@ jan.valid? # => true
 Jan::Validator.validate("4901277241126") # => true
 ```
 
+### Calculate check digit
+
+```ruby
+# Correct code: "4901277241126"
+
+Jan::CheckDigitCalculator.calculate("490127724112") # => 6
+```
+
+
 ### Get elements
 
 ```ruby

data/lib/jan/validator.rb

@@ -6,8 +6,14 @@ class Jan
     module_function
 
     def validate(code)
-      code = code.to_s
-      return false unless [8,13].include?(code.size)
+      validate_size(code.to_s) && validate_check_digit(code.to_s)
+    end
+
+    def validate_size(code)
+      [8,13].include?(code.to_s.size)
+    end
+
+    def validate_check_digit(code)
       Parser.check_digit(code) == CheckDigitCalculator.calculate(Parser.body(code))
     end
   end

data/lib/jan/version.rb

@@ -1,3 +1,3 @@
 class Jan
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/jan/validator_spec.rb

@@ -20,4 +20,57 @@ describe Jan::Validator do
       end
     end
   end
+
+  describe ".validate_size" do
+    context "valid codes" do
+      valid_size_codes = [8, 13].map{|n| "x" * n }
+
+      valid_size_codes.each do |code|
+        it "#{code} should be valid" do
+          actual = Jan::Validator.validate_size(code)
+          expect(actual).to be true
+        end
+      end
+    end
+
+    context "invalid codes" do
+      invalid_size_codes = [1,2,3,4,5,6,7,9,10,11,12,14,15].map{|n| "x" * n }
+
+      invalid_size_codes.each do |code|
+        it "#{code} should be invalid" do
+          actual = Jan::Validator.validate_size(code)
+          expect(actual).to be false
+        end
+      end
+    end
+  end
+
+  describe ".validate_check_digit" do
+    context "valid codes" do
+      valid_check_digit_codes = (3..15).to_a.map{|n| Jan::Random.code(n) }
+
+      valid_check_digit_codes.each do |code|
+        it "#{code} should be valid" do
+          actual = Jan::Validator.validate_check_digit(code)
+          expect(actual).to be true
+        end
+      end
+    end
+
+    context "invalid codes" do
+      invalid_check_digit_codes = []
+      (3..15).each do |n|
+        code = Jan::Random.code(n)
+        code[-1] = ((Jan::Parser.check_digit(code) + 1 ) % 10).to_s
+        invalid_check_digit_codes << code
+      end
+
+      invalid_check_digit_codes.each do |code|
+        it "#{code} should be invalid" do
+          actual = Jan::Validator.validate_check_digit(code)
+          expect(actual).to be false
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jan
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - OSA Shunsuke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-12 00:00:00.000000000 Z
+date: 2014-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler