jackbox 0.9.6.6 → 0.9.6.8

data/spec/lib/jackbox/patterns_spec.rb

@@ -197,76 +197,79 @@ describe 'some use cases', :traits do
 
 		a 'different way of doing it using: JIT inheritance' do
 		             
-			# some data
+	    # some data
 
-			def database_content
-				%{car truck airplane boat}
-			end 
+	    def database_content                # could be any model
+	    	%{car truck airplane boat}
+	    end 
 
-			# rendering helper controls
+	    # rendering helper controls
 
-			class MyWidgetClass
-				def initialize(content)
-					@content = content
-				end       
+	    class MyWidget
+	    	def initialize(content)
+	    		@content = content
+	    	end       
 
-				def render
-					"<div id='MyWidget'>#{@content}</div>"
-				end
-			end
+	    	def render
+	    		"<div id='MyWidget'>#{@content}</div>"
+	    	end
+	    end
 
-			
-			MainDecorator = trait :WidgetDecorator do
-				
-				attr_accessor :font, :width, :height       
 
-				def dim(width, heigth)
-					@width, @heigth = width, heigth
-				end
-				
-				def render
-					%{
-						<style>
-						#MyWidget{
-							font: 14px, #{@font};
-							width:#{@width};
-							height: #{@heigth}
-						}
-						</style>
-						#{super()}
-					}
-				end
-			end
+	    MainFace = trait :WidgetFace do     # our trait
 
-			# somewhere in a view
+	    	attr_accessor :font, :width, :height       
 
-			browser = 'Safari'
-			@content = database_content
+	    	def dim(width, heigth)
+	    		@width, @heigth = width, heigth
+	    	end
 
-			my_widget = case browser
-			when match(/Safari|Firefox|IE/)
-				# debugger
-				MyWidgetClass.new(@content).enrich(WidgetDecorator() do
-					
-					def render															# override invoking JIT inheritance
-						dim '600px', '200px'									# normal inherited method call
-						@font = 'helvetica'
+	    	def render
+	    		%{
+	    			<style>
+	    			#MyWidget{
+	    				font: 14px, #{@font};
+	    				width:#{@width};
+	    				height: #{@heigth}
+	    			}
+	    			</style>
+	    			#{super()}
+	    		}
+	    	end
+	    end
 
-						super()
-					end
-				end)
+	    # somewhere in a view
 
-			else
-				MyWidgetClass.new(@content).enrich(WidgetDecorator() do
-					
-					def render															# override invoking JIT inheritance
-						dim '200px', '600px'                  # normal inherited method call
-						@font ='arial'
+	    browser = 'Safari'                  # the user selected media
+	    @content = database_content
 
-						super()
-					end
-				end)
-			end
+
+	    my_widget = case browser
+	    when match(/Safari|Firefox|IE/)
+
+	    	MyWidget.new(@content).enrich(WidgetFace() do
+
+	    		def render															# override invoking JIT inheritance
+	    			dim '600px', '200px'									# normal inherited method call
+	    			@font = 'helvetica'
+
+	    			super()
+	    		end
+	    	end)
+
+	    else
+
+	    	MyWidget.new(@content).enrich(WidgetFace() do
+
+	    		def render															# override invoking JIT inheritance
+	    			dim '200px', '600px'                  # normal inherited method call
+	    			@font ='arial'
+
+	    			super()
+	    		end
+	    	end)
+
+	    end
 
 			# expect(WidgetDecorator().ancestors).to eq([WidgetDecorator(), MainDecorator])
 
@@ -291,7 +294,7 @@ describe 'some use cases', :traits do
 			my_widget = case browser
 			when match(/Safari|Firefox|IE/)
 				# debugger
-				MyWidgetClass.new(@content).enrich(WidgetDecorator() do
+				MyWidget.new(@content).enrich(WidgetFace() do
 					
 					def render
 						dim '600px', '200px'
@@ -301,7 +304,7 @@ describe 'some use cases', :traits do
 					end
 				end)
 			else
-				MyWidgetClass.new(@content).enrich(WidgetDecorator() do
+				MyWidget.new(@content).enrich(WidgetFace() do
 					def render
 						dim '200px', '600px'
 						@font ='arial'
@@ -325,7 +328,7 @@ describe 'some use cases', :traits do
 					}.split.join
 			)
 			
-			WidgetDecorator(:implode)
+			WidgetFace(:implode)
 			 
 		end
 		
@@ -545,96 +548,130 @@ describe 'some use cases', :traits do
 
 		describe "jiti as decorators with internal base" do
 			before do
-				JD1 = trait :jd do
-					def m1
-						1
+				suppress_warnings do
+					JD1 = trait :jd do
+						def m1
+							1
+						end
 					end
-				end
-				JD2 = jd do
-					def m1
-						super + 2
+					JD2 = jd do
+						def m1
+							super + 2
+						end
 					end
 				end
 			end
+			
 			it 'works like normal decorators' do
 
-				o = Object.new
-				o.enrich JD2, JD1
-				o.m1.should == 3
-				
-				p = Object.new
-				p.enrich JD1, JD2
-				p.m1.should == 1
+				suppress_warnings do
+					o = Object.new
+					o.enrich JD2, JD1
+					o.m1.should == 3
+				end
 				
 			end
 			
-			it 'raise errors on decorator collusions' do
-				
+			it 'issues warnings on decorator collusions' do
+
+				expect { 							# same as above without #suppress_warnings
+					
+					o = Object.new
+					o.enrich JD2, JD1
+					o.m1.should == 3
+
+				}.to output(a_string_starting_with('warning')).to_stderr
 				expect{
 					
 					r = Object.new
 					r.enrich JD1, JD1
 					r.m1.should == 1
 				
-				}.to raise_error(ArgumentError)
+				}.to output(a_string_starting_with('warning')).to_stderr
+				expect{
+					
+					p = Object.new
+					p.enrich JD1, JD2
+					p.m1.should == 1
+
+				}.to output(a_string_starting_with('warning')).to_stderr
 				expect{
 					
 					q = Object.new
 					q.enrich JD2, JD2
 					q.m1.should == 5
 				
-				}.to raise_error(ArgumentError)
+				}.to output(a_string_starting_with('warning')).to_stderr
 				
 			end
 		end
 		
-		describe "jiti as decorators on external base" do
+		describe "jiti as decorators with external base" do
 			before do
-				JD1 = trait :jd do
-					def m1
-						super + 1
+				suppress_warnings do
+					
+					class JDClass
+						def m1
+							1
+						end
 					end
-				end
-				JD2 = jd do
-					def m1
-						super + 2
+					JD1 = trait :jd do
+						def m1
+							super + 1
+						end
 					end
-				end
-				class JDClass
-					def m1
-						1
+					JD2 = jd do
+						def m1
+							super + 2
+						end
 					end
+					
 				end
 			end
 			
-			it 'can work like normal decorators' do
+			it 'works like normal decorators' do
 
-				o = JDClass.new
-				o.enrich JD2, JD1
-				o.m1.should == 5
+				suppress_warnings do
+					o = JDClass.new
+					o.enrich(JD1).m1.should == 2
+					o.enrich(JD2)
+					o.m1.should == 5
+				end
+				
 				
-				p = JDClass.new
-				p.enrich JD1, JD2
-				p.m1.should == 5
-
 			end
 			
-			it 'raises errors on decorator collusions' do
+			it 'should issue warnings for colluding ancestors' do
 				
-				expect{
+				expect {
+					
+					o = JDClass.new
+					o.enrich(JD1).m1.should == 2
+					o.enrich(JD2)
+					o.m1.should == 5
+					
+				}.to output(a_string_starting_with('warning')).to_stderr
+				expect {
 					
 					r = JDClass.new
-					r.enrich JD1, JD1
-					r.m1.should == 3
+					r.enrich(JD1).m1.should == 2
+					r.enrich(JD1).m1.should == 3
 				
-				}.to raise_error(ArgumentError)
+				}.to output(a_string_starting_with('warning')).to_stderr
+				expect{
+					
+					p = JDClass.new
+					p.enrich JD1, JD2
+					p.m1.should == 5
+
+				}.to output(a_string_starting_with('warning')).to_stderr
 				expect{
 					
 					q = JDClass.new
 					q.enrich JD2, JD2
 					q.m1.should == 6
 
-				}.to raise_error(ArgumentError)
+				}.to output(a_string_starting_with('warning')).to_stderr
 				
 			end
 		end

data/spec/lib/jackbox/prefs_spec.rb

@@ -9,6 +9,17 @@ include Injectors
 
 describe 'what Prefs does' do
 
+	# def launch program
+	# 	case
+	# 	when OS.windows?
+	# 		return system "ruby.exe", program if File.exists?(program)
+	# 		system "ruby.exe", '-e', program
+	# 	else
+	# 		return system "/usr/bin/env ruby", program if File.exists?(program)
+	# 		system "/usr/bin/env ruby", '-e', program
+	# 	end
+	# end
+
 	it 'creates module level attribute methods' do
 		module Tester
 			extend Prefs
@@ -51,45 +62,45 @@ describe 'what Prefs does' do
 		Jester.value.should == 10 
 	end
 
-	it 'persists across processes' do
-		# we run a process and make settings
-		launch %{
-			require 'jackbox'
-
-			class Application
-				include Prefs
-
-				pref :data_path => "#{ENV['HOME']}/tmp/jackbox"
-
-				def foo
-				end
-			end
-			
-			#...
-			
-			Application.data_path = "#{ENV['HOME']}/tmp/foo"
-		}
-		Process.waitall
-		
-		# After the previous invocation
-		class Application
-			include Prefs
-			
-			pref :data_path => "#{ENV['HOME']}/tmp/jackbox"
-			
-			def foo
-			end
-		end
-		
-		# ...
-		
-		Application.data_path.should == "#{ENV['HOME']}/tmp/foo"
-
-		# ...
-
-		Application.reset
-		Application.data_path.should == "#{ENV['HOME']}/tmp/jackbox"
-	end
+	# it 'persists across processes' do
+	# 	# we run a process and make settings
+	# 	launch %{
+	# 		require 'jackbox'
+	# 
+	# 		class Application
+	# 			include Prefs
+	# 
+	# 			pref :data_path => "#{ENV['HOME']}/tmp/jackbox"
+	# 
+	# 			def foo
+	# 			end
+	# 		end
+	# 		
+	# 		#...
+	# 		
+	# 		Application.data_path = "#{ENV['HOME']}/tmp/foo"
+	# 	}
+	# 	Process.waitall
+	# 	
+	# 	# After the previous invocation
+	# 	class Application
+	# 		include Prefs
+	# 		
+	# 		pref :data_path => "#{ENV['HOME']}/tmp/jackbox"
+	# 		
+	# 		def foo
+	# 		end
+	# 	end
+	# 	
+	# 	# ...
+	# 	
+	# 	Application.data_path.should == "#{ENV['HOME']}/tmp/foo"
+	# 
+	# 	# ...
+	# 
+	# 	Application.reset
+	# 	Application.data_path.should == "#{ENV['HOME']}/tmp/jackbox"
+	# end
 
 	it 'should allow definition of prefs outside the module definition' do
 		lambda{

data/spec/lib/jackbox/vmc_spec.rb

@@ -14,24 +14,31 @@ include Injectors
 describe "VMC (Virtual Method Cache)" do
 	
 	before do
-		jack :J1
-		jack :K1
-		jack :L1
-		jack :M1
-		jack :N1
+		suppress_warnings do
+			jack :J1
+			jack :K1
+			jack :L1
+			jack :M1
+			jack :N1
+			A = Class.new
+			B = Class.new
+		end
 	end
-	
 	after do
-		J1(:implode)
-		K1(:implode)
-		L1(:implode)
-		M1(:implode)
-		N1(:implode)
+		suppress_warnings do
+			A = nil
+			B = nil
+			J1(:implode)
+			K1(:implode)
+			L1(:implode)
+			M1(:implode)
+			N1(:implode)
+		end
 	end
 	
 	it 'goes 3 deep' do
 		
-		class AA4
+		class A
 		  inject J1()
 		end
 		J1 do
@@ -49,15 +56,15 @@ describe "VMC (Virtual Method Cache)" do
 		  end
 		end
 		# debugger
-		AA4.new.n1m1
-		AA4.new.n2m1
-		AA4.new.n3m1
+		A.new.n1m1
+		A.new.n2m1
+		A.new.n3m1
 		
 	end
 	
 	it 'goes even deeper' do
 		
-		class AA5
+		class A
 		  inject J1()
 		end
 		J1 do
@@ -73,7 +80,7 @@ describe "VMC (Virtual Method Cache)" do
 			def daa
 			end
 		end
-		AA5.new.daa
+		A.new.daa
 		
 	end
 
@@ -306,8 +313,6 @@ describe "VMC (Virtual Method Cache)" do
 		 	trait :J2
 		 	trait :J3
 
-			class AA1
-			end
 			J1 do
 				include J2()
 			end
@@ -321,12 +326,12 @@ describe "VMC (Virtual Method Cache)" do
 					:mJ1
 				end
 			end
-			class AA1
+			class A
 				include J1()
 			end
 
-			AA1.new.mJ2.should == :mJ2
-			AA1.new.mJ1.should == :mJ1
+			A.new.mJ2.should == :mJ2
+			A.new.mJ1.should == :mJ1
 
 		}.not_to raise_error
 		
@@ -347,10 +352,10 @@ describe "VMC (Virtual Method Cache)" do
 			    end
 			  end
 			end
-			class AA2
+			class A
 			  include K1()
 			end
-			AA2.new.mj2.should == :mj2
+			A.new.mj2.should == :mj2
 			K2 do
 			  include K3() do
 			    def mj3						# virtual cache method with another indirect
@@ -358,7 +363,7 @@ describe "VMC (Virtual Method Cache)" do
 			    end
 			  end
 			end
-			AA2.new.mj3.should == :mj3
+			A.new.mj3.should == :mj3
 
 		}.not_to raise_error
 		
@@ -379,10 +384,10 @@ describe "VMC (Virtual Method Cache)" do
 					end
 				end
 			end
-			class AA3
+			class A
 				include M1()
 			end
-			AA3.new.mk2.should == :mk2
+			A.new.mk2.should == :mk2
 			M2 do
 				include M3()
 			end
@@ -391,7 +396,7 @@ describe "VMC (Virtual Method Cache)" do
 					:mk3
 				end
 			end
-			AA3.new.mk3.should == :mk3
+			A.new.mk3.should == :mk3
 
 		}.not_to raise_error