jack-eb 0.1.6 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: aeafb675a751c393409d6a719583390bd8cc711b
-  data.tar.gz: 25cdd6bc564734c88fb4c0d68c479e20dd369256
+  metadata.gz: 2dc1841b5ba329d4b7075647c4ad06cb6949392b
+  data.tar.gz: 2ddb7d30db167c363ea5ad52b5d584858f3d801c
 SHA512:
-  metadata.gz: 6aed79a0db2e4f5c3fb4695c935ce63e706f1ac7610016c87adb8cb493f0ba7e24a34180ea9cb8c163f9d43d1e8a7ffdf1264e103c982158b4f1e7223b3af87f
-  data.tar.gz: 2ad41ee9616bd454961dca5ee3519f75737940d4d2a391663bbb8eaafbc4b8f7ad714e8573092f3fc08fc92b7c60e10e40378f0513457acaa1f4c1fbce78554a
+  metadata.gz: 42198b5dfcb6daa56c1faee7fc67569f53607b4ece7eae7870182e58dd4f3d3d6db0be0396fafbd673fb5adc28468fe691a889ca76cc8d7a1fb0fc2277e6b456
+  data.tar.gz: 47e426272c7dc8395bee6a8ffdfc8866e4aede18f20bf9f1ada5dc973d706e8b8d874971f1ffc28bf107a57b9c9932a5c2c2aec7a290c862552575d7ac178f33

data/.rspec

@@ -1 +1,3 @@
 --color
+--require spec_helper
+--format documentation

data/README.md

@@ -1,12 +1,21 @@
 # Jack and the Elastic Beanstalk
 
+[![ReadmeCI](http://www.readmeci.com/images/readmeci-badge.svg)](http://www.readmeci.com/tongueroo/jack)
 [![Build Status](https://travis-ci.org/tongueroo/jack.svg?branch=master)](https://travis-ci.org/tongueroo/jack)
 [![Code Climate](https://codeclimate.com/github/tongueroo/jack/badges/gpa.svg)](https://codeclimate.com/github/tongueroo/jack)
 [![Test Coverage](https://codeclimate.com/github/tongueroo/jack/badges/coverage.svg)](https://codeclimate.com/github/tongueroo/jack)
 
-Jack is a wrapper tool around the eb cli tool that can be use to manage AWS Elastic Beanstalk environments.  It allows you to create environments based on a saved template configuration file, located in the jack/cfg folder of your project.  It also provides a helpful config command to manage the template configuration. 
+Jack is a wrapper tool around the [aws eb cli3](http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/eb-cli3.html) tool use to manage AWS Elastic Beanstalk, EB, environments.  It allows you to create environments based on a saved template configuration file, located in the jack/cfg folder of your project.  The jack/cfg files are the same files that are saved by the `eb config save` command, they are simply moved into the jack directory.
 
-For things that this tool does not do, it is recommended that you use use the underlying eb tool directly.  This tool has been tested with the 3.1.2 version of the eb command, so have at least that version installed.
+Jack also provides a `jack config upload` command to update the EB environment.   Before uploading the configuration to EB jack first downloads the current configuration and then does a diff on the changes that are about to be applied.  This gives a very helpful preview of exactly what you are intending to change.  This is also very helpful when changes are made through the EB GUI and are out of sync with what is stored in the `jack/cfg` files.
+
+For things that this tool does not do, it is recommended that you use use the underlying aws `eb` tool directly.  This tool has been tested with `EB CLI 3.7.6 (Python 2.7.1)`.
+
+## Use Cases
+
+* Downloading EB config to codified the EB infrastructure that has been built.
+* Allowing safe uploading of new configs.
+* Moving EB enviroments from one EB application to another EB application.  EB provides a way to clone environments within an application but not to another application.
 
 ## Installation
 
@@ -18,32 +27,79 @@ Note that the gem is called jack-eb but the command that is installed is called
 
 ### Setup
 
-This gem relies on the eb cli tool.  To install follow the instructions on [AWS EB Documentation](http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/eb-cli3-getting-set-up.html).  Here's the gist of it:
+If the version of `eb` that you are using is not working with jack, here is a way to install the specific version jack has been tested with.
 
 <pre>
-$ sudo pip install awsebcli
+cd ~/ && wget https://pypi.python.org/packages/source/a/awsebcli/awsebcli-3.7.6.tar.gz
+tar -zxvf awsebcli-3.7.6.tar.gz
+cd awsebcli-3.7.6
+sudo python setup.py install
 </pre>
 
-You need at least version 3.1.2 of the eb tool.  To check the version `eb --version`.  If you need to upgrade:
+More detail instructions are on [AWS EB Documentation](http://docs.aws.amazon.com/elasticbeanstalk/latest/dg/eb-cli3-getting-set-up.html).
+
+I typically install the `eb` cli tool with homebrew.
 
 <pre>
-$ sudo pip install --upgrade awsebcli
+brew install awsebcli
 </pre>
 
-You'll also need to set up your environment with your aws access keys since the tool also uses the aws-sdk.  Add the following to your ~/.profile, replacing xxx with your actually credentials.  Don't forgot to source the ~/.profile or open up a new terminal.
+You will also need to set up your environment with your aws access keys since the tool also uses the aws-sdk.  Add the following to your ~/.profile, replacing xxx with your actually credentials.  Do not forgot to source the ~/.profile or open up a new terminal.
 
 <pre>
 export AWS_ACCESS_KEY_ID=xxx
 export AWS_SECRET_ACCESS_KEY=xxx
 </pre>
 
+The jack tool does not yet support the `.aws/credentials` method of setting the aws keys.
+
 You're ready to go.
 
 ## Usage
 
+### Conventions
+
+Before using the tool, it is good to know that jack follows a convention for the environment and application name.  This is done in order to keep the jack commands simple and short.  The convention is:
+
+<pre>
+environment_name: [env]-[app]-[role]
+application_name: [app]
+</pre>
+
+A concrete example is helpful:
+
+<pre>
+environment_name: prod-api-web
+application_name: api
+</pre>
+
+The example above means the EB application name will be `api` and the environment name will be `prod-api-web`.  The second word of the environment name is by convention the application name.
+
+This convention can be overriden easily via by creating a `~/.jack/settings.yml` or `jack/settings` within the project and defining your own regular expression with the `conventions.app_name_pattern` key.  The regexp is a ruby regexp and must have 1 capture group.  Here is an example:
+
+```yaml
+create:
+  keyname: default
+  platform: "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0"
+conventions:
+  app_name_pattern: (\w+)-\w+-\w+
+```
+
+In the example above, the capture group is the first word and this will result in:
+
+<pre>
+environment_name: api-web-prod
+application_name: api
+</pre>
+
+
+The default settings are located at [lib/jack/default/settings.yml](https://github.com/tongueroo/jack/blob/master/lib/jack/default/settings.yml).
+
+You can also override the application name convention from the cli with the `--app` flag.  Examples are provided below.
+
 ### Overview
 
-In your project folder create a folder call jack/cfg.  It might be useful for your company to create a baseline config that you can use.  If you do not already have a baseline template, you can download the template from an existing environment like so:
+You can download a starting baseline jack cfg and use it as template from one of your existing EB environments.
 
 <pre>
 $ jack config download [ENVIRONMENT_NAME]
@@ -63,17 +119,17 @@ Config downloaded to jack/cfg/stag-rails-app.cfg.yml
 $ 
 </pre>
 
-Results in a saved jack/cfg/stag-rails-app-s1.cfg.yml template configuration file.  This is overridable. 
+Results in a saved jack/cfg/stag-rails-app-s1.cfg.yml template configuration file.  This saved path is overridable with the `-c` flag. 
 
 <pre>
 $ jack config download -c myconfig stag-rails-app-s1
 </pre>
 
-Results in a saved jack/cfg/myconfig.cfg.yml template configuration file. 
+Results in a saved `jack/cfg/myconfig.cfg.yml`. 
 
 #### Configuration Templates
 
-Configuration templates hold all the options and settings that we can set for an EB environment.  Elastic Beanstalk surfaces a portion of all the settings actually available on the underlying AWS Resources that we are allowed to configured.  These includes the some of the ELB behavior, VPC, LaunchConfiguration, Autoscaling settings, hard drive size, environment variables, etc.   
+Configuration templates hold all the options and settings that we can set for an EB environment.  Elastic Beanstalk surfaces a portion of settings available from the underlying AWS Resources.  These settings include ELB behavior, VPC, LaunchConfiguration, Autoscaling settings, hard drive size, environment variables, etc.
 
 * [Here](https://gist.github.com/tongueroo/acc421c5ec998f238b4b) is an example of all the settings available.
 * [Here](https://gist.github.com/tongueroo/f22bbae7864ecec41ff3) is an example of what you would tyically see when you download the initial saved configuration.
@@ -83,12 +139,14 @@ Configuration templates hold all the options and settings that we can set for an
 The purpose of the jack/cfg configs is allow us to be able to create environments with a codified configuration file that can be versioned controlled.
 
 <pre>
-$ jack create stag-rails-app-s1 # uses the jack/cfg/stag-rails-app-s1.cfg.yml template
-$ jack create stag-rails-app-s2 # uses the jack/cfg/stag-rails-app-s2.cfg.yml template
-$ jack create -c myconfig stag-rails-app-s3 # creates environment using a config not based on environment naming convention
+$ jack create stag-rails-app-s1 # uses the jack/cfg/stag-rails-app-s1.cfg.yml config
+$ jack create stag-rails-app-s2 # uses the jack/cfg/stag-rails-app-s2.cfg.yml config
+$ jack create -c myconfig stag-rails-app-s3 # creates environment using jack/cfg/myconfig.cfg.yml
 </pre>
 
-If the project is brand new and has never had `eb init` ran on it before.  For example, a project that has just been git cloned.  Then calling any of the jack commands will automatically call `eb init` in the project.  `eb init` requires the platform flag in order to avoid prompting.  By default, the latest Docker solution stack is used for the platform option.  But you can override that by creating an ~/.jack/create.yml or jack/create.yml within the project folder.  Here's an [example](https://gist.github.com/tongueroo/086e3c11c4d00d5c39b6). The options from each file is merged using the following precedence: project folder, user home, default that is packaged with this gem.  Most of the settings that `jack create` should used should be in the template configuration file though.
+If the project is brand new and has never had `eb init` ran on it before.  For example, a project that has just been git cloned.  Then calling any of the jack commands will automatically call `eb init` in the project.  `eb init` requires the platform flag in order to avoid prompting.  The default platform is "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0".  But you can override that by creating an `~/.jack/settings.yml` or `jack/settings.yml` within the project folder and setting the `create.platform` key.
+
+Here's an [example](https://gist.github.com/tongueroo/086e3c11c4d00d5c39b6). The options from each file is merged and combined together in following order: project folder, user home, [default](lib/jack/default/settings.yml) that is packaged with this gem.
 
 ### Downloading and Uploading Template Configurations
 
@@ -98,6 +156,8 @@ To download a template configuration.
 
 ```
 $ jack config download stag-rails-app-s1
+
+$ jack config download stag-rails-app-s1 --app customappname
 ```
 
 This will save the config to jack/cfg/stag-rails-app-s1.cfg.yml.
@@ -108,21 +168,23 @@ To upload a template configuration.
 
 ```
 $ jack config upload stag-rails-app-s1
+
+$ jack config upload stag-rails-app-s1 --app customappname
 ```
 
-This will save the config to jack/cfg/stag-rails-app-s1.cfg.yml.  Here's an example of the [output](http://d.pr/i/14Sfh).
+This will save the config to `jack/cfg/stag-rails-app-s1.cfg.yml`.  
 
-Notice that the `eb config upload` command also prompts you with the diff before uploading and ask for confirmation.  You can bypass the prompt with the force option.
+You will notice that the `eb config upload` command prompts you with the diff and asks for confirmation before uploading.  You can bypass the prompt with the force option.
 
 #### Diff - Comparing your local config to the live environment config
 
-You can use the diff command directly to compare your local config to what configs the environment is actually using is useful.  To see the diff.  
+You can use the diff command directly to compare your local config to what configs the environment is actually using is useful.  To see the diff.
 
 ```
 $ jack config diff stag-rails-app-s1
 ```
 
-A note about the configs.  They are formatted so that the keys are sorted.  This has been done so the diffs are actually useful.  It is also recommended you install colordiff so you can see the diff output colorized.  You can also specify your own diff viewer via the JACK_DIFF environment variable.  Example of [colorized diff](http://d.pr/i/9wrS).
+A note about the configs.  They are formatted so that the keys are sorted.  This has been done so the diffs are actually useful.  It is also recommended you install colordiff so you can see the diff output colorized.  You can also specify your own diff viewer via the JACK_DIFF environment variable.
 
 ### More Help
 
@@ -133,10 +195,5 @@ $ jack help
 $ jack help create
 $ jack config help download
 $ jack config help upload
-$ jack config help upload
 $ jack config help sort
 </pre>
-
-### TODO
-
-* encrypted the jack/cfg files similar to how [shopify/ejson](https://github.com/Shopify/ejson) works, except with yaml - pull requests are welcome

data/jack.gemspec

@@ -24,7 +24,8 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
+  spec.add_development_dependency "pry"
   spec.add_development_dependency "guard"
   spec.add_development_dependency "guard-bundler"
   spec.add_development_dependency "guard-rspec"
-end
+end

data/lib/jack.rb

@@ -7,10 +7,10 @@ require File.expand_path("../jack/ext/hash", __FILE__)
 module Jack
   autoload :CLI, 'jack/cli'
   autoload :Create, 'jack/create'
-  autoload :CreateYaml, 'jack/create_yaml'
+  autoload :Settings, 'jack/settings'
   autoload :EbConfig, 'jack/eb_config'
   autoload :Config, 'jack/config'
   autoload :UI, 'jack/ui'
   autoload :Util, 'jack/util'
   autoload :VersionChecker, 'jack/version_checker'
-end
+end

data/lib/jack/config/diff.rb

@@ -28,7 +28,7 @@ module Jack
 
       def cleanup_files
         return false if @options[:dirty]
-        @download.clean(silent=true)
+        @download.clean(mute=true)
       end
 
       def diff_command
@@ -41,4 +41,4 @@ module Jack
       end
     end
   end
-end
+end

data/lib/jack/config/download.rb

@@ -21,7 +21,7 @@ module Jack
       end
 
       def download
-        add_gitignore
+        # add_gitignore
         get_current_cfg
         copy_to_local_cfg
         clean
@@ -63,9 +63,9 @@ module Jack
       end
 
       # remove both the local download file and remote eb config
-      def clean(silent=false)
+      def clean(mute=false)
         return if @options[:dirty]
-        UI.say "Cleaning up eb remote config and local files" unless silent
+        UI.say "Cleaning up eb remote config and local files" unless mute
         eb.delete_configuration_template(
           application_name: @updater.app_name,
           template_name: current_name
@@ -75,4 +75,4 @@ module Jack
 
     end
   end
-end
+end

data/lib/jack/config/upload.rb

@@ -47,7 +47,7 @@ overwrite your #{@local_config_path} instead, you can use this command:
 $ jack config download #{@env_name}
 $ jack config help download # for more info
 EOL
-        print "yes/no? [no] " unless @options[:silent] || @options[:force]
+        print "yes/no? [no] " unless @options[:mute] || @options[:force]
         answer = get_answer
         answer =~ /^y/
       end
@@ -90,4 +90,4 @@ EOL
 
     end
   end
-end
+end

data/lib/jack/create.rb

@@ -36,12 +36,12 @@ module Jack
 
     def build_command
       @cfg = upload_cfg
-      flags = CreateYaml.new.flags
+      flags = settings.create_flags
       "eb create --sample --nohang #{flags} #{@cfg}#{cname}#{@env_name}"
     end
 
     def upload_cfg
-      @upload = Config::Upload.new(@options.merge(skip_sync: true))
+      @upload = Config::Upload.new(@options)
       if @upload.local_cfg_exist?
         @upload.upload 
         cfg = "--cfg #{@upload.upload_name} "
@@ -53,4 +53,4 @@ module Jack
     end
 
   end
-end
+end

data/lib/jack/default/settings.yml

@@ -0,0 +1,5 @@
+create:
+  keyname: default
+  platform: "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0"
+conventions:
+  app_name_pattern: \w+-(\w+)-\w+

data/lib/jack/eb_config/base.rb

@@ -27,12 +27,12 @@ module Jack
 
       def write_eb_config_yml
         data = YAML.load_file(eb_config_path)
-        data['global']['application_name'] = app_name
-        data['global']['default_platform'] = platform
+        data['global']['application_name'] = app_name # from subclass
+        data['global']['default_platform'] = platform # from subclass
         dump = YAML.dump(data).gsub("!ruby/object:Hash", '')
         dump = dump.split("\n")[1..-1].join("\n") # strip first line
         File.write(eb_config_path, dump)
       end
     end
   end
-end
+end

data/lib/jack/eb_config/create.rb

@@ -8,7 +8,10 @@ module Jack
       end
 
       def platform
-        CreateYaml.new.data['Platform'] || latest_docker_platform
+        # TODO: change so that the gem default settins has nil for platform
+        # but need to provide a deprecation warning first.
+        # Right now it will never hit the lastest_docker_platform logic
+        settings.create['platform'] || latest_docker_platform
       end
 
       def app_name
@@ -16,7 +19,10 @@ module Jack
       end
 
       def latest_docker_platform
-        "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0"
+        solution_stacks.grep(/Docker/).
+                        reject {|x| x =~ /Preconfigured/}.
+                        reject {|x| x =~ /Multi-container/}.
+                        sort.last
       end
    
       def solution_stacks

data/lib/jack/settings.rb

@@ -0,0 +1,43 @@
+module Jack
+  class Settings
+    def initialize(root=nil)
+      @root = root || '.'
+    end
+
+    def data
+      return @settings_yaml if @settings_yaml
+
+      project_file = "#{@root}/jack/settings.yml"
+      project = File.exist?(project_file) ? YAML.load_file(project_file) : {}
+
+      user_file = "#{home}/.jack/settings.yml"
+      user = File.exist?(user_file) ? YAML.load_file(user_file) : {}
+
+      default_file = File.expand_path("../default/settings.yml", __FILE__)
+      default = YAML.load_file(default_file)
+
+      @settings_yaml = default.merge(project.merge(user))
+    end
+
+    def home
+      # hack but fast
+      ENV['TEST'] ? "spec/fixtures/home" : ENV['HOME']
+    end
+
+    def create_flags
+      create.inject("") {|s,(k,v)| s << %{--#{k} "#{v}" } ; s }.strip
+    end
+
+    def create
+      data["create"]
+    end
+
+    def app_name_pattern
+      Regexp.new(conventions["app_name_pattern"])
+    end
+
+    def conventions
+      data["conventions"]
+    end
+  end
+end

data/lib/jack/util.rb

@@ -1,14 +1,23 @@
 module Jack
+  # Any class that includes this module should define @root as it is used in
+  # the settings method.
   module Util
     def do_cmd(command, options={})
-      UI.say "Running: #{command.colorize(:green)}" unless options[:silent]
+      UI.say "Running: #{command.colorize(:green)}"
       return command if options[:noop]
       out = `#{command}`
-      UI.say out unless options[:silent]
+      UI.say out
     end
 
     def app_name_convention(env_name)
-      env_name.split('-')[1] # convention
+      pattern = settings.app_name_pattern
+      env_name.match(pattern)[1]
+    end
+
+    def settings
+      # do not like the instance @root variable in this module but better
+      # than having to pass settings around
+      @settings ||= Settings.new(@root)
     end
 
     def eb
@@ -19,6 +28,5 @@ module Jack
     def ensure_folder_exist(folder)
       FileUtils.mkdir_p(folder) unless File.exist?(folder)
     end
-
   end
-end
+end

data/lib/jack/version.rb

@@ -1,3 +1,3 @@
 module Jack
-  VERSION = "0.1.6"
-end
+  VERSION = "0.2.0"
+end

data/spec/lib/config/download_spec.rb

@@ -15,11 +15,11 @@ describe Jack::Config do
       download.download
     end
 
-    it "should add jack/cfg/*.yml to gitignore" do
-      download.download
-      ignore = IO.read("#{@root}/.gitignore")
-      expect(ignore).to include("jack/cfg")
-    end
+    # it "should add jack/cfg/*.yml to gitignore" do
+    #   download.download
+    #   ignore = IO.read("#{@root}/.gitignore")
+    #   expect(ignore).to include("jack/cfg")
+    # end
 
   end
-end
+end

data/spec/lib/config/upload_spec.rb

@@ -5,7 +5,7 @@ describe Jack::Config::Upload do
     Jack::UI.mute = true
   end
 
-  let(:upload) { Jack::Config::Upload.new(test_options.merge(silent: true)) }
+  let(:upload) { Jack::Config::Upload.new(test_options.merge(mute: true)) }
 
   describe "upload" do
     it "upload code paths" do
@@ -23,4 +23,4 @@ describe Jack::Config::Upload do
       upload.run
     end
   end
-end
+end

data/spec/lib/create_spec.rb

@@ -2,6 +2,7 @@ require 'spec_helper'
 
 describe Jack::Create do
   before(:all) do
+    Jack::UI.mute = true
     @create = Jack::Create.new(test_options)
   end
 
@@ -16,4 +17,4 @@ describe Jack::Create do
       expect(command).to include('stag-rails-app-s9')
     end
   end
-end
+end

data/spec/lib/eb_config/create_spec.rb

@@ -3,31 +3,55 @@ require 'spec_helper'
 describe Jack::EbConfig do
   before(:all) do
     Jack::UI.mute = true
-    fake_eb_config
   end
 
   def solution_stacks
-    ["64bit Amazon Linux 2014.09 v1.2.0 running Docker 1.3.3", "64bit Amazon Linux 2014.03 v1.0.0 running Docker 1.0.0", "64bit Amazon Linux 2014.03 v1.0.1 running Docker 1.0.0", "64bit Amazon Linux 2014.03 v1.0.4 running Docker 0.9.0", "64bit Amazon Linux 2014.03 v1.0.5 running Docker 0.9.0", "64bit Debian jessie v1.2.0 running Go 1.3 (Preconfigured - Docker)", "64bit Debian jessie v1.2.0 running Go 1.4 (Preconfigured - Docker)"]
+    [
+      "64bit Amazon Linux 2015.03 v1.4.6 running Docker 1.6.2",
+      "64bit Amazon Linux 2015.09 v2.0.6 running Docker 1.7.1",
+      "64bit Amazon Linux 2016.03 v2.1.0 running Docker 1.9.1",
+      "64bit Debian jessie v2.1.0 running GlassFish 4.1 Java 8 (Preconfigured - Docker)",
+      "64bit Amazon Linux 2015.03 v1.4.6 running Multi-container Docker 1.6.2 (Generic)"
+    ]
   end
 
-  let(:create) { 
-    Jack::EbConfig::Create.new(test_options)
-  }
+  let(:create) do
+    Jack::EbConfig::Create.new(test_options(env_name))
+  end
+  let(:env_name) { "stag-rails-app-s9" }
 
-  describe "create" do
-    it "sync config" do
-      expect(create).to receive(:solution_stacks).and_return(solution_stacks)
-      create.sync
+  describe "Create#sync" do
+    context "default platform from default settings" do
+      it "have default platform from default settings" do
+        create.sync
+
+        data = YAML.load_file(create.eb_config_path)
+        global = data['global']
+        expect(global['application_name']).to eq "rails"
+        expect(global['default_platform']).to eq "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0"
+      end
+    end
+
+    context "different platform from project settings" do
+      let(:env_name) { "rails-app-stag9" }
+
+      before(:each) { fake_project.create_settings }
+      after(:each)  { fake_project.remove_settings }
+      it "have platform from project settings" do
+        create.sync
 
-      data = YAML.load_file(create.eb_config_path)
-      global = data['global']
-      expect(global['application_name']).to eq "rails"
-      expect(global['default_platform']).to eq "64bit Amazon Linux 2014.09 v1.2.0 running Docker 1.3.3"
+        data = YAML.load_file(create.eb_config_path)
+        global = data['global']
+        expect(global['application_name']).to eq "rails"
+        expect(global['default_platform']).to eq "Fake Platform From Project Settings"
+      end
     end
 
+    # To see newest solution stacks:
+    # aws elasticbeanstalk list-available-solution-stacks  | jq '.SolutionStacks' | grep Docker
     it "list solution stacks" do
       expect(create).to receive(:solution_stacks).and_return(solution_stacks)
-      expect(create.latest_docker_platform).to eq "64bit Amazon Linux 2014.09 v1.2.0 running Docker 1.3.3"
+      expect(create.latest_docker_platform).to eq "64bit Amazon Linux 2016.03 v2.1.0 running Docker 1.9.1"
     end
   end
-end
+end

data/spec/lib/settings_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe Jack::Settings do
+  before(:all) do
+    Jack::UI.mute = true
+  end
+  let(:settings) {
+    Jack::Settings.new(@root)
+  }
+
+  describe "create" do
+    context "custom project settings" do
+      before(:each) { fake_project.create_settings }
+      after(:each)  { fake_project.remove_settings }
+      it "flags uses custom project settings" do
+        project_flags = '--keyname "default" --platform "Fake Platform From Project Settings"'
+        expect(settings.create_flags).to eq(project_flags)
+      end
+    end
+
+    context "no custom project settings" do
+      it "flags uses defaults provided gem" do
+        project_flags = '--keyname "default" --platform "64bit Amazon Linux 2015.03 v1.4.0 running Docker 1.6.0"'
+        expect(settings.create_flags).to eq(project_flags)
+      end
+    end
+  end
+end

data/spec/lib/util_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+# just for the spec
+class Utilable
+  include Jack::Util
+  def initialize(root)
+    @root = root
+  end
+end
+
+describe Jack::Util do
+  before(:all) do
+    Jack::UI.mute = true
+  end
+  let(:util) do
+    Utilable.new(@root)
+  end
+
+  describe "util" do
+    it "app_name_convention default" do
+      app_name = util.app_name_convention("prod-rails-web-s1")
+      expect(app_name).to eq "rails"
+    end
+
+    context "custom app_name_convention" do
+      before(:each) { fake_project.create_settings }
+      after(:each)  { fake_project.remove_settings }
+      it "app_name_convention from project settings.yml" do
+        app_name = util.app_name_convention("rails-web-prod1")
+        expect(app_name).to eq "rails"
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -5,10 +5,13 @@ CodeClimate::TestReporter.start
 
 require "pp"
 require 'ostruct'
+require 'pry'
  
 root = File.expand_path('../../', __FILE__)
 require "#{root}/lib/jack"
 
+require "#{root}/spec/support/fake_project"
+
 module Helpers
   def execute(cmd)
     puts "Running: #{cmd}" if ENV['DEBUG']
@@ -17,38 +20,31 @@ module Helpers
     out
   end
 
-  def test_options
+  def test_options(env_name="stag-rails-app-s9")
     {
       noop: true,
       mute: true,
       force: true,
       root: @root,
-      env_name: "stag-rails-app-s9"
+      env_name: env_name
     }
   end
 
-  def fake_eb_config
-      data = <<-EOL
---- 
-global:
-  application_name: blah
-  default_platform: 64bit Amazon Linux 2014.09 v1.2.0 running Docker 1.3.3
-EOL
-      path = "#{@root}/.elasticbeanstalk/config.yml"
-      dir = File.dirname(path)
-      FileUtils.mkdir_p(dir) unless File.exist?(path)
-      File.write(path, data) unless File.exist?(path)
+  def fake_project
+    return @fake_project if @fake_project
+    @fake_project = FakeProject.new(@root)
+    @fake_project.create_eb_config
+    @fake_project
   end
-
 end
 
 RSpec.configure do |c|
   c.include Helpers
   c.before :all do
-    @root = "spec/fixtures/project"
-    fake_eb_config
+    @root = "spec/fixtures/project" # @root is being treated as a global with specs
+    fake_project
   end
   c.after :all do
     FileUtils.rm_f("#{@root}/.gitignore")
   end
-end
+end

data/spec/support/fake_project.rb

@@ -0,0 +1,51 @@
+class FakeProject
+  def initialize(root)
+    @root = root || '.'
+  end
+
+  def create_eb_config
+    data = <<-EOL
+--- 
+global:
+  application_name: blah
+  default_platform: 64bit Amazon Linux 2014.09 v1.2.0 running Docker 1.3.3
+EOL
+    path = "#{@root}/.elasticbeanstalk/config.yml"
+    create_file(path, data)
+  end
+
+  def create_settings
+    data = <<-EOL
+create:
+  keyname: default
+  platform: "Fake Platform From Project Settings"
+conventions:
+  app_name_pattern: (\\w+)-\\w+-\\w+
+EOL
+    # really tricky but when writting yaml file like this the \ needs to be escaped
+    # when writing the yaml file normal, they do not need to be escaped
+    create_file(settings_path, data)
+  end
+
+  def remove_settings
+    remove_file(settings_path)
+  end
+
+  def settings_path
+    "#{@root}/jack/settings.yml"
+  end
+
+  def create_file(path, contents)
+    ensure_parent_folder(path)
+    File.write(path, contents) unless File.exist?(path)
+  end
+
+  def remove_file(path)
+    FileUtils.rm_f(path)
+  end
+
+  def ensure_parent_folder(path)
+    dir = File.dirname(path)
+    FileUtils.mkdir_p(dir) unless File.exist?(path)
+  end
+end

metadata

@@ -1,125 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: jack-eb
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.0
 platform: ruby
 authors:
 - Tung Nguyen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-28 00:00:00.000000000 Z
+date: 2016-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: colorize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: aws-sdk
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Wrapper tool to manage AWS Elastic Beanstalk environments
@@ -130,9 +144,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE.txt
@@ -151,13 +165,13 @@ files:
 - lib/jack/config/upload.rb
 - lib/jack/config/yaml_formatter.rb
 - lib/jack/create.rb
-- lib/jack/create_yaml.rb
-- lib/jack/default/create.yml
+- lib/jack/default/settings.yml
 - lib/jack/eb_config.rb
 - lib/jack/eb_config/base.rb
 - lib/jack/eb_config/create.rb
 - lib/jack/eb_config/update.rb
 - lib/jack/ext/hash.rb
+- lib/jack/settings.rb
 - lib/jack/ui.rb
 - lib/jack/util.rb
 - lib/jack/version.rb
@@ -172,11 +186,13 @@ files:
 - spec/lib/config/yaml_formatter_spec.rb
 - spec/lib/config_spec.rb
 - spec/lib/create_spec.rb
-- spec/lib/create_yaml_spec.rb
 - spec/lib/eb_config/create_spec.rb
 - spec/lib/eb_config/update_spec.rb
+- spec/lib/settings_spec.rb
+- spec/lib/util_spec.rb
 - spec/lib/verison_checker_spec.rb
 - spec/spec_helper.rb
+- spec/support/fake_project.rb
 homepage: ''
 licenses:
 - MIT
@@ -187,17 +203,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Wrapper tool to manage AWS Elastic Beanstalk environments
@@ -212,9 +228,11 @@ test_files:
 - spec/lib/config/yaml_formatter_spec.rb
 - spec/lib/config_spec.rb
 - spec/lib/create_spec.rb
-- spec/lib/create_yaml_spec.rb
 - spec/lib/eb_config/create_spec.rb
 - spec/lib/eb_config/update_spec.rb
+- spec/lib/settings_spec.rb
+- spec/lib/util_spec.rb
 - spec/lib/verison_checker_spec.rb
 - spec/spec_helper.rb
+- spec/support/fake_project.rb
 has_rdoc: 

data/lib/jack/create_yaml.rb

@@ -1,22 +0,0 @@
-module Jack
-  class CreateYaml
-    def data
-      return @create_yaml if @create_yaml
-
-      project_file = "#{@root}/jack/create.yml"
-      project = File.exist?(project_file) ? YAML.load_file(project_file) : {}
-
-      user_file = "#{ENV['HOME']}/.jack/create.yml"
-      user = File.exist?(user_file) ? YAML.load_file(user_file) : {}
-
-      default_file = File.expand_path("../default/create.yml", __FILE__)
-      default = YAML.load_file(default_file)
-
-      @create_yaml = default.merge(project.merge(user))
-    end
-
-    def flags
-      data.inject("") {|s,(k,v)| s << %{--#{k} "#{v}" } ; s }.strip
-    end
-  end
-end

data/lib/jack/default/create.yml

@@ -1 +0,0 @@
-keyname: default

data/spec/lib/create_yaml_spec.rb

@@ -1,17 +0,0 @@
-require 'spec_helper'
-
-describe Jack::CreateYaml do
-  before(:all) do
-    Jack::UI.mute = true
-  end
-
-  let(:create_yaml) { 
-    Jack::CreateYaml.new
-  }
-
-  describe "create" do
-    it "flags" do
-      expect(create_yaml.flags).to eq('--keyname "default"')
-    end
-  end
-end