izi_json_ld 1.0.6 → 1.0.10

data/spec/entities/faq_page_entity_spec.rb

@@ -71,5 +71,18 @@ RSpec.describe FaqPageEntity do
       expect(answer['name']).to eq 'ShortQuestion'
       expect(answer.dig('acceptedAnswer', 'text')).to eq 'ShortAnswer'
     end
+
+    it 'should not render useless @context' do
+      parsed = JSON.parse(item.to_json)
+
+      expect(parsed['@context']).to be_present
+      expect(parsed['@context']).to eq 'https://schema.org'
+
+      expect(parsed.dig('mainEntity', 0)).to be_present
+      expect(parsed.dig('mainEntity', 0)).not_to have_key '@context'
+
+      expect(parsed.dig('mainEntity', 0, 'acceptedAnswer')).to be_present
+      expect(parsed.dig('mainEntity', 0, 'acceptedAnswer')).not_to have_key '@context'
+    end
   end
 end

data/spec/entities/person_entity_spec.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+RSpec.describe PersonEntity do
+  let(:item) { described_class.new(person_name: 'Johan') }
+
+  it 'should be searializable as string' do
+    expect(item.to_json).to be_present
+  end
+
+  it 'should have @context' do
+    expect(item.as_json).to have_key '@context'
+    expect(item.as_json['@context']).to be_present
+    expect(item.as_json['@context']).to include 'schema.org'
+  end
+
+  it 'should have @type' do
+    expect(item.as_json).to have_key '@type'
+    expect(item.as_json['@type']).to be_present
+    expect(item.as_json['@type']).to eq 'Person'
+  end
+
+  it 'allow to pass single sameAs item' do
+    item2 = nil
+    expect do
+      item2 = described_class.new(person_name: 'Johan', sameAs: 'http://example.com')
+    end.not_to raise_error
+    expect(item2).to be_present
+    expect(item2.as_json).to be_present
+    expect(item2.as_json['sameAs']).to eq 'http://example.com'
+  end
+
+  it 'allow to pass multiple sameAs links' do
+    item2 = nil
+    expect do
+      item2 = described_class.new(person_name: 'Johan', sameAs: ['http://example.com', 'http://example.com/extra'])
+    end.not_to raise_error
+    expect(item2).to be_present
+    expect(item2.as_json).to be_present
+    expect(item2.as_json['sameAs']).to include 'http://example.com'
+    expect(item2.as_json['sameAs']).to include 'http://example.com/extra'
+  end
+end

data/spec/entities/review_entity_spec.rb

@@ -2,13 +2,15 @@
 
 RSpec.describe ReviewEntity do
   let(:time) { 1.week.ago }
-  let(:item) do
-    described_class.new(
+  let(:item_data) do
+    {
       author: 'John',
+      publisher: 'Fodojo LLC',
       description: 'TODO',
       reviewRating: { ratingValue: 3 }
-    )
+    }
   end
+  let(:item) { described_class.new(item_data) }
 
   it 'should be searializable as hash' do
     expect(item.as_json).to be_present
@@ -28,17 +30,71 @@ RSpec.describe ReviewEntity do
     expect(item.as_json['@type']).to eq 'Review'
   end
 
-  it 'should allow set datePublished as datetime' do
-    i2 = described_class.new(datePublished: time)
-    obj = JSON.parse(i2.to_json)
-    newTime = Time.zone.parse(obj['datePublished'])
-    expect(newTime).to be_within(1.second).of(time)
+  context 'datePublished' do
+    it 'should allow set datePublished as datetime' do
+      i2 = described_class.new(datePublished: time)
+      obj = JSON.parse(i2.to_json)
+
+      new_time = Time.zone.parse(obj['datePublished'])
+      expect(new_time).to be_within(1.second).of(time)
+    end
+
+    it 'should allow set datePublished as iso8601' do
+      i2 = described_class.new(datePublished: time.iso8601)
+      obj = JSON.parse(i2.to_json)
+
+      new_time = Time.zone.parse(obj['datePublished'])
+      expect(new_time).to be_within(1.second).of(time)
+    end
   end
 
-  it 'should allow set datePublished as iso8601' do
-    i2 = described_class.new(datePublished: time.iso8601)
-    obj = JSON.parse(i2.to_json)
-    newTime = Time.zone.parse(obj['datePublished'])
-    expect(newTime).to be_within(1.second).of(time)
+  context 'author' do
+    it 'should parse author name as person' do
+      author = item.as_json['author']
+      expect(author).to be_a Hash
+      expect(author['@type']).to eq 'Person'
+      expect(author['name']).to eq item.author
+    end
+
+    it 'should allow to pass author hash' do
+      raw = described_class.new(item_data.merge(author: { person_name: 'Kenny' }))
+      author = raw.as_json['author']
+      expect(author).to be_a Hash
+      expect(author['@type']).to eq 'Person'
+      expect(author['name']).to eq raw.author.name
+    end
+
+    it 'should allow to pass author hash (Organization)' do
+      raw = described_class.new(item_data.merge(author: { name: 'Kenny' }))
+      author = raw.as_json['author']
+      expect(author).to be_a Hash
+      expect(author['@type']).to eq 'Organization'
+      expect(author['name']).to eq raw.author.name
+    end
+  end
+
+  context 'publisher' do
+    it 'should parse publisher name as organizaton' do
+      publisher = item.as_json['publisher']
+      expect(publisher).to be_a Hash
+      expect(publisher['@type']).to eq 'Organization'
+      expect(publisher['name']).to eq item.publisher
+    end
+
+    it 'should allow to pass publisher hash' do
+      raw = described_class.new(item_data.merge(publisher: { person_name: 'Kenny' }))
+      publisher = raw.as_json['publisher']
+      expect(publisher).to be_a Hash
+      expect(publisher['@type']).to eq 'Person'
+      expect(publisher['name']).to eq raw.publisher.name
+    end
+
+    it 'should allow to pass publisher hash (Organization)' do
+      raw = described_class.new(item_data.merge(publisher: { name: 'Kenny' }))
+      publisher = raw.as_json['publisher']
+      expect(publisher).to be_a Hash
+      expect(publisher['@type']).to eq 'Organization'
+      expect(publisher['name']).to eq raw.publisher.name
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: izi_json_ld
 version: !ruby/object:Gem::Version
-  version: 1.0.6
+  version: 1.0.10
 platform: ruby
 authors:
 - IzikAJ
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-19 00:00:00.000000000 Z
+date: 2021-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-struct
@@ -93,7 +93,6 @@ files:
 - spec/dummy/config/routes.rb
 - spec/dummy/db/development.sqlite3
 - spec/dummy/db/test.sqlite3
-- spec/dummy/log/development.log
 - spec/dummy/log/test.log
 - spec/dummy/tmp/development_secret.txt
 - spec/entities/aggregate_rating_entity_spec.rb
@@ -101,6 +100,7 @@ files:
 - spec/entities/breadcrumb_list_entity_spec.rb
 - spec/entities/faq_page_entity_spec.rb
 - spec/entities/offer_entity_spec.rb
+- spec/entities/person_entity_spec.rb
 - spec/entities/product_entity_spec.rb
 - spec/entities/rating_entity_spec.rb
 - spec/entities/review_entity_spec.rb
@@ -155,13 +155,13 @@ test_files:
 - spec/dummy/db/test.sqlite3
 - spec/dummy/db/development.sqlite3
 - spec/dummy/log/test.log
-- spec/dummy/log/development.log
 - spec/dummy/tmp/development_secret.txt
 - spec/rails_helper.rb
 - spec/entities/aggregate_rating_entity_spec.rb
 - spec/entities/review_entity_spec.rb
 - spec/entities/breadcrumb_list_entity_spec.rb
 - spec/entities/faq_page_entity_spec.rb
+- spec/entities/person_entity_spec.rb
 - spec/entities/rating_entity_spec.rb
 - spec/entities/offer_entity_spec.rb
 - spec/entities/article_entity_spec.rb

data/spec/dummy/log/development.log

@@ -1,16 +0,0 @@
-   (0.1ms)  SELECT sqlite_version(*)
-  ↳ bin/rails:4
-   (1.2ms)  CREATE TABLE "schema_migrations" ("version" varchar NOT NULL PRIMARY KEY)
-  ↳ bin/rails:4
-   (1.2ms)  CREATE TABLE "ar_internal_metadata" ("key" varchar NOT NULL PRIMARY KEY, "value" varchar, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)
-  ↳ bin/rails:4
-  ActiveRecord::InternalMetadata Load (0.2ms)  SELECT  "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
-  ↳ bin/rails:4
-   (0.1ms)  begin transaction
-  ↳ bin/rails:4
-  ActiveRecord::InternalMetadata Create (0.4ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "environment"], ["value", "development"], ["created_at", "2021-03-17 08:43:32.839496"], ["updated_at", "2021-03-17 08:43:32.839496"]]
-  ↳ bin/rails:4
-   (0.7ms)  commit transaction
-  ↳ bin/rails:4
-   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
-  ↳ bin/rails:4