itunes_store_transporter 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1706c7254e4158ee42930c52f11f48bd22ddb409
-  data.tar.gz: fb2b7760daa79915b5628f3631b622a4d978b375
+  metadata.gz: bc9637b7cc0896807aa9592f53c742651f264280
+  data.tar.gz: e3510e67c8d7dab12965308d15d38aad958834b1
 SHA512:
-  metadata.gz: 2fb763cde86787bb12b99fdf3e1cebf2e7213d0458cccef43f9c17edbf8903ca32244829d403672ce813f5027c93882b8635a6288f5fb8bdf89645152c934a37
-  data.tar.gz: b3b59d68150bb088732c2c9a6f0822b59e843cdebd7e13a7439c54070baa855bb0e3da3e88fe4a43e39f8215afef7204b8b44253eedaca821132be88b414dd47
+  metadata.gz: 53d6ea94ed09ff77c56bfe036171b1d30c6fa4644ce7002f4871b85c047f180fc6ac3263745f53919a322ebf1547b3c6ae7f77a8d5def24b9fb783b7cb9edcff
+  data.tar.gz: 213aaac35b156e73afd63e6ce961f4d212b14adfb74ee6c38132c180e03117ed564e93237e167c5019037a78f17f2c6b93f1cec7d194de2f8f84f3649e9c73fb

data/Changes

@@ -1,3 +1,8 @@
+v0.2.1    2018-04-14
+--------------------
+Enhancements:
+* Support for itc_provider option
+
 v0.2.0    2017-02-07
 --------------------
 Changes:

data/README.rdoc

@@ -11,7 +11,7 @@ Upload and manage your assets in the iTunes Store using the iTunes Store's Trans
  require "itunes/store/transporter"
 
  itms = iTunes::Store::Transporter.new(:username => "SomeUser",
-                                       :shortname => "shrt",
+                                       :shortname => "shrt",  # or :itc_provider, if you have no shortname
                                        :password => "w3c@llYoU!")
 
  itms.upload("/path/to/yourpackage.itmsp")
@@ -50,35 +50,16 @@ that it can send email notifications and allows one to set global/per-command de
 
 === Locating iTMSTransporter
 
-If the +iTMSTransporter+ cannot be found in {one your platform's known locations}[https://github.com/sshaw/itunes_store_transporter/tree/master/lib/itunes/store/transporter/shell.rb#L28-L40] you must specify it when creating an instance of <code>iTunes::Store::Transporter</code> via {the <code>:path</code> option}[http://ruby-doc.org/gems/docs/i/itunes_store_transporter-0.1.1/ITunes/Store/Transporter/ITMSTransporter.html#method-c-new-label-Options].
+If the +iTMSTransporter+ cannot be found in {one your platform's known locations}[https://github.com/sshaw/itunes_store_transporter/blob/fcb4f0f9ada4a45764160beac6a049b0d419c8a9/lib/itunes/store/transporter/shell.rb#L31] you must specify it when creating an instance of <code>iTunes::Store::Transporter</code> via {the <code>:path</code> option}[http://www.rubydoc.info/gems/itunes_store_transporter/ITunes/Store/Transporter/ITMSTransporter#initialize-instance_method].
 
 If you're using the bundled +itms+ command you must use its +--path+ option or specify the path in the itms config file. See the +itms+ section for more info.
 
-=== Running on Windows
-
-On Windows +iTMSTransporter+ is called via the +iTMSTransporter.CMD+ batch file. This file does not handle the
-+iTMSTransporter+'s exit status correctly, causing <code>iTunes::Store::Transporter</code> to report everything as a success.
-
-This can be fixed by modifying +iTMSTransporter.CMD+ (note that the following does not mimic the batch file exactly):
-
-  ...
-
-  call iTMSTransporter\iTMSTransporter %*
-
-  REM Add this line:
-  set exited=%errorlevel%
-
-  cd %olddir%
-
-  REM Add this line too:
-  exit /b %exited%
-
 === Using itms
 
 <code>itms COMMAND [OPTIONS] [PACKAGE]</code>
 
-* +COMMAND+ - The command to run, which can be any one of {the <code>iTunes::Store::Transporter</code> methods}[http://ruby-doc.org/gems/docs/i/itunes_store_transporter-0.1.1/ITunes/Store/Transporter/ITMSTransporter.html]
-* +OPTIONS+ - These are quivalent to the given +COMMAND+'s options except they must be given in a strict long option format. For example <code>:apple_id => "X123"</code> would be <code>--apple-id=X123</code>. Boolean options can be negated with the <code>--no-</code> prefix. For more info see {each command's options}[http://ruby-doc.org/gems/docs/i/itunes_store_transporter-0.1.1/ITunes/Store/Transporter/ITMSTransporter.html].
+* +COMMAND+ - The command to run, which can be any one of {the <code>iTunes::Store::Transporter</code> methods}[http://sshaw.github.io/itunes_store_transporter/classes/ITunes/Store/Transporter/ITMSTransporter.html]
+* +OPTIONS+ - These are quivalent to the given +COMMAND+'s options except they must be given in a strict long option format. For example <code>:apple_id => "X123"</code> would be <code>--apple-id=X123</code>. Boolean options can be negated with the <code>--no-</code> prefix. For more info see {each command's options}[http://sshaw.github.io/itunes_store_transporter/classes/ITunes/Store/Transporter/ITMSTransporter.html].
 * +PACKAGE+ - The package or directory to operate on, if required by the command
 
 <b>Note that options with a value must contain the equals character</b> (<code>"="</code>).
@@ -166,10 +147,10 @@ As you can see, command options are turned into template variables.
 
 === More Info
 
-* Docs: http://www.rubydoc.info/gems/itunes_store_transporter
+* Docs: http://sshaw.github.io/itunes_store_transporter
 * Bugs: http://github.com/sshaw/itunes_store_transporter/issues
 * Source Code: http://github.com/sshaw/itunes_store_transporter
-* Transporter GUI: http://github.com/sshaw/itunes_store_transporter_web
+* iTunes Store Transporter: GUI: http://transportergui.com
 
 === Author
 
@@ -178,3 +159,7 @@ Skye Shaw [skye.shaw AT gmail.com]
 === License
 
 Released under the MIT License: http://www.opensource.org/licenses/MIT
+
+---
+
+Made by {ScreenStaring}[http://screenstaring.com]

data/lib/itunes/store/transporter.rb

@@ -20,7 +20,7 @@ module ITunes
 end
 
 unless ENV["ITUNES_STORE_TRANSPORTER_NO_SYNTAX_SUGAR"].to_i > 0
-  def iTunes
+  def iTunes                    # :nodoc: all
     ITunes
   end
 end

data/lib/itunes/store/transporter/command.rb

@@ -86,7 +86,6 @@ module ITunes
             options.on :mode, "-m", /\w+/, :required => true
             options.on :username, "-u", :required => true
             options.on :password, "-p", :required => true
-            options.on *SHORTNAME
           end
 
           protected

data/lib/itunes/store/transporter/command/lookup.rb

@@ -14,6 +14,9 @@ module ITunes
         class Lookup < Mode
           def initialize(*config)
             super
+            options.on *SHORTNAME
+            options.on *ITC_PROVIDER
+
             # These 2 are mutually exclusive, and one is required.
             # Optout has no way to denote this
             options.on *VENDOR_ID

data/lib/itunes/store/transporter/command/option.rb

@@ -9,6 +9,7 @@ module ITunes
           VENDOR_ID   = [ :vendor_id, "-vendor_id", /\w/ ]
           APPLE_ID    = [ :apple_id, "-apple_id", /\w/ ]
           SHORTNAME   = [ :shortname, "-s", /\w/ ]
+          ITC_PROVIDER= [ :itc_provider, "-itc_provider", /\w/ ]
           TRANSPORT   = [ :transport, "-t", %w|Aspera Signiant DAV| ]
           SUCCESS     = [ :success, "-success", Optout::Dir.exists ]
           FAILURE     = [ :failure, "-failure", Optout::Dir.exists ]

data/lib/itunes/store/transporter/command/schema.rb

@@ -12,6 +12,9 @@ module ITunes
         class Schema < Mode
           def initialize(*config)
             super
+            options.on *SHORTNAME
+            options.on *ITC_PROVIDER
+
             options.on *DESTINATION
             options.on :type, "-schemaType", /\A(transitional|strict)\z/i, :required => true
             options.on :version, "-schema", /\w+/i, :required => true

data/lib/itunes/store/transporter/command/status.rb

@@ -12,6 +12,8 @@ module ITunes
         class Status < Mode
           def initialize(*config)
             super
+            options.on *SHORTNAME
+            options.on *ITC_PROVIDER
             options.on :vendor_id, "-vendor_ids", /\w/, :multiple => true
             options.on :apple_id, "-apple_ids", /\w/, :multiple => true
             options.on :format, "-outputFormat", %w[xml]

data/lib/itunes/store/transporter/command/upload.rb

@@ -15,6 +15,8 @@ module ITunes
             options.on *TRANSPORT
             options.on *SUCCESS
             options.on *FAILURE
+            options.on *SHORTNAME
+            options.on *ITC_PROVIDER
             options.on :delete, "-delete", Optout::Boolean
             options.on :rate, "-k", Integer  # Required if TRANSPORT is Aspera or Signiant
             options.on :streams, "-numStreams", Integer  # Only valid if TRANSPORT is Signiant

data/lib/itunes/store/transporter/command/verify.rb

@@ -14,6 +14,8 @@ module ITunes
         class Verify < BatchMode
           def initialize(*config)
             super
+            options.on *SHORTNAME
+            options.on *ITC_PROVIDER
             options.on :verify_assets, "-disableAssetVerification", Optout::Boolean  # If false verify MD only no assets
           end
 

data/lib/itunes/store/transporter/itms_transporter.rb

@@ -18,7 +18,8 @@ module ITunes
         #
         # [:username (String)] Your username
         # [:password (String)] Your password
-        # [:shortname (String)] Your shortname. Optional, not every iTunes account has one
+        # [:shortname (String)] Your shortname (encoding house user). Optional, not every iTunes account has one
+        # [:itc_provider (String)] Your iTunes Connect user. Optional, not every iTunes account has one
         # [:path (String)] The path to the +iTMSTransporter+. Optional.
         # [:print_stdout (Boolean)] Print +iTMSTransporter+'s stdout to your stdout. Defaults to +false+.
         # [:print_stderr (Boolean)] Print +iTMSTransporter+'s stderr to your stderr. Defaults to +false+.

data/lib/itunes/store/transporter/version.rb

@@ -1,7 +1,7 @@
 module ITunes
   module Store
     module Transporter
-      VERSION = "0.2.0"
+      VERSION = "0.2.1"
     end
   end
 end

data/spec/command_spec.rb

@@ -19,7 +19,7 @@ shared_examples_for "a transporter option that expects a directory" do |option,
 
   context "when the directory does not exist" do
     it "raises an OptionError" do
-      lambda { subject.run(options.merge(option => "__baaaaahd_directory__")) }.should raise_exception(ITunes::Store::Transporter::OptionError, /does not exist/)
+      expect { subject.run(options.merge(option => "__baaaaahd_directory__")) }.to raise_exception(ITunes::Store::Transporter::OptionError, /does not exist/)
     end
   end
 end
@@ -54,7 +54,13 @@ shared_examples_for "a required option" do |option|
   end
 end
 
+shared_examples_for "a command that accepts an itc_provider argument" do
+  it_should_behave_like "a transporter option", { :itc_provider => "sshaw" }, "-itc_provider", "sshaw"
+end
+
 shared_examples_for "a command that accepts a shortname argument" do
+  it_should_behave_like "a transporter option", { :shortname => "sshaw" }, "-s", "sshaw"
+
   context "when the shortname's invalid" do
     it "raises an OptionError" do
       expect { subject.run(options.merge(:shortname => "+")) }.to raise_exception(ITunes::Store::Transporter::OptionError, /shortname/)
@@ -259,7 +265,7 @@ shared_examples_for "a command that requires a package argument" do
       path = Tempfile.new("").path
       options = create_options(:package => path)
       # TODO: Optout's error message will probably be changed to something more descriptive, change this when that happens
-      lambda { subject.run(options) }.should raise_error(ITunes::Store::Transporter::OptionError, /dir/i)
+      expect { subject.run(options) }.to raise_error(ITunes::Store::Transporter::OptionError, /dir/i)
     end
   end
 end
@@ -288,6 +294,7 @@ describe ITunes::Store::Transporter::Command::Upload do
   it_behaves_like "a transporter mode"
   it_behaves_like "a command that requires a package argument"
   it_behaves_like "a command that accepts a shortname argument"
+  it_behaves_like "a command that accepts an itc_provider argument"
 
   subject { described_class.new({}) }
   let(:options) { create_options(:package => create_package, :transport => "Aspera")  }
@@ -348,6 +355,7 @@ end
 describe ITunes::Store::Transporter::Command::Lookup do
   it_behaves_like "a transporter mode"
   it_behaves_like "a command that accepts a shortname argument"
+  it_behaves_like "a command that accepts an itc_provider argument"
 
   subject { described_class.new({}) }
 
@@ -386,7 +394,7 @@ describe ITunes::Store::Transporter::Command::Lookup do
         before { FileUtils.rm_rf(@tmpdir) }
 
         it "raises a TransporterError" do
-          lambda { subject.run(options) }.should raise_exception(ITunes::Store::Transporter::TransporterError, /no metadata file/i)
+          expect { subject.run(options) }.to raise_exception(ITunes::Store::Transporter::TransporterError, /no metadata file/i)
         end
       end
     end
@@ -409,6 +417,7 @@ end
 describe ITunes::Store::Transporter::Command::Schema do
   it_behaves_like "a transporter mode"
   it_behaves_like "a command that accepts a shortname argument"
+  it_behaves_like "a command that accepts an itc_provider argument"
 
   subject { described_class.new({}) }
   let(:options) { create_options(:type => "strict", :version => "film5") }
@@ -458,6 +467,8 @@ end
 describe ITunes::Store::Transporter::Command::Status do
   # Ugh, issue with stubbed print_stdout test, we need XML here :(
   #it_behaves_like "a transporter mode"
+  it_behaves_like "a command that accepts a shortname argument"
+  it_behaves_like "a command that accepts an itc_provider argument"
 
   subject { described_class.new({}) }
   let(:options) { create_options(:vendor_id => 123123) }
@@ -578,6 +589,7 @@ describe ITunes::Store::Transporter::Command::Verify do
   it_behaves_like "a transporter mode"
   it_behaves_like "a command that requires a package argument"
   it_behaves_like "a command that accepts a shortname argument"
+  it_behaves_like "a command that accepts an itc_provider argument"
 
   subject { described_class.new({}) }
   let(:options) { create_options(:package => create_package) }

data/spec/errors_spec.rb

@@ -5,48 +5,48 @@ describe ITunes::Store::Transporter::TransporterMessage do
   its(:code) { should == 1 }
   its(:message) { should == "some message" }
 
-  describe "#to_s" do     
-    it "includes the code and message" do 
+  describe "#to_s" do
+    it "includes the code and message" do
       subject.to_s.should == "some message (1)"
-    end    
+    end
   end
 
-  describe "error predicate methods" do 
-    method_codes = { 
-      :bad_data? => [3000, 3999], 
+  describe "error predicate methods" do
+    method_codes = {
+      :bad_data? => [3000, 3999],
       :invalid_data? => [4000, 4999],
       :missing_data? => [5000, 5999],
-      :unsupported_feature? => [6000, 6999], 
-      :schema_error? => [8000, 8999], 
-      :asset_error? => [9000, 9999] 
+      :unsupported_feature? => [6000, 6999],
+      :schema_error? => [8000, 8999],
+      :asset_error? => [9000, 9999]
     }
 
     method_codes.each do |method, codes|
       [codes.first, codes.last].each do |code|
 
-        context "code #{code}" do        
+        context "code #{code}" do
           subject { described_class.new("", code) }
-          its(method) { should be_true }        
-          its(:validation_error?) { should be_true }        
+          its(method) { should be true }
+          its(:validation_error?) { should be true }
 
           (method_codes.keys - [method]).each do |other|
-            its(other) { should be_false }
+            its(other) { should be false }
           end
         end
       end
     end
   end
 end
-    
-describe ITunes::Store::Transporter::ExecutionError do 
+
+describe ITunes::Store::Transporter::ExecutionError do
   subject { described_class.new(messages, 1) }
   let(:messages) { 2.times.inject([]) { |err, i| err << ITunes::Store::Transporter::TransporterMessage.new("message #{i}", i) } }
   its(:exitstatus) { should == 1 }
   its(:errors) { should == messages }
 
-  describe "#to_s" do 
-    it "includes each messages and its code" do 
-      subject.to_s.should == "message 0 (0), message 1 (1)" 
+  describe "#to_s" do
+    it "includes each messages and its code" do
+      subject.to_s.should == "message 0 (0), message 1 (1)"
     end
   end
 end

data/spec/output_parser_spec.rb

@@ -54,9 +54,14 @@ describe ITunes::Store::Transporter::OutputParser do
       before(:all) { @parser = described_class.new(fixture("errors_and_warnings.with_error_number")) }
 
       subject { @parser }
-      its(:warnings) { should be_empty }
-      its(:errors) { should have(2).items }
 
+      it "generates no warnings" do
+        expect(@parser.warnings).to be_empty
+      end
+
+      it "generates two errors" do
+        expect(@parser.errors.size).to eq 2
+      end
 
       describe "the first error" do
         subject { @parser.errors.first }
@@ -85,8 +90,14 @@ describe ITunes::Store::Transporter::OutputParser do
     before(:all) { @parser = described_class.new(fixture("errors_and_warnings.single_warning")) }
 
     subject { @parser }
-    its(:errors) { should be_empty }
-    its(:warnings) { should have(1).item }
+
+    it "generates no errors" do
+      expect(@parser.errors).to be_empty
+    end
+
+    it "generates one warning" do
+      expect(@parser.warnings.size).to eq 1
+    end
 
     describe "the warning" do
       subject { @parser.warnings.first }

data/spec/transporter_spec.rb

@@ -45,7 +45,7 @@ describe ITunes::Store::Transporter::ITMSTransporter do
   describe "#new" do
     context "when the options are not a Hash or nil" do
       it "raises an ArgumentError" do
-	lambda { described_class.new(123) }.should raise_exception(ArgumentError, /must be/)
+	expect { described_class.new(123) }.to raise_exception(ArgumentError, /must be/)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itunes_store_transporter
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Skye Shaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-07 00:00:00.000000000 Z
+date: 2018-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -72,9 +72,9 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3'
-description: "    iTunes::Store::Transporter is a wrapper around Apple's iTMSTransporter
-  program. It allows you to upload packages to the \n    Apple Store, validate them,
-  retrieve status information, lookup metadata, and more!\n"
+description: |2
+      iTunes::Store::Transporter is a wrapper around Apple's iTMSTransporter program. It allows you to upload packages to the
+      Apple Store, validate them, retrieve status information, lookup metadata, and more!
 email: skye.shaw@gmail.com
 executables:
 - itms
@@ -115,16 +115,11 @@ files:
 - spec/spec_helper.rb
 - spec/transporter_spec.rb
 - spec/xml_status_spec.rb
-- spec/xml_status_spec.rb~
 homepage: http://github.com/sshaw/itunes_store_transporter
 licenses:
 - MIT
 metadata: {}
-post_install_message: "\n  !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n  !!
-  \         ATTENTION WINDOWS USERS             !!\n  !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n
-  \ \n  You must make a small change to the iTMSTransporter.CMD batch file, otherwise
-  \n  this library will not function correctly. \n  \n  For details see: http://github.com/sshaw/itunes_store_transporter#running-on-windows
-  \ \n\n"
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -140,7 +135,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Upload and manage your assets in the iTunes Store using the iTunes Store's
@@ -158,4 +153,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/transporter_spec.rb
 - spec/xml_status_spec.rb
-- spec/xml_status_spec.rb~

data/spec/xml_status_spec.rb~

@@ -1,22 +0,0 @@
-require "spec_helper"
-
-RSpec.describe ITunes::Store::Transporter::XML::Status do
-  context "given a valid XML doc with a single status" do
-    it "returns a Hash with a single status" do
-
-    end
-
-  end
-
-  context "given a valid XML doc with multiple statuses" do
-    it "returns a Hash with multiple statuses" do
-
-    end
-  end
-
-  context "given an XML invalid XML doc" do
-    it "raises a ParseError" do
-
-    end
-  end
-end