itsi 0.2.13 → 0.2.15

data/gems/server/test/options/ruby_thread_request_backlog_size.rb

@@ -10,7 +10,7 @@ class TestRubyThreadRequestBacklogSize < Minitest::Test
         ruby_thread_request_backlog_size 1
         get("/foo"){|r| sleep 0.1; r.ok "ok" }
       end) do
-      responses = 3.times.map{ Thread.new{ get_resp("/foo") } }.map(&:value)
+      responses = 10.times.map{ Thread.new{ get_resp("/foo") } }.map(&:value)
 
       assert_equal "ok", responses.first.body
       assert_equal "200", responses.first.code

data/gems/server/test/rack/test_rack_server.rb

@@ -356,7 +356,7 @@ class TestRackServer < Minitest::Test
   end
 
   def test_multi_field_headers
-    server(app_with_lint: lambda do |env|
+    server(app_with_lint: lambda do |_|
       [200, { "content-type" => "text/plain", "x-example" => ["one, two, three", "four, five"] }, ["Multiple Field Headers"]]
     end) do
       response = get_resp("/")
@@ -365,4 +365,35 @@ class TestRackServer < Minitest::Test
       assert_equal "Multiple Field Headers", response.body
     end
   end
+
+  # For backwards compatibility with Rack-2, which uses "\n" for multiple values in headers.
+  # https://github.com/rack/rack/blob/df6c47357f6c6bec2d585f45f417285d813d9b3a/lib/rack/utils.rb#L271
+  #
+  # In Rack 3, the behavior has changed to using Arrays of Strings exclusively.
+  # Note we don't use Rack lint here, because it'll complain about the invalid header value.
+  def test_multiline_headers_legacy_cookie
+    cookies = "one\r\ntwo\n three\n\tfour\nfive\n\n"
+    server(app: ->(_) { [200, { "set-cookie" => cookies }, ["OK"]] }) do
+      resp = get_resp("/")
+      assert_equal "200", resp.code
+      # folded lines should coalesce; empty lines disappear
+      assert_equal %w[one two three four five], resp.get_fields("set-cookie")
+    end
+  end
+
+  def test_control_chars_are_stripped
+    evil = "good\nbad\x01bad\ngood"
+    server(app: ->(_) { [200, { "x-evil" => evil }, ["body"]] }) do
+      resp = get_resp("/")
+      assert_equal %w[good good], resp.get_fields("x-evil")
+    end
+  end
+
+  def test_rack3_array_is_untouched
+    server(app: ->(_) { [200,
+                        { "set-cookie" => ["a=b", "c=d"] }, ["OK"] ] }) do
+      resp = get_resp("/")
+      assert_equal %w[a=b c=d], resp.get_fields("set-cookie")
+    end
+  end
 end

data/lib/itsi/version.rb

@@ -1,3 +1,3 @@
 module Itsi
-  VERSION = '0.2.13'
+  VERSION = '0.2.15'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: itsi
 version: !ruby/object:Gem::Version
-  version: 0.2.13
+  version: 0.2.15
 platform: ruby
 authors:
 - Wouter Coppieters
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.15
 - !ruby/object:Gem::Dependency
   name: itsi-server
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.15
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.13
+        version: 0.2.15
 description: Wrapper Gem for both the Itsi server and the Itsi Fiber scheduler
 email:
 - wc@pico.net.nz
@@ -1027,7 +1027,7 @@ files:
 - tasks.txt
 homepage: https://itsi.fyi
 licenses:
-- MIT
+- LGPL-3.0
 metadata:
   homepage_uri: https://itsi.fyi
   source_code_uri: https://github.com/wouterken/itsi