itsi-scheduler 0.1.5 → 0.1.11

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.


This version of itsi-scheduler might be problematic. Click here for more details.

@@ -3,8 +3,11 @@ use crate::server::{
3
3
  process_worker::ProcessWorker,
4
4
  };
5
5
  use itsi_error::{ItsiError, Result};
6
- use itsi_rb_helpers::{call_without_gvl, create_ruby_thread};
6
+ use itsi_rb_helpers::{
7
+ call_proc_and_log_errors, call_with_gvl, call_without_gvl, create_ruby_thread,
8
+ };
7
9
  use itsi_tracing::{error, info, warn};
10
+ use magnus::Value;
8
11
  use nix::{
9
12
  libc::{self, exit},
10
13
  unistd::Pid,
@@ -19,9 +22,9 @@ use tokio::{
19
22
  sync::{broadcast, watch, Mutex},
20
23
  time::{self, sleep},
21
24
  };
22
- use tracing::instrument;
25
+ use tracing::{debug, instrument};
23
26
  pub(crate) struct ClusterMode {
24
- pub listeners: Arc<Vec<Arc<Listener>>>,
27
+ pub listeners: parking_lot::Mutex<Vec<Listener>>,
25
28
  pub server: Arc<Server>,
26
29
  pub process_workers: parking_lot::Mutex<Vec<ProcessWorker>>,
27
30
  pub lifecycle_channel: broadcast::Sender<LifecycleEvent>,
@@ -34,12 +37,9 @@ static CHILD_SIGNAL_SENDER: parking_lot::Mutex<Option<watch::Sender<()>>> =
34
37
  impl ClusterMode {
35
38
  pub fn new(
36
39
  server: Arc<Server>,
37
- listeners: Arc<Vec<Arc<Listener>>>,
40
+ listeners: Vec<Listener>,
38
41
  lifecycle_channel: broadcast::Sender<LifecycleEvent>,
39
42
  ) -> Self {
40
- if let Some(f) = server.before_fork.lock().take() {
41
- f();
42
- }
43
43
  let process_workers = (0..server.workers)
44
44
  .map(|_| ProcessWorker {
45
45
  worker_id: WORKER_ID.fetch_add(1, std::sync::atomic::Ordering::Relaxed),
@@ -48,7 +48,7 @@ impl ClusterMode {
48
48
  .collect();
49
49
 
50
50
  Self {
51
- listeners,
51
+ listeners: parking_lot::Mutex::new(listeners),
52
52
  server,
53
53
  process_workers: parking_lot::Mutex::new(process_workers),
54
54
  lifecycle_channel,
@@ -152,7 +152,7 @@ impl ClusterMode {
152
152
 
153
153
  tokio::select! {
154
154
  _ = monitor_handle => {
155
- info!("All children exited early, exit normally")
155
+ debug!("All children exited early, exit normally")
156
156
  }
157
157
  _ = sleep(Duration::from_secs_f64(shutdown_timeout)) => {
158
158
  warn!("Graceful shutdown timeout reached, force killing remaining children");
@@ -191,6 +191,9 @@ impl ClusterMode {
191
191
  #[instrument(skip(self), fields(mode = "cluster", pid=format!("{:?}", Pid::this())))]
192
192
  pub fn run(self: Arc<Self>) -> Result<()> {
193
193
  info!("Starting in Cluster mode");
194
+ if let Some(proc) = self.server.hooks.get("before_fork") {
195
+ call_with_gvl(|_| call_proc_and_log_errors(proc.clone()))
196
+ }
194
197
  self.process_workers
195
198
  .lock()
196
199
  .iter()
@@ -228,6 +231,9 @@ impl ClusterMode {
228
231
  if let Some(current_mem_usage) = largest_worker.memory_usage(){
229
232
  if current_mem_usage > memory_limit {
230
233
  largest_worker.reboot(self_ref.clone()).await.ok();
234
+ if let Some(hook) = self_ref.server.hooks.get("after_memory_threshold_reached") {
235
+ call_with_gvl(|_| hook.call::<_, Value>((largest_worker.pid(),)).ok() );
236
+ }
231
237
  }
232
238
  }
233
239
  }
@@ -4,7 +4,7 @@ use crate::{
4
4
  io_stream::IoStream,
5
5
  itsi_server::{RequestJob, Server},
6
6
  lifecycle_event::LifecycleEvent,
7
- listener::{Listener, TokioListener},
7
+ listener::{Listener, ListenerInfo},
8
8
  thread_worker::{build_thread_workers, ThreadWorker},
9
9
  },
10
10
  };
@@ -15,17 +15,23 @@ use hyper_util::{
15
15
  server::conn::auto::Builder,
16
16
  };
17
17
  use itsi_error::{ItsiError, Result};
18
+ use itsi_rb_helpers::print_rb_backtrace;
18
19
  use itsi_tracing::{debug, error, info};
19
20
  use nix::unistd::Pid;
21
+ use parking_lot::Mutex;
20
22
  use std::{
21
23
  num::NonZeroU8,
24
+ panic,
22
25
  pin::Pin,
23
26
  sync::Arc,
24
27
  time::{Duration, Instant},
25
28
  };
26
29
  use tokio::{
27
30
  runtime::{Builder as RuntimeBuilder, Runtime},
28
- sync::broadcast,
31
+ sync::{
32
+ broadcast,
33
+ watch::{self, Sender},
34
+ },
29
35
  task::JoinSet,
30
36
  };
31
37
  use tracing::instrument;
@@ -34,7 +40,7 @@ pub struct SingleMode {
34
40
  pub executor: Builder<TokioExecutor>,
35
41
  pub server: Arc<Server>,
36
42
  pub sender: async_channel::Sender<RequestJob>,
37
- pub(crate) listeners: Arc<Vec<Arc<Listener>>>,
43
+ pub(crate) listeners: Mutex<Vec<Listener>>,
38
44
  pub(crate) thread_workers: Arc<Vec<ThreadWorker>>,
39
45
  pub(crate) lifecycle_channel: broadcast::Sender<LifecycleEvent>,
40
46
  }
@@ -49,18 +55,24 @@ impl SingleMode {
49
55
  #[instrument(parent=None, skip_all, fields(pid=format!("{:?}", Pid::this())))]
50
56
  pub(crate) fn new(
51
57
  server: Arc<Server>,
52
- listeners: Arc<Vec<Arc<Listener>>>,
58
+ listeners: Vec<Listener>,
53
59
  lifecycle_channel: broadcast::Sender<LifecycleEvent>,
54
60
  ) -> Result<Self> {
55
61
  let (thread_workers, sender) = build_thread_workers(
62
+ server.clone(),
56
63
  Pid::this(),
57
64
  NonZeroU8::try_from(server.threads).unwrap(),
58
- server.app,
65
+ server.app.clone(),
59
66
  server.scheduler_class.clone(),
60
- )?;
67
+ )
68
+ .inspect_err(|e| {
69
+ if let Some(err_val) = e.value() {
70
+ print_rb_backtrace(err_val);
71
+ }
72
+ })?;
61
73
  Ok(Self {
62
74
  executor: Builder::new(TokioExecutor::new()),
63
- listeners,
75
+ listeners: Mutex::new(listeners),
64
76
  server,
65
77
  sender,
66
78
  thread_workers,
@@ -80,147 +92,166 @@ impl SingleMode {
80
92
  }
81
93
 
82
94
  pub fn stop(&self) -> Result<()> {
95
+ self.lifecycle_channel.send(LifecycleEvent::Shutdown).ok();
83
96
  Ok(())
84
97
  }
85
98
 
86
- #[instrument(parent=None, skip(self))]
99
+ #[instrument(parent=None, skip(self), fields(pid=format!("{}", Pid::this())))]
87
100
  pub fn run(self: Arc<Self>) -> Result<()> {
88
101
  let mut listener_task_set = JoinSet::new();
89
- let self_ref = Arc::new(self);
90
- self_ref.build_runtime().block_on(async {
91
-
92
- for listener in self_ref.listeners.clone().iter() {
93
- let listener = Arc::new(listener.to_tokio_listener());
94
- let mut lifecycle_rx = self_ref.lifecycle_channel.subscribe();
95
- let self_ref = self_ref.clone();
96
- let listener = listener.clone();
97
- let (shutdown_sender, mut shutdown_receiver) = tokio::sync::watch::channel::<RunningPhase>(RunningPhase::Running);
98
- let listener_clone = listener.clone();
99
-
100
- tokio::spawn(async move {
101
- listener_clone.spawn_state_task().await;
102
- });
103
-
104
- listener_task_set.spawn(async move {
105
- let strategy = self_ref.clone();
106
- loop {
107
- tokio::select! {
108
- accept_result = listener.accept() => match accept_result {
109
- Ok(accept_result) => {
110
- if let Err(e) = strategy.serve_connection(accept_result, listener.clone(), shutdown_receiver.clone()).await {
111
- error!("Error in serve_connection {:?}", e)
112
- }
113
- },
114
- Err(e) => debug!("Listener.accept failed {:?}", e),
115
- },
116
- _ = shutdown_receiver.changed() => {
117
- break;
118
- }
119
- lifecycle_event = lifecycle_rx.recv() => match lifecycle_event{
120
- Ok(lifecycle_event) => {
121
- if let Err(e) = strategy.handle_lifecycle_event(lifecycle_event, shutdown_sender.clone()).await{
122
- match e {
123
- ItsiError::Break() => break,
124
- _ => error!("Error in handle_lifecycle_event {:?}", e)
125
- }
102
+ let runtime = self.build_runtime();
103
+
104
+ runtime.block_on(async {
105
+ let tokio_listeners = self
106
+ .listeners.lock()
107
+ .drain(..)
108
+ .map(|list| {
109
+ Arc::new(list.into_tokio_listener())
110
+ })
111
+ .collect::<Vec<_>>();
112
+ let (shutdown_sender, _) = watch::channel(RunningPhase::Running);
113
+ for listener in tokio_listeners.iter() {
114
+ let mut lifecycle_rx = self.lifecycle_channel.subscribe();
115
+ let listener_info = Arc::new(listener.listener_info());
116
+ let self_ref = self.clone();
117
+ let listener = listener.clone();
118
+ let shutdown_sender = shutdown_sender.clone();
119
+
120
+ let listener_clone = listener.clone();
121
+ let mut shutdown_receiver = shutdown_sender.subscribe();
122
+ let shutdown_receiver_clone = shutdown_receiver.clone();
123
+ listener_task_set.spawn(async move {
124
+ listener_clone.spawn_state_task(shutdown_receiver_clone).await;
125
+ });
126
+
127
+ listener_task_set.spawn(async move {
128
+ let strategy_clone = self_ref.clone();
129
+ let mut acceptor_task_set = JoinSet::new();
130
+ loop {
131
+ tokio::select! {
132
+ accept_result = listener.accept() => match accept_result {
133
+ Ok(accept_result) => {
134
+ let strategy = strategy_clone.clone();
135
+ let listener_info = listener_info.clone();
136
+ let shutdown_receiver = shutdown_receiver.clone();
137
+ acceptor_task_set.spawn(async move {
138
+ strategy.serve_connection(accept_result, listener_info, shutdown_receiver).await;
139
+ });
140
+ },
141
+ Err(e) => debug!("Listener.accept failed {:?}", e),
142
+ },
143
+ _ = shutdown_receiver.changed() => {
144
+ break;
126
145
  }
146
+ lifecycle_event = lifecycle_rx.recv() => match lifecycle_event{
147
+ Ok(lifecycle_event) => {
148
+ if let Err(e) = self_ref.handle_lifecycle_event(lifecycle_event, shutdown_sender.clone()).await{
149
+ match e {
150
+ ItsiError::Break() => break,
151
+ _ => error!("Error in handle_lifecycle_event {:?}", e)
152
+ }
153
+ }
127
154
 
128
- },
129
- Err(e) => error!("Error receiving lifecycle_event: {:?}", e),
130
- }
155
+ },
156
+ Err(e) => error!("Error receiving lifecycle_event: {:?}", e),
157
+ }
158
+ }
131
159
  }
132
- }
133
- if let Ok(listener) = Arc::try_unwrap(listener){
134
- listener.unbind();
135
- }
136
- });
160
+ while let Some(_res) = acceptor_task_set.join_next().await {}
161
+ });
137
162
 
138
- }
163
+ }
139
164
 
140
- while let Some(_res) = listener_task_set.join_next().await {}
141
- });
165
+ while let Some(_res) = listener_task_set.join_next().await {}
142
166
 
167
+ });
168
+ runtime.shutdown_timeout(Duration::from_millis(100));
169
+ debug!("Runtime has shut down");
143
170
  Ok(())
144
171
  }
145
172
 
146
173
  pub(crate) async fn serve_connection(
147
174
  &self,
148
175
  stream: IoStream,
149
- listener: Arc<TokioListener>,
150
- shutdown_channel: tokio::sync::watch::Receiver<RunningPhase>,
151
- ) -> Result<()> {
176
+ listener: Arc<ListenerInfo>,
177
+ shutdown_channel: watch::Receiver<RunningPhase>,
178
+ ) {
152
179
  let sender_clone = self.sender.clone();
153
180
  let addr = stream.addr();
154
181
  let io: TokioIo<Pin<Box<IoStream>>> = TokioIo::new(Box::pin(stream));
155
182
  let server = self.server.clone();
156
183
  let executor = self.executor.clone();
157
184
  let mut shutdown_channel_clone = shutdown_channel.clone();
158
- tokio::spawn(async move {
159
- let server = server.clone();
160
- let mut executor = executor.clone();
161
- let mut binding = executor.http1();
162
- let shutdown_channel = shutdown_channel_clone.clone();
163
- let mut serve = Box::pin(
164
- binding
165
- .timer(TokioTimer::new())
166
- .header_read_timeout(Duration::from_secs(1))
167
- .serve_connection_with_upgrades(
168
- io,
169
- service_fn(move |hyper_request: Request<Incoming>| {
170
- ItsiRequest::process_request(
171
- hyper_request,
172
- sender_clone.clone(),
173
- server.clone(),
174
- listener.clone(),
175
- addr.clone(),
176
- shutdown_channel.clone(),
177
- )
178
- }),
179
- ),
180
- );
181
-
182
- tokio::select! {
183
- // Await the connection finishing naturally.
184
- res = &mut serve => {
185
- match res{
186
- Ok(()) => {
187
- debug!("Connection closed normally")
188
- },
189
- Err(res) => {
190
- debug!("Connection finished with error: {:?}", res)
191
- }
192
- }
193
- serve.as_mut().graceful_shutdown();
194
- },
195
- // A lifecycle event triggers shutdown.
196
- _ = shutdown_channel_clone.changed() => {
197
- // Initiate graceful shutdown.
198
- serve.as_mut().graceful_shutdown();
199
- // Now await the connection to finish shutting down.
200
- if let Err(e) = serve.await {
201
- debug!("Connection shutdown error: {:?}", e);
185
+ let server = server.clone();
186
+ let mut executor = executor.clone();
187
+ let mut binding = executor.http1();
188
+ let shutdown_channel = shutdown_channel_clone.clone();
189
+ let mut serve = Box::pin(
190
+ binding
191
+ .timer(TokioTimer::new())
192
+ .header_read_timeout(Duration::from_secs(1))
193
+ .serve_connection_with_upgrades(
194
+ io,
195
+ service_fn(move |hyper_request: Request<Incoming>| {
196
+ ItsiRequest::process_request(
197
+ hyper_request,
198
+ sender_clone.clone(),
199
+ server.clone(),
200
+ listener.clone(),
201
+ addr.clone(),
202
+ shutdown_channel.clone(),
203
+ )
204
+ }),
205
+ ),
206
+ );
207
+
208
+ tokio::select! {
209
+ // Await the connection finishing naturally.
210
+ res = &mut serve => {
211
+ match res{
212
+ Ok(()) => {
213
+ debug!("Connection closed normally")
214
+ },
215
+ Err(res) => {
216
+ debug!("Connection finished with error: {:?}", res)
202
217
  }
203
218
  }
219
+ serve.as_mut().graceful_shutdown();
220
+ },
221
+ // A lifecycle event triggers shutdown.
222
+ _ = shutdown_channel_clone.changed() => {
223
+ // Initiate graceful shutdown.
224
+ serve.as_mut().graceful_shutdown();
225
+
226
+ // Now await the connection to finish shutting down.
227
+ if let Err(e) = serve.await {
228
+ debug!("Connection shutdown error: {:?}", e);
229
+ }
204
230
  }
205
- });
206
- Ok(())
231
+ }
207
232
  }
208
233
 
209
234
  pub async fn handle_lifecycle_event(
210
235
  &self,
211
236
  lifecycle_event: LifecycleEvent,
212
- shutdown_sender: tokio::sync::watch::Sender<RunningPhase>,
237
+ shutdown_sender: Sender<RunningPhase>,
213
238
  ) -> Result<()> {
239
+ info!("Handling lifecycle event: {:?}", lifecycle_event);
214
240
  if let LifecycleEvent::Shutdown = lifecycle_event {
215
- shutdown_sender
216
- .send(RunningPhase::ShutdownPending)
217
- .expect("Failed to send shutdown pending signal");
218
- let deadline = Instant::now() + Duration::from_secs_f64(self.server.shutdown_timeout);
241
+ //1. Stop accepting new connections.
242
+ shutdown_sender.send(RunningPhase::ShutdownPending).ok();
243
+ tokio::time::sleep(Duration::from_millis(25)).await;
244
+
245
+ //2. Break out of work queues.
219
246
  for worker in &*self.thread_workers {
220
247
  worker.request_shutdown().await;
221
248
  }
249
+
250
+ tokio::time::sleep(Duration::from_millis(25)).await;
251
+
252
+ //3. Wait for all threads to finish.
253
+ let deadline = Instant::now() + Duration::from_secs_f64(self.server.shutdown_timeout);
222
254
  while Instant::now() < deadline {
223
- tokio::time::sleep(Duration::from_millis(50)).await;
224
255
  let alive_threads = self
225
256
  .thread_workers
226
257
  .iter()
@@ -232,10 +263,8 @@ impl SingleMode {
232
263
  tokio::time::sleep(Duration::from_millis(200)).await;
233
264
  }
234
265
 
235
- info!("Sending shutdown signal");
236
- shutdown_sender
237
- .send(RunningPhase::Shutdown)
238
- .expect("Failed to send shutdown signal");
266
+ //4. Force shutdown any stragglers
267
+ shutdown_sender.send(RunningPhase::Shutdown).ok();
239
268
  self.thread_workers.iter().for_each(|worker| {
240
269
  worker.poll_shutdown(deadline);
241
270
  });
@@ -10,6 +10,10 @@ pub static SIGNAL_HANDLER_CHANNEL: LazyLock<(
10
10
  broadcast::Receiver<LifecycleEvent>,
11
11
  )> = LazyLock::new(|| sync::broadcast::channel(5));
12
12
 
13
+ pub fn send_shutdown_event() {
14
+ SIGNAL_HANDLER_CHANNEL.0.send(LifecycleEvent::Shutdown).ok();
15
+ }
16
+
13
17
  pub static SIGINT_COUNT: AtomicI8 = AtomicI8::new(0);
14
18
  fn receive_signal(signum: i32, _: sighandler_t) {
15
19
  SIGINT_COUNT.fetch_add(-1, std::sync::atomic::Ordering::SeqCst);
@@ -1,7 +1,7 @@
1
- use super::itsi_server::RequestJob;
1
+ use super::itsi_server::{RequestJob, Server};
2
2
  use crate::{request::itsi_request::ItsiRequest, ITSI_SERVER};
3
3
  use itsi_rb_helpers::{
4
- call_with_gvl, call_without_gvl, create_ruby_thread, kill_threads, HeapValue,
4
+ call_with_gvl, call_without_gvl, create_ruby_thread, kill_threads, HeapVal, HeapValue,
5
5
  };
6
6
  use itsi_tracing::{debug, error, info, warn};
7
7
  use magnus::{
@@ -24,6 +24,7 @@ use std::{
24
24
  use tokio::{runtime::Builder as RuntimeBuilder, sync::watch};
25
25
  use tracing::instrument;
26
26
  pub struct ThreadWorker {
27
+ pub server: Arc<Server>,
27
28
  pub id: String,
28
29
  pub app: Opaque<Value>,
29
30
  pub receiver: Arc<async_channel::Receiver<RequestJob>>,
@@ -48,11 +49,12 @@ static CLASS_FIBER: Lazy<RClass> = Lazy::new(|ruby| {
48
49
 
49
50
  pub struct TerminateWakerSignal(bool);
50
51
 
51
- #[instrument(name = "Boot", parent=None, skip(threads, app, pid, scheduler_class))]
52
+ #[instrument(name = "Boot", parent=None, skip(server, threads, app, pid, scheduler_class))]
52
53
  pub fn build_thread_workers(
54
+ server: Arc<Server>,
53
55
  pid: Pid,
54
56
  threads: NonZeroU8,
55
- app: Opaque<Value>,
57
+ app: HeapVal,
56
58
  scheduler_class: Option<String>,
57
59
  ) -> Result<(Arc<Vec<ThreadWorker>>, async_channel::Sender<RequestJob>)> {
58
60
  let (sender, receiver) = async_channel::bounded(20);
@@ -65,6 +67,7 @@ pub fn build_thread_workers(
65
67
  .map(|id| {
66
68
  info!(pid = pid.as_raw(), id, "Thread");
67
69
  ThreadWorker::new(
70
+ server.clone(),
68
71
  format!("{:?}#{:?}", pid, id),
69
72
  app,
70
73
  receiver_ref.clone(),
@@ -79,15 +82,11 @@ pub fn build_thread_workers(
79
82
  }
80
83
 
81
84
  pub fn load_app(
82
- app: Opaque<Value>,
85
+ app: HeapVal,
83
86
  scheduler_class: Option<String>,
84
87
  ) -> Result<(Opaque<Value>, Option<Opaque<Value>>)> {
85
88
  call_with_gvl(|ruby| {
86
- let app = app.get_inner_with(&ruby);
87
- let app = Opaque::from(
88
- app.funcall::<_, _, Value>(*ID_CALL, ())
89
- .expect("Couldn't load app"),
90
- );
89
+ let app = Opaque::from(app.funcall::<_, _, Value>(*ID_CALL, ())?);
91
90
  let scheduler_class = if let Some(scheduler_class) = scheduler_class {
92
91
  Some(Opaque::from(
93
92
  ruby.module_kernel()
@@ -101,6 +100,7 @@ pub fn load_app(
101
100
  }
102
101
  impl ThreadWorker {
103
102
  pub fn new(
103
+ server: Arc<Server>,
104
104
  id: String,
105
105
  app: Opaque<Value>,
106
106
  receiver: Arc<async_channel::Receiver<RequestJob>>,
@@ -108,6 +108,7 @@ impl ThreadWorker {
108
108
  scheduler_class: Option<Opaque<Value>>,
109
109
  ) -> Result<Self> {
110
110
  let mut worker = Self {
111
+ server,
111
112
  id,
112
113
  app,
113
114
  receiver,
@@ -126,7 +127,7 @@ impl ThreadWorker {
126
127
  Ok(_) => {}
127
128
  Err(err) => error!("Failed to send shutdown request: {}", err),
128
129
  };
129
- info!("Requesting shutdown");
130
+ debug!("Requesting shutdown");
130
131
  }
131
132
 
132
133
  #[instrument(skip(self, deadline), fields(id = self.id))]
@@ -141,7 +142,7 @@ impl ThreadWorker {
141
142
  if thread.funcall::<_, _, bool>(*ID_ALIVE, ()).unwrap_or(false) {
142
143
  return true;
143
144
  }
144
- info!("Thread has shut down");
145
+ debug!("Thread has shut down");
145
146
  }
146
147
  self.thread.write().take();
147
148
 
@@ -155,17 +156,23 @@ impl ThreadWorker {
155
156
  let receiver = self.receiver.clone();
156
157
  let terminated = self.terminated.clone();
157
158
  let scheduler_class = self.scheduler_class;
159
+ let server = self.server.clone();
158
160
  call_with_gvl(|_| {
159
161
  *self.thread.write() = Some(
160
162
  create_ruby_thread(move || {
161
163
  if let Some(scheduler_class) = scheduler_class {
162
- if let Err(err) =
163
- Self::fiber_accept_loop(id, app, receiver, scheduler_class, terminated)
164
- {
164
+ if let Err(err) = Self::fiber_accept_loop(
165
+ server,
166
+ id,
167
+ app,
168
+ receiver,
169
+ scheduler_class,
170
+ terminated,
171
+ ) {
165
172
  error!("Error in fiber_accept_loop: {:?}", err);
166
173
  }
167
174
  } else {
168
- Self::accept_loop(id, app, receiver, terminated);
175
+ Self::accept_loop(server, id, app, receiver, terminated);
169
176
  }
170
177
  })
171
178
  .into(),
@@ -181,6 +188,7 @@ impl ThreadWorker {
181
188
  receiver: &Arc<async_channel::Receiver<RequestJob>>,
182
189
  terminated: &Arc<AtomicBool>,
183
190
  waker_sender: &watch::Sender<TerminateWakerSignal>,
191
+ oob_gc_responses_threshold: Option<u64>,
184
192
  ) -> magnus::block::Proc {
185
193
  let leader = leader.clone();
186
194
  let receiver = receiver.clone();
@@ -244,10 +252,15 @@ impl ThreadWorker {
244
252
  }
245
253
 
246
254
  let yield_result = if receiver.is_empty() {
255
+ let should_gc = if let Some(oob_gc_threshold) = oob_gc_responses_threshold {
256
+ idle_counter = (idle_counter + 1) % oob_gc_threshold;
257
+ idle_counter == 0
258
+ } else {
259
+ false
260
+ };
247
261
  waker_sender.send(TerminateWakerSignal(false)).unwrap();
248
- idle_counter = (idle_counter + 1) % 100;
249
262
  call_with_gvl(|ruby| {
250
- if idle_counter == 0 {
263
+ if should_gc {
251
264
  ruby.gc_start();
252
265
  }
253
266
  scheduler.funcall::<_, _, Value>(*ID_BLOCK, (thread_current, None::<u8>))
@@ -265,6 +278,8 @@ impl ThreadWorker {
265
278
 
266
279
  #[instrument(skip_all, fields(thread_worker=id))]
267
280
  pub fn fiber_accept_loop(
281
+ server: Arc<Server>,
282
+
268
283
  id: String,
269
284
  app: Opaque<Value>,
270
285
  receiver: Arc<async_channel::Receiver<RequestJob>>,
@@ -274,10 +289,16 @@ impl ThreadWorker {
274
289
  let ruby = Ruby::get().unwrap();
275
290
  let (waker_sender, waker_receiver) = watch::channel(TerminateWakerSignal(false));
276
291
  let leader: Arc<Mutex<Option<RequestJob>>> = Arc::new(Mutex::new(None));
277
- let server = ruby.get_inner(&ITSI_SERVER);
278
- let scheduler_proc =
279
- Self::build_scheduler_proc(app, &leader, &receiver, &terminated, &waker_sender);
280
- let (scheduler, scheduler_fiber) = server.funcall::<_, _, (Value, Value)>(
292
+ let server_class = ruby.get_inner(&ITSI_SERVER);
293
+ let scheduler_proc = Self::build_scheduler_proc(
294
+ app,
295
+ &leader,
296
+ &receiver,
297
+ &terminated,
298
+ &waker_sender,
299
+ server.oob_gc_responses_threshold,
300
+ );
301
+ let (scheduler, scheduler_fiber) = server_class.funcall::<_, _, (Value, Value)>(
281
302
  "start_scheduler_loop",
282
303
  (scheduler_class, scheduler_proc),
283
304
  )?;
@@ -338,21 +359,31 @@ impl ThreadWorker {
338
359
 
339
360
  #[instrument(skip_all, fields(thread_worker=id))]
340
361
  pub fn accept_loop(
362
+ server: Arc<Server>,
341
363
  id: String,
342
364
  app: Opaque<Value>,
343
365
  receiver: Arc<async_channel::Receiver<RequestJob>>,
344
366
  terminated: Arc<AtomicBool>,
345
367
  ) {
346
368
  let ruby = Ruby::get().unwrap();
347
- let server = ruby.get_inner(&ITSI_SERVER);
369
+ let server_class = ruby.get_inner(&ITSI_SERVER);
370
+ let mut idle_counter = 0;
348
371
  call_without_gvl(|| loop {
372
+ if receiver.is_empty() {
373
+ if let Some(oob_gc_threshold) = server.oob_gc_responses_threshold {
374
+ idle_counter = (idle_counter + 1) % oob_gc_threshold;
375
+ if idle_counter == 0 {
376
+ ruby.gc_start();
377
+ }
378
+ };
379
+ }
349
380
  match receiver.recv_blocking() {
350
381
  Ok(RequestJob::ProcessRequest(request)) => {
351
382
  if terminated.load(Ordering::Relaxed) {
352
383
  break;
353
384
  }
354
385
  call_with_gvl(|_ruby| {
355
- request.process(&ruby, server, app).ok();
386
+ request.process(&ruby, server_class, app).ok();
356
387
  })
357
388
  }
358
389
  Ok(RequestJob::Shutdown) => {