itsf_services 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a107130b7ab2bb78b7d67cc18e8be8bcf8398bab
-  data.tar.gz: cb7585bc4d51edf185959e0ad24db3cc2e81b4a1
+  metadata.gz: 4d0d8490c215e149350517465ece1376541b5e3d
+  data.tar.gz: 03b483c2a0bc91a7864f507a4f6e522e715e10a3
 SHA512:
-  metadata.gz: 244bc213550b0db6f7ef9e026e34206409b221fdef68c6153ce27d1cdc98d514bd89a8ec506d6ea7f40e7de233474e88c28575401d71807437990199146d5dc0
-  data.tar.gz: 745ed006d51aec988758b2982fb4ee2752f0d06203d7d95081c8b3a383a64828491f35636194b702aa7e4ee5718f4ff5edfd129f2a91980336bfe72a19c96306
+  metadata.gz: 8cfb138860536f00b461749930b6b01c289373502313d6ae50378c8be8a73c492b864a52071343960ec0c48895dcd62e5ee01c06b1e2c3c99bbfbd8ec4038463
+  data.tar.gz: b103ca61ba97fe19abe09e258322972f75a4f0b5e64fd05393917260fe507e212f497c8f20f9a87e6d35c9c9bcd4919c2a96c604a49de2ec3e6c70767f7c1887

data/Rakefile

@@ -14,9 +14,4 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-
 Bundler::GemHelper.install_tasks
-
-
-
-task default: :test

data/config/routes.rb

@@ -1,2 +1,2 @@
 Itsf::Services::Engine.routes.draw do
-end
+end

data/lib/itsf/services/engine.rb

@@ -4,4 +4,4 @@ module Itsf
       isolate_namespace Itsf::Services
     end
   end
-end
+end

data/lib/itsf/services/v2/response/base.rb

@@ -9,19 +9,22 @@ module Itsf
           attr_writer :success
 
           def initialize
-            @errors  = ActiveModel::Errors.new(self)
-            # @success = false
+            @errors = ActiveModel::Errors.new(self)
           end
 
           def success?
             @errors.blank?
           end
 
+          def failed?
+            !success?
+          end
+
           def read_attribute_for_validation(attr)
             send(attr)
           end
 
-          def self.human_attribute_name(attr, options = {})
+          def self.human_attribute_name(attr, _options = {})
             attr
           end
 
@@ -31,11 +34,9 @@ module Itsf
 
           private
 
-          def errors=(errors)
-            @errors = errors
-          end
+          attr_writer :errors
         end
       end
     end
   end
-end
+end

data/lib/itsf/services/v2/service/base.rb

@@ -11,7 +11,7 @@ module Itsf
           def_delegator :@instrumenter, :instrument
           attr_accessor :instrumenter
           attr_reader :response
-          
+
           def self.i18n_scope
             'activerecord'
           end
@@ -22,21 +22,21 @@ module Itsf
 
           def initialize(attributes = {}, *args)
             options = args.extract_options!
-            options.reverse_merge!({ :instrumenter => ActiveSupport::Notifications })
+            options.reverse_merge!(instrumenter: ActiveSupport::Notifications)
 
-            @errors  = ActiveModel::Errors.new(self)
+            @errors = ActiveModel::Errors.new(self)
 
             initialize_instrumenter(options[:instrumenter])
             instrument('initialize.export_to_sap.payment.dzb') do
               initialize_attributes if respond_to?(:initialize_attributes)
-              set_attributes(attributes)
+              send_attributes(attributes)
               initialize_response
             end
           end
 
           private
 
-          def set_attributes(attributes)
+          def send_attributes(attributes)
             attributes.each do |name, value|
               send("#{name}=", value)
             end
@@ -70,4 +70,4 @@ module Itsf
       end
     end
   end
-end
+end

data/lib/itsf/services/version.rb

@@ -1,5 +1,5 @@
 module Itsf
   module Services
-    VERSION = "0.0.1"
+    VERSION = '0.0.2'
   end
 end

data/lib/itsf_services.rb

@@ -1,5 +1,5 @@
 require 'itsf/services/v2/service/base'
 require 'itsf/services/v2/response/base'
 
-require "itsf/services"
-require "itsf/services/engine"
+require 'itsf/services'
+require 'itsf/services/engine'

metadata

@@ -1,32 +1,46 @@
 --- !ruby/object:Gem::Specification
 name: itsf_services
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Roberto Vasquez Angel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-25 00:00:00.000000000 Z
+date: 2015-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Provides Service Objects with rich Responses.
 email:
-- roberto.vasquez@anwr-group.com
+- roberto@vasquez-angel.de
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -47,9 +61,6 @@ files:
 - lib/itsf/services/version.rb
 - lib/itsf_services.rb
 - lib/tasks/itsf/services_tasks.rake
-- test/integration/navigation_test.rb
-- test/itsf/services_test.rb
-- test/test_helper.rb
 homepage: https://github.com/robotex82/itsf_services
 licenses:
 - MIT
@@ -74,7 +85,5 @@ rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: ITSF Services Rails Engine.
-test_files:
-- test/integration/navigation_test.rb
-- test/itsf/services_test.rb
-- test/test_helper.rb
+test_files: []
+has_rdoc: 

data/test/integration/navigation_test.rb

@@ -1,10 +0,0 @@
-require 'test_helper'
-
-class NavigationTest < ActionDispatch::IntegrationTest
-  fixtures :all
-
-  # test "the truth" do
-  #   assert true
-  # end
-end
-

data/test/itsf/services_test.rb

@@ -1,7 +0,0 @@
-require 'test_helper'
-
-class Itsf::Services::Test < ActiveSupport::TestCase
-  test "truth" do
-    assert_kind_of Module, Itsf::Services
-  end
-end

data/test/test_helper.rb

@@ -1,20 +0,0 @@
-# Configure Rails Environment
-ENV["RAILS_ENV"] = "test"
-
-require File.expand_path("../..//config/environment.rb",  __FILE__)
-ActiveRecord::Migrator.migrations_paths = [File.expand_path("../..//db/migrate", __FILE__)]
-require "rails/test_help"
-
-# Filter out Minitest backtrace while allowing backtrace from other libraries
-# to be shown.
-Minitest.backtrace_filter = Minitest::BacktraceFilter.new
-
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
-# Load fixtures from the engine
-if ActiveSupport::TestCase.respond_to?(:fixture_path=)
-  ActiveSupport::TestCase.fixture_path = File.expand_path("../fixtures", __FILE__)
-  ActiveSupport::TestCase.file_fixture_path = ActiveSupport::TestCase.fixture_path + "files"
-  ActiveSupport::TestCase.fixtures :all
-end