item 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56ba445d6443100a1fedeeed36b40af7f525cddd
-  data.tar.gz: 7bddb796ba035f8fe3a0db15f71b91d5cd75013f
+  metadata.gz: 6636b67af901b2fb8d53f9b5e07ee473847c986f
+  data.tar.gz: 1fb525437828700232569ffd3669dc6598c91b4e
 SHA512:
-  metadata.gz: c90429c61712c3e2236ff13b7ef2fc6b67058d2496bfde65f95d80efba7523a88a03abe5e7bf05fccacd649dce9d122e4ea265739e592aa0e18f940a50ff3fa6
-  data.tar.gz: af169929858e6362b27093836eafd4c7fb0f864d198ec86851e8b04d5ad6851aa3ec61ec6ded8ecfb3ff7c7ab8327ec2535784b083f4aa672f55e25c5181dfc0
+  metadata.gz: 51c6516bc919592aa92f3788452d434f845da401967c1bc63ca13c330cdea911ea60a18b1d79f233350419d2e080fb282e43f933ce5e6993b4e4cca3be5c3774
+  data.tar.gz: 02de298d3b9174019921fe610f448221cad268333c81f09879cd0c635872f6423deea25bd9b270957adb1f4167efc14afdbb2846111e9d458440fde47ec32eb5

data/.gitignore

@@ -19,4 +19,4 @@ tmp
 *.so
 *.o
 *.a
-mkmf.log
+*.log

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+# Changelog
+
+### 0.0.3
+
+* Don't use `capture` in view helpers
+
+### 0.0.2
+
+* Require Rails >= 3.2.0 instead of 4.1
+
+### 0.0.1
+
+* Initial release

data/lib/item/version.rb

@@ -1,3 +1,3 @@
 module Item
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/item/view_helpers.rb

@@ -1,9 +1,7 @@
 module Item
   module ViewHelpers
     def scope(key, options = {}, &block)
-      content = capture(&block)
-      concat content_tag(:div, content, itemscope: "itemscope", itemtype: Util.itemtype(key))
-      nil
+      content_tag(:div, itemscope: "itemscope", itemtype: Util.itemtype(key), &block)
     end
 
     def prop(key, value = nil, options = {}, &block)
@@ -16,10 +14,8 @@ module Item
         itemprop = Util.itemprop(key)
 
         if block
-          value = capture(&block)
           itemtype = Util.itemtype(options[:type].presence || key)
-          concat content_tag(:div, value, itemprop: itemprop, itemscope: "itemscope", itemtype: itemtype)
-          nil
+          content_tag(:div, itemprop: itemprop, itemscope: "itemscope", itemtype: itemtype, &block)
         else
           content_tag(:span, value, itemprop: itemprop)
         end

data/test/view_helpers_test.rb

@@ -4,63 +4,59 @@ class ViewHelpersTest < ActionView::TestCase
   include Item::ViewHelpers
 
   test "scope" do
-    text = scope :aggregate_rating do
+    content = scope :aggregate_rating do
       "content"
     end
 
-    assert_nil text
     assert_equal %{<div itemscope="itemscope" itemtype="http://schema.org/AggregateRating">content</div>},
-                 output_buffer
+                 content
   end
 
   test "prop" do
-    concat prop(:aggregate_rating, "content")
+    content = prop(:aggregate_rating, "content")
 
     assert_equal %{<span itemprop="aggregateRating">content</span>},
-                 output_buffer
+                 content
   end
 
   test "hidden prop" do
-    concat prop(aggregate_rating: "Rating content", title: "Title content")
+    content = prop(aggregate_rating: "Rating content", title: "Title content")
 
     assert_equal %{<meta content="Rating content" itemprop="aggregateRating" />\n<meta content="Title content" itemprop="title" />},
-                 output_buffer
+                 content
   end
 
   test "link prop" do
-    concat prop(:availability, :in_stock)
+    content = prop(:availability, :in_stock)
 
     assert_equal %{<link href="http://schema.org/InStock" itemprop="availability" />},
-                 output_buffer
+                 content
   end
 
   test "prop block" do
-    text = prop :aggregate_rating do
+    content = prop :aggregate_rating do
       "content"
     end
 
-    assert_nil text
     assert_equal %{<div itemprop="aggregateRating" itemscope="itemscope" itemtype="http://schema.org/AggregateRating">content</div>},
-                 output_buffer
+                 content
   end
 
   test "prop block with type" do
-    text = prop :aggregate_rating, type: :other_type do
+    content = prop :aggregate_rating, type: :other_type do
       "content"
     end
 
-    assert_nil text
     assert_equal %{<div itemprop="aggregateRating" itemscope="itemscope" itemtype="http://schema.org/OtherType">content</div>},
-                 output_buffer
+                 content
   end
 
   test "combined" do
-    text = scope :product do
+    content = scope :product do
       concat prop(:title, "My Title")
     end
 
-    assert_nil text
     assert_equal %{<div itemscope="itemscope" itemtype="http://schema.org/Product"><span itemprop="title">My Title</span></div>},
-                 output_buffer
+                 content
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: item
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Lasse Bunk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-26 00:00:00.000000000 Z
+date: 2014-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -75,6 +75,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.html