itax_code 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e97e7183d8c6311ab15d58adef992c883882edb76045018da2497c10fb8c5bc5
-  data.tar.gz: 845c4e2e027f06335b3aff1e2f03f7af44a60590de9b065a4c0edca444825c13
+  metadata.gz: 15fec89c684546176ef2c266a3c2b896225ba46b3051798bda0fca1975f03f89
+  data.tar.gz: bc02a9d22d009daf6800cc616d1ce84827267eaa877bc6e7b591c0707b3eee08
 SHA512:
-  metadata.gz: e00f7799aebc8babd76844fda3e3f02dff0b4fd06eacb073243466d93356be682d0563f7c874b9b506958793bf8661b2a3135a2c06644cf84fdac0c6a25eb309
-  data.tar.gz: b78c6f9b881232b182a051d863246193df4353f77f78fcffa6acb7131a0df13cca3587b54d3351d95a32b5064d2163253c4100cd07483492af7aa4036ca35e40
+  metadata.gz: 5121195f517531b125f1b8cb94c8c45b071b557068d4875e67ab87b5425d57fd4c73374d3c833885c5d66da43cae1cd0d27c2598a420aa4c0e8b83cb0e91b92e
+  data.tar.gz: 3805ae947b4505220130467207f5d86808825722bc3c563021cd163986a8643c996e9bdf1c01fa9918c2e111868f7a2204508a3d9c299e50c195333a7668411a

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    itax_code (0.1.4)
+    itax_code (0.2.0)
       activesupport
 
 GEM
@@ -22,13 +22,13 @@ GEM
     minitest (5.14.4)
     mocha (1.13.0)
     parallel (1.21.0)
-    parser (3.0.2.0)
+    parser (3.0.3.0)
       ast (~> 2.4.1)
     rainbow (3.0.0)
     rake (13.0.6)
     regexp_parser (2.1.1)
     rexml (3.2.5)
-    rubocop (1.22.3)
+    rubocop (1.23.0)
       parallel (~> 1.10)
       parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
@@ -37,9 +37,9 @@ GEM
       rubocop-ast (>= 1.12.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.12.0)
+    rubocop-ast (1.13.0)
       parser (>= 3.0.1.1)
-    rubocop-minitest (0.15.2)
+    rubocop-minitest (0.17.0)
       rubocop (>= 0.90, < 2.0)
     rubocop-performance (1.12.0)
       rubocop (>= 1.7.0, < 2.0)
@@ -71,4 +71,4 @@ DEPENDENCIES
   simplecov
 
 BUNDLED WITH
-   2.1.4
+   2.2.28

data/README.md

@@ -29,9 +29,9 @@ Or install it yourself as:
 ItaxCode.encode(
   surname: "Rossi",
   name: "Mario",
-  gender: "M", # "M" or "F"
-  birthdate: "1980-1-1", # String, Time, Date or DateTime
-  birthplace: "Milano"
+  gender: "M", # M|F
+  birthdate: "1980-01-01", # String|Time|Date|DateTime
+  birthplace: "Milano" # Name(Milano)|code(F205)
 )
 ```
 
@@ -45,7 +45,7 @@ ItaxCode.decode("RSSMRA80A01F205X")
 # {
 #   code: "RSSMRA80A01F205X",
 #   gender: "M",
-#   birthdate: "1980-1-1",
+#   birthdate: "1980-01-01",
 #   birthplace: {
 #     code: "F205",
 #     province: "MI",
@@ -83,7 +83,7 @@ ItaxCode.valid?(
     surname: "Rossi",
     name: "Mario",
     gender: "M",
-    birthdate: "1980-1-1",
+    birthdate: "1980-01-01",
     birthplace: "Milano"
   }
 )

data/lib/itax_code/encoder.rb

@@ -10,9 +10,9 @@ module ItaxCode
   # @example
   #   ItaxCode::Encoder.new(
   #     surname: "Rossi",
-  #     name: "Matteo",
+  #     name: "Mario",
   #     gender: "M",
-  #     birthdate: "1990-08-23",
+  #     birthdate: "1980-01-01",
   #     birthplace: "Milano"
   #   ).encode
   #
@@ -24,15 +24,12 @@ module ItaxCode
       @surname    = data[:surname]
       @name       = data[:name]
       @gender     = data[:gender]&.upcase
-      @birthdate  = Date.parse(data[:birthdate].to_s)
+      @birthdate  = data[:birthdate].to_s
       @birthplace = data[:birthplace]
       @utils      = utils
+      validate_data_presence!
 
-      instance_variables.each do |ivar|
-        next if instance_variable_get(ivar).present?
-
-        raise MissingDataError, "missing #{ivar} value"
-      end
+      @birthdate = parse_birthdate!
     end
 
     # Computes the tax code from its components.
@@ -78,15 +75,30 @@ module ItaxCode
         "#{year}#{month}#{day}"
       end
 
-      def encode_birthplace(src = utils.cities, exit: false)
-        place = src.find do |item|
-          utils.slugged(birthplace) == utils.slugged(item["name"])
-        end
+      def encode_birthplace(src = utils.cities, stop: false)
+        lookup_key = birthplace.match?(/^\w{1}\d{3}$/) ? "code" : "name"
+        place_slug = utils.slugged(birthplace)
+        place_item = src.find { |i| place_slug == utils.slugged(i[lookup_key]) }
 
-        code = place.try(:[], "code")
+        code = place_item.try(:[], "code")
         return code if code.present?
+        raise MissingDataError, "no code found for #{birthplace}" if stop
+
+        encode_birthplace(utils.countries, stop: true)
+      end
+
+      def validate_data_presence!
+        instance_variables.each do |ivar|
+          next if instance_variable_get(ivar).present?
+
+          raise MissingDataError, "missing #{ivar} value"
+        end
+      end
 
-        exit || encode_birthplace(utils.countries, exit: true)
+      def parse_birthdate!
+        Date.parse(birthdate)
+      rescue StandardError
+        raise ArgumentError, "#{birthdate} is not a valid date"
       end
   end
 end

data/lib/itax_code/parser.rb

@@ -33,7 +33,7 @@ module ItaxCode
       {
         code: tax_code,
         gender: gender,
-        birthdate: [year, month, day].join("-"),
+        birthdate: Date.parse([year, month, day].join("-")).to_s,
         birthplace: birthplace,
         omocodes: Omocode.new(tax_code).list,
         raw: raw

data/lib/itax_code/version.rb

@@ -1,3 +1,3 @@
 module ItaxCode
-  VERSION = "0.1.4".freeze
+  VERSION = "0.2.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: itax_code
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - Matteo Rossi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-03 00:00:00.000000000 Z
+date: 2021-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport