itamae 1.10.0 → 1.12.5

data/spec/integration/ordinary_user_spec.rb

@@ -0,0 +1,108 @@
+require 'spec_helper'
+
+describe file('/tmp/remote_file') do
+  it { should be_file }
+  it { should be_owned_by "ordinary_san" }
+  it { should be_grouped_into "ordinary_san" }
+  its(:content) { should match(/Hello Itamae/) }
+end
+
+describe file('/tmp/remote_file_root') do
+  it { should be_file }
+  it { should be_owned_by "root" }
+  it { should be_grouped_into "root" }
+  its(:content) { should match(/Hello Itamae/) }
+end
+
+%w[/tmp/remote_file_another_ordinary /tmp/remote_file_another_ordinary_with_root].each do |path|
+  describe file(path) do
+    it { should be_file }
+    it { should be_owned_by "itamae" }
+    it { should be_grouped_into "itamae" }
+    its(:content) { should match(/Hello Itamae/) }
+  end
+end
+
+###
+
+describe file('/tmp/file') do
+  it { should be_file }
+  it { should be_owned_by "ordinary_san" }
+  it { should be_grouped_into "ordinary_san" }
+  its(:content) { should match(/Hello World/) }
+end
+
+describe file('/tmp/file_root') do
+  it { should be_file }
+  it { should be_owned_by "root" }
+  it { should be_grouped_into "root" }
+  its(:content) { should match(/Hello World/) }
+end
+
+%w[/tmp/file_another_ordinary /tmp/file_another_ordinary_with_root].each do |path|
+  describe file(path) do
+    it { should be_file }
+    it { should be_owned_by "itamae" }
+    it { should be_grouped_into "itamae" }
+    its(:content) { should match(/Hello World/) }
+  end
+end
+
+###
+
+describe file('/tmp/template') do
+  it { should be_file }
+  it { should be_owned_by "ordinary_san" }
+  it { should be_grouped_into "ordinary_san" }
+  its(:content) { should match(/Hello/) }
+  its(:content) { should match(/Good bye/) }
+  its(:content) { should match(/^total memory: \d+kB$/) }
+  its(:content) { should match(/^uninitialized node key: $/) }
+end
+
+describe file('/tmp/template_root') do
+  it { should be_file }
+  it { should be_owned_by "root" }
+  it { should be_grouped_into "root" }
+  its(:content) { should match(/Hello/) }
+  its(:content) { should match(/Good bye/) }
+  its(:content) { should match(/^total memory: \d+kB$/) }
+  its(:content) { should match(/^uninitialized node key: $/) }
+end
+
+%w[/tmp/template_another_ordinary /tmp/template_another_ordinary_with_root].each do |path|
+  describe file(path) do
+    it { should be_file }
+    it { should be_owned_by "itamae" }
+    it { should be_grouped_into "itamae" }
+    its(:content) { should match(/Hello/) }
+    its(:content) { should match(/Good bye/) }
+    its(:content) { should match(/^total memory: \d+kB$/) }
+    its(:content) { should match(/^uninitialized node key: $/) }
+  end
+end
+
+###
+
+describe file('/tmp/http_request.html') do
+  it { should be_file }
+  it { should be_owned_by "ordinary_san" }
+  it { should be_grouped_into "ordinary_san" }
+  its(:content) { should match(/"from":\s*"itamae"/) }
+end
+
+describe file('/tmp/http_request_root.html') do
+  it { should be_file }
+  it { should be_owned_by "root" }
+  it { should be_grouped_into "root" }
+  its(:content) { should match(/"from":\s*"itamae"/) }
+end
+
+%w[/tmp/http_request_another_ordinary.html /tmp/http_request_another_ordinary_with_root.html].each do |path|
+  describe file(path) do
+    it { should be_file }
+    it { should be_owned_by "itamae" }
+    it { should be_grouped_into "itamae" }
+    its(:content) { should match(/"from":\s*"itamae"/) }
+  end
+end

data/spec/integration/recipes/default.rb

@@ -45,10 +45,6 @@ package 'dstat' do
   action :install
 end
 
-package 'sl' do
-  version '3.03-17'
-end
-
 package 'resolvconf' do
   action :remove
 end
@@ -65,10 +61,6 @@ gem_package 'tzinfo' do
   version '1.2.2'
 end
 
-gem_package 'bundler' do
-  options ['--no-ri', '--no-rdoc']
-end
-
 gem_package 'rake' do
   version '11.1.0'
 end
@@ -218,46 +210,10 @@ http_request "/tmp/http_request_headers.html" do
   url "https://httpbin.org/get"
 end
 
-http_request "/tmp/http_request_redirect.html" do
-  redirect_limit 1
-  url "https://httpbin.org/redirect-to?url=https%3A%2F%2Fhttpbin.org%2Fget%3Ffrom%3Ditamae"
-end
-
-######
-
-service "cron" do
-  action :stop
-end
-
-execute "ps -C cron > /tmp/cron_stopped; true"
-
-service "cron" do
-  action :start
-end
-
-execute "ps -C cron > /tmp/cron_running; true"
-
-######
-
-package "nginx" do
-  options "--force-yes"
-end
-
-service "nginx" do
-  action [:enable, :start]
-end
-
-execute "test -f /etc/rc3.d/S20nginx" # test
-execute "test $(ps h -C nginx | wc -l) -gt 0" # test
-
-service "nginx" do
-  action [:disable, :stop]
-end
-
-execute "test ! -f /etc/rc3.d/S20nginx" # test
-execute "test $(ps h -C nginx | wc -l) -eq 0" # test
-
-######
+# http_request "/tmp/http_request_redirect.html" do
+#   redirect_limit 1
+#   url "https://httpbin.org/redirect-to?url=https%3A%2F%2Fhttpbin.org%2Fget%3Ffrom%3Ditamae"
+# end
 
 link "/tmp-link" do
   to "/tmp"
@@ -600,3 +556,9 @@ unless v1 == v2 && v2 == v3 && v1 =~ /\A\d+kB\z/
   raise "failed to fetch host inventory value (#{v1}, #{v2}, #{v3})"
 end
 
+include_recipe "toplevel_module"
+file "/tmp/toplevel_module" do
+  content ToplevelModule.helper
+end
+
+include_recipe "variables"

data/spec/integration/recipes/docker.rb

@@ -0,0 +1,44 @@
+package 'sl' do
+  version '3.03-17'
+end
+
+######
+
+gem_package 'ast' do
+  version '2.0.0'
+  options ['--no-ri', '--no-rdoc']
+end
+
+######
+
+service "cron" do
+  action :stop
+end
+
+execute "ps -C cron > /tmp/cron_stopped; true"
+
+service "cron" do
+  action :start
+end
+
+execute "ps -C cron > /tmp/cron_running; true"
+
+######
+
+package "nginx" do
+  options "--force-yes"
+end
+
+service "nginx" do
+  action [:enable, :start]
+end
+
+execute "test -f /etc/rc3.d/S20nginx" # test
+execute "test $(ps h -C nginx | wc -l) -gt 0" # test
+
+service "nginx" do
+  action [:disable, :stop]
+end
+
+execute "test ! -f /etc/rc3.d/S20nginx" # test
+execute "test $(ps h -C nginx | wc -l) -eq 0" # test

data/spec/integration/recipes/local.rb

@@ -0,0 +1,19 @@
+package 'sl'
+
+######
+
+gem_package 'ast' do
+  version '2.0.0'
+  options ['--no-document']
+end
+
+######
+
+# Docker backend raises an error with `user` option, so it tests only on `itamae local`.
+# After fix this error, please move this code and the spec to `default.rb`.
+file "/tmp/file_as_ordinary_user" do
+  content "Hello World"
+  user "itamae"
+  owner "itamae"
+  group "itamae"
+end

data/spec/integration/recipes/ordinary_user.rb

@@ -0,0 +1,109 @@
+remote_file "/tmp/remote_file" do
+  source "hello.txt"
+end
+
+remote_file "/tmp/remote_file_root" do
+  user 'root'
+  owner 'root'
+  group 'root'
+  source "hello.txt"
+end
+
+remote_file "/tmp/remote_file_another_ordinary" do
+  user 'itamae'
+  owner 'itamae'
+  group 'itamae'
+  source "hello.txt"
+end
+
+remote_file "/tmp/remote_file_another_ordinary_with_root" do
+  user 'root'
+  owner 'itamae'
+  group 'itamae'
+  source "hello.txt"
+end
+
+###
+
+file "/tmp/file" do
+  content "Hello World"
+end
+
+file "/tmp/file_root" do
+  user 'root'
+  owner 'root'
+  group 'root'
+  content 'Hello World'
+end
+
+file "/tmp/file_another_ordinary" do
+  user 'itamae'
+  owner 'itamae'
+  group 'itamae'
+  content 'Hello World'
+end
+
+file "/tmp/file_another_ordinary_with_root" do
+  user 'root'
+  owner 'itamae'
+  group 'itamae'
+  content 'Hello World'
+end
+
+###
+
+template "/tmp/template" do
+  source "hello.erb"
+  variables goodbye: "Good bye"
+end
+
+template "/tmp/template_root" do
+  user 'root'
+  owner 'root'
+  group 'root'
+  source "hello.erb"
+  variables goodbye: "Good bye"
+end
+
+template "/tmp/template_another_ordinary" do
+  user 'itamae'
+  owner 'itamae'
+  group 'itamae'
+  source "hello.erb"
+  variables goodbye: "Good bye"
+end
+
+template "/tmp/template_another_ordinary_with_root" do
+  user 'root'
+  owner 'itamae'
+  group 'itamae'
+  source "hello.erb"
+  variables goodbye: "Good bye"
+end
+
+###
+
+http_request "/tmp/http_request.html" do
+  url "https://httpbin.org/get?from=itamae"
+end
+
+http_request "/tmp/http_request_root.html" do
+  user 'root'
+  owner 'root'
+  group 'root'
+  url "https://httpbin.org/get?from=itamae"
+end
+
+http_request "/tmp/http_request_another_ordinary.html" do
+  user 'itamae'
+  owner 'itamae'
+  group 'itamae'
+  url "https://httpbin.org/get?from=itamae"
+end
+
+http_request "/tmp/http_request_another_ordinary_with_root.html" do
+  user 'root'
+  owner 'itamae'
+  group 'itamae'
+  url "https://httpbin.org/get?from=itamae"
+end

data/spec/integration/recipes/toplevel_module.rb

@@ -0,0 +1,6 @@
+# Testing you don't need to write `module ::ToplevelModule`
+module ToplevelModule
+  def self.helper
+    "helper"
+  end
+end

data/spec/integration/recipes/variables.rb

@@ -0,0 +1,14 @@
+node.reverse_merge!(
+  variables: {
+    lvars: binding.local_variables,
+    ivars: instance_variables,
+  }
+)
+
+file "/tmp/local_variables" do
+  content node[:variables][:lvars].to_s
+end
+
+file "/tmp/instance_variables" do
+  content node[:variables][:ivars].to_s
+end

data/spec/unit/lib/itamae/backend_spec.rb

@@ -17,38 +17,38 @@ module Itamae
 
       describe ".send_file" do
         context "the source file doesn't exist" do
-          subject { -> { itamae_backend.send_file("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "The file 'src' doesn't exist.") }
+          subject { itamae_backend.send_file("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "The file 'src' doesn't exist.") }
         end
 
         context "the source file exist, but it is not a regular file" do
           before { Dir.mkdir("src")  }
-          subject { -> { itamae_backend.send_file("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a file.") }
+          subject { itamae_backend.send_file("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a file.") }
         end
 
         context "the source file is a regular file" do
           before { FileUtils.touch("src")  }
-          subject { -> { itamae_backend.send_file("src", "dst") } }
+          subject { itamae_backend.send_file("src", "dst") }
           it { expect { subject }.not_to raise_error }
         end
       end
 
       describe ".send_directory" do
         context "the source directory doesn't exist" do
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "The directory 'src' doesn't exist.") }
+          subject { itamae_backend.send_directory("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "The directory 'src' doesn't exist.") }
         end
 
         context "the source directory exist, but it is not a directory" do
           before { FileUtils.touch("src")  }
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
-          it { expect(subject).to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a directory.") }
+          subject { itamae_backend.send_directory("src", "dst") }
+          it { expect{ subject }.to raise_error(Itamae::Backend::SourceNotExistError, "'src' is not a directory.") }
         end
 
         context "the source directory is a directory" do
           before { Dir.mkdir("src")  }
-          subject { -> { itamae_backend.send_directory("src", "dst") } }
+          subject { itamae_backend.send_directory("src", "dst") }
           it { expect { subject }.not_to raise_error }
         end
       end

data/tasks/integration_local_spec.rb

@@ -0,0 +1,117 @@
+desc 'Run all integration tests on `itamae local` command'
+task 'spec:integration:local' => ['spec:integration:local:main', 'spec:integration:local:ordinary_user']
+
+namespace 'spec:integration:local' do
+  desc 'Run main integration test with `itamae local`'
+  task 'main' do
+    if RUBY_DESCRIPTION.include?('dev')
+      $stderr.puts "This integration test is skipped with unreleased Ruby."
+      $stderr.puts "Use released Ruby to execute this integration test."
+      next
+    end
+
+    IntegrationLocalSpecRunner.new(
+      [
+        [
+          "spec/integration/recipes/default.rb",
+          "spec/integration/recipes/default2.rb",
+          "spec/integration/recipes/redefine.rb",
+          "spec/integration/recipes/local.rb",
+        ],
+        [
+          "--dry-run",
+          "spec/integration/recipes/dry_run.rb",
+        ],
+      ],
+      ['spec/integration/default_spec.rb']
+    ).run
+    
+  end
+
+  desc 'Run integration test for ordinary user with `itamae local`'
+  task 'ordinary_user' do
+    if RUBY_DESCRIPTION.include?('dev')
+      $stderr.puts "This integration test is skipped with unreleased Ruby."
+      $stderr.puts "Use released Ruby to execute this integration test."
+      next
+    end
+
+    runner = IntegrationLocalSpecRunner.new(
+      [
+        [
+          "--dry-run",
+          "spec/integration/recipes/ordinary_user.rb",
+        ],
+        [
+          "spec/integration/recipes/ordinary_user.rb"
+        ],
+      ],
+      ['spec/integration/ordinary_user_spec.rb'],
+      user: 'ordinary_san'
+    )
+    runner.docker_exec 'useradd', 'ordinary_san', '-p', '*'
+    runner.docker_exec 'useradd', 'itamae', '-p', '*', '--create-home'
+    runner.docker_exec 'sh', '-c', 'echo "ordinary_san ALL=(ALL:ALL) NOPASSWD: ALL" >> /etc/sudoers'
+    runner.run
+  end
+end
+
+class IntegrationLocalSpecRunner
+  CONTAINER_NAME = 'itamae'
+  include FileUtils
+
+  def initialize(suites, specs, ruby_version: RUBY_VERSION.split('.')[0..1].join('.'), user: nil)
+    @suites = suites
+    @specs = specs
+    @ruby_version = ruby_version
+    @user = user
+
+    docker_run
+    prepare
+  end
+
+  def run
+    provision
+    serverspec
+    clean_docker_container
+  end
+
+  def docker_run
+    mount_dir = Pathname(__dir__).join('../').to_s
+    sh 'docker', 'run', '--privileged', '-d', '--name', CONTAINER_NAME, '-v', "#{mount_dir}:/itamae", "ruby:#{@ruby_version}", 'sleep', '1d'
+  end
+
+  def prepare
+    docker_exec 'gem', 'install', 'bundler'
+    docker_exec 'bundle', 'install', options: %w[--workdir /itamae]
+    docker_exec 'apt-get', 'update', '-y'
+    docker_exec 'apt-get', 'install', 'locales', 'sudo', '-y'
+    docker_exec 'localedef', '-i', 'en_US', '-c', '-f', 'UTF-8', '-A', '/usr/share/locale/locale.alias', 'en_US.UTF-8'
+  end
+
+  def provision
+    @suites.each do |suite|
+      cmd = %W!bundle exec ruby -w bin/itamae local!
+      cmd << "-l" << (ENV['LOG_LEVEL'] || 'debug')
+      cmd << "-j" << "spec/integration/recipes/node.json"
+      cmd += suite
+
+      options = %w[--workdir /itamae]
+      options.push('--user',  @user) if @user
+      docker_exec(*cmd, options: options)
+    end
+  end
+
+  def serverspec
+    ENV['DOCKER_CONTAINER'] = CONTAINER_NAME
+    sh('bundle', 'exec', 'rspec', '-I', './spec/integration', *@specs)
+  end
+
+  def clean_docker_container
+    sh('docker', 'rm', '-f', CONTAINER_NAME)
+  end
+
+  def docker_exec(*cmd, options: [])
+    sh 'docker', 'exec', '--env', 'LANG=en_US.utf8', *options, CONTAINER_NAME, *cmd
+  end
+end