issue-db 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c7e786c1b79b72e6ef52d8347d5d647f5275c714fd72699fd187032034ee0aae
-  data.tar.gz: 6f18ea1176291ab1a6da20e90bc7e95d7ca3f727097c012a31bf3adb50faf1e3
+  metadata.gz: 6f4349ba13a8c9f2971aae3c557c6bcd8d0b1b3fc51ecb4a901e3db2a30538db
+  data.tar.gz: a59e1724a2f9068bd4596a311b051224ad48a8df158e0607f5dc51374f096033
 SHA512:
-  metadata.gz: 4379608b58b9cc396deeabfed41e01753e927792483000f3047e4c600eb0b2cf02e49ee53c3b8c34a7de494713899f9abc944013d344263961a20e13197a2cab
-  data.tar.gz: 11da329ed7e764483a38934d552ad87dddbec88b9be0136de249fa45d5519604b176b9a3fe2f33d5a13c61e37c64c1af374fc2e8cdbe774e45065bae28cf8d89
+  metadata.gz: e64935039edab751270a2fe8d924d32fff52035364baaa0a6455cf2fd0931fd4c51d39164b283435646c44cde628d3fb5cd98908673d8a1c0138a028855750d3
+  data.tar.gz: 28e242676837588f0dbadf5dc831569bc26e703d2533938daebe62e0eb45d59c3d243d8678d4f91dd03baeba371f40cc3272a4290d23af6b6bafd88aac8b2976

data/lib/issue_db/cache.rb

@@ -16,7 +16,13 @@ module Cache
     rescue StandardError => e
       retry_err_msg = "error search_issues() call: #{e.message}"
       @log.error(retry_err_msg)
-      raise retry_err_msg
+      raise StandardError, retry_err_msg
+    end
+
+    # Safety check to ensure search_response and items are not nil
+    if search_response.nil? || search_response.items.nil?
+      @log.error("search_issues returned nil response or nil items")
+      raise StandardError, "search_issues returned invalid response"
     end
 
     @log.debug("issue cache updated - cached #{search_response.total_count} issues")

data/lib/issue_db/database.rb

@@ -51,8 +51,11 @@ class Database
     # if we make it here, no existing issues were found so we can safely create one
     issue = @client.create_issue(@repo.full_name, key, body, { labels: @label })
 
-    # append the newly created issue to the issues cache
-    @issues << issue
+    # ensure the cache is initialized before appending and handle race conditions
+    current_issues = issues
+    if current_issues && !current_issues.include?(issue)
+      @issues << issue
+    end
 
     @log.debug("issue created: #{key}")
     return Record.new(issue)
@@ -89,7 +92,14 @@ class Database
     updated_issue = @client.update_issue(@repo.full_name, issue.number, key, body)
 
     # update the issue in the cache using the reference we have
-    @issues[@issues.index(issue)] = updated_issue
+    index = @issues.index(issue)
+    if index
+      @issues[index] = updated_issue
+    else
+      @log.warn("issue not found in cache during update: #{key}")
+      # Force a cache refresh to ensure consistency
+      update_issue_cache!
+    end
 
     @log.debug("issue updated: #{key}")
     return Record.new(updated_issue)
@@ -105,8 +115,15 @@ class Database
 
     deleted_issue = @client.close_issue(@repo.full_name, issue.number)
 
-    # remove the issue from the cache
-    @issues.delete(issue)
+    # update the issue in the cache using the reference we have
+    index = @issues.index(issue)
+    if index
+      @issues[index] = deleted_issue
+    else
+      @log.warn("issue not found in cache during delete: #{key}")
+      # Force a cache refresh to ensure consistency
+      update_issue_cache!
+    end
 
     # return the deleted issue as a Record object as it may contain useful data
     return Record.new(deleted_issue)
@@ -120,7 +137,10 @@ class Database
   # options = {include_closed: true}
   # keys = db.list_keys(options)
   def list_keys(options = {})
-    keys = issues.select do |issue|
+    current_issues = issues
+    return [] if current_issues.nil?
+
+    keys = current_issues.select do |issue|
       options[:include_closed] || issue[:state] == "open"
     end.map do |issue|
       issue[:title]
@@ -137,7 +157,10 @@ class Database
   # options = {include_closed: true}
   # records = db.list(options)
   def list(options = {})
-    records = issues.select do |issue|
+    current_issues = issues
+    return [] if current_issues.nil?
+
+    records = current_issues.select do |issue|
       options[:include_closed] || issue[:state] == "open"
     end.map do |issue|
       Record.new(issue)
@@ -187,9 +210,8 @@ class Database
     # update the issues cache if it is nil
     update_issue_cache! if @issues.nil?
 
-    # update the cache if it has expired
-    issues_cache_expired = (Time.now - @issues_last_updated) > @cache_expiry
-    if issues_cache_expired
+    # update the cache if it has expired (with nil safety)
+    if !@issues_last_updated.nil? && (Time.now - @issues_last_updated) > @cache_expiry
       @log.debug("issue cache expired - last updated: #{@issues_last_updated} - refreshing now")
       update_issue_cache!
     end

data/lib/issue_db/utils/github.rb

@@ -276,7 +276,10 @@ class GitHub
   # @param args [Array] The arguments passed to the method.
   # @param block [Proc] An optional block passed to the method.
   # @return [Object] The result of the method call on the Octokit client.
-  def method_missing(method, *args, &block)
+  def method_missing(method, *args, **kwargs, &block)
+    # Check if retry is explicitly disabled for this call
+    disable_retry = kwargs.delete(:disable_retry) || false
+
     # Determine the rate limit type based on the method name and arguments
     rate_limit_type = case method.to_s
                       when /search_/
@@ -296,10 +299,16 @@ class GitHub
 
     # Handle special case for search_issues which can hit secondary rate limits
     if method.to_s == "search_issues"
+      request_proc = proc do
+        wait_for_rate_limit!(rate_limit_type)
+        client.send(method, *args, **kwargs, &block) # rubocop:disable GitHub/AvoidObjectSendWithDynamicMethod
+      end
+
       begin
-        retry_request do
-          wait_for_rate_limit!(rate_limit_type)
-          client.send(method, *args, &block) # rubocop:disable GitHub/AvoidObjectSendWithDynamicMethod
+        if disable_retry
+          request_proc.call
+        else
+          retry_request(&request_proc)
         end
       rescue StandardError => e
         # re-raise the error but if its a secondary rate limit error, just sleep for a minute
@@ -311,9 +320,15 @@ class GitHub
       end
     else
       # For all other methods, use standard retry and rate limiting
-      retry_request do
+      request_proc = proc do
         wait_for_rate_limit!(rate_limit_type)
-        client.send(method, *args, &block) # rubocop:disable GitHub/AvoidObjectSendWithDynamicMethod
+        client.send(method, *args, **kwargs, &block) # rubocop:disable GitHub/AvoidObjectSendWithDynamicMethod
+      end
+
+      if disable_retry
+        request_proc.call
+      else
+        retry_request(&request_proc)
       end
     end
   end

data/lib/issue_db/utils/init.rb

@@ -9,10 +9,11 @@ module Init
         @repo.full_name,
         @label,
         "000000",
-        { description: "This issue is managed by the issue-db Ruby library. Please do not remove this label." }
+        { description: "This issue is managed by the issue-db Ruby library. Please do not remove this label." },
+        disable_retry: true
       )
     rescue StandardError => e
-      if e.message.include?("code: already_exists")
+      if e.message.include?("already_exists")
         @log.debug("label #{@label} already exists")
       else
         @log.error("error creating label: #{e.message}") unless ENV.fetch("ENV", nil) == "acceptance"

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Version
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: issue-db
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - runwaylab