isrc 1.0.0 → 1.0.1

data/isrc.gemspec

@@ -5,8 +5,7 @@ Gem::Specification.new do |g|
   g.authors       = ["Michael Bianco"]
   g.email         = ["info@cliffsidedev.com"]
   g.description   = "Pull ISRC codes from PPLK UK's database"
-  g.summary       = "Gem to pull ISRC codes from PPL UK's database. " + 
-                    "Match by artist and title."
+  g.summary       = "Pull ISRC codes from PPLK UK's database"
   g.homepage      = "http://github.com/iloveitaly/isrc"
 
   g.files         = `git ls-files`.split($\)

data/lib/isrc.rb

@@ -11,7 +11,7 @@ module ISRC
 
   class PPLUK
     def retrieve(opts)
-      puts "INFO #{opts[:artist]}:#{opts[:title]}"
+      # puts "INFO #{opts[:artist]}:#{opts[:title]}"
       agent = Mechanize.new
       agent.log = Logger.new "mech.log"
       agent.user_agent_alias = 'Mac Safari'
@@ -74,7 +74,7 @@ module ISRC
       end
 
       # creates an array representation of the table:
-      #   artist, title, isrc, released, time
+      #   artist, title, isrc, rights holder, released, time
       isrc_html = Nokogiri::HTML(isrc_search.body)
       @matches = isrc_html.css("table[id='T400335881332330323192:ars_form:searchResultsTable'] tbody tr").map do |m|
         columns = m.css('td')
@@ -110,7 +110,7 @@ module ISRC
         match_quality = []
 
         @matches.each do |song_match|
-          song_seconds = timestring_to_integer(song_match[4].match(/([0-9]:[0-9]{2})/)[1])
+          song_seconds = timestring_to_integer(song_match[5].match(/([0-9]:[0-9]{2})/)[1])
           match_quality << { :delta => (song_seconds - seconds).abs, :match => song_match }
         end
 

data/lib/isrc/version.rb

@@ -1,3 +1,3 @@
 module ISRC
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/spec/isrc_spec.rb

@@ -12,16 +12,22 @@ describe ISRC do
 
   it "should correctly handle a single search result" do
     isrc.retrieve artist: 'Coldplay', title: 'Glass'
-    isrc.match(time:'5:08')[:isrc].should == 'GBAYE0800410'    
+    isrc.match(time:'5:08')[:isrc].should == 'GBAYE0800410'
   end
 
-  it "should handle songs with multiple results" do
-    isrc.retrieve artist:'Soul II Soul', title: 'Back To Life (However Do You Want Me) (Club Mix)'
-    isrc.match(time:'7:39')[:isrc].should == 'GBAAA8900153'
+  context "should handle songs with multiple results" do
+    it "when the results have the same title and time code" do
+      isrc.retrieve artist:'Parade', title:'Louder'
+      isrc.match(time:'2:53')[:isrc].should == 'GBAHS1000333'      
+    end
 
-    # the better match seems to be: GB1209500610
-    # however, the length delta is huge
+    it "when there are multiple results, but all with different names" do
+      isrc.retrieve artist:'Soul II Soul', title: 'Back To Life (However Do You Want Me) (Club Mix)'
+      isrc.match(time:'7:39')[:isrc].should == 'GBAAA8900153'
 
+      # the better match seems to be: GB1209500610
+      # however, the length delta is huge
+    end
   end
 
   it "should handle songs with no results" do

metadata

@@ -1,96 +1,96 @@
 --- !ruby/object:Gem::Specification
 name: isrc
 version: !ruby/object:Gem::Version
-  version: 1.0.0
   prerelease: 
+  version: 1.0.1
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-18 00:00:00.000000000 Z
+date: 2013-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: httparty
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: nokogiri
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: mechanize
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: mechanize
   type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: rspec
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: guard
   type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
 description: Pull ISRC codes from PPLK UK's database
 email:
 - info@cliffsidedev.com
@@ -117,23 +117,23 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+  none: false
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
-summary: Gem to pull ISRC codes from PPL UK's database. Match by artist and title.
+summary: Pull ISRC codes from PPLK UK's database
 test_files:
 - spec/isrc_spec.rb
 - spec/spec_helper.rb