isomorfeus-transport 2.0.0.rc10 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d917e168e3e1a7202e735ae3b178ec1a47f5e9a2a9e9c988a275b3bb860b3f9
-  data.tar.gz: a0275946e81d79596e2531f1397fb0d615933692ee9f09897879da26bfeedeec
+  metadata.gz: 93245ae3a021e4b349684a57b655ac9a0d382aaf6dd0903ecbe780d1be636eb7
+  data.tar.gz: 7636567bb65d92cf8085ac320cb8fcc86c1cc990a49705583c9358408b95fa7c
 SHA512:
-  metadata.gz: ff815ba21a967ffbefdf5d4cab22f5e7fedd58b91b465c23aa7af8cdc6162d579064e5a9d2e1be69d27fd027bf7bcc390339c005ee9c69be98c932bc31df3cef
-  data.tar.gz: fbe065429e783ba90055a306377fe3d83bf795a747ec8321f3975646f1acb8dee9552019a71a28269473afd6996db8c1fd2fd998f73d749092e448e01e892e43
+  metadata.gz: 9aa80c35739e28cf78af788026f8cf3bf417ab54a6fc3d9019899e499bda6acd4862d4faedc902636e375bfee5f06dc89e5089f390134a0fea834d5cad022792
+  data.tar.gz: 0a6e0f1375ceed9327fdcb1cc0d489e11b4e250ba5e1ad629121604e24dd6ff90ca9348e26b631f2bbfd15620d430543aca85c3e2ec9a3e07cbe44711f07fddf

data/README.md

@@ -3,7 +3,7 @@
 Transport and PubSub for Isomorfeus.
 
 ### Community and Support
-At the [Isomorfeus Framework Project](http://isomorfeus.com) 
+At the [Isomorfeus Framework Project](http://isomorfeus.com)
 
 ## Installation
 isomorfeus-transport is usually installed with the installer.
@@ -23,5 +23,5 @@ Server only:
 
 ## Usage
 
-- [Authentication and Current User](https://github.com/isomorfeus/isomorfeus-project/blob/master/ruby/isomorfeus-transport/docs/authentication.md)
-- [Channels (PubSub)](https://github.com/isomorfeus/isomorfeus-project/blob/master/ruby/isomorfeus-transport/docs/channels.md)
+- [Authentication and Current User](https://github.com/isomorfeus/isomorfeus-project/blob/master/isomorfeus-transport/docs/authentication.md)
+- [Channels (PubSub)](https://github.com/isomorfeus/isomorfeus-project/blob/master/isomorfeus-transport/docs/channels.md)

data/lib/isomorfeus/transport/config.rb

@@ -30,6 +30,7 @@ module Isomorfeus
     add_client_option(:api_websocket_host)
     add_client_option(:api_websocket_port)
     add_client_option(:api_websocket_path)
+    add_client_option(:api_logout_path)
     add_client_option(:cookie_eater_path)
     add_client_option(:transport_init_class_names, [])
 
@@ -69,6 +70,7 @@ module Isomorfeus
       attr_accessor :api_websocket_host
       attr_accessor :api_websocket_port
       attr_accessor :api_websocket_path
+      attr_accessor :api_logout_path
       attr_accessor :cookie_eater_path
       attr_reader :session_store
 
@@ -168,8 +170,8 @@ module Isomorfeus
     end
 
     self.session_store_init do
-      store_path = File.expand_path(File.join(Isomorfeus.root, 'data', Isomorfeus.env), 'session_store')
-      Isomorfeus::Transport::HamsterSessionStore.new(store_path) # dont use this one, but we keep it here to have at least something
+      store_path = File.expand_path(File.join(Isomorfeus.root, 'data', Isomorfeus.env, 'session_store'))
+      Isomorfeus::Transport::HamsterSessionStore.new(store_path)
     end
   end
 
@@ -177,6 +179,6 @@ module Isomorfeus
   self.api_websocket_host = 'localhost'
   self.api_websocket_port = '3000'
   self.api_websocket_path = '/isomorfeus/api/websocket'
-
-  self.cookie_eater_path = '/isomorfeus/cookie/eat'
+  self.api_logout_path    = '/isomorfeus/api/logout'
+  self.cookie_eater_path  = '/isomorfeus/cookie/eat'
 end

data/lib/isomorfeus/transport/handler/authentication_handler.rb

@@ -6,8 +6,8 @@ module Isomorfeus
 
         on_request do |response_agent|
           # promise_send_path('Isomorfeus::Transport::Handler::AuthenticationHandler', 'login', user_class_name, user_identifier, user_password)
-          response_agent.request.each_key do |login_or_logout|
-            if login_or_logout == 'login'
+          response_agent.request.each_key do |login_or_ssr_login|
+            if login_or_ssr_login == 'login'
               response_agent.agent_result = { error: 'Authentication failed' }
               tries = pub_sub_client.instance_variable_get(:@isomorfeus_authentication_tries)
               tries = 0 unless tries
@@ -33,34 +33,19 @@ module Isomorfeus
                   session_id = SecureRandom.uuid
                   session_cookie = "session=#{session_id}; SameSite=Strict; HttpOnly; Path=/; Max-Age=2592000#{'; Secure' if Isomorfeus.production?}"
                   session_cookie_accessor = SecureRandom.uuid
-                  Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_user, user)
                   Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_authentication_tries, nil)
-                  Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_session_cookie, session_cookie)
                   Isomorfeus.session_store.add(session_id: session_id, cookie: session_cookie, user: user, accessor: session_cookie_accessor)
                   response_agent.agent_result = { success: 'ok', data: user.to_transport, session_cookie_accessor: session_cookie_accessor }
                 end
               end
-            elsif login_or_logout == 'ssr_login'
+            elsif login_or_ssr_login == 'ssr_login'
               response_agent.agent_result = { error: 'Authentication failed' }
               session_id = response_agent.request['ssr_login']
               user = Isomorfeus.session_store.get_user(session_id: session_id)
               if user
-                Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_user, user)
                 Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_authentication_tries, nil)
-                Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_session_cookie, nil)
                 response_agent.agent_result = { success: 'ok', data: user.to_transport }
               end
-            elsif login_or_logout == 'logout'
-              begin
-                # bogus
-                session_cookie = nil
-              ensure
-                Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_user, nil)
-                Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_authentication_tries, nil)
-                Isomorfeus.pub_sub_client.instance_variable_set(:@isomorfeus_session_cookie, nil)
-                Isomorfeus.session_store.remove(cookie: session_cookie)
-                response_agent.agent_result = { success: 'ok' }
-              end
             end
           end
         end

data/lib/isomorfeus/transport/rack_middleware.rb

@@ -9,10 +9,24 @@ module Isomorfeus
         @app = app
       end
 
+      def user_from_env(env)
+        cookies = env['HTTP_COOKIE']
+        if cookies
+          cookies = cookies.split('; ')
+          cookie = cookies.detect { |c| c.start_with?('session=') }
+          if cookie
+            session_id = cookie[8..-1]
+            user = Isomorfeus.session_store.get_user(session_id: session_id)
+            [user, session_id]
+          end
+        end
+      end
+
       def call(env)
         if env['PATH_INFO'] == Isomorfeus.api_websocket_path
           if env['rack.upgrade?'] == :websocket
-            env['rack.upgrade'] = Isomorfeus::Transport::ServerSocketProcessor.new
+            user, _session_id = user_from_env(env)
+            env['rack.upgrade'] = Isomorfeus::Transport::ServerSocketProcessor.new(user)
           end
           WS_RESPONSE
         elsif env['PATH_INFO'] == Isomorfeus.cookie_eater_path
@@ -27,20 +41,25 @@ module Isomorfeus
           else
             [404, {}, ["Must specify relative path!"]]
           end
-        else
-          cookies = env['HTTP_COOKIE']
-          if cookies
-            cookies = cookies.split('; ')
-            cookie = cookies.detect { |c| c.start_with?('session=') }
-            if cookie
-              session_id = cookie[8..-1]
-              user = Isomorfeus.session_store.get_user(session_id: session_id)
-              if user
-                Thread.current[:isomorfeus_user] = user
-                Thread.current[:isomorfeus_session_id] = session_id
-              end
+        elsif env['PATH_INFO'] == Isomorfeus.api_logout_path
+          user, session_id = user_from_env(env)
+          if user
+            begin
+              Isomorfeus.session_store.remove(session_id: session_id)
+              cookie = "session=#{session_id}; SameSite=Strict; HttpOnly; Path=/; expires=Thu, 01 Jan 1970 00:00:00 UTC#{'; Secure' if Isomorfeus.production?}"
+              return [302, { 'Location' => '/', 'Set-Cookie' => cookie }, ["Logged out!"]]
+            ensure
+              Thread.current[:isomorfeus_user] = nil
+              Thread.current[:isomorfeus_session_id] = nil
             end
           end
+          return [302, { 'Location' => '/', 'Set-Cookie' => cookie }, ["Tried to log out!"]]
+        else
+          user, session_id = user_from_env(env)
+          if user
+            Thread.current[:isomorfeus_user] = user
+            Thread.current[:isomorfeus_session_id] = session_id
+          end
           begin
             result = @app.call(env)
           ensure

data/lib/isomorfeus/transport/server_socket_processor.rb

@@ -3,6 +3,10 @@ module Isomorfeus
     class ServerSocketProcessor
       include Isomorfeus::Transport::ServerProcessor
 
+      def initialize(user)
+        @user = user
+      end
+
       def on_message(client, data)
         if Isomorfeus.development?
           write_lock = Isomorfeus.zeitwerk_lock.try_write_lock
@@ -45,9 +49,7 @@ module Isomorfeus
       end
 
       def user(client)
-        current_user = client.instance_variable_get(:@isomorfeus_user)
-        return current_user if current_user
-        Anonymous.new
+        @user ||= Anonymous.new
       end
     end
   end

data/lib/isomorfeus/transport/version.rb

@@ -1,5 +1,5 @@
 module Isomorfeus
   module Transport
-    VERSION = '2.0.0.rc10'
+    VERSION = '2.0.3'
   end
 end

data/lib/lucid_authentication/mixin.rb

@@ -60,12 +60,13 @@ module LucidAuthentication
       end
 
       def promise_deauthentication_with_isomorfeus
-        Isomorfeus::Transport.promise_send_path('Isomorfeus::Transport::Handler::AuthenticationHandler', 'logout', 'logout').then do |agent|
-          `document.cookie = "session="`
-          Isomorfeus.set_current_user(nil)
-          Isomorfeus.force_init_store!
-          agent.processed = true
-          agent.response.key?(:success) ? true : raise('Logout failed!')
+        cookie = `document.cookie`
+        p = Promise.new
+        begin
+          logout_query = Isomorfeus.api_logout_path
+          `window.location = logout_query`
+        rescue
+          p.reject
         end
       end
     else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isomorfeus-transport
 version: !ruby/object:Gem::Version
-  version: 2.0.0.rc10
+  version: 2.0.3
 platform: ruby
 authors:
 - Jan Biedermann
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-15 00:00:00.000000000 Z
+date: 2022-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.4
+        version: 0.14.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.14.4
+        version: 0.14.5
 - !ruby/object:Gem::Dependency
   name: isomorfeus-hamster
   requirement: !ruby/object:Gem::Requirement
@@ -114,28 +114,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.6.6
+        version: 10.6.11
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.6.6
+        version: 10.6.11
 - !ruby/object:Gem::Dependency
   name: isomorfeus-policy
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc10
+        version: 2.0.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc10
+        version: 2.0.3
 - !ruby/object:Gem::Dependency
   name: isomorfeus-redux
   requirement: !ruby/object:Gem::Requirement
@@ -170,14 +170,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc10
+        version: 2.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc10
+        version: 2.0.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -272,9 +272,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.3.3
 signing_key: