isomorfeus-preact 22.10.0.rc2 → 23.1.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed19ddda76f48b8c66af26970d4f7b4e1927b9061bf6ec9080dc40d5e51ff1cd
-  data.tar.gz: 97cc9fc63e4a06bb9a7d8dd6f7b2d90737f681935bc21f274870658c26e77e5d
+  metadata.gz: e85fc4bc0d60fef17a258c8258cd5504d99b2858ee72accca8c8379eae111250
+  data.tar.gz: 6d536d46743e666dba8b065b8dc65bd341335abcbdf20f909b41d675f3c28341
 SHA512:
-  metadata.gz: e39ee8b131d18503cb85f83b0a3750b32163661aa46d368933f06bf4d09b873c5d1a36a03b2c54c352956c49c785be245530fa65d4eeee2526c583ce6a2f33f2
-  data.tar.gz: 53961fada45da80ce23e4ef9f1ebbb5bbda85358e410c5cb70f00b5457f4ffff88d1605943bdbaba88c37aed574e1ea3d513f57e69347065b59c60f347104d4c
+  metadata.gz: 223fd1527f4cde895a172c2e4316494d6c60ab44e9a82594004a87406429c80b9b4c9071f1a2159594f4c9204dbddd73672ba2f1901c45fb491d6e168e6916aa
+  data.tar.gz: 1bc4550c3bd80124883658451a13388e43aaea6cafc50dbcabd8eda1c7a821fc71e048aa65974f0e04d498f31160cbeac101e0c93f246c0947c5d933e6f0f117

data/ext/isomorfeus_preact_ext/preact.c

@@ -20,6 +20,7 @@ static ID id_downcase;
 static ID id_encode_entities;
 static ID id_eqeq;
 static ID id_for;
+static ID id_freeze;
 static ID id_get_child_context;
 static ID id_get_derived_state_from_props;
 static ID id_gsub;
@@ -155,6 +156,7 @@ VALUE render_class_component(VALUE vnode, VALUE context) {
 
 	VALUE node_type = v->type;
   VALUE props = v->props;
+  VALUE state = rb_hash_new();
 
   // get context
 	VALUE cctx = get_context(node_type, context);
@@ -166,13 +168,16 @@ VALUE render_class_component(VALUE vnode, VALUE context) {
     if (rb_funcall(mIsomorfeus, id_development, 0) == Qtrue) { rb_funcall(node_type, id_validate_props, 1, props); }
   }
 
+  // freeze props
+  rb_funcall(props, id_freeze, 0);
+
   // instantiate component
   VALUE c = rb_funcall(node_type, id_new, 2, props, cctx);
 	v->component = c;
 
   // set state, props, context
   rb_ivar_set(c, iv_props, props);
-  if (rb_funcall(c, id_state, 0) == Qnil) { rb_ivar_set(c, iv_state, rb_hash_new()); }
+  if (rb_funcall(c, id_state, 0) == Qnil) { rb_ivar_set(c, iv_state, state); }
   if (rb_ivar_get(c, iv_next_state) == Qnil) { rb_ivar_set(c, iv_next_state, rb_funcall(c, id_state, 0)); }
   rb_ivar_set(c, iv_context, cctx);
 
@@ -183,6 +188,9 @@ VALUE render_class_component(VALUE vnode, VALUE context) {
     rb_ivar_set(c, iv_state, rb_funcall(state, id_merge, res));
   }
 
+  // freeze state
+  rb_funcall(rb_funcall(c, id_state, 0), id_freeze, 0);
+
   // render
 	return rb_funcall(c, id_render, 0);
 }
@@ -460,6 +468,7 @@ void Init_Preact(void) {
   id_gsub = rb_intern("gsub");
   id_html_for = rb_intern("html_for");
   id_for = rb_intern("for");
+  id_freeze = rb_intern("freeze");
   id_include = rb_intern("include?");
   id_is_a = rb_intern("is_a?");
   id_is_renderable = rb_intern("is_renderable?");

data/lib/browser/history.rb

@@ -27,7 +27,7 @@ module Browser
       end
 
       def state
-        ::Hash.new(`#@native.state`)
+        `Opal.hash(#@native.state)`
       end
     else
       def back; end

data/lib/isomorfeus/preact/version.rb

@@ -1,5 +1,5 @@
 module Isomorfeus
   module Preact
-    VERSION = '22.10.0.rc2'
+    VERSION = '23.1.0.rc1'
   end
 end

data/lib/isomorfeus/top_level.rb

@@ -28,7 +28,7 @@ module Isomorfeus
             end
           end
           if component
-            props = Hash.new(p.JS[:props])
+            props = `Opal.hash(p.props)`
             if init
               Isomorfeus::TopLevel.hydrated = p.JS[:hydrated]
               %x{
@@ -37,7 +37,7 @@ module Isomorfeus
                   var keys = Object.keys(state);
                   for(var i=0; i < keys.length; i++) {
                     if (Object.keys(state[keys[i]]).length > 0) {
-                      #{Isomorfeus.store.dispatch({ type: `keys[i].toUpperCase()`, set_state: Hash.new(`state[keys[i]]`) })}
+                      #{Isomorfeus.store.dispatch({ type: `keys[i].toUpperCase()`, set_state: Hash.recursive_new(`state[keys[i]]`) })}
                     }
                   }
                 }

data/lib/lucid_app.rb

@@ -10,7 +10,7 @@ class LucidApp < LucidComponent
         block_result = _internal_render(pr, &block)
         children = pr.pop
         if Preact.is_renderable?(block_result)
-          children.push(block_result)
+          children << block_result
         end
         Preact.create_element(LucidApplicationContext.Provider, state[:_app_ctx], children)
       end

data/lib/lucid_component.rb

@@ -11,7 +11,7 @@ class LucidComponent < Preact::Component
         pr = Preact.render_buffer
         block_result = _internal_render(pr, &block)
         if Preact.is_renderable?(block_result)
-          pr.pop.push(block_result)
+          pr.pop << block_result
         else
           pr.pop
         end
@@ -81,7 +81,7 @@ class LucidComponent < Preact::Component
   end
 
   def _internal_render(pr, &block)
-    pr.push([])
+    pr << []
     outer_loading = Isomorfeus.something_loading?
     ex = nil
     begin

data/lib/nano_css.rb

@@ -120,7 +120,7 @@ class NanoCSS
 
     decls.each do |prop, value|
       if value.is_a?(Hash) && !value.is_a?(Array)
-        postponed.push(prop)
+        postponed << prop
       else
         str += decl(prop, value)
       end
@@ -237,19 +237,19 @@ class NanoCSS
       if pos
         if parents.empty?
           replaced_selector = sel.gsub(/&/, parent)
-          result.push(replaced_selector)
+          result << replaced_selector
         else
           parents.each do |parent|
             replaced_selector = sel.gsub(/&/, parent)
-            result.push(replaced_selector)
+            result << replaced_selector
           end
         end
       else
         if parents.empty?
-          result.push(sel)
+          result << sel
         else
           parents.each do |parent|
-            result.push("#{parent} #{sel}")
+            result << "#{parent} #{sel}"
           end
         end
       end

data/lib/preact/component.rb

@@ -75,10 +75,10 @@ module Preact
       def render(&block)
         define_method(:render) do
           pr = Preact.render_buffer
-          pr.push([])
+          pr << []
           block_result = instance_exec(&block)
           if Preact.is_renderable?(block_result)
-            pr.pop.push(block_result)
+            pr.pop << block_result
           else
             pr.pop
           end
@@ -168,7 +168,7 @@ module Preact
         # is coming from. We need this because forceUpdate should never call
         # should_component_update
         @_force = true
-        @_renderCallbacks.push(block.to_n) if block_given?
+        @_renderCallbacks << block.to_n if block_given?
         Preact._enqueue_render(self)
       end
     end
@@ -190,7 +190,7 @@ module Preact
       end
 
       if @_vnode
-        @_renderCallbacks.push(block.to_n) if block_given?
+        @_renderCallbacks << block.to_n if block_given?
         Preact._enqueue_render(self)
       end
     end

data/lib/preact/component_resolution.rb

@@ -13,9 +13,16 @@ module Preact::ComponentResolution
         let sc = self.$class();
         // disable stack traces here for improved performance
         // if const cannot be found, the orignal method_mising will throw with stacktrace
-        Opal.config.enable_stack_trace = false
+        let orig_est = Opal.config.enable_stack_trace;
+        Opal.config.enable_stack_trace = false;
         try {
-          constant = sc.$const_get(component_name);
+          // disable the const cache for development, so that always the latest constant
+          // version is used to make hot reloading reliable
+          if (!Opal.Isomorfeus.development) {
+            if (!self.$$iso_preact_const_cache) { self.$$iso_preact_const_cache = {}; }
+            constant = self.$$iso_preact_const_cache[component_name];
+          }
+          if (!constant) { constant = sc.$const_get(component_name); }
         } catch(err) {
           let module_names;
           if (sc.$$full_name) { module_names = sc.$$full_name.split("::"); }
@@ -29,9 +36,12 @@ module Preact::ComponentResolution
             } catch(err) { }
           }
         } finally {
-          Opal.config.enable_stack_trace = true
+          Opal.config.enable_stack_trace = orig_est;
         }
         if (constant) {
+          if (!Opal.Isomorfeus.development && !self.$$iso_preact_const_cache[component_name]) {
+            self.$$iso_preact_const_cache[component_name] = constant;
+          }
           let last = args[args.length-1];
           #{`Opal.Preact`._render_element(`constant`, `(last === undefined || last === null) ? nil : last`, &block)};
           return nil;
@@ -48,21 +58,25 @@ module Preact::ComponentResolution
       # Further on it must check for modules, because const_get does not take
       # the full nesting into account
       constant = nil
-      if self.is_a?(Module)
-        constant = const_get(component_name) rescue nil
-      else
-        begin
-          constant = self.class.const_get(component_name)
-        rescue
-          module_names = self.class.to_s.split('::')
-          module_names.each_index do |i|
-            module_name = module_names[0..i].join('::')
-            constant = self.class.const_get(module_name).const_get(component_name, false) rescue nil
-            break if constant
-          end
+      begin
+        if !Isomorfeus.development?
+          @iso_preact_const_cache = {} unless @iso_preact_const_cache
+          constant = @iso_preact_const_cache[component_name]
+        end
+        constant = self.class.const_get(component_name) unless constant
+      rescue
+        module_names = self.class.to_s.split('::')
+        module_names.each_index do |i|
+          module_name = module_names[0..i].join('::')
+          constant = self.class.const_get(module_name).const_get(component_name, false) rescue nil
+          break if constant
         end
       end
+
       if constant
+        if !Isomorfeus.development? && @iso_preact_const_cache.key?(component_name)
+          @iso_preact_const_cache[component_name] = constant
+        end
         Preact._render_element(constant, args.last, &block)
         nil
       else

data/lib/preact/context.rb

@@ -43,7 +43,7 @@ module Preact
       end
 
       def sub(component)
-        @subs.push(component)
+        @subs << component
         component.provider_subs = @subs
       end
     end

data/lib/preact/html_elements.rb

@@ -52,7 +52,7 @@ module Preact::HtmlElements
   end
 
   def RPE(el)
-    Preact.render_buffer.last.push(el)
+    Preact.render_buffer.last << el
     nil
   end
 end

data/lib/preact/module_component_resolution.rb

@@ -17,6 +17,12 @@ class Module
           // if const cannot be found, the orignal method_mising will throw with stacktrace
           Opal.config.enable_stack_trace = false;
           try {
+            // disable the const cache for development, so that always the latest constant
+            // version is used to make hot reloading reliable
+            if (!Opal.Isomorfeus.development) {
+              if (!self.$$iso_preact_const_cache) { self.$$iso_preact_const_cache = {}; }
+              constant = self.$$iso_preact_const_cache[component_name];
+            }
             constant = self.$const_get(component_name);
           } catch(err) {
             // nothing
@@ -24,6 +30,9 @@ class Module
             Opal.config.enable_stack_trace = true;
           }
           if (constant) {
+            if (!Opal.Isomorfeus.development && !self.$$iso_preact_const_cache[component_name]) {
+              self.$$iso_preact_const_cache[component_name] = constant;
+            }
             let last = args[args.length-1];
             #{`Opal.Preact`._render_element(`constant`, `(last === undefined || last === null) ? nil : last`, &block)};
             return nil;
@@ -42,11 +51,19 @@ class Module
     def method_missing(component_name, *args, &block)
       # check for ruby component and render it
       # otherwise pass on method missing
-      component_name_s = component_name.to_s
-      c = component_name_s[0]
+      c = component_name.to_s[0]
       if c == c.upcase
-        constant = const_get(component_name) rescue nil
+        if !Isomorfeus.development?
+          @iso_preact_const_cache = {} unless @iso_preact_const_cache
+          constant = @iso_preact_const_cache[component_name]
+        end
+        unless constant
+          constant = const_get(component_name) rescue nil
+        end
         if constant && constant.ancestors.include?(Preact::Component)
+          if !Isomorfeus.development? && @iso_preact_const_cache.key?(component_name)
+            @iso_preact_const_cache[component_name] = constant
+          end
           Preact._render_element(constant, args.last, &block)
           return nil
         end

data/lib/preact.rb

@@ -650,7 +650,7 @@ module Preact
           // If excessDomChildren was not null, repopulate it with the current element's children:
           excessDomChildren = excessDomChildren && slice.call(dom.childNodes);
 
-          oldProps = oldVNode.props || Opal.Hash.$new();
+          oldProps = oldVNode.props || Opal.hash();
 
           let oldHtml = oldProps["$[]"]("dangerouslySetInnerHTML");
           let newHtml = newProps["$[]"]("dangerouslySetInnerHTML");
@@ -661,7 +661,7 @@ module Preact
             // But, if we are in a situation where we are using existing DOM (e.g. replaceNode)
             // we should read the existing DOM attributes to diff them
             if (excessDomChildren != null) {
-              oldProps = Opal.Hash.$new();
+              oldProps = Opal.hash();
               for (i = 0; i < dom.attributes.length; i++) {
                 oldProps["$[]="](dom.attributes[i].name, dom.attributes[i].value);
               }
@@ -797,13 +797,14 @@ module Preact
               // Instantiate the new component
               // validate props
               validate_props(newType, newProps);
-              // The check above verifies that newType is suppose to be constructed
+              newProps.$freeze();
+              // The check above verifies that newType is supposed to be constructed
               newVNode._component = c = newType.$new(newProps, componentContext);
 
               if (provider && provider !== nil) provider.$sub(c);
 
               c.props = newProps;
-              if (c.state === nil || !c.state) c.state = Opal.Hash.$new();
+              if (c.state === nil || !c.state) c.state = Opal.hash();
               c.context = componentContext;
               c._globalContext = globalContext;
               isNew = c._dirty = true;
@@ -811,11 +812,12 @@ module Preact
             }
 
             // Invoke get_derived_state_from_props
-            if (c._nextState === nil) {
+            if (!c._nextState || c._nextState === nil) {
               c._nextState = c.state;
             }
 
             if (!isNew) { validate_props(newType, newProps); }
+            newProps.$freeze();
             if (c["$respond_to?"]("get_derived_state_from_props")) {
               if (c._nextState == c.state) {
                 c._nextState = c._nextState.$dup();
@@ -825,6 +827,7 @@ module Preact
 
             oldProps = c.props;
             oldState = c.state;
+            c._nextState.$freeze();
 
             // Invoke pre-render lifecycle methods
             if (isNew) {
@@ -1007,7 +1010,6 @@ module Preact
           "$nil?": is_nil,
           "$$is_vnode": true
         };
-
         return vnode;
       }
 
@@ -1043,7 +1045,7 @@ module Preact
           // our custom `_children` property.
           vnode,
           ov ? oldVNode : EMPTY_OBJ,
-          Opal.Hash.$new(),
+          Opal.hash(),
           parentDom.ownerSVGElement !== undefined,
           nohy_reno ? [replaceNode] : ov ? null : parentDom.firstChild ? slice.call(parentDom.childNodes) : null,
           commitQueue,
@@ -1216,7 +1218,7 @@ module Preact
       end
 
       def _enqueue_render(c)
-        if ((`!c._dirty` && (`c._dirty = true`) && rerender_queue.push(c) && `!self.process._rerenderCount++`))
+        if ((`!c._dirty` && (`c._dirty = true`) && (rerender_queue << c) && `!self.process._rerenderCount++`))
           `setTimeout(self.process)`
         end
       end
@@ -1320,7 +1322,7 @@ module Preact
 
       def _render_element(element, props, &block)
         pr = Preact.render_buffer
-        pr[pr.length-1].push(create_element(element, props, nil, &block))
+        pr[pr.length-1] << create_element(element, props, nil, &block)
         nil
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isomorfeus-preact
 version: !ruby/object:Gem::Version
-  version: 22.10.0.rc2
+  version: 23.1.0.rc1
 platform: ruby
 authors:
 - Jan Biedermann
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-07 00:00:00.000000000 Z
+date: 2023-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oj
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.13.21
+        version: 3.13.23
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.13.21
+        version: 3.13.23
 - !ruby/object:Gem::Dependency
   name: opal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.7.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.7.0.rc1
 - !ruby/object:Gem::Dependency
   name: opal-activesupport
   requirement: !ruby/object:Gem::Requirement
@@ -52,48 +52,62 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.3.3
+- !ruby/object:Gem::Dependency
+  name: isomorfeus-asset-manager
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.16.2
 - !ruby/object:Gem::Dependency
   name: isomorfeus-i18n
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 22.10.0.rc2
+        version: 23.1.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 22.10.0.rc2
+        version: 23.1.0.rc1
 - !ruby/object:Gem::Dependency
   name: isomorfeus-redux
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 22.10.0.rc2
+        version: 23.1.0.rc1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 22.10.0.rc2
+        version: 23.1.0.rc1
 - !ruby/object:Gem::Dependency
   name: isomorfeus-puppetmaster
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: 0.8.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.8.1
+        version: 0.8.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -217,7 +231,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.4.0.dev
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: Preact Components for Isomorfeus.