isomorfeus-asset-manager 0.12.3 → 0.12.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f575fac540b8916e9bdb3c48d41b94ec54397e02825211f43b7f199babab387
-  data.tar.gz: daacbb919e74341f9a2d7a8403656c1c50854c934fae45e50aab444e07aeab3e
+  metadata.gz: 6f2bba888a2b50846a6384f6b5a04036b3e5e7e9e367f867b4cb23996ceb8ba1
+  data.tar.gz: 2ef547ce6fb466c561b1c4964d561c2c5612a2a641179b1dfdb33f555142f6b0
 SHA512:
-  metadata.gz: bd0528ded14edd3a7fdd0d8fbd92c7d52c0d9e68c14c6c4ca1637ca966cceec25f3220f98b963aab961b44383f4e73dac8b23db2f023ccb59f999094969e5881
-  data.tar.gz: 0f6524ae7a5210e36a83565cda386e32254c468fb24b83202bf038099578b159097e62d9daa1d513e71d346f5b5318deba4ccd634318cc92c5dddc4bacc33b89
+  metadata.gz: 5b65f19ea35eb669fc45e946afe44b7da36b75910d28b69c4f9fdd9657f23c446c0f22e5fb505bf78755537428f91dcddd391edd4d818f9cabc8b2b3ca115e68
+  data.tar.gz: 7acea3a93903a46f1d59ae45f83617c619812836015c58bbbab9b7ebf1e24c21708b013021eb1898ab9cfcdafaf991ae0f821db6dddbd256097a170118a0a133

data/lib/isomorfeus/asset_manager/asset.rb

@@ -63,6 +63,31 @@ module Isomorfeus
         end
         js << "\n" if !@js_imports.empty? && !@ruby_imports.empty?
         unless @ruby_imports.empty?
+          if Isomorfeus.development? && @target == :browser
+            js << <<~JAVASCRIPT
+            // Isomorfeus Asset Manager HMR code begin
+            let ws_protocol = (window.location.protocol == 'https:') ? 'wss:' : 'ws:';
+            let ws_url = ws_protocol + '//' + window.location.host + "#{Isomorfeus.assets_websocket_path}";
+            let hmr_ws = new WebSocket(ws_url);
+            hmr_ws.onmessage = function(event) {
+              let update = JSON.parse(event.data);
+              if (typeof update.error !== 'undefined') { console.error(update.error); return; }
+              let start_index = '/* Generated by Opal 1.2.0 */\\nOpal.modules[\\"'.length;
+              let end_index = update.javascript.indexOf('"', start_index);
+              let opal_module_name = update.javascript.substr(start_index, end_index - start_index);
+              console.log('Updating ', opal_module_name);
+              if (typeof Opal !== 'undefined' && typeof Opal.require_table !== "undefined" && Opal.require_table['corelib/module']) {
+                try {
+                  eval(update.javascript);
+                  if (Opal.require_table[opal_module_name]) { Opal.load.call(Opal, opal_module_name); } 
+                  else { Opal.require.call(Opal, opal_module_name); }
+                  Opal.Isomorfeus.$force_render();
+                } catch (e) { console.error(e); return; }
+              }
+            }
+            // Isomorfeus Asset Manager HMR code end
+            JAVASCRIPT
+          end
           js << "#{@ruby_imports.map(&:to_s).join("\n")}"
         end
         js

data/lib/isomorfeus/asset_manager/config.rb

@@ -1,18 +1,20 @@
 module Isomorfeus
   # available settings
   if RUBY_ENGINE == 'opal'
-    add_client_option(:assets_websocket_path)
     add_client_option(:assets_path)
-    add_client_option(:opal_assets_path)
   else
     class << self
       attr_reader :env
       attr_accessor :root
       attr_accessor :app_root
       attr_accessor :assets_path
+      attr_accessor :assets_websocket_path 
       attr_accessor :asset_manager_tmpdir
+      attr_accessor :asset_manager_hmr_channel
+      attr_accessor :asset_manager_hmr_dirs
       attr_accessor :node_paths
       attr_accessor :assets
+      attr_accessor :hmr_listener
 
       def add_web_js_import(*args)
         Isomorfeus.assets['web.js'].add_js_import(*args)
@@ -62,6 +64,10 @@ module Isomorfeus
     end
   end
 
+  self.hmr_listener = nil
+  self.asset_manager_hmr_channel = :isomorfeus_asset_manager_module_updates
+  self.asset_manager_hmr_dirs = %w[channels, components, data, operations, policies]
+  self.assets_websocket_path = '/_assets_websocket'
   self.assets_path = '/assets'
   self.assets = {
     'web.js' => Isomorfeus::AssetManager::Asset.new(:browser),

data/lib/isomorfeus/asset_manager/rack_middleware.rb

@@ -3,10 +3,11 @@
 module Isomorfeus
   class AssetManager
     class RackMiddleware
-      WS_RESPONSE = [0, {}, []]
+      WS_RESPONSE = [0, {}, []].freeze
       attr_reader :asset_manager
 
       def initialize(app)
+        STDERR.puts "asset manager"
         @app = app
         @asset_manager = Isomorfeus::AssetManager.new
         @compressible_types = %w[application/javascript text/javascript]
@@ -17,67 +18,70 @@ module Isomorfeus
           @assets_path = Isomorfeus.assets_path + '/'
           @assets_path_size = @assets_path.size
         end
+      rescue Exception => e
+        STDERR.puts "#{e.message}\n#{e.backtrace.join("\n")}\n"
       end
 
       def call(env)
-        begin
-          path_info = env['PATH_INFO']
-          if path_info.start_with?(@assets_path)
-            asset_key = path_info[@assets_path_size..-1]
+        path_info = env['PATH_INFO']
+        if path_info.start_with?(@assets_path)
+          asset_key = path_info[@assets_path_size..-1]
 
-            # get js
-            if Isomorfeus.assets.has_key?(asset_key)
-              asset = Isomorfeus.assets[asset_key]
-              if asset && asset.target != :node
-                asset_manager.transition(asset_key, asset)
-                headers = {}
-                headers['Last-Modified'] = asset.mtime
-                headers[Rack::CONTENT_TYPE] = 'application/javascript'
-                if should_gzip?(env)
-                  headers['Content-Encoding'] = "gzip"
-                  headers[Rack::CONTENT_LENGTH] = asset.bundle_gz_size
-                  return [200, headers, asset.bundle_gz]
-                else
-                  headers[Rack::CONTENT_LENGTH] = asset.bundle_size
-                  return [200, {}, asset.bundle]
-                end              
-              end
-            
-            # get source map
-            elsif asset_key.end_with?('.js.map')
-              asset = Isomorfeus.assets[asset_key[0..-5]]
-              if asset && asset.target != :node
-                asset_manager.transition(asset_key, asset) unless asset.bundled?
-                headers = {}
-                headers['Last-Modified'] = asset.mtime
-                headers[Rack::CONTENT_TYPE] = 'application/json'
-                if should_gzip?(env)
-                  headers['Content-Encoding'] = "gzip"
-                  headers[Rack::CONTENT_LENGTH] = asset.bundle_map_gz.size
-                  return [200, headers, asset.bundle_map_gz]
-                else
-                  headers[Rack::CONTENT_LENGTH] = asset.bundle_map.size
-                  return [200, {}, asset.bundle_map]
-                end 
-              end
+          # get js
+          if Isomorfeus.assets.key?(asset_key)
+            asset = Isomorfeus.assets[asset_key]
+            if asset && asset.target != :node
+              asset_manager.transition(asset_key, asset)
+              headers = {}
+              headers['Last-Modified'] = asset.mtime
+              headers[Rack::CONTENT_TYPE] = 'application/javascript'
+              if should_gzip?(env)
+                headers['Content-Encoding'] = "gzip"
+                headers[Rack::CONTENT_LENGTH] = asset.bundle_gz_size
+                return [200, headers, asset.bundle_gz]
+              else
+                headers[Rack::CONTENT_LENGTH] = asset.bundle_size
+                return [200, {}, asset.bundle]
+              end              
             end
-            # elsif Isomorfeus.development? && path_info == Isomorfeus.api_asset_hmr_socket_path
-            #   if env['rack.upgrade?'] == :websocket
-            #     env['rack.upgrade'] = Isomorfeus::AssetManager::ServerSocketProcessor.new
-            #   end
-            #   WS_RESPONSE
+          
+          # get source map
+          elsif asset_key.end_with?('.js.map')
+            asset = Isomorfeus.assets[asset_key[0..-5]]
+            if asset && asset.target != :node
+              asset_manager.transition(asset_key, asset) unless asset.bundled?
+              headers = {}
+              headers['Last-Modified'] = asset.mtime
+              headers[Rack::CONTENT_TYPE] = 'application/json'
+              if should_gzip?(env)
+                headers['Content-Encoding'] = "gzip"
+                headers[Rack::CONTENT_LENGTH] = asset.bundle_map_gz.size
+                return [200, headers, asset.bundle_map_gz]
+              else
+                headers[Rack::CONTENT_LENGTH] = asset.bundle_map.size
+                return [200, {}, asset.bundle_map]
+              end 
+            end
+          end
+
+        # hot reloading subscription
+        elsif Isomorfeus.development? && path_info == Isomorfeus.assets_websocket_path
+          if env['rack.upgrade?'] == :websocket
+            env['rack.upgrade'] = Isomorfeus::AssetManager::ServerSocketProcessor.new
           end
-        rescue Exception => e
-          STDERR.puts "#{e}\n#{e.backtrace.join("\n")}"
+          WS_RESPONSE
+        else
           @app.call(env)
         end
+      rescue Exception => e
+        STDERR.puts "#{e.message}\n#{e.backtrace.join("\n")}\n"
         @app.call(env)
       end
 
       def should_gzip?(env)
-        return true if env.has_key?('HTTP_ACCEPT_ENCODING') && env['HTTP_ACCEPT_ENCODING'].match?(/\bgzip\b/)
+        return true if env.key?('HTTP_ACCEPT_ENCODING') && env['HTTP_ACCEPT_ENCODING'].match?(/\bgzip\b/)
         return false if /\bno-transform\b/.match?(env[Rack::CACHE_CONTROL].to_s) || env['Content-Encoding']&.!~(/\bidentity\b/)
-        return false if @compressible_types && !(env.has_key?(Rack::CONTENT_TYPE) && @compressible_types.include?(env[Rack::CONTENT_TYPE][/[^;]*/]))
+        return false if @compressible_types && !(env.key?(Rack::CONTENT_TYPE) && @compressible_types.include?(env[Rack::CONTENT_TYPE][/[^;]*/]))
         true
       end
     end

data/lib/isomorfeus/asset_manager/server_socket_processor.rb

@@ -1,55 +1,21 @@
-module Isomorfeus
-  class AssetManager
-    class ServerSocketProcessor
-      # include Isomorfeus::Transport::ServerProcessor
-
-      # def on_message(client, data)
-      #   # TODO
-      #   if Isomorfeus.development?
-      #     write_lock = Isomorfeus.zeitwerk_lock.try_write_lock
-      #     if write_lock
-      #       Isomorfeus.zeitwerk.reload
-      #       Isomorfeus.zeitwerk_lock.release_write_lock
-      #     end
-      #     Isomorfeus.zeitwerk_lock.acquire_read_lock
-      #   end
-      #   request_hash = Oj.load(data, mode: :strict)
-      #   handler_instance_cache = {}
-      #   response_agent_array = []
-      #   Thread.current[:isomorfeus_user] = user(client)
-      #   Thread.current[:isomorfeus_pub_sub_client] = client
-      #   process_request(request_hash, handler_instance_cache, response_agent_array)
-      #   handler_instance_cache.each_value do |handler|
-      #     handler.resolve if handler.resolving?
-      #   end
-      #   result = {}
-      #   response_agent_array.each do |response_agent|
-      #     result.deep_merge!(response_agent.result)
-      #   end
-      #   client.write Oj.dump(result, mode: :strict) unless result.empty?
-      # ensure
-      #   Thread.current[:isomorfeus_user] = nil
-      #   Thread.current[:isomorfeus_pub_sub_client] = nil
-      #   Isomorfeus.zeitwerk_lock.release_read_lock if Isomorfeus.development?
-      # end
-
-      # def on_close(client)
-      #   # nothing for now
-      # end
-
-      # def on_open(client)
-      #   # nothing for now
-      # end
-
-      # def on_shutdown(client)
-      #   # nothing for now
-      # end
-
-      # def user(client)
-      #   current_user = client.instance_variable_get(:@isomorfeus_user)
-      #   return current_user if current_user
-      #   Anonymous.new
-      # end
-    end
-  end
-end
+module Isomorfeus
+  class AssetManager
+    class ServerSocketProcessor
+      def on_message(client, data)
+        # nothing for now
+      end
+
+      def on_close(client)
+        # client.unsubscribe Isomorfeus.asset_manager_hmr_channel
+      end
+
+      def on_open(client)
+        client.subscribe Isomorfeus.asset_manager_hmr_channel
+      end
+
+      def on_shutdown(client)
+        # nothing for now
+      end
+    end
+  end
+end

data/lib/isomorfeus/asset_manager/version.rb

@@ -1,5 +1,5 @@
 module Isomorfeus
   class AssetManager
-    VERSION = '0.12.3'
+    VERSION = '0.12.7'
   end
 end

data/lib/isomorfeus/asset_manager.rb

@@ -8,6 +8,7 @@ module Isomorfeus
       @output_path = File.join(@tmpdir, 'output')
       FileUtils.mkdir_p(@imports_path)
       FileUtils.mkdir_p(@output_path)
+      @server_path = File.join(Isomorfeus.app_root, 'server')
 
       @context = ExecJS.permissive_compile(init_js)
 
@@ -20,16 +21,18 @@ module Isomorfeus
         ssr_imports_file = File.join(imports_path, 'ssr.js')
         Isomorfeus.add_ssr_js_import(ssr_imports_file) if File.exist?(ssr_imports_file)
       end
+
+      init_hmr_listener if Isomorfeus.development? && !Isomorfeus.hmr_listener
     end
   
-    def transition(asset_key, asset)
+    def transition(asset_key, asset, analyze: false)
       return if !Isomorfeus.development? && asset.bundled?
       asset.mutex.synchronize do
         return if !Isomorfeus.development? && asset.bundled?
         asset.touch
-        compile_ruby_and_save(asset_key, asset)
+        build_ruby_and_save(asset_key, asset)
         save_imports(asset_key, asset)
-        run_esbuild(asset_key, asset)
+        run_esbuild(asset_key, asset, analyze)
         asset.bundle = bundled_asset(asset_key)
         asset.bundle_map = bundled_asset_map(asset_key) unless Isomorfeus.production?
       end
@@ -49,12 +52,12 @@ module Isomorfeus
       File.write(File.join(@imports_path, asset_key), asset.to_s)
     end
 
-    def compile_ruby_and_save(asset_key, asset)
+    def build_ruby_and_save(asset_key, asset)
       asset.ruby_imports.each do |ruby_import|
         out_file = File.join(@imports_path, ruby_import.module_name + '.js')
         next if !Isomorfeus.development? && File.exist?(out_file)
         js_map_path = File.join(@imports_path, ruby_import.module_name + '.js.map')
-        result = Opal::Builder.build(ruby_import.resolved_path, { es6_wrap: true })
+        result = Opal::Builder.build(ruby_import.resolved_path, { esm: true })
         FileUtils.mkdir_p(File.join(*[@imports_path].concat(ruby_import.module_name.split('/')[0...-1]))) if ruby_import.module_name.include?('/')
         js = result.to_s
         unless Isomorfeus.production?
@@ -65,6 +68,13 @@ module Isomorfeus
       end
     end
 
+    def compile_ruby(file)
+      source = File.read(file)
+      module_file = file[(Isomorfeus.app_root.size + 1)..-1]
+      compiler = Opal::Compiler.new(source, requirable: true, file: module_file)
+      { javascript: compiler.compile }
+    end
+
     def print_message(m, level)
       l = m['location']
       STDERR.puts "#{l['file']}:#{l['line']}:#{l['column']}: #{level}: #{m['text']}"
@@ -72,17 +82,6 @@ module Isomorfeus
     end
 
     def handle_errors(asset_key, result)
-      # Todo simplify
-      unless result['warnings'].empty?
-        result['warnings'].each do |w|
-          print_message(w, 'warning')
-          unless w['notes'].empty?
-            w['notes'].each do |n|
-              print_message(n, 'note')
-            end
-          end
-        end
-      end
       unless result['errors'].empty?
         result['errors'].each do |e|
           print_message(w, 'error')
@@ -92,7 +91,7 @@ module Isomorfeus
             end
           end
         end
-        raise "Aseet Manager: error bundling '#{asset_key}'" 
+        raise "Asset Manager: error bundling '#{asset_key}'" 
       end
     end
 
@@ -109,23 +108,52 @@ module Isomorfeus
       JAVASCRIPT
     end
 
+    def init_hmr_listener
+      return unless Dir.exist?(Isomorfeus.app_root)
+      listen_dirs = []
+      Isomorfeus.asset_manager_hmr_dirs.each do |dir|
+        if File.absolute_path?(dir)
+          listen_dirs << dir if Dir.exist?(dir)
+        else
+          listen_dir = File.join(Isomorfeus.app_root, dir)
+          listen_dirs << listen_dir if Dir.exist?(listen_dir)
+        end
+      end
+      Isomorfeus.hmr_listener = Listen.to(*listen_dirs) do |modified, added, _|
+        (modified + added).each do |file|
+          next if file.start_with?(@server_path)
+          begin
+            update = compile_ruby(file)
+            update_json = Oj.dump(update, mode: :strict)
+            Iodine.publish(Isomorfeus.asset_manager_hmr_channel, update_json)
+          rescue Exception => e
+            message = "#{e.message}\n#{e.backtrace.join("\n")}"
+            STDERR.puts message
+            Iodine.publish(Isomorfeus.asset_manager_hmr_channel, Oj.dump({ error: message }, mode: :struct))
+          end
+        end
+      end
+      Isomorfeus.hmr_listener.start
+    end
+
     # possible future improvement
     # loader: {
     #   '.png': 'dataurl',
     #   '.svg': 'text',
     # },
-    def run_esbuild(asset_key, asset)
+    def run_esbuild(asset_key, asset, analyze = false)
       resolve_paths = ENV['NODE_PATH'].split(Gem.win_platform? ? ';' : ':')
       resolve_paths << 'node_modules'
       resolve_paths.uniq!
 
       result = @context.exec <<~JAVASCRIPT
-      return esbuild.buildSync({
+      let res = esbuild.buildSync({
         entryPoints: [path.resolve(global.imports_path, '#{asset_key}')],
         bundle: true,
         color: false,
         format: '#{asset.target == :node ? 'cjs' : 'iife'}',
         legalComments: 'linked',
+        metafile: true,
         minify: #{Isomorfeus.production? ? 'true' : 'false'},
         nodePaths: #{resolve_paths},
         outdir: global.output_path,
@@ -136,7 +164,15 @@ module Isomorfeus
         target: 'es6',
         write: true
       });
+      global.res_meta = res.metafile;
+      return res;
       JAVASCRIPT
+      if analyze
+        analysis = @context.await <<~JAVASCRIPT
+        esbuild.analyzeMetafile(global.res_meta, { verbose: true });
+        JAVASCRIPT
+        STDOUT.puts "Bundle analysis for #{asset_key}:\n#{analysis}\n"
+      end
       handle_errors(asset_key, result)
     end
   end