isodoc 3.4.1 → 3.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18d33859f89e36a66412218c04370f02c727fe131dd91b73fd3671ab25cf228f
-  data.tar.gz: cc2996c38878a5acacf24932cf2719a1bef922cea11cf5c26411172e9a93032a
+  metadata.gz: ab9b39e8179c40594c9f9665530cbbd6e5138379bd61e6b15799770a33032738
+  data.tar.gz: 6f3c2bd190862970a129ba9156c67dc4fc2610a90f1d561b8d057258c9f09420
 SHA512:
-  metadata.gz: dde602b7132920dff5599dc3da2bb0de9ef027f5b3dd703fadc190adec9fab8e26901798bc208d3b3d279b57c5d19fa7ccbe885c37591da875e79f8dd5c364d4
-  data.tar.gz: 8d67a2d2518105cf854c7bb7f21a841de922785b0c77060e6002e6023c8de2b14efb8a9cbea25d140101183349b4b346287332eeb230b0c33aa5e0db3dcb3321
+  metadata.gz: 5d3f6c2eaaed487ae2c6921fb5ba4adcb52dd44c979e95a599532a0c3ebedf5471c25db030597cdf6dbac5f8eb1f17c0a51c1a9b608e5951226aa5098286b2d5
+  data.tar.gz: 51cc8feda89a2c3660723681bfe774cc17a926a8326be96466397c3c9efaa0185215e49e4bac84b8a0790f09e163003dbc1c9abb42838fbd3012285489ef7337

data/lib/isodoc/base_style/typography.scss

@@ -67,4 +67,9 @@
   td.header {
     font-weight: 400;
   }
+
+   table.plain, table.plain th, table.plain td {
+     border: none !important;
+     font-size: 0.95em;
+   }
 }

data/lib/isodoc/convert.rb

@@ -88,7 +88,7 @@ module IsoDoc
     def bibrenderer(options = {})
       ::Relaton::Render::IsoDoc::General
         .new(options.merge(language: @lang, script: @script,
-                           i18nhash: @i18n.get))
+                           i18nhash: @i18n.get, config: @relatonrenderconfig))
     end
 
     def convert1_namespaces(html)
@@ -112,11 +112,12 @@ module IsoDoc
       docxml = Nokogiri::XML(file, &:huge)
       filename, dir = init_file(input_filename, debug)
       docxml.root.default_namespace = ""
+      docxml_var_init(docxml)
       convert_i18n_init(docxml)
       metadata_init(@lang, @script, @locale, @i18n)
       xref_init(@lang, @script, self, @i18n,
                 { locale: @locale, bibrender: @bibrender })
-      toc_init(docxml)
+      @xrefs.klass.doctype = @doctype
       [docxml, filename, dir]
     end
 

data/lib/isodoc/function/blocks.rb

@@ -118,6 +118,30 @@ module IsoDoc
         end
       end
 
+      def key_parse(node, out)
+        klass = "key #{node['class']}".strip
+        out.div **attr_code(class: klass) do |div|
+          node.children.each do |n|
+            if n.name == "name"
+              key_name_parse(n, div)
+              "<p keep-with-next='true'><strong>#{@i18n.key}</strong></p>"
+            else parse(n, div)
+            end
+          end
+        end
+      end
+
+      def key_name_parse(node, div)
+        a = keep_style(node)
+        a&.include?("page-break-after:") or
+          a = "page-break-after: avoid;#{a}"
+        div.p style: a do |p|
+          p.b do |s|
+            children_parse(node, s)
+          end
+        end
+      end
+
       def para_class(node)
         classtype = nil
         classtype = "MsoCommentText" if in_comment
@@ -137,13 +161,17 @@ module IsoDoc
 
       def para_parse(node, out)
         out.p **attr_code(para_attrs(node)) do |p|
-                    children_parse(node, p)
+          para_prefix(node, p)
+          node.children.each { |n| parse(n, p) unless n.name == "note" }
         end
+        node.xpath(ns("./note")).each { |n| parse(n, out) }
       end
 
+      def para_prefix(node, out); end
+
       def attribution_parse(node, out)
         out.div class: "QuoteAttribution" do |div|
-                    children_parse(node, div)
+          children_parse(node, div)
         end
       end
 
@@ -167,14 +195,14 @@ module IsoDoc
 
       def toc_parse(node, out)
         out.div class: "toc" do |div|
-                    children_parse(node, div)
+          children_parse(node, div)
         end
       end
 
       def source_parse(node, out)
         out.div class: "BlockSource" do |d|
           d.p do |p|
-                      children_parse(node, p)
+            children_parse(node, p)
           end
         end
       end
@@ -201,7 +229,7 @@ module IsoDoc
         tag = node.parent.name == "fmt-footnote-container" ? "aside" : "div"
         id = node["is_table"] ? node["reference"] : node["id"]
         out.send tag, id: "fn:#{id}", class: "footnote" do |div|
-                    children_parse(node, div)
+          children_parse(node, div)
         end
       end
     end

data/lib/isodoc/function/blocks_example_note.rb

@@ -4,7 +4,7 @@ module IsoDoc
       def example_label(_node, div, name)
         name.nil? and return
         div.p class: "example-title" do |_p|
-                    children_parse(name, div)
+          children_parse(name, div)
         end
       end
 
@@ -64,7 +64,9 @@ module IsoDoc
       end
 
       def starts_with_para?(node)
-        block_body_first_elem(node)&.name == "p"
+        elem = block_body_first_elem(node) or return
+        elem.name == "p" || elem.elements.first&.name == "p" ||
+          block_body_first_elem(elem)&.name == "p"
       end
 
       def note_p_class
@@ -73,7 +75,7 @@ module IsoDoc
 
       def note_p_parse(node, div)
         name = node.at(ns("./fmt-name"))
-        para = node.at(ns("./p"))
+        para = node.at(ns("./p")) || node.at(ns("./semx/p"))
         div.p **attr_code(class: note_p_class) do |p|
           name and p.span class: "note_label" do |s|
             name.children.each { |n| parse(n, s) }

data/lib/isodoc/function/cleanup.rb

@@ -8,8 +8,8 @@ module IsoDoc
       def passthrough_cleanup(docxml)
         docxml.split(%r{(<passthrough>|</passthrough>)}).each_slice(4)
           .map do |a|
-          a.size > 2 and a[2] = HTMLEntities.new.decode(a[2])
-          [a[0], a[2]]
+            a.size > 2 and a[2] = HTMLEntities.new.decode(a[2])
+            [a[0], a[2]]
         end.join
       end
 
@@ -112,7 +112,8 @@ module IsoDoc
       end
 
       TABLENOTE_CSS = "div[@class = 'Note' or @class = 'BlockSource' " \
-        "or @class = 'TableFootnote' or @class = 'figdl']".freeze
+        "or @class = 'TableFootnote' or @class = 'figdl' or @class = 'key']"
+        .freeze
 
       def table_note_cleanup(docxml)
         docxml.xpath("//table[dl or #{TABLENOTE_CSS}]").each do |t|
@@ -120,7 +121,7 @@ module IsoDoc
           insert_here = new_fullcolspan_row(t, tfoot)
           t.xpath("dl | p[@class = 'ListTitle'] | #{TABLENOTE_CSS}")
             .each do |d|
-            d.parent = insert_here
+              d.parent = insert_here
           end
         end
       end

data/lib/isodoc/function/inline.rb

@@ -4,9 +4,9 @@ module IsoDoc
   module Function
     module Inline
       def link_parse(node, out)
-        url = node["target"]
-        node["update-type"] == "true" and url = suffix_url(url)
-        out.a **attr_code(href: url, title: node["alt"]) do |l|
+        url = link_parse_url(node)
+        out.a **attr_code(href: url, title: node["alt"],
+                          class: node["style"]) do |l|
           if node.elements.empty? && node.text.strip.empty?
             l << @c.encode(node["target"].sub(/^mailto:/, ""), :basic,
                            :hexadecimal)
@@ -15,6 +15,12 @@ module IsoDoc
         end
       end
 
+      def link_parse_url(node)
+        url = node["target"]
+        node["update-type"] == "true" and url = suffix_url(url)
+        url
+      end
+
       # Presentation XML classes which we need not pass on to HTML or DOC
       SPAN_UNWRAP_CLASSES =
         %w[fmt-caption-label fmt-label-delim fmt-caption-delim fmt-autonum-delim
@@ -213,30 +219,6 @@ module IsoDoc
           children_parse(node, s)
         end
       end
-
-      def fmt_concept_parse(node, out)
-        children_parse(node, out)
-      end
-
-      def fmt_date_parse(node, out)
-        children_parse(node, out)
-      end
-
-      def fmt_fn_label_parse(node, out)
-        children_parse(node, out)
-      end
-
-      def fmt_footnote_container_parse(node, out)
-        children_parse(node, out)
-      end
-
-      def fmt_annotation_start_parse(node, out)
-        children_parse(node, out)
-      end
-
-      def fmt_annotation_end_parse(node, out)
-        children_parse(node, out)
-      end
     end
   end
 end

data/lib/isodoc/function/inline_simple.rb

@@ -98,6 +98,31 @@ module IsoDoc
       def semx_sourcecode_parse(node, out); end
       def annotation_note_parse(node, out); end
       def semx_source_parse(node, out); end
+
+     def fmt_concept_parse(node, out)
+        children_parse(node, out)
+      end
+
+      def fmt_date_parse(node, out)
+        children_parse(node, out)
+      end
+
+      def fmt_fn_label_parse(node, out)
+        children_parse(node, out)
+      end
+
+      def fmt_footnote_container_parse(node, out)
+        children_parse(node, out)
+      end
+
+      def fmt_annotation_start_parse(node, out)
+        children_parse(node, out)
+      end
+
+      def fmt_annotation_end_parse(node, out)
+        children_parse(node, out)
+      end
+
     end
   end
 end

data/lib/isodoc/function/references.rb

@@ -3,10 +3,17 @@ module IsoDoc
     module References
       def bibitem_entry(list, bib, _ordinal, biblio)
         list.p **attr_code(iso_bibitem_entry_attrs(bib, biblio)) do |ref|
-          tag = bib.at(ns("./biblio-tag"))
-          tag&.children&.each { |n| parse(n, ref) }
+          children_parse(bib.at(ns("./biblio-tag")), ref)
           reference_format(bib, ref)
         end
+        bibitem_notes(list, bib, _ordinal, biblio)
+      end
+
+      def bibitem_notes(list, bib, _ordinal, biblio)
+        bib.xpath(ns("./formattedref/note")).each do |n|
+          parse(n, list)
+          list.parent.elements[-1]["class"] += biblio ? " Biblio" : " NormRef"
+        end
       end
 
       def iso_bibitem_entry_attrs(bib, biblio)
@@ -14,8 +21,8 @@ module IsoDoc
       end
 
       def reference_format(bib, out)
-        ftitle = bib.at(ns("./formattedref"))
-        ftitle&.children&.each { |n| parse(n, out) }
+        ftitle = bib.at(ns("./formattedref")) or return
+        ftitle.children.each { |n| n.name == "note" or parse(n, out) }
       end
 
       def biblio_list(refs, div, biblio)

data/lib/isodoc/function/setup.rb

@@ -42,6 +42,7 @@ module IsoDoc
 
       def info(isoxml, out)
         @meta.localdir = @localdir
+        @meta.presentation isoxml, out
         @meta.code_css isoxml, out
         @meta.title isoxml, out
         @meta.subtitle isoxml, out
@@ -57,7 +58,7 @@ module IsoDoc
         @meta.url isoxml, out
         @meta.keywords isoxml, out
         @meta.note isoxml, out
-        @meta.presentation isoxml, out
+        @meta.images isoxml, out
         @meta.get
       end
     end

data/lib/isodoc/function/table.rb

@@ -51,7 +51,7 @@ module IsoDoc
         c = node["class"]
         style = table_attrs_style(node, c)
         attr_code(id: node["id"],
-                  class: node["plain"] == "true" ? nil : (c || "MsoISOTable"),
+                  class: node["plain"] == "true" ? "plain" : (c || "MsoISOTable"),
                   style: style, title: node["alt"])
       end
 
@@ -93,7 +93,7 @@ module IsoDoc
       end
 
       def table_parse_tail(node, out)
-        (dl = node.at(ns("./dl"))) && parse(dl, out)
+        (dl = node.at(ns("./key"))) && parse(dl, out)
         node.xpath(ns("./fmt-source")).each { |n| parse(n, out) }
         node.xpath(ns("./note")).each { |n| parse(n, out) }
         node.xpath(ns("./fmt-footnote-container/fmt-fn-body"))

data/lib/isodoc/function/to_word_html.rb

@@ -241,6 +241,7 @@ module IsoDoc
           when "fmt-annotation-start" then fmt_annotation_start_parse(node, out)
           when "fmt-annotation-end" then fmt_annotation_end_parse(node, out)
           when "fmt-annotation-body" then fmt_annotation_body_parse(node, out)
+          when "key" then key_parse(node, out)
           else error_parse(node, out)
           end
         end

data/lib/isodoc/function/utils.rb

@@ -84,7 +84,7 @@ module IsoDoc
       end
 
       NOTE_CONTAINER_ANCESTOR = <<~XPATH.strip.freeze
-        .//ancestor::*[local-name() = 'annex' or local-name() = 'foreword' or local-name() = 'appendix' or local-name() = 'introduction' or local-name() = 'terms' or local-name() = 'acknowledgements' or local-name() = 'executivesummary' or local-name() = 'term' or local-name() = 'clause' or local-name() = 'references' or local-name() = 'figure' or local-name() = 'formula' or local-name() = 'table' or local-name() = 'example']/@id
+        .//ancestor::*[local-name() = 'annex' or local-name() = 'foreword' or local-name() = 'appendix' or local-name() = 'introduction' or local-name() = 'terms' or local-name() = 'acknowledgements' or local-name() = 'executivesummary' or local-name() = 'term' or local-name() = 'clause' or local-name() = 'references' or local-name() = 'figure' or local-name() = 'formula' or local-name() = 'table' or local-name() = 'example' or local-name() = 'bibitem']/@id
       XPATH
 
       # no recursion on references

data/lib/isodoc/init.rb

@@ -19,15 +19,24 @@ module IsoDoc
       @i18n.l10n(expr, lang, script, opt)
     end
 
-    def toc_init(docxml)
+    def docxml_var_init(docxml)
+      doctype_init(docxml)
+      toc_init(docxml)
+    end
+
+    def doctype_init(docxml)
       @doctype = docxml.at(ns("//bibdata/ext/doctype"))&.text
       @subdoctype = docxml.at(ns("//bibdata/ext/subdoctype"))&.text
-      @xrefs.klass.doctype = @doctype
-      x = "//metanorma-extension/presentation-metadata" \
-          "[name[text() = 'TOC Heading Levels']]/value"
-      n = docxml.at(ns(x.sub("TOC", "DOC TOC"))) and
+      @docscheme = docxml.at(ns("//metanorma-extension/presentation-metadata/"\
+        "document-scheme"))&.text
+    end
+
+    def toc_init(docxml)
+      x = "//metanorma-extension/presentation-metadata/" \
+          "toc-heading-levels"
+      n = docxml.at(ns(x.sub("toc", "doc-toc"))) and
         @wordToClevels = n.text.to_i
-      n = docxml.at(ns(x.sub("TOC", "HTML TOC"))) and
+      n = docxml.at(ns(x.sub("toc", "html-toc"))) and
         @htmlToClevels = n.text.to_i
     end
 
@@ -80,6 +89,7 @@ module IsoDoc
       @script = options[:script] || "Latn"
       @locale = options[:locale]
       @localizenumber = options[:localizenumber]
+      @relatonrenderconfig = options[:relatonrenderconfig]
     end
 
     def init_locations(options)
@@ -186,7 +196,7 @@ module IsoDoc
     def omit_docid_prefix(prefix)
       prefix.nil? || prefix.empty? and return true
       %w(ISO IEC IEV ITU W3C BIPM csd metanorma repository metanorma-ordinal
-         title).include? prefix
+         author-date title).include? prefix
     end
 
     def connectives_spans(text)

data/lib/isodoc/metadata.rb

@@ -9,7 +9,7 @@ module IsoDoc
       Common::ns(xpath)
     end
 
-        def l10n(expr, lang = @lang, script = @script, opt = {})
+    def l10n(expr, lang = @lang, script = @script, opt = {})
       opt[:locale] ||= @locale
       @i18n.l10n(expr, lang, script, opt)
     end
@@ -52,6 +52,8 @@ module IsoDoc
     def doctype(isoxml, _out)
       b = isoxml.at(ns("//bibdata/ext/doctype#{NOLANG}")) || return
       set(:doctype, status_print(b.text))
+      ba = isoxml.at(ns("//bibdata/ext/doctype/@abbreviation")) and
+        set(:doctype_abbr, status_print(ba.text))
       b1 = isoxml.at(ns("//bibdata/ext/doctype#{currlang}")) || b
       set(:doctype_display, status_print(b1.text))
       b = isoxml.at(ns("//bibdata/ext/subdoctype#{NOLANG}")) || return
@@ -113,7 +115,7 @@ module IsoDoc
     def draftinfo(draft, revdate)
       return "" unless draft
 
-      draftinfo = " (#{@labels['draft_label']} #{draft}"
+      draftinfo = " (#{@labels['draft_label']} <esc>#{draft}</esc>"
       draftinfo += ", #{revdate}" if revdate
       draftinfo += ")"
       l10n(draftinfo, @lang, @script)
@@ -182,17 +184,19 @@ module IsoDoc
       set(:title_footnote, ret)
     end
 
+    def images(_isoxml, _out)
+    end
+
     def code_css(isoxml, _out)
       c = isoxml.at(ns("//metanorma-extension/source-highlighter-css")) or return
       set(:code_css, c.text)
     end
 
     def presentation(xml, _out)
-      xml.xpath(ns("//metanorma-extension/presentation-metadata")).each do |p|
-        ((n = p.at(ns("./name"))) && (v = p.at(ns("./value")))) or next
-        lbl = "presentation_metadata_#{n.text}".to_sym
+      xml.xpath(ns("//metanorma-extension/presentation-metadata/*")).each do |p|
+        lbl = "presentation_metadata_#{p.name}".to_sym
         m = get[lbl] || []
-        set(lbl, m << v.text)
+        set(lbl, m << p.text)
       end
     end
 

data/lib/isodoc/metadata_contributor.rb

@@ -53,6 +53,19 @@ module IsoDoc
     def author(xml, _out)
       personal_authors(xml)
       agency(xml)
+      contributor_role(xml, "authorizer")
+      contributor_role(xml, "enabler")
+    end
+
+    def contributor_role(xml, role)
+      ret = xml.xpath(ns("//bibdata/contributor[xmlns:role/@type = " \
+                         "'#{role}']/organization"))
+        .each_with_object([]) do |org, m|
+        name = org.at(ns("./name[@language = '#{@lang}']")) ||
+          org.at(ns("./name"))
+        m << name.text
+      end
+      ret.empty? or set(role.to_sym, ret)
     end
 
     def iso?(org)
@@ -66,8 +79,8 @@ module IsoDoc
       logos = []
       agency_data(xml).each do |org|
         agency1 = org[:abbr] || org[:name]
-        org[:name] and publisher << org[:name]
-        org[:logo] and logos << org[:logo]
+        org[:name] && !org[:name].empty? and publisher << org[:name]
+        org[:logo] && !org[:logo].empty? and logos << org[:logo]
         agency = iso?(org) ? "ISO/#{agency}" : "#{agency}#{agency1}/"
       end
       [agency.sub(%r{/$}, ""), publisher, logos]

data/lib/isodoc/presentation_function/autonum.rb

@@ -1,6 +1,7 @@
 module IsoDoc
   class PresentationXMLConvert < ::IsoDoc::Convert
     def prefix_name(node, delims, label, elem)
+      sem_xml_descendant?(node) and return
       label, delims = prefix_name_defaults(node, delims, label, elem)
       name, ins, ids, number = prefix_name_prep(node, elem)
       ins.next = fmt_xref_label(label, number, ids)
@@ -30,7 +31,6 @@ module IsoDoc
     end
 
     def prefix_name_labels(node)
-      #@new_ids ||= {}
       id = "_#{UUIDTools::UUID.random_create}"
       @new_ids[id] = nil
       { elem: node["id"], name: id }
@@ -78,7 +78,7 @@ module IsoDoc
     end
 
     def semx(node, label, element = "autonum")
-      id = node["id"] || node[:id] || elem['original-id']
+      id = node["id"] || node[:id] || elem["original-id"]
       /<semx element='[^']+' source='#{id}'/.match?(label) and return label
       l = stripsemx(label)
       %(<semx element='#{element}' source='#{id}'>#{l}</semx>)
@@ -113,13 +113,22 @@ module IsoDoc
 
     def prefix_container_fmt_xref_label(container, xref)
       container or return xref
-      container_container = @xrefs.anchor(container, :container, false)
+      container_container = prefix_container_container(container)
       container_label =
         prefix_container_fmt_xref_label(container_container,
                                         @xrefs.anchor(container, :xref, false))
       l10n(connectives_spans(@i18n.nested_xref
         .sub("%1", "<span class='fmt-xref-container'>#{esc container_label}</span>")
-        .sub("%2", xref)))
+        .sub("%2", xref || "[Unknown]")))
+    end
+
+    def prefix_container_container(container)
+      container_container = @xrefs.anchor(container, :container, false)
+      if @xrefs.anchor(container, :type) == "bibitem"
+        p = @bibitem_lookup[container].parent
+        p and container_container ||= p["id"]
+      end
+      container_container
     end
 
     # detect whether string which may contain XML markup is empty
@@ -160,5 +169,57 @@ module IsoDoc
       text.nil? || text.empty? and return text
       "<esc>#{text}</esc>"
     end
+
+    # do not change to Presentation XML rendering
+    # this is sensitive to ordering of Presentation XML processing:
+    # blocks > terms > inline
+    def sem_xml_descendant?(node)
+      ancestor_names = node.ancestors.map(&:name)
+      sem_xml_descendant_terms?(node, ancestor_names) and return true
+      sem_xml_descendant_inline?(node, ancestor_names) and return true
+      sem_xml_descendant_bibitem?(node, ancestor_names) and return true
+      sem_xml_descendant_provision?(node, ancestor_names) and return true
+      false
+    end
+
+    # keep Presentation XML blocks within provisions,
+    # they are processed separately
+    # into distinct Presentation XML fmt-provision later
+    def sem_xml_descendant_provision?(node, ancestor_names)
+      block?(node) and return false
+      (ancestor_names & %w[requirement recommendation permission]).any? &&
+        !ancestor_names.include?("fmt-provision")
+    end
+
+    def sem_xml_descendant_bibitem?(_node, ancestor_names)
+      ancestor_names.include?("bibitem") &&
+        %w[formattedref biblio-tag].none? do |name|
+          ancestor_names.include?(name)
+        end
+    end
+
+    def sem_xml_descendant_inline?(_node, ancestor_names)
+      %w[xref eref origin link name title newcontent]
+        .any? do |name|
+          ancestor_names.include?(name)
+      end and return true
+    end
+
+    # keep Presentation XML blocks within designations,
+    # they are processed separately
+    # into distinct Presentation XML fmt-* designations later
+    def sem_xml_descendant_terms?(node, ancestor_names)
+      block?(node) and return false
+      %w[preferred admitted deprecated related definition source]
+        .any? do |name|
+          ancestor_names.include?(name)
+      end
+    end
+
+    def block?(node)
+      %w(figure table note example termnote termexample formula sourcecode
+         admonition ul ol dl quote permission requirement recommendation)
+        .include?(node.name)
+    end
   end
 end

data/lib/isodoc/presentation_function/bibdata.rb

@@ -42,7 +42,8 @@ module IsoDoc
     def bibdata_i18n(bib)
       hash_translate(bib, @i18n.get["doctype_dict"], "./ext/doctype",
                      "//presentation-metadata/doctype-alias", @lang)
-      hash_translate(bib, @i18n.get["stage_dict"], "./status/stage", nil, @lang)
+      hash_translate(bib, @i18n.get["stage_dict"], "./status/stage",
+                     "//presentation-metadata/stage-alias", @lang)
       hash_translate(bib, @i18n.get["substage_dict"], "./status/substage", nil,
                      @lang)
       edition_translate(bib)
@@ -63,10 +64,20 @@ module IsoDoc
     # to be mixed
     def edition_translate(bibdata)
       x = bibdata.at(ns("./edition")) or return
+      if @i18n.edition_ordinal && num = edition_integer?(bibdata)
+        tag_translate(x, @lang, @i18n
+          .populate("edition_ordinal", { "var1" => num }))
+      elsif @i18n.edition_cardinal
+        tag_translate(x, @lang, @i18n
+          .populate("edition_cardinal", { "var1" => x.text }))
+      end
+    end
+
+    def edition_integer?(bibdata)
+      x = bibdata.at(ns("./edition[not(@language) or @language = '']"))
+      x or return
       /^\d+$/.match?(x.text) or return
-      @i18n.edition_ordinal or return
-      tag_translate(x, @lang, @i18n
-        .populate("edition_ordinal", { "var1" => x.text.to_i }))
+      x.text.to_i
     end
 
     def tag_translate(tag, lang, value)