isodoc 1.5.5 → 1.6.4

data/lib/isodoc/presentation_xml_convert.rb

@@ -1,5 +1,6 @@
 require_relative "presentation_function/block"
 require_relative "presentation_function/inline"
+require_relative "presentation_function/math"
 require_relative "presentation_function/section"
 require_relative "presentation_function/bibdata"
 
@@ -59,7 +60,7 @@ module IsoDoc
       variant docxml
     end
 
-    def postprocess(result, filename, dir)
+    def postprocess(result, filename, _dir)
       toXML(result, filename)
       @files_to_delete.each { |f| FileUtils.rm_rf f }
     end

data/lib/isodoc/sassc_importer.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'sassc'
+require "sassc"
 
 class SasscImporter < SassC::Importer
   def imports(path, _parent_path)

data/lib/isodoc/version.rb

@@ -1,3 +1,3 @@
 module IsoDoc
-  VERSION = "1.5.5".freeze
+  VERSION = "1.6.4".freeze
 end

data/lib/isodoc/word_function/body.rb

@@ -1,5 +1,5 @@
-require_relative "./table.rb"
-require_relative "./inline.rb"
+require_relative "./table"
+require_relative "./inline"
 
 module IsoDoc::WordFunction
   module Body
@@ -71,8 +71,8 @@ module IsoDoc::WordFunction
       node.xpath(ns("./note")).each { |n| parse(n, out) }
     end
 
-    WORD_DT_ATTRS = {class: @note ? "Note" : nil, align: "left",
-                     style: "margin-left:0pt;text-align:left;"}.freeze
+    WORD_DT_ATTRS = { class: @note ? "Note" : nil, align: "left",
+                      style: "margin-left:0pt;text-align:left;" }.freeze
 
     def dt_parse(dt, term)
       term.p **attr_code(WORD_DT_ATTRS) do |p|
@@ -102,6 +102,7 @@ module IsoDoc::WordFunction
 
     def dl_parse_notes(node, v)
       return if node.elements.reject { |n| dt_dd? n }.empty?
+
       v.tr do |tr|
         tr.td **{ colspan: 2 } do |td|
           node.elements.reject { |n| dt_dd? n }.each { |n| parse(n, td) }
@@ -109,19 +110,19 @@ module IsoDoc::WordFunction
       end
     end
 
-    def figure_get_or_make_dl(t)
-      dl = t.at(".//table[@class = 'dl']")
+    def figure_get_or_make_dl(node)
+      dl = node.at(".//table[@class = 'dl']")
       if dl.nil?
-        t.add_child("<p><b>#{@i18n.key}</b></p><table class='dl'></table>")
-        dl = t.at(".//table[@class = 'dl']")
+        node.add_child("<p><b>#{@i18n.key}</b></p><table class='dl'></table>")
+        dl = node.at(".//table[@class = 'dl']")
       end
       dl
     end
 
-    def figure_aside_process(f, aside, key)
+    def figure_aside_process(fig, aside, key)
       # get rid of footnote link, it is in diagram
-      f&.at("./a[@class='TableFootnoteRef']")&.remove
-      fnref = f.at(".//span[@class='TableFootnoteRef']/..")
+      fig&.at("./a[@class='TableFootnoteRef']")&.remove
+      fnref = fig.at(".//span[@class='TableFootnoteRef']/..")
       tr = key.add_child("<tr></tr>").first
       dt = tr.add_child("<td valign='top' align='left'></td>").first
       dd = tr.add_child("<td valign='top'></td>").first
@@ -174,31 +175,32 @@ module IsoDoc::WordFunction
         attrs[:align] = node["align"] unless node["align"] == "justify"
         attrs[:style] += "text-align:#{node['align']};"
       end
-      attrs[:style] += "#{keep_style(node)}"
+      attrs[:style] += keep_style(node).to_s
       attrs[:style] = nil if attrs[:style].empty?
       attrs
     end
 
     def example_table_attr(node)
       super.merge({
-        style: "mso-table-lspace:15.0cm;margin-left:423.0pt;"\
-        "mso-table-rspace:15.0cm;margin-right:423.0pt;"\
-        "mso-table-anchor-horizontal:column;"\
-        "mso-table-overlap:never;border-collapse:collapse;"\
-        "#{keep_style(node)}"
-      })
+                    style: "mso-table-lspace:15.0cm;margin-left:423.0pt;"\
+                    "mso-table-rspace:15.0cm;margin-right:423.0pt;"\
+                    "mso-table-anchor-horizontal:column;"\
+                    "mso-table-overlap:never;border-collapse:collapse;"\
+                    "#{keep_style(node)}",
+                  })
     end
 
-    def formula_where(dl, out)
-      return unless dl
+    def formula_where(deflist, out)
+      return unless deflist
+
       out.p { |p| p << @i18n.where }
-      parse(dl, out)
+      parse(deflist, out)
       out.parent.at("./table")["class"] = "formula_dl"
     end
 
     def formula_parse1(node, out)
       out.div **attr_code(class: "formula") do |div|
-        div.p do |p|
+        div.p do |_p|
           parse(node.at(ns("./stem")), div)
           insert_tab(div, 1)
           if lbl = node&.at(ns("./name"))&.text
@@ -209,7 +211,7 @@ module IsoDoc::WordFunction
     end
 
     def li_parse(node, out)
-      out.li  **attr_code(id: node["id"]) do |li|
+      out.li **attr_code(id: node["id"]) do |li|
         if node["uncheckedcheckbox"] == "true"
           li << '<span class="zzMoveToFollowing">&#x2610; </span>'
         elsif node["checkedcheckbox"] == "true"
@@ -220,7 +222,9 @@ module IsoDoc::WordFunction
     end
 
     def suffix_url(url)
-      return url if %r{^http[s]?://}.match(url)
+      return url if %r{^https?://}.match?(url)
+      return url unless File.extname(url).empty?
+
       url.sub(/#{File.extname(url)}$/, ".doc")
     end
   end

data/lib/isodoc/word_function/footnotes.rb

@@ -2,7 +2,7 @@ module IsoDoc::WordFunction
   module Footnotes
     def bookmarkid
       ret = "X"
-      until !@bookmarks_allocated[ret] do
+      until !@bookmarks_allocated[ret]
         ret = Random.rand(1000000000)
       end
       @bookmarks_allocated[ret] = true
@@ -11,6 +11,7 @@ module IsoDoc::WordFunction
 
     def footnotes(div)
       return if @footnotes.empty?
+
       @footnotes.each { |fn| div.parent << fn }
     end
 
@@ -52,6 +53,7 @@ module IsoDoc::WordFunction
     def get_table_ancestor_id(node)
       table = node.ancestors("table") || node.ancestors("figure")
       return UUIDTools::UUID.random_create.to_s if table.empty?
+
       table.last["id"]
     end
 
@@ -61,30 +63,34 @@ module IsoDoc::WordFunction
       make_table_footnote_link(out, tid + fn, fn)
       # do not output footnote text if we have already seen it for this table
       return if @seen_footnote.include?(tid + fn)
+
       @in_footnote = true
       out.aside { |a| a << make_table_footnote_text(node, tid + fn, fn) }
       @in_footnote = false
       @seen_footnote << (tid + fn)
     end
 
-    def seen_footnote_parse(node, out, fn)
-      out.span **{style: "mso-element:field-begin"}
-      out << " NOTEREF _Ref#{@fn_bookmarks[fn]} \\f \\h"
-      out.span **{style: "mso-element:field-separator"}
-      out.span **{class: "MsoFootnoteReference"} do |s|
-        s << fn
+    def seen_footnote_parse(_node, out, footnote)
+      out.span **{ style: "mso-element:field-begin" }
+      out << " NOTEREF _Ref#{@fn_bookmarks[footnote]} \\f \\h"
+      out.span **{ style: "mso-element:field-separator" }
+      out.span **{ class: "MsoFootnoteReference" } do |s|
+        s << footnote
       end
-      out.span **{style: "mso-element:field-end"}
+      out.span **{ style: "mso-element:field-end" }
     end
 
     def footnote_parse(node, out)
       return table_footnote_parse(node, out) if (@in_table || @in_figure) &&
-        !node.ancestors.map {|m| m.name }.include?("name")
+        !node.ancestors.map { |m| m.name }.include?("name")
+
       fn = node["reference"] || UUIDTools::UUID.random_create.to_s
       return seen_footnote_parse(node, out, fn) if @seen_footnote.include?(fn)
+
       @fn_bookmarks[fn] = bookmarkid
-      out.span **{style: "mso-bookmark:_Ref#{@fn_bookmarks[fn]}"} do |s|
-        s.a **{ "class": "FootnoteRef", "epub:type": "footnote", href: "#ftn#{fn}" } do |a|
+      out.span **{ style: "mso-bookmark:_Ref#{@fn_bookmarks[fn]}" } do |s|
+        s.a **{ "class": "FootnoteRef", "epub:type": "footnote",
+                href: "#ftn#{fn}" } do |a|
           a.sup { |sup| sup << fn }
         end
       end
@@ -94,12 +100,13 @@ module IsoDoc::WordFunction
       @seen_footnote << fn
     end
 
-    def make_footnote(node, fn)
-      return if @seen_footnote.include?(fn)
+    def make_footnote(node, footnote)
+      return if @seen_footnote.include?(footnote)
+
       @in_footnote = true
-      @footnotes << make_generic_footnote_text(node, fn)
+      @footnotes << make_generic_footnote_text(node, footnote)
       @in_footnote = false
-      @seen_footnote << fn
+      @seen_footnote << footnote
     end
   end
 end

data/lib/isodoc/word_function/postprocess.rb

@@ -1,17 +1,17 @@
 require "fileutils"
-require_relative "./postprocess_cover.rb"
+require_relative "./postprocess_cover"
 
 module IsoDoc::WordFunction
   module Postprocess
     # add namespaces for Word fragments
     WORD_NOKOHEAD = <<~HERE.freeze
-    <!DOCTYPE html SYSTEM "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
-    <html xmlns="http://www.w3.org/1999/xhtml"
-xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office"
-xmlns:w="urn:schemas-microsoft-com:office:word"
-xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
-    <head> <title></title> <meta charset="UTF-8" /> </head>
-    <body> </body> </html>
+      <!DOCTYPE html SYSTEM "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+      <html xmlns="http://www.w3.org/1999/xhtml"
+      xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office"
+      xmlns:w="urn:schemas-microsoft-com:office:word"
+      xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
+      <head> <title></title> <meta charset="UTF-8" /> </head>
+      <body> </body> </html>
     HERE
 
     def to_word_xhtml_fragment(xml)
@@ -22,7 +22,8 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
     def table_note_cleanup(docxml)
       super
       # preempt html2doc putting MsoNormal there
-      docxml.xpath("//p[not(self::*[@class])][ancestor::*[@class = 'Note']]").each do |p|
+      docxml.xpath("//p[not(self::*[@class])][ancestor::*[@class = 'Note']]")
+        .each do |p|
         p["class"] = "Note"
       end
     end
@@ -38,16 +39,21 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
     def toWord(result, filename, dir, header)
       result = from_xhtml(word_cleanup(to_xhtml(result)))
       @wordstylesheet = wordstylesheet_update
-      Html2Doc.process(result, filename: filename, stylesheet: @wordstylesheet&.path,
-                       header_file: header&.path, dir: dir,
-                       asciimathdelims: [@openmathdelim, @closemathdelim],
-                       liststyles: { ul: @ulstyle, ol: @olstyle })
+      Html2Doc.process(
+        result,
+        filename: filename,
+        stylesheet: @wordstylesheet&.path,
+        header_file: header&.path, dir: dir,
+        asciimathdelims: [@openmathdelim, @closemathdelim],
+        liststyles: { ul: @ulstyle, ol: @olstyle }
+      )
       header&.unlink
-      @wordstylesheet&.unlink if @wordstylesheet&.is_a?(Tempfile)
+      @wordstylesheet.unlink if @wordstylesheet.is_a?(Tempfile)
     end
 
-    def wordstylesheet_update()
+    def wordstylesheet_update
       return if @wordstylesheet.nil?
+
       f = File.open(@wordstylesheet.path, "a")
       @landscapestyle.empty? or f.write(@landscapestyle)
       if @wordstylesheet_override && @wordstylesheet
@@ -62,7 +68,8 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
 
     def word_admonition_images(docxml)
       docxml.xpath("//div[@class = 'Admonition']//img").each do |i|
-        i["width"], i["height"] = Html2Doc.image_resize(i, image_localfile(i), @maxheight, 300)
+        i["width"], i["height"] =
+          Html2Doc.image_resize(i, image_localfile(i), @maxheight, 300)
       end
     end
 
@@ -88,21 +95,23 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
       cells2d = {}
       docxml.xpath("//table[colgroup]").each do |t|
         w = colgroup_widths(t)
-        t.xpath(".//tr").each_with_index { |tr, r| cells2d[r] = {} }
+        t.xpath(".//tr").each_with_index { |_tr, r| cells2d[r] = {} }
         t.xpath(".//tr").each_with_index do |tr, r|
-          tr.xpath("./td | ./th").each_with_index do |td, i|
+          tr.xpath("./td | ./th").each_with_index do |td, _i|
             x = 0
             rs = td&.attr("rowspan")&.to_i || 1
             cs = td&.attr("colspan")&.to_i || 1
-            while cells2d[r][x] do
-              x += 1 
+            while cells2d[r][x]
+              x += 1
             end
-            for y2 in r..(r + rs - 1)
-              for x2 in x..(x + cs - 1)
+            (r..(r + rs - 1)).each do |y2|
+              (x..(x + cs - 1)).each do |x2|
                 cells2d[y2][x2] = 1
               end
             end
-            width = (x..(x+cs-1)).each_with_object({width: 0}) { |z, m| m[:width] += w[z] }
+            width = (x..(x + cs - 1)).each_with_object({ width: 0 }) do |z, m|
+              m[:width] += w[z]
+            end
             td["width"] = "#{width[:width]}%"
             x += cs
           end
@@ -111,8 +120,8 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
     end
 
     # assume percentages
-    def colgroup_widths(t)
-      t.xpath("./colgroup/col").each_with_object([]) do |c, m|
+    def colgroup_widths(table)
+      table.xpath("./colgroup/col").each_with_object([]) do |c, m|
         m << c["width"].sub(/%$/, "").to_f
       end
     end
@@ -127,12 +136,13 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
 
     def style_update(node, css)
       return unless node
-      node["style"] = node["style"] ?  node["style"].sub(/;?$/, ";#{css}") : css
+
+      node["style"] = node["style"] ? node["style"].sub(/;?$/, ";#{css}") : css
     end
 
     def word_image_caption(docxml)
-      docxml.xpath("//p[@class = 'FigureTitle' or @class = 'SourceTitle']").
-        each do |t|
+      docxml.xpath("//p[@class = 'FigureTitle' or @class = 'SourceTitle']")
+        .each do |t|
         if t&.previous_element&.name == "img"
           img = t.previous_element
           t.previous_element.swap("<p class=\'figure\'>#{img.to_xml}</p>")
@@ -150,7 +160,8 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
       xpath.each do |list|
         (list.xpath(".//li") - list.xpath(".//ol//li | .//ul//li")).each do |l|
           l.xpath("./p | ./div | ./table").each_with_index do |p, i|
-            next if i == 0
+            next if i.zero?
+
             p.wrap(%{<div class="ListContLevel#{lvl}"/>})
           end
           list_add(l.xpath(".//ul") - l.xpath(".//ul//ul | .//ol//ul"), lvl + 1)
@@ -162,20 +173,21 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
     def word_table_align(docxml)
       docxml.xpath("//td[@align]/p | //th[@align]/p").each do |p|
         next if p["align"]
-        style_update(p, "text-align: #{p.parent["align"]}")
+
+        style_update(p, "text-align: #{p.parent['align']}")
       end
     end
 
     def word_table_separator(docxml)
       docxml.xpath("//p[@class = 'TableTitle']").each do |t|
         next unless t.children.empty?
+
         t["style"] = t["style"].sub(/;?$/, ";font-size:0pt;")
         t.children = "&nbsp;"
       end
     end
 
-    def word_annex_cleanup(docxml)
-    end
+    def word_annex_cleanup(docxml); end
 
     def word_example_cleanup(docxml)
       docxml.xpath("//div[@class = 'example']//p[not(@class)]").each do |p|
@@ -194,19 +206,21 @@ xmlns:m="http://schemas.microsoft.com/office/2004/12/omml">
       docxml.xpath("//div[p/br]").each do |d|
         /^WordSection\d+_\d+$/.match(d["class"]) or next
         d.elements[0].name == "p" && !d.elements[0].elements.empty? or next
-        d.elements[0].elements[0].name == "br" && d.elements[0].elements[0]["style"] ==
-          "mso-special-character:line-break;page-break-before:always" or next
+        d.elements[0].elements[0].name == "br" &&
+          d.elements[0].elements[0]["style"] ==
+            "mso-special-character:line-break;page-break-before:always" or next
         d.elements[0].remove
       end
     end
 
     def word_footnote_format(docxml)
-      # the content is in a[@epub:type = 'footnote']//sup, but in Word, 
+      # the content is in a[@epub:type = 'footnote']//sup, but in Word,
       # we need to inject content around the autonumbered footnote reference
       docxml.xpath("//a[@epub:type = 'footnote']").each do |x|
         footnote_reference_format(x)
       end
-      docxml.xpath("//a[@class = 'TableFootnoteRef'] | //span[@class = 'TableFootnoteRef']").each do |x|
+      docxml.xpath("//a[@class = 'TableFootnoteRef'] | "\
+                   "//span[@class = 'TableFootnoteRef']").each do |x|
         table_footnote_reference_format(x)
       end
       docxml

data/lib/isodoc/xref.rb

@@ -11,7 +11,7 @@ module IsoDoc
     include XrefGen::Blocks
     include XrefGen::Sections
 
-     def initialize(lang, script, klass, i18n, options = {})
+    def initialize(lang, script, klass, i18n, options = {})
       @anchors = {}
       @lang = lang
       @script = script
@@ -28,13 +28,12 @@ module IsoDoc
 
     def anchor(id, lbl, warning = true)
       return nil if id.nil? || id.empty?
-      unless @anchors[id]
-        if warning
-          @seen ||= Seen_Anchor.instance
-          @seen.seen(id) or warn "No label has been processed for ID #{id}"
-          @seen.add(id)
-          return "[#{id}]"
-        end
+
+      if warning && !@anchors[id]
+        @seen ||= Seen_Anchor.instance
+        @seen.seen(id) or warn "No label has been processed for ID #{id}"
+        @seen.add(id)
+        return "[#{id}]"
       end
       @anchors.dig(id, lbl)
     end
@@ -56,8 +55,8 @@ module IsoDoc
       Common::ns(xpath)
     end
 
-    def l10n(a, lang = @lang, script = @script)
-      @i18n.l10n(a, lang, script)
+    def l10n(text, lang = @lang, script = @script)
+      @i18n.l10n(text, lang, script)
     end
   end
 end