iso8583 0.1.6 → 0.2.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NjVlYWQ5YmQzY2ZlYWVjYWYxODliYTQ4NjViMzhiZDM3Y2NiY2I5Mw==
-  data.tar.gz: !binary |-
-    YzQ0OTBiYmI4MGQ0NjViMTI2YzNlM2NiZTUzNTIxZTliYWU4OTQzOQ==
+SHA256:
+  metadata.gz: 4c551d563390f55d323d8aea190eb31b20dcc98f786a9f872faa5df24fd229d1
+  data.tar.gz: c448bfe8446285da07c61ac8b5cfbb908477cf98a9e1bf703cfdae47d17cb2c9
 SHA512:
-  metadata.gz: !binary |-
-    NWU4Zjg3NDQwNjdmNThjOWYwZWYyOWEwZTQ5ZDU1ZDFkNWNlZDE5OWFiOTgw
-    NjY4M2QzNWIxNTlkNDAwM2Y5ZjUzZTM3ZTc3ZGNhMGQ3ODI4Zjg1OWVmOGMx
-    YmIzZWE4YWJlNDc5ZGIwNWJjMmMyZDBkZDE2M2EzMjdjNjU0OTg=
-  data.tar.gz: !binary |-
-    YzQ2YzU2N2E1YzM2YjRjZThiNTdiOWE2NGViYjA1NmMzNWQwZGNjZmJkMTg2
-    MDBlOWU2MTdmOTkyOWZkYmQwYWVmNjJkMTkxMDkyMTY3NDk1MjcyYjI3OWM2
-    MGU1MDVlN2QzNTAxNTAzZjQ4YzA0NmQ2ZmVmMzI0ZDlkMzYyZWQ=
+  metadata.gz: 1fe629ddc4d985d96b63d20e6bacfb7e9c7d7cbe429232a9dcb8f5e972f9be5e0263bb675e11d78e272de4a3c58d0ced9a7a8b2646e2f94d64d0aea8b632f66c
+  data.tar.gz: 05bb98f645a560bf44bc2b64884a301b0869f7df1b7694291c82d991abe21538df5b8a08d57ab716e8e30482770e9db8dc6f49146de2ba36aa9640e355265329

data/AUTHORS

@@ -1,3 +1,9 @@
 Tim Becker (tim@kuriositaet.de)
 Slava Kravchenko (cordawyn@gmail.com)
 Tonni Aagesen (https://github.com/ta)
+Lasse Skindstad Ebert (https://github.com/lasseebert)
+Joel Ibaceta (https://github.com/joelibaceta)
+Jackson Harper <jackson@juvo.com>
+absrd (https://github.com/absrd)
+Nicolas Leger (https://github.com/nicolasleger)
+Jérémie Bonal (https://github.com/Aquaj)

data/CHANGELOG

@@ -1,12 +1,38 @@
+0.2.4
+=========
+  better errors for missing bitmap
+  cleanup warnings
+
+0.2.3
+=========
+  Change Fixnum to Integer as Fixnum is deprecated
+
+
+0.2.2
+=========
+Thu Feb 16 13:29:41 CET 2017
+
+Added network big order codec
+
+
+0.2.0
+=========
+  no more 1.8 compatibility, byte encoding for 1.9+, ci
+  Inherit ISOException from StandardError
+  Add bundler stuff, and dev dependancy for test-unit which was removed
+     for no good reason in 2.2
+  Use ASCII for all forced_encodings
+
 0.1.6
 =========
-restrict to ruby < 2
-allow removal of empty fields
+  restrict to ruby < 2
+  allow removal of empty fields
+  Thanks: Lasse Skindstad Ebert https://github.com/lasseebert
 
 0.1.5
 =========
-MMDD Codec
-BCD encoder checks odd length fields
+  MMDD Codec
+  BCD encoder checks odd length fields
 
 0.1.4
 =========

data/Gemfile

@@ -0,0 +1,3 @@
+source "https://rubygems.org"
+
+gemspec

data/README.md

@@ -0,0 +1,29 @@
+# ISO 8583 Financial Messaging for Ruby
+
+This package currently contains code for coding an decoding ISO 8583
+Financial Message.
+
+## Developing
+
+In case you're using a ruby version >= 2.2, test-unit is no longer in
+the std lib, so it needs to be available. Bundler installs this, if not
+using bundler, you need to run `gem install test-unit` before running
+the tests.
+
+## Installing
+
+You can install the last version of the +iso8583+ package by executing:
+
+	gem install iso8583 
+
+## Source
+
+The source is most readily available on github[http://github.com/a2800276/8583].
+
+## Mailing List
+
+In case you discover bugs, spelling errors, offer suggestions for
+improvements or would like to help out with the project, you can contact
+me directly (tim@kuriositaet.de).
+
+[![Build Status](https://travis-ci.org/a2800276/8583.svg?branch=master)](https://travis-ci.org/a2800276/8583)

data/Rakefile

@@ -84,7 +84,6 @@ spec = Gem::Specification.new do |s|
   s.requirements << "none"
   s.require_path = "lib"
   s.description = LONG_DESC
-  s.has_rdoc = true
   s.authors = ["Tim Becker", "Slava Kravchenko"]
   s.email = ["tim.becker@kuriositaet.de","cordawyn@gmail.com"]
   s.homepage = "http://github.com/a2800276/8583/"
@@ -125,7 +124,7 @@ end
 Rake::TestTask.new do |t|
   t.libs << "test"
   t.libs << "."
-  t.ruby_opts = ["-rubygems"]
+  t.ruby_opts = ["-rrubygems"]
   t.test_files = FileList["test/*.rb"]
   t.verbose = true
 end

data/lib/iso8583/berlin.rb

@@ -72,7 +72,7 @@ if __FILE__==$0
   mes[2] = 474747474747
   mes["Processing Code"] = "123456"
 
-  pan = mes["Primary Account Number (PAN)"]
+  #pan = mes["Primary Account Number (PAN)"]
   #mes.pan = 47474747474747
 
   #puts mes.pan

data/lib/iso8583/bitmap.rb

@@ -17,18 +17,17 @@ module ISO8583
     # not, this initializes and empty bitmap.
     def initialize(message = nil)
       @bmp = Array.new(128, false)
-      if !message
-
-      else
+      if message
         initialize_from_message message
       end
     end
     
     # yield once with the number of each set field.
-    def each #:yields: each bit set in the bitmap.
-      @bmp.each_with_index {|set, i| yield i+1 if set}
+    # :yields: each bit set in the bitmap. Except for the first bit which is used to determine the bitmap sizec
+    def each
+      @bmp.each_with_index {|set, i| yield i+1 if set && i != 0}
     end
-    
+
     # Returns whether the bit is set or not.
     def [](i)
       @bmp[i-1]
@@ -76,7 +75,7 @@ module ISO8583
           break
         end
       }
-      str = ""
+      str = "".force_encoding("ASCII-8BIT")
       1.upto(self[1] ? 128 : 64) {|i|
         str << (self[i] ? "1" : "0")
       }

data/lib/iso8583/codec.rb

@@ -53,6 +53,8 @@ module ISO8583
   #                       during encoding, no validity check during decoding. 
   # [+ANS_Codec+]         passes through ASCII string checking they conform to [\x20-\x7E]
   #                       during encoding, no validity check during decoding.
+  # [BE_U16]              16-bit unsigned, network (big-endian) byte order 
+  # [BE_U32]              32-bit unsigned, network (big-endian) byte order  
   # [+Null_Codec+]        passes anything along untouched.
   # [<tt>Track2</tt>]     rudimentary check that string conforms to Track2
   # [+MMDDhhmmssCodec+]   encodes Time, Datetime or String to the described date format, checking 
@@ -111,7 +113,7 @@ module ISO8583
     [val].pack("H*")
   }
   Packed_Number.decoder = lambda{|encoded|
-    d = encoded.unpack("H*")[0].to_i
+    encoded.unpack("H*")[0].to_i
   }
 
   A_Codec = Codec.new
@@ -141,6 +143,23 @@ module ISO8583
     str
   }
   ANS_Codec.decoder = PASS_THROUGH_DECODER
+  
+  BE_U16 = Codec.new
+  BE_U16.encoder = lambda {|num|
+    raise ISO8583Exception.new("Invalid value: #{num} must be 0<= X <=2^16-1") unless 0 <= num && num <= 2**16-1
+    [num].pack("n")
+  }
+  BE_U16.decoder = lambda { |encoded|
+    encoded.unpack("n")[0]
+  }
+  BE_U32 = Codec.new
+  BE_U32.encoder = lambda {|num|
+    raise ISO8583Exception.new("Invalid value: #{num} must be 0<= X <=2^32-1") unless 0 <= num && num <= 2**32-1
+    [num].pack("N")
+  }
+  BE_U32.decoder = lambda { |encoded|
+    encoded.unpack("N")[0]
+  }
 
   Null_Codec = Codec.new
   Null_Codec.encoder = lambda {|str|

data/lib/iso8583/exception.rb

@@ -1,4 +1,4 @@
 module ISO8583
-  class ISO8583Exception < Exception; end
+  class ISO8583Exception < StandardError; end
   class ISO8583ParseException < ISO8583Exception; end
 end

data/lib/iso8583/field.rb

@@ -19,7 +19,7 @@ module ISO8583
 
     def parse(raw)
       len, raw = case length
-                 when Fixnum
+                 when Integer
                    [length, raw]
                  when Field
                    length.parse(raw)
@@ -27,7 +27,7 @@ module ISO8583
                    raise ISO8583Exception.new("Cannot determine the length of '#{name}' field")
                  end
 
-      raw_value = raw[0,len]
+      raw_value = raw.byteslice(0,len)
       
       # make sure we have enough data ...
       if raw_value.length != len
@@ -35,7 +35,7 @@ module ISO8583
         raise ISO8583ParseException.new(mes)
       end
 
-      rest = raw[len, raw.length]
+      rest = raw.byteslice(len, raw.length)
       begin
         real_value = codec.decode(raw_value)
       rescue
@@ -67,10 +67,10 @@ module ISO8583
       end
 
       len_str = case length
-                when Fixnum
+                when Integer
                   raise ISO8583Exception.new("Too long: #{value} (#{name})! length=#{length}")  if encoded_value.length > length
                   raise ISO8583Exception.new("Too short: #{value} (#{name})! length=#{length}") if encoded_value.length < length
-                  "" 
+                  "".force_encoding("ASCII-8BIT")
                 when Field
                   raise ISO8583Exception.new("Max lenth exceeded: #{value}, max: #{max}") if max && encoded_value.length > max
                   length.encode(encoded_value.length)

data/lib/iso8583/fields.rb

@@ -57,63 +57,75 @@ module ISO8583
   }
 
   LL_BCD        = BCDField.new
+  LL_BCD.name   = "LL_BCD"
   LL_BCD.length = 2
   LL_BCD.codec  = Packed_Number
 
   # Two byte variable length ASCII numeral, payload ASCII numerals
   LLVAR_N        = Field.new
+  LLVAR_N.name   = "LLVAR_N"
   LLVAR_N.length = LL
   LLVAR_N.codec  = ASCII_Number
 
   # Three byte variable length ASCII numeral, payload ASCII numerals
   LLLVAR_N        = Field.new
+  LLLVAR_N.name   = "LLLVAR_N"
   LLLVAR_N.length = LLL
   LLLVAR_N.codec  = ASCII_Number
 
   # Two byte variable length ASCII numeral, payload Track2 data
   LLVAR_Z         = Field.new
+  LLVAR_Z.name    = "LLVAR_Z"
   LLVAR_Z.length  = LL
   LLVAR_Z.codec   = Track2
 
   # Two byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLVAR_AN        = Field.new
+  LLVAR_AN.name   = "LLVAR_AN"
   LLVAR_AN.length = LL
   LLVAR_AN.codec  = AN_Codec
 
   # Two byte variable length ASCII numeral, payload ASCII+special
   LLVAR_ANS        = Field.new
+  LLVAR_ANS.name   = "LLVAR_ANS"
   LLVAR_ANS.length = LL
   LLVAR_ANS.codec  = ANS_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII, fixed length, zeropadded (right)
   LLLVAR_AN        = Field.new
+  LLLVAR_AN.name   = "LLLVAR_AN"
   LLLVAR_AN.length = LLL
   LLLVAR_AN.codec  = AN_Codec
 
   # Three byte variable length ASCII numeral, payload ASCII+special
   LLLVAR_ANS        = Field.new
+  LLLVAR_ANS.name   = "LLLVAR_ANS"
   LLLVAR_ANS.length = LLL
   LLLVAR_ANS.codec  = ANS_Codec
 
   # Two byte variable length binary payload
   LLVAR_B        = Field.new
+  LLVAR_B.name   = "LLVAR_B"
   LLVAR_B.length = LL
   LLVAR_B.codec  = Null_Codec
 
 
   # Three byte variable length binary payload
   LLLVAR_B        = Field.new
+  LLLVAR_B.name   = "LLLVAR_B"
   LLLVAR_B.length = LLL
   LLLVAR_B.codec  = Null_Codec
 
   # Fixed lengh numerals, repesented in ASCII, padding right justified using zeros
   N = Field.new
+  N.name  = "N"
   N.codec = ASCII_Number
   N.padding = lambda {|val, len|
     sprintf("%0#{len}d", val)
   }
 
   N_BCD = BCDField.new
+  N_BCD.name  = "N_BCD"
   N_BCD.codec = Packed_Number
 
   PADDING_LEFT_JUSTIFIED_SPACES = lambda {|val, len|
@@ -122,25 +134,30 @@ module ISO8583
 
   # Fixed length ASCII letters [A-Za-z]
   A = Field.new
+  A.name  = "A"
   A.codec = A_Codec
 
   # Fixed lengh ASCII [A-Za-z0-9], padding left justified using spaces.
   AN = Field.new
+  AN.name  = "AN"
   AN.codec = AN_Codec
   AN.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed lengh ASCII [A-Za-z0-9] and space, padding left, spaces
   ANP = Field.new
+  ANP.name  = "ANP"
   ANP.codec = ANP_Codec
   ANP.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Fixed length ASCII  [\x20-\x7E], padding left, spaces
   ANS = Field.new
+  ANS.name = ANS
   ANS.codec = ANS_Codec
   ANS.padding = PADDING_LEFT_JUSTIFIED_SPACES
 
   # Binary data, padding left using nulls (0x00)
   B = Field.new
+  B.name  = "B"
   B.codec = Null_Codec
   B.padding = lambda {|val, len|
     while val.length < len
@@ -151,24 +168,29 @@ module ISO8583
 
   # Date, formatted as described in ASCII numerals
   MMDDhhmmss        = Field.new
+  MMDDhhmmss.name   = "MMDDhhmmss"
   MMDDhhmmss.codec  = MMDDhhmmssCodec
   MMDDhhmmss.length = 10
 
   #Date, formatted as described in ASCII numerals
   YYMMDDhhmmss        = Field.new
+  YYMMDDhhmmss.name   = "YYMMDDhhmmss"
   YYMMDDhhmmss.codec  = YYMMDDhhmmssCodec
   YYMMDDhhmmss.length = 12
 
   #Date, formatted as described in ASCII numerals
   YYMM        = Field.new
+  YYMM.name   = "YYMM"
   YYMM.codec  = YYMMCodec
   YYMM.length = 4
   
   MMDD        = Field.new
+  MMDD.name   = "MMDD"
   MMDD.codec  = MMDDCodec
   MMDD.length = 4
 
   Hhmmss        = Field.new
+  Hhmmss.name   = "Hhmmss"
   Hhmmss.codec  = HhmmssCodec
   Hhmmss.length = 6
 

data/lib/iso8583/message.rb

@@ -135,7 +135,7 @@ module ISO8583
     #    mes = MyMessage.new
     #    mes.mti = 1100 # or mes.mti = "Authorization Request Acquirer Gateway"
     def mti=(value)
-      num, name = _get_mti_definition(value)
+      num, _ = _get_mti_definition(value)
       @mti = num
     end
     
@@ -173,8 +173,10 @@ module ISO8583
     # Retrieve the byte representation of the bitmap.
     def to_b
       raise ISO8583Exception.new "no MTI set!" unless mti
-      mti_enc = self.class._mti_format.encode(mti)
-      mti_enc << _body.join
+      mti_enc = self.class._mti_format.encode(mti) 
+      str_body="".force_encoding('ASCII-8BIT')
+      _body.map {|b| str_body+=b.force_encoding('ASCII-8BIT')} 
+      mti_enc << str_body
     end
 
     # Returns a nicely formatted representation of this
@@ -202,7 +204,7 @@ module ISO8583
     # [bitmap_bytes, message_bytes]
     def _body
       bitmap  = Bitmap.new
-      message = ""
+      message = "".force_encoding('ASCII-8BIT')
       @values.keys.sort.each do |bmp_num|
         bitmap.set(bmp_num)
         enc_value = @values[bmp_num].encode
@@ -341,14 +343,19 @@ module ISO8583
           # @values[bmp] = bmp_def
         }
       end
-      
+
       # Parse the bytes `str` returning a message of the defined type.
+      #
+      # returns an instance of Message
+      #
+      # will raise an ISO8583Exception if the bitmap definition can't be found
       def parse(str)
+        str = str.force_encoding('ASCII-8BIT')
         message = self.new
         message.mti, rest = _mti_format.parse(str)
         bmp,rest = Bitmap.parse(rest)
         bmp.each {|bit|
-          bmp_def      = _definitions[bit]
+          bmp_def      = message._get_definition(bit)
           value, rest  = bmp_def.field.parse(rest)
           message[bit] = value
         }

data/lib/iso8583/util.rb

@@ -19,20 +19,25 @@ module ISO8583
   #
   # Convert a String containing hex data to
   # a String containing the corresponding bytes:
-  # 
+  #
   #   hex2b "abcd12" => "\xa\cd\12"
   #
   def hex2b(hex_string)
+
     string = hex_string.gsub(/\s+/, "")
+
     raise ISO8583Exception.new("Invalid Hex chars: #{hex_string}") unless string =~ /^[A-Fa-f0-9]*$/
     raise ISO8583Exception.new("Uneven number of Hex chars #{hex_string}") unless ( (string.length % 2) == 0)
-    [string].pack("H*")
+
+    [string].pack("H*").force_encoding('ASCII-8BIT')
+
   end
 
+
   def _conv(str, mapping)
-    _str = ""
+    _str = "".force_encoding('ASCII-8BIT')
     str.each_byte{|byte|
-      _str << mapping[byte]
+      _str << [mapping[byte]].pack("C")
     }
     _str
   end

data/lib/iso8583/version.rb

@@ -1,4 +1,4 @@
 # -*- mode: ruby; encoding: utf-8; tab-width: 2; indent-tabs-mode: nil -*-
 module ISO8583
-  VERSION = "0.1.6"
+  VERSION = "0.2.4"
 end

data/test/BitmapTests.rb

@@ -22,14 +22,14 @@ class BitmapTests < Test::Unit::TestCase
 
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_out_of_bounds_errors
     b = Bitmap.new
     assert_raises(ISO8583Exception) {b.set 1000 }
     assert_raises(ISO8583Exception) {	b.set 1 }
-    assert_raises(ISO8583Exception) {	b.set -1 }
+    assert_raises(ISO8583Exception) {	b.set(-1) }
   end
 
   def test_parse_bmp
@@ -76,5 +76,16 @@ class BitmapTests < Test::Unit::TestCase
     assert_equal [2,3,5,6], arr
   end
 
+  def test_each_w_two_bitmaps_doesnt_yield_first_field
+    #10000000000000000001000000100000010000001000000100000010000001000000100000010000001000000100000010000001000000100000010000001000
+    # generated by: 20.step(128,7) {|i| mp.set(i)}
+    tst = "\x80\x00\x10\x20\x40\x81\x02\x04\x08\x10\x20\x40\x81\x02\x04\x08"
+    bmp = Bitmap.new tst
+    arr = []
+    bmp.each{|bit|
+      arr.push bit
+    }
+    assert_equal 20, arr.first
+  end
 end
 

data/test/message_test.rb

@@ -38,13 +38,31 @@ class MessageTest < Test::Unit::TestCase
     pan = 474747474747
 
     assert_raises(ISO8583Exception) {
-      mes = BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
+      BerlinMessage.parse "@\000\000\000\000\000\000\00012474747474747"
     }
     mes = BerlinMessage.parse "1430@\000\000\000\000\000\000\00012474747474747"
     assert_equal pan, mes.pan
     assert_equal 1430, mes.mti
   end
 
+  def test_unknown_field
+    assert_raises(ISO8583Exception.new("no definition for field: 8")) {
+      mes = BerlinMessage.parse "1430A\000\000\000\000\000\000\00012474747474747"
+    }
+  end
+
+  def test_rescue_standard_error
+    rescued = false
+    begin
+      BerlinMessage.parse("bogus")
+    rescue => error
+      assert_instance_of ISO8583Exception, error
+      rescued = true
+    end
+
+    assert rescued
+  end
+
   def test_to_s
     mes     = BerlinMessage.new
     mes.mti = "Network Management Request Response Issuer Gateway or Acquirer Gateway" 
@@ -157,8 +175,8 @@ END
     mes[64] = "\xF0\xF0\xF0\xF0"
 
     bytes = mes.to_b
-    mes2 = BerlinMessage.parse(mes.to_b)
-    assert_equal(mes.to_b, mes2.to_b)
+    mes2 = BerlinMessage.parse(bytes)
+    assert_equal(bytes, mes2.to_b)
   end
 
   def test_remove_field

data/test/test_codec.rb

@@ -101,7 +101,7 @@ class FieldTest < Test::Unit::TestCase
   end
   def test_A_Codec
     assert_raise(ISO8583Exception) {
-      dt = A_Codec.encode "!!!"
+      A_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
@@ -109,7 +109,7 @@ class FieldTest < Test::Unit::TestCase
 
   def test_AN_Codec
     assert_raise(ISO8583Exception) {
-      dt = AN_Codec.encode "!!!"
+      AN_Codec.encode "!!!"
     }
     assert_equal "bla", AN_Codec.encode("bla")
     assert_equal "bla", AN_Codec.decode("bla")
@@ -117,10 +117,10 @@ class FieldTest < Test::Unit::TestCase
 
   def test_Track2_Codec
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode "!!!"
+      Track2.encode "!!!"
     }
     assert_raise(ISO8583Exception) {
-      dt = Track2.encode ";12312312=123?5"
+      Track2.encode ";12312312=123?5"
     }
     assert_equal ";123123123=123?5", Track2.encode(";123123123=123?5")
     assert_equal ";123123123=123?5", Track2.decode(";123123123=123?5")
@@ -133,10 +133,48 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "\x02", Packed_Number.encode(2)
     assert_equal "\x02\x55", Packed_Number.encode(0xff)
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode ";12312312=123?5"
+      Packed_Number.encode ";12312312=123?5"
     }
     assert_raise(ISO8583Exception) {
-      dt = Packed_Number.encode "F"
+      Packed_Number.encode "F"
     }
   end
+
+  def test_BE_U16 
+    assert_raise(ISO8583Exception) {
+      BE_U16.encode 2**16
+    }
+    assert_raise(ISO8583Exception) {
+      BE_U16.encode(-1)
+    }
+    assert_equal "\0\0", BE_U16.encode(0)
+    expected = "\xff\xff".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U16.encode(2**16-1)
+    expected = "\x0f\xf0".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U16.encode(0x00000ff0)
+    expected = "\xf0\x0f".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U16.encode(0x0000f00f)
+    expected = "\x5A\xA5".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U16.encode(0b0101101010100101)
+
+    assert_equal 0x5aa5, BE_U16.decode(expected)
+  end
+  def test_BE_U32 
+    assert_raise(ISO8583Exception) {
+      BE_U32.encode 2**32
+    }
+    assert_raise(ISO8583Exception) {
+      BE_U32.encode(-1)
+    }
+    assert_equal "\0\0\0\0", BE_U32.encode(0)
+    expected = "\xff\xff\xff\xff".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U32.encode(2**32-1)
+    expected = "\xf0\xf0\x0f\x0f".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U32.encode(0xf0f00f0f)
+    expected = "\0\0\0\x1".force_encoding('ASCII-8BIT')
+    assert_equal expected, BE_U32.encode(1)
+
+    assert_equal 1, BE_U32.decode(expected)
+    assert_equal 10, BE_U32.decode("\0\0\0\xa")
+  end
 end

data/test/test_fields.rb

@@ -10,7 +10,7 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "456", rest
 
     assert_raise(ISO8583ParseException) {
-      l,rest = LLL.parse "12"
+      _,rest = LLL.parse "12"
     }
 
     enc = LLL.encode 123
@@ -50,10 +50,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal "123ABC", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_AN.parse "12"
+      _,rest = LLLVAR_AN.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_AN.parse "12123"
+      _,rest = LLVAR_AN.parse "12123"
     }
 
     enc = LLVAR_AN.encode "123A"
@@ -83,10 +83,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal 1234, value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLLVAR_N.parse "12"
+      _,rest = LLLVAR_N.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_N.parse "12123"
+      _,rest = LLVAR_N.parse "12123"
     }
 
     enc = LLVAR_N.encode 1234
@@ -116,10 +116,10 @@ class FieldTest < Test::Unit::TestCase
     assert_equal ";123123123=123?5", value
     assert_equal "", rest
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "12"
+      _,rest = LLVAR_Z.parse "12"
     }
     assert_raise(ISO8583ParseException) {
-      l,rest = LLVAR_Z.parse "17;123123123=123?5"
+      _,rest = LLVAR_Z.parse "17;123123123=123?5"
     }
 
     enc = LLVAR_Z.encode ";123123123=123?5"
@@ -213,6 +213,7 @@ class FieldTest < Test::Unit::TestCase
     fld.length=3
     value, rest = fld.parse "\x01\x23\x45"
     assert_equal 123, value
+    assert_equal "\x45", rest
 
     assert_equal "\x01\x23", fld.encode(123)
     assert_equal "\x01\x23", fld.encode("123")
@@ -241,6 +242,7 @@ class FieldTest < Test::Unit::TestCase
     assert_equal 12, dt.hour
     assert_equal 34, dt.min
     assert_equal 56, dt.sec
+    assert_equal "", rest
     
     assert_raise(ISO8583Exception) {
       fld.encode 1234567

data/test/test_message_metaclass.rb

@@ -0,0 +1,30 @@
+require 'lib/iso8583'
+require 'test/unit'
+
+
+class TestMessage < Message
+    mti_format N, :length => 4
+    mti 1100, "Authorization Request Acquirer Gateway"
+end
+
+class TestMessage2 < Message
+    mti_format N_BCD, :length => 4
+    mti 1100, "Authorization Request Acquirer Gateway"
+end
+
+class MessageMetaclassTest < Test::Unit::TestCase
+  def test_mti
+    t = TestMessage.new
+    t.mti = 1100
+    expected = "1100\0\0\0\0\0\0\0\0"
+    bs = t.to_b
+    assert_equal expected, bs
+  end
+  def test_len_prefix
+    t = TestMessage2.new
+    t.mti = 1100
+    expected = "\x11\0\0\0\0\0\0\0\0\0"
+    bs = t.to_b
+    assert_equal expected, bs
+  end
+end

data/test/test_util.rb

@@ -5,9 +5,18 @@ include ISO8583
 
 class UtilTest < Test::Unit::TestCase
   def test_hex2b
-    assert_equal "\xab\xcd\x12", hex2b("abcd12")
-    assert_equal "\xab\xcd\x12", hex2b("a b c d 1 2")
-    assert_equal "\xab\xcd\x12", hex2b("ABCD12")
+    # weird ruby 2.0 workaround:
+    # literal:
+    #   "\xab\xcd\x12"
+    # is interpretted as:
+    #   "\xAB\xCD\u0012"
+    # ...force_encoding(...) fixes this.
+
+    expected = "\xab\xcd\x12".force_encoding("ASCII-8BIT")
+
+    assert_equal expected, hex2b("abcd12")
+    assert_equal expected, hex2b("a b c d 1 2")
+    assert_equal expected, hex2b("ABCD12")
     assert_raise(ISO8583Exception){
       # non hex
       hex2b("ABCDEFGH")
@@ -27,6 +36,6 @@ class UtilTest < Test::Unit::TestCase
   end
 
   def test_ascii2ebcdic
-    assert_equal "\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9", ascii2ebcdic("0123456789")
+    assert_equal "\xf0\xf1\xf2\xf3\xf4\xf5\xf6\xf7\xf8\xf9".force_encoding('ASCII-8BIT'), ascii2ebcdic("0123456789")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: iso8583
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.2.4
 platform: ruby
 authors:
 - Tim Becker
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-10 00:00:00.000000000 Z
+date: 2021-07-04 00:00:00.000000000 Z
 dependencies: []
-description: ! 'Ruby implementation of ISO 8583 financial messaging
+description: 'Ruby implementation of ISO 8583 financial messaging
 
-'
+  '
 email:
 - tim.becker@kuriositaet.de
 - cordawyn@gmail.com
@@ -23,8 +23,9 @@ extra_rdoc_files: []
 files:
 - AUTHORS
 - CHANGELOG
+- Gemfile
 - LICENSE
-- README
+- README.md
 - Rakefile
 - TODO
 - lib/8583.rb
@@ -42,6 +43,7 @@ files:
 - test/message_test.rb
 - test/test_codec.rb
 - test/test_fields.rb
+- test/test_message_metaclass.rb
 - test/test_seperate_msg.rb
 - test/test_util.rb
 homepage: http://github.com/a2800276/8583/
@@ -53,19 +55,18 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements:
 - none
-rubyforge_project: iso8583
-rubygems_version: 2.2.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
-summary: ! 'iso8583: Ruby implementation of ISO 8583 financial messaging'
+summary: 'iso8583: Ruby implementation of ISO 8583 financial messaging'
 test_files: []

data/README

@@ -1,26 +0,0 @@
-= ISO 8583 Financial Messaging for Ruby
-
-This package currently contains code for coding an decoding ISO 8583
-Financial Message.
-
-== Using
-
-The best place to get started using the library is the documentation of the
-Message class. Once a stable state is reached, this should be the only
-class you need to use ...
-
-== Installing
-
-You can install the +iso8583+ package by executing:
-
-	gem install iso8583
-
-== Source
-
-The source is most readily available on github[http://github.com/a2800276/8583].
-
-== Mailing List
-
-In case you discover bugs, spelling errors, offer suggestions for
-improvements or would like to help out with the project, you can contact
-me directly (tim@kuriositaet.de).