iso-iban 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1331caf363e5c9959e34a85b95c69a112e9b9e52
-  data.tar.gz: 86451b8eeb5fd428501f250cf442ba49aacc3e65
+  metadata.gz: 3d1b83f6a5ea9e59b2c0e67a3692481e59e37af2
+  data.tar.gz: ba05ced9a335ac538674ddcc7dc38a1f9d3ee5b9
 SHA512:
-  metadata.gz: b84ad4b9a52ffb2b1c644237f3ef462f0003746ef9ce1503039df28f46a1c52518e741f8d6335f5439503821b9d3ffeca951e0b42a13077fdf0ca07eab727a88
-  data.tar.gz: abc912af4577970c0708822751d206ba0b097d744290a6c13972f90e2b8837f47ae37655020db96ea93270a49bdcc199249e14a9b7f30cbf40018be075d4f8c9
+  metadata.gz: 1fe30f823be684f459cb21c772509c08da8959e8d95b52af05fe878564c172fc9702bf517b8d1840f9e33b7b804d55d84e2da828beba1858a83fe1b6c2d9f23e
+  data.tar.gz: 49db76377be9e9ddc86d46ca25007ad6bc3b077e5b3495cb7be20bb92b5d9711a20602c33047bead39b6a80e15a94fbad43d5c072ea0eeb9af6e03bd5ffc189f

data/data/iso-iban/specs.yaml

@@ -49,7 +49,7 @@ BH:
 - BH2!n4!a14!c
 - 22
 - 4!a14!c
-- 22
+- 18
 - 4
 - 7
 - 
@@ -104,7 +104,7 @@ CR:
 - CR2!n3!n14!n
 - 21
 - 3!n14!n
-- 7
+- 17
 - 4
 - 6
 - 
@@ -145,7 +145,7 @@ CZ:
 DK:
 - Denmark
 - DK
-- DK2!n4!n9!n1!n, FO2!n4!n9!n1!n, GL2!n4!n9!n1!n
+- DK2!n4!n9!n1!n
 - 18
 - 4!n9!n1!n
 - 14
@@ -156,7 +156,7 @@ DK:
 FO:
 - Denmark
 - FO
-- DK2!n4!n9!n1!n, FO2!n4!n9!n1!n, GL2!n4!n9!n1!n
+- FO2!n4!n9!n1!n
 - 18
 - 4!n9!n1!n
 - 14
@@ -167,7 +167,7 @@ FO:
 GL:
 - Denmark
 - GL
-- DK2!n4!n9!n1!n, FO2!n4!n9!n1!n, GL2!n4!n9!n1!n
+- GL2!n4!n9!n1!n
 - 18
 - 4!n9!n1!n
 - 14
@@ -202,8 +202,8 @@ FI:
 - FI
 - FI2!n6!n7!n1!n
 - 18
-- Not in use
-- 0
+- 6!n7!n1!n
+- 14
 - 4
 - 6
 - 
@@ -367,7 +367,7 @@ DE:
 - DE
 - DE2!n8!n10!n
 - 22
-- 8!n10!n;
+- 8!n10!n
 - 18
 - 4
 - 11
@@ -376,7 +376,7 @@ DE:
 GI:
 - Gibraltar
 - GI
-- 'GI2!n4!a15!c:'
+- GI2!n4!a15!c
 - 23
 - 4!a15!c
 - 19
@@ -411,7 +411,7 @@ HU:
 - HU
 - HU2!n3!n4!n1!n15!n1!n
 - 28
-- '3!n4!n1!n15!n1!n:'
+- 3!n4!n1!n15!n1!n
 - 24
 - 4
 - 6
@@ -464,7 +464,7 @@ IT:
 KW:
 - Kuwait
 - KW
-- KW2!n4!a22!
+- KW2!n4!a22!c
 - 30
 - 4!a22!c
 - 26
@@ -475,9 +475,8 @@ KW:
 KZ:
 - Kazakhstan
 - KZ
-- 2!a2!n3!n13!c 1,2 characters – country code (KZ) 3,4 characters – IBAN check digits
-  5,7 characters – bank identifier  8-20 characters – intrabank account number
-- 0
+- KZ2!n3!n13!c
+- 20
 - 3!n13!c
 - 16
 - 4
@@ -512,7 +511,7 @@ LI:
 - LI2!n5!n12!c
 - 21
 - 5!n12!c
-- 19
+- 17
 - 4
 - 8
 - 
@@ -564,7 +563,7 @@ MT:
 MR:
 - Mauritania
 - MR
-- MR135!n5!n11!n2!n
+- MR2!n5!n5!n11!n2!n
 - 27
 - 5!n5!n11!n2!n
 - 23
@@ -586,7 +585,7 @@ MU:
 MD:
 - Republic of Moldova
 - MD
-- MD2!n20!c
+- MD2!n2!c18!c
 - 24
 - 2!c18!c
 - 20
@@ -663,7 +662,7 @@ PS:
 PL:
 - Poland
 - PL
-- PL2!n8!n16n
+- PL2!n8!n16!n
 - 28
 - 8!n16!n
 - 24
@@ -784,7 +783,7 @@ CH:
 TN:
 - Tunisia
 - TN
-- TN592!n3!n13!n2!n
+- TN2!n2!n3!n13!n2!n
 - 24
 - 2!n3!n13!n2!n
 - 20
@@ -806,7 +805,7 @@ TR:
 AE:
 - United Arab Emirates
 - AE
-- AE07 0331 2345 6789 0123 456
+- AE2!n3!n16!n
 - 23
 - 3!n16!n
 - 19

data/iso-iban.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name                      = "iso-iban"
-  s.version                   = "0.0.2"
+  s.version                   = "0.0.3"
   s.authors                   = "Stefan Rusterholz"
   s.email                     = "stefan.rusterholz@gmail.com"
   s.homepage                  = "https://github.com/apeiros/iso-iban"

data/lib/iso/iban.rb

@@ -61,6 +61,18 @@ module ISO
     # (digits-only) form
     CharacterCodes  = Hash[('0'..'9').zip('0'..'9')+('a'..'z').zip(10..35)+('A'..'Z').zip(10..35)]
 
+    # All uppercase letters
+    UpperAlpha   = [*'A'..'Z']
+
+    # All lowercase letters
+    LowerAlpha   = [*'a'..'z']
+
+    # All digits
+    Digits       = [*'0'..'9']
+
+    # All uppercase letters, lowercase letters and digits
+    AlphaNumeric = [*'A'..'Z', *'a'..'z', *'0'..'9']
+
     # All specifications, see ISO::IBAN::Specification
     @specifications = nil
 
@@ -160,6 +172,34 @@ module ISO
       iban
     end
 
+    # @param [String] countries
+    #   A list of 2 letter country codes. If empty, all countries in
+    #   ISO::IBAN::specifications are used.
+    #
+    # @return [ISO::IBAN] A random, valid IBAN
+    def self.random(*countries)
+      countries = specifications.keys if countries.empty?
+      country   = countries.sample
+      account   = specification(country).iban_structure.scan(/([A-Z]+)|(\d+)(!?)([nac])/).map { |exact, length, fixed, code|
+        if exact
+          exact
+        elsif code == 'a'
+          Array.new(length.to_i) { UpperAlpha.sample }.join('')
+        elsif code == 'c'
+          Array.new(length.to_i) { AlphaNumeric.sample }.join('')
+        elsif code == 'e'
+          ' '*length.to_i
+        elsif code == 'n'
+          Array.new(length.to_i) { Digits.sample }.join('')
+        end
+      }.join('')
+      account[2,2] = '??'
+      iban = new(account)
+      iban.update_checksum!
+
+      iban
+    end
+
     # Converts a String into its digits-only form, i.e. all characters a-z are replaced with their corresponding
     # digit sequences, according to the IBAN specification.
     #

data/lib/iso/iban/specification.rb

@@ -23,20 +23,24 @@ module ISO
         Hash[YAML.load_file(path).map { |country, spec| [country, new(*spec)] }]
       end
 
-      # Parse the SWIFT provided file (which sadly is a mess).
+      # Parse the SWIFT provided file (which sadly is a huge mess and not machine friendly at all).
       #
       # @return [Array<ISO::IBAN::Specification>] an array with all specifications.
       def self.parse_file(path)
         File.read(path, encoding: Encoding::Windows_1252).encode(Encoding::UTF_8).split("\r\n").tap(&:shift).flat_map { |line|
-          country_name, country_codes, iban_structure, iban_length, bban_structure, bban_length, bank_position = line.split(/\t/).values_at(0,1,11,12,4,5,6)
-          codes = country_codes.size == 2 ? [country_codes] : country_codes.scan(/\b[A-Z]{2}\b/)
+          country_name, country_codes, iban_structure_raw, iban_length, bban_structure, bban_length, bank_position = line.split(/\t/).values_at(0,1,11,12,4,5,6)
+          codes        = country_codes.size == 2 ? [country_codes] : country_codes.scan(/\b[A-Z]{2}\b/)
+          primary_code = codes.first
           bank_position_from, bank_position_to, branch_position_from, branch_position_to = bank_position.match(/(?:[Pp]ositions?|) (\d+)-(\d+)(?:.*Branch identifier positions?: (\d+)-(\d+))?/).captures.map { |pos| pos && pos.to_i+3 }
 
           codes.map { |a2_country_code|
+            iban_structure = iban_structure_raw[/#{a2_country_code}[acen\!\d]*/] || iban_structure_raw[/#{primary_code}[acen\!\d]*/]
+            bban_structure = bban_structure[/[acen\!\d]*/]
+
             new(
               country_name.strip,
               a2_country_code,
-              iban_structure.strip,
+              iban_structure,
               iban_length.to_i,
               bban_structure.strip,
               bban_length.to_i,

data/lib/iso/iban/version.rb

@@ -13,6 +13,6 @@ module ISO
     # @note
     #   require 'iso/iban' loads the version.
     #
-    Version = Gem::Version.new("0.0.2")
+    Version = Gem::Version.new("0.0.3")
   end
 end

data/test/unit/lib/iso/iban.rb

@@ -7,6 +7,27 @@ suite "ISO::IBAN" do
     ISO::IBAN.instance_variable_set(:@specifications, {'CH' => ISO::IBAN::Specification.new("Switzerland", "CH", "CH2!n5!n12!c", 21, "5!n12!c", 17, 4, 8, nil, nil)})
   end
 
+  # since the specs provided by swift are a mess, we do a sanity check
+  test 'Specifications provided by SWIFT' do
+    ISO::IBAN.load_specifications
+    ISO::IBAN.specifications.each do |country, spec|
+      structure_length = spec.iban_structure.scan(/([A-Z]+)|(\d+)(!?)([nac])/).map { |exact, length, fixed, code|
+        exact ? exact.length : length.to_i
+      }.inject(:+)
+
+      assert_equal spec.iban_length, structure_length, "Spec for country #{country} is invalid, invalid length"
+      assert_equal spec.bban_structure, spec.iban_structure[5..-1], "Spec for country #{country} is invalid, iban differs from country + 2!n + bban"
+      assert_equal spec.bban_length, spec.iban_length-4, "Spec for country #{country} is invalid, iban length differs from bban length + 4"
+    end
+  end
+
+  test 'Random IBAN generation' do
+    ISO::IBAN.load_specifications
+    ISO::IBAN.specifications.each do |country, spec|
+      assert ISO::IBAN.random(country).valid?, "Random IBAN generator for country #{country} is invalid"
+    end
+  end
+
   test 'ISO::IBAN::generate problem, TODO' do
     ISO::IBAN.instance_variable_set(:@specifications, {'BG' => ISO::IBAN::Specification.new("Bulgaria", "BG", "BG2!n4!a4!n2!n8!c", 22, "4!a4!n2!n8!c", 18, 4, 7, 8, 11)})
     assert ISO::IBAN.generate('BG', 'AAAA', '2', 'C').valid? # this works now

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: iso-iban
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Stefan Rusterholz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-09 00:00:00.000000000 Z
+date: 2013-07-10 00:00:00.000000000 Z
 dependencies: []
 description: |-
   ISO::IBAN implements IBAN (International Bank Account Number) specification as per ISO 13616-1.