ismasan-sluggable_finder 2.0.3 → 2.0.4

data/README.markdown

@@ -103,6 +103,14 @@ If you wan to unpack the gem to you app's "vendor" directory:
 
     rake gems:unpack
 
+## TODO:
+
+*Refactor. It works but I hate the code.
+
+*Avoid including in ALL models. At the moment we need to extend associations for all models. Not sure how to only extend associations for models that use the plugin.
+
+*Better testing for scoped collections. @user.posts.find 'blah' should only look in posts for @user without needing to add :scope
+
 ## LICENSE:
 
 (The MIT License)

data/lib/sluggable_finder/finder.rb

@@ -4,7 +4,7 @@ module SluggableFinder
   module Finder
     
     def find_with_slug(*args)
-      if (args.first.is_a?(String) and !(args.first =~ /\A\d+\Z/))#only contain digits
+      if (respond_to?(:sluggable_finder_options) && args.first.is_a?(String) and !(args.first =~ /\A\d+\Z/))#only contain digits
           options = {:conditions => ["#{ sluggable_finder_options[:to]} = ?", args.first]}
           first(options) or 
             raise SluggableFinder.not_found_exception.new("There is no #{sluggable_finder_options[:sluggable_type]} with #{sluggable_finder_options[:to]} '#{args.first}'")

data/lib/sluggable_finder.rb

@@ -2,7 +2,7 @@ $:.unshift(File.dirname(__FILE__)) unless
   $:.include?(File.dirname(__FILE__)) || $:.include?(File.expand_path(File.dirname(__FILE__)))
 
 module SluggableFinder
-  VERSION = '2.0.3'
+  VERSION = '2.0.4'
   
   @@not_found_exception = nil
   
@@ -28,7 +28,6 @@ module SluggableFinder
         end
       }.each do |klass|
         klass.send :include, SluggableFinder::Finder
-        klass.class_eval { alias_method_chain :find, :slug }
       end
       
     end

data/spec/sluggable_finder_spec.rb

@@ -14,6 +14,11 @@ class Item < ActiveRecord::Base
   named_scope :published, :conditions => {:published => true}
 end
 
+# No sluggable finder, should be unnaffected
+#
+class NoFinder < Item
+
+end
 # Simple slug
 #
 class SimpleItem < Item
@@ -208,4 +213,18 @@ describe SimpleItem, 'with AR named scopes' do
       SimpleItem.published.find('not-published')
     }.should raise_error(ActiveRecord::RecordNotFound)
   end
+end
+
+describe NoFinder, "with no finder" do
+  before(:each) do
+    NoFinder.delete_all
+    @item = NoFinder.create(:title => 'no finder here')
+    @string_id = "#{@item.id}-some-string"
+  end
+  
+  it "should use find normally" do
+    NoFinder.find(:first).should == @item
+    NoFinder.find(@item.id).should == @item
+    NoFinder.find(@string_id).should == @item
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: ismasan-sluggable_finder
 version: !ruby/object:Gem::Version 
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors: 
 - Ismael Celis