isimud 1.4.2 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d00087ddb9c814123247016a8369c981460dd5fe
-  data.tar.gz: 08af358a3d6b7095c7612ac524ac3d02f82b42d0
+  metadata.gz: 24e6e7c078fcbde044973d789c6864ad9d2f135d
+  data.tar.gz: d360568fc6f12868894f4e7ea73326588e2d54fd
 SHA512:
-  metadata.gz: b13ddd2631d2f5354489b69aa1ad1e2dfffe2a1ab680f0c5ddffc37bdbe2cc05a9a32aeb40fbc8dc3c3e7e3fdbeec764e5920bc4b9d8e2a075467e4716f41bf0
-  data.tar.gz: 242fb5bca098a9f563d3a87b6b0dc26cebc868d86486af7d479ba23bac9cf06d87b2062363df5a4683aaa1ece0e288edba1f4a058234a2f889c57e13f21a90d7
+  metadata.gz: 4ccb82c28094f8c9c11c65c2f28a323f9537a521753f93ecc5018b9cc9c893d2fba136020e714017f3e1bce93dd15253097ece8e1dab61b139694a18891c3188
+  data.tar.gz: 1b1b713a107beca0d3b318bdf042bf7b7490d19570eddf4a479ad98b69f365f883f6085fd8f9d22d0a527a6af2dc782a4f6fe1f544f094722860fd59b7fb73de

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    isimud (1.4.2)
+    isimud (1.4.3)
       activerecord (>= 4.1.4)
       activesupport (>= 4.1.4)
       bunny (>= 1.6.0)

data/README.md

@@ -93,11 +93,11 @@ for cold startup on a new AMQP broker.
 
 Each time that a message is retrieved from the queue, the following properties are set in the current thread:
 
- | name | contents |
- | ---- | -------- |
- | isimud_queue_name | Name of the queue processing the thread |
- | isimud_delivery_info | Message delivery information (*Bunny::DeliveryInfo*) |
- | isimud_properties | Message properties metadata (*Bunny::MessageProperties*) |
+| name | contents |
+| ---- | -------- |
+| isimud_queue_name | Name of the queue processing the thread |
+| isimud_delivery_info | Message delivery information (*Bunny::DeliveryInfo*) |
+| isimud_properties | Message properties metadata (*Bunny::MessageProperties*) |
  
 ### Exception Handling
 
@@ -120,6 +120,11 @@ the message is not re-queued.
 
 # Changes
 
+## 1.4.3
+
+* When an exception is raised during message processing, check status of channel before calling reject()
+* Symbolize keys in options when initializing BunnyClient
+
 ## 1.4.2
 
 * BunnyClient#publish now accepts additional metadata options
@@ -134,6 +139,12 @@ the message is not re-queued.
 * Log messages for receipt and ack of messages downgraded to debug level.
 * Force manual_ack mode for all queue subscriptions. 
 
+## 1.3.9
+
+* EventListener changes:
+  * start_event_thread, dump exception backtrace to log
+  * set log level to info or higher for all event thread messages
+
 ## 1.3.8
 
 * In EventListener event thread, rescue all exceptions, not just Bunny ones.

data/checksum/isimud-1.4.2.gem.sha512

@@ -0,0 +1 @@
+e4a69fdd34af13d8dc4363f6f50ac5ea7b3b0eda113977da90ce1f1a5c02a43dba63981b079208c15c92a776546f13307530f527f3b744f74e3bbaab31a2a119

data/doc/_index.html

@@ -91,7 +91,7 @@
 </div>
 
     <div id="footer">
-  Generated on Wed Aug 24 20:16:22 2016 by
+  Generated on Fri Sep 16 16:32:29 2016 by
   <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.8.7.6 (ruby-2.3.0).
 </div>

data/doc/file.LICENSE.html

@@ -64,7 +64,7 @@
     <div id="content"><div id='filecontents'>Copyright (c) 2016 Welltok Inc.<br/><br/>Permission is hereby granted, free of charge, to any person obtaining a copy<br/>of this software and associated documentation files (the &quot;Software&quot;), to deal<br/>in the Software without restriction, including without limitation the rights<br/>to use, copy, modify, merge, publish, distribute, sublicense, and/or sell<br/>copies of the Software, and to permit persons to whom the Software is<br/>furnished to do so, subject to the following conditions:<br/><br/>The above copyright notice and this permission notice shall be included in all<br/>copies or substantial portions of the Software.<br/><br/>THE SOFTWARE IS PROVIDED &quot;AS IS&quot;, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR<br/>IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,<br/>FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE<br/>AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER<br/>LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,<br/>OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE<br/>SOFTWARE.</div></div>
 
     <div id="footer">
-  Generated on Wed Aug 24 20:16:23 2016 by
+  Generated on Fri Sep 16 16:32:31 2016 by
   <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.8.7.6 (ruby-2.3.0).
 </div>

data/doc/file.README.html

@@ -189,9 +189,9 @@ AMQP broker.</p>
 <p>Each time that a message is retrieved from the queue, the following
 properties are set in the current thread:</p>
 
-<p>| name | contents |  | —- | ——– |  | isimud_queue_name | Name of the queue
-processing the thread |  | isimud_delivery_info | Message delivery
-information (<em>Bunny::DeliveryInfo</em>) |  | isimud_properties | Message
+<p>| name | contents | | —- | ——– | | isimud_queue_name | Name of the queue
+processing the thread | | isimud_delivery_info | Message delivery
+information (<em>Bunny::DeliveryInfo</em>) | | isimud_properties | Message
 properties metadata (<em>Bunny::MessageProperties</em>) |</p>
 
 <h3 id="label-Exception+Handling">Exception Handling</h3>
@@ -217,16 +217,44 @@ falsey, the message is not re-queued.</p>
 
 <h1 id="label-Changes">Changes</h1>
 
+<h2 id="label-1.4.3">1.4.3</h2>
+<ul><li>
+<p>When an exception is raised during message processing, check status of
+channel before calling reject()</p>
+</li><li>
+<p>Symbolize keys in options when initializing BunnyClient</p>
+</li></ul>
+
 <h2 id="label-1.4.2">1.4.2</h2>
 <ul><li>
+<p>BunnyClient#publish now accepts additional metadata options</p>
+</li><li>
+<p>Isimud::Event changes:</p>
+</li><li>
+<p>Added #timestamp property</p>
+</li><li>
+<p>Added #message_id for generating unique message IDs</p>
+</li><li>
+<p>message_id is now added to metadata when publishing</p>
+</li></ul>
+
+<h2 id="label-1.4.1">1.4.1</h2>
+<ul><li>
 <p>Enable conditional re-queuing of messages after an exception is raised (see
 <em>Exception Handling</em> above).</p>
 </li><li>
 <p>Log messages for receipt and ack of messages downgraded to debug level.</p>
 </li><li>
 <p>Force manual_ack mode for all queue subscriptions.</p>
+</li></ul>
+
+<h2 id="label-1.3.9">1.3.9</h2>
+<ul><li>
+<p>EventListener changes:</p>
+</li><li>
+<p>start_event_thread, dump exception backtrace to log</p>
 </li><li>
-<p>BunnyClient#publish now accepts additional</p>
+<p>set log level to info or higher for all event thread messages</p>
 </li></ul>
 
 <h2 id="label-1.3.8">1.3.8</h2>
@@ -554,7 +582,7 @@ feature&#39;</code>)</p>
 </div></div>
 
     <div id="footer">
-  Generated on Wed Aug 24 20:16:23 2016 by
+  Generated on Fri Sep 16 16:32:31 2016 by
   <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.8.7.6 (ruby-2.3.0).
 </div>

data/doc/index.html

@@ -189,9 +189,9 @@ AMQP broker.</p>
 <p>Each time that a message is retrieved from the queue, the following
 properties are set in the current thread:</p>
 
-<p>| name | contents |  | —- | ——– |  | isimud_queue_name | Name of the queue
-processing the thread |  | isimud_delivery_info | Message delivery
-information (<em>Bunny::DeliveryInfo</em>) |  | isimud_properties | Message
+<p>| name | contents | | —- | ——– | | isimud_queue_name | Name of the queue
+processing the thread | | isimud_delivery_info | Message delivery
+information (<em>Bunny::DeliveryInfo</em>) | | isimud_properties | Message
 properties metadata (<em>Bunny::MessageProperties</em>) |</p>
 
 <h3 id="label-Exception+Handling">Exception Handling</h3>
@@ -217,16 +217,44 @@ falsey, the message is not re-queued.</p>
 
 <h1 id="label-Changes">Changes</h1>
 
+<h2 id="label-1.4.3">1.4.3</h2>
+<ul><li>
+<p>When an exception is raised during message processing, check status of
+channel before calling reject()</p>
+</li><li>
+<p>Symbolize keys in options when initializing BunnyClient</p>
+</li></ul>
+
 <h2 id="label-1.4.2">1.4.2</h2>
 <ul><li>
+<p>BunnyClient#publish now accepts additional metadata options</p>
+</li><li>
+<p>Isimud::Event changes:</p>
+</li><li>
+<p>Added #timestamp property</p>
+</li><li>
+<p>Added #message_id for generating unique message IDs</p>
+</li><li>
+<p>message_id is now added to metadata when publishing</p>
+</li></ul>
+
+<h2 id="label-1.4.1">1.4.1</h2>
+<ul><li>
 <p>Enable conditional re-queuing of messages after an exception is raised (see
 <em>Exception Handling</em> above).</p>
 </li><li>
 <p>Log messages for receipt and ack of messages downgraded to debug level.</p>
 </li><li>
 <p>Force manual_ack mode for all queue subscriptions.</p>
+</li></ul>
+
+<h2 id="label-1.3.9">1.3.9</h2>
+<ul><li>
+<p>EventListener changes:</p>
+</li><li>
+<p>start_event_thread, dump exception backtrace to log</p>
 </li><li>
-<p>BunnyClient#publish now accepts additional</p>
+<p>set log level to info or higher for all event thread messages</p>
 </li></ul>
 
 <h2 id="label-1.3.8">1.3.8</h2>
@@ -554,7 +582,7 @@ feature&#39;</code>)</p>
 </div></div>
 
     <div id="footer">
-  Generated on Wed Aug 24 20:16:23 2016 by
+  Generated on Fri Sep 16 16:32:30 2016 by
   <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.8.7.6 (ruby-2.3.0).
 </div>

data/doc/top-level-namespace.html

@@ -93,7 +93,7 @@
 </div>
 
     <div id="footer">
-  Generated on Wed Aug 24 20:16:23 2016 by
+  Generated on Fri Sep 16 16:32:31 2016 by
   <a href="http://yardoc.org" title="Yay! A Ruby Documentation Tool" target="_parent">yard</a>
   0.8.7.6 (ruby-2.3.0).
 </div>

data/lib/isimud/bunny_client.rb

@@ -18,7 +18,8 @@ module Isimud
     def initialize(_url = nil, _bunny_options = {})
       log "Isimud::BunnyClient.initialize: options = #{_bunny_options.inspect}"
       @url           = _url || DEFAULT_URL
-      @bunny_options = _bunny_options
+      @url.symbolize_keys! if @url.respond_to?(:symbolize_keys!)
+      @bunny_options = _bunny_options.symbolize_keys
     end
 
     # Convenience method that finds or creates a named queue, binds to an exchange, and subscribes to messages.
@@ -68,18 +69,18 @@ module Isimud
       queue.subscribe(options.merge(manual_ack: true)) do |delivery_info, properties, payload|
         current_channel = channel
         begin
-          log "Isimud: queue #{queue.name} received #{delivery_info.delivery_tag} routing_key: #{delivery_info.routing_key}", :debug
+          log "Isimud: queue #{queue.name} received #{properties[:message_id]} routing_key: #{delivery_info.routing_key}", :debug
           Thread.current['isimud_queue_name']    = queue.name
           Thread.current['isimud_delivery_info'] = delivery_info
           Thread.current['isimud_properties']    = properties
           block.call(payload)
-          log "Isimud: queue #{queue.name} finished with #{delivery_info.delivery_tag}, acknowledging", :debug
+          log "Isimud: queue #{queue.name} finished with #{properties[:message_id]}, acknowledging", :debug
           current_channel.ack(delivery_info.delivery_tag)
         rescue => e
-          log("Isimud: queue #{queue.name} error processing #{delivery_info.delivery_tag} payload #{payload.inspect}: #{e.class.name} #{e.message}\n  #{e.backtrace.join("\n  ")}", :warn)
+          log("Isimud: queue #{queue.name} error processing #{properties[:message_id]} payload #{payload.inspect}: #{e.class.name} #{e.message}\n  #{e.backtrace.join("\n  ")}", :warn)
           retry_status  = run_exception_handlers(e)
-          log "Isimud: rejecting #{delivery_info.delivery_tag} requeue=#{retry_status}", :warn
-          current_channel.reject(delivery_info.delivery_tag, retry_status)
+          log "Isimud: rejecting #{properties[:message_id]} requeue=#{retry_status}", :warn
+          current_channel.open? && current_channel.reject(delivery_info.delivery_tag, retry_status)
         end
       end
     end

data/lib/isimud/event_listener.rb

@@ -84,8 +84,8 @@ module Isimud
       @events_exchange     = options[:events_exchange]
       @models_exchange     = options[:models_exchange]
       @name                = options[:name]
-      @observer_mutex      = Mutex.new
-      @error_counter_mutex = Mutex.new
+      @observer_mutex      = Thread::Mutex.new
+      @error_counter_mutex = Thread::Mutex.new
       @status              = STATUS_INITIALIZE
     end
 
@@ -171,16 +171,16 @@ module Isimud
 
     def start_event_thread
       Thread.new do
-        log 'EventListener: starting event_thread'
+        log 'EventListener: starting event_thread', :info
         until shutdown? do
           begin
             bind_queues
-            log 'EventListener: event_thread finished'
+            log 'EventListener: event_thread bind_queues finished', :info
             @status = STATUS_RUNNING
             Thread.stop
           rescue => e
+            log "EventListener: error in event thread: #{e.message}\n  #{e.backtrace.join("\n  ")}", :warn
             count_error(e)
-            log 'EventListener: resetting queues', :warn
             @observer_queue = nil
             client.reset
           end
@@ -201,7 +201,7 @@ module Isimud
     end
 
     def start_error_counter_thread
-      log 'EventListener: starting error counter'
+      log 'EventListener: starting error counter', :info
       @error_count = 0
       Thread.new do
         while true

data/lib/isimud/version.rb

@@ -1,3 +1,3 @@
 module Isimud
-  VERSION = '1.4.2'
+  VERSION = '1.4.3'
 end

data/spec/isimud/bunny_client_spec.rb

@@ -1,14 +1,24 @@
 require 'spec_helper'
 
 describe Isimud::BunnyClient do
-  let!(:exchange_name) { 'isimud_test' }
-  let!(:url) { 'amqp://guest:guest@localhost' }
-  let!(:client) { Isimud::BunnyClient.new(url) }
-  let!(:connection) { client.connection }
+  let(:exchange_name) { 'isimud_test' }
+  let(:url) { 'amqp://guest:guest@localhost' }
+  let(:client) { Isimud::BunnyClient.new(url) }
+  let(:connection) { client.connection }
 
   describe '#initialize' do
-    it 'sets the broker URL' do
-      expect(client.url).to eq(url)
+    context 'with a string URL' do
+      it 'sets the broker URL' do
+        expect(client.url).to eq(url)
+      end
+    end
+
+    context 'with a server specified as a hash' do
+      let(:options) { {host: 'foo@example.com', port: 15671, user: 'user', password: 'secret'} }
+      let(:url) { options.stringify_keys }
+      it 'symbolizes the keys and passes the hash' do
+        expect(client.url).to eql(options)
+      end
     end
   end
 
@@ -113,6 +123,7 @@ describe Isimud::BunnyClient do
 
   describe '#connected?' do
     it 'is true for an open session' do
+      channel = client.connect
       expect(client).to be_connected
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: isimud
 version: !ruby/object:Gem::Version
-  version: 1.4.2
+  version: 1.4.3
 platform: ruby
 authors:
 - George Feil
@@ -31,7 +31,7 @@ cert_chain:
   wSKk31gq6KY7rgi11mcLvVzwSuwZFqnonAmu/uin3cbXcOUkqNsyzZ0LQLXNKiwi
   k0RgrsSNtQ8hcsVSQla0Ot+X3WpFI4ZuIfSLFA==
   -----END CERTIFICATE-----
-date: 2016-08-25 00:00:00.000000000 Z
+date: 2016-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -116,6 +116,7 @@ files:
 - checksum/isimud-1.3.8.gem.sha512
 - checksum/isimud-1.4.0.gem.sha512
 - checksum/isimud-1.4.1.gem.sha512
+- checksum/isimud-1.4.2.gem.sha512
 - config.ru
 - config/tddium.yml
 - doc/Isimud.html