isic 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 37b0a1eedfd4c4e8f4b37a9d985ae135d62c4422
-  data.tar.gz: 1d1cb3f925b8f540b5f7b1bc2847a4ca0d59968e
+  metadata.gz: 22f2116c09217baebfa04f3fc5e2a8c884239218
+  data.tar.gz: 4fbc6075ac3ae7192dab2478a81025bad97a07ec
 SHA512:
-  metadata.gz: c5819a3b659eb6e46791bb82be8ed87498363babe60ea95fb2fafe9485b19b9c1925ae709524e58109f1317e4e5ea5112080b815ef329e27a9dd1cad21915e52
-  data.tar.gz: e2dff3463c9bc6a87495778fdc5c3dd8ea9df68a0fdf7536a071844bd2f741b15a490c60bb5e4a9b1b2844535f61c7adc99941355c7d88f885a556a7ef33c031
+  metadata.gz: 337c16d195a072740194466926cd3808be6be39d1748556c282ccea9708edad9ddd8bfad18e4d832c7a3e0ee51caa79f68a241aa30fe2091a7595d224c64456e
+  data.tar.gz: 6e0940c23e25de503165a235d8292d71545ff196e06798ff8872a5f1c0699b971c6b982315ab069d3d450069c906076cf55d88f1f91853bae22fa25b95dc09ea

data/.travis.yml

@@ -0,0 +1,4 @@
+language: ruby
+rvm:
+  - "2.1.3"
+script: bundle exec rspec spec

data/README.md

@@ -24,87 +24,100 @@ Or install it yourself as:
 
 Given an ISIC code, find its place in the hierarchy:
 
-    > Isic::Entity.new("0891").classify
-    {
-      :section => { :code => "B", :description => "Mining and quarrying" },
-      :division => { :code => "08", :description => "Other mining and quarrying" },
-      :group => { :code => "089", :description => "Mining and quarrying n.e.c." },
-      :class => { :code => "0891", :description => "Mining of chemical and fertilizer minerals" }
-    }
+```ruby
+> Isic::Entity.new("0891").classify
+{
+  :section => { :code => "B", :description => "Mining and quarrying" },
+  :division => { :code => "08", :description => "Other mining and quarrying" },
+  :group => { :code => "089", :description => "Mining and quarrying n.e.c." },
+  :class => { :code => "0891", :description => "Mining of chemical and fertilizer minerals" }
+}
+```
 
 Find all the sections:
 
-    > Isic.sections
-    [
-      {:code=>"A", :description=>"Agriculture, forestry and fishing"},
-      {:code=>"B", :description=>"Mining and quarrying"},
-      {:code=>"C", :description=>"Manufacturing"}
-      {:code=>"D", :description=>"Electricity, gas, steam and air conditioning supply"},
-      {:code=>"E", :description=>"Water supply; sewerage, waste management and remediation activities"},
-      {:code=>"F", :description=>"Construction"},
-      {:code=>"G", :description=>"Wholesale and retail trade; repair of motor vehicles and motorcycles"},
-      {:code=>"H", :description=>"Transportation and storage"},
-      {:code=>"I", :description=>"Accommodation and food service activities"},
-      {:code=>"J", :description=>"Information and communication"},
-      {:code=>"K", :description=>"Financial and insurance activities"},
-      {:code=>"L", :description=>"Real estate activities"},
-      {:code=>"M", :description=>"Professional, scientific and technical activities"},
-      {:code=>"N", :description=>"Administrative and support service activities"},
-      {:code=>"O", :description=>"Public administration and defence; compulsory social security"},
-      {:code=>"P", :description=>"Education"}, {:code=>"Q", :description=>"Human health and social work activities"},
-      {:code=>"R", :description=>"Arts, entertainment and recreation"},
-      {:code=>"S", :description=>"Other service activities"},
-      {:code=>"T", :description=>"Activities of households as employers; undifferentiated goods- and services-producing activities of households for own use"},
-      {:code=>"U", :description=>"Activities of extraterritorial organizations and bodies"}
-    ]
+```ruby
+> Isic.sections
+[
+  {:code=>"A", :description=>"Agriculture, forestry and fishing"},
+  {:code=>"B", :description=>"Mining and quarrying"},
+  {:code=>"C", :description=>"Manufacturing"}
+  {:code=>"D", :description=>"Electricity, gas, steam and air conditioning supply"},
+  {:code=>"E", :description=>"Water supply; sewerage, waste management and remediation activities"},
+  {:code=>"F", :description=>"Construction"},
+  {:code=>"G", :description=>"Wholesale and retail trade; repair of motor vehicles and motorcycles"},
+  {:code=>"H", :description=>"Transportation and storage"},
+  {:code=>"I", :description=>"Accommodation and food service activities"},
+  {:code=>"J", :description=>"Information and communication"},
+  {:code=>"K", :description=>"Financial and insurance activities"},
+  {:code=>"L", :description=>"Real estate activities"},
+  {:code=>"M", :description=>"Professional, scientific and technical activities"},
+  {:code=>"N", :description=>"Administrative and support service activities"},
+  {:code=>"O", :description=>"Public administration and defence; compulsory social security"},
+  {:code=>"P", :description=>"Education"}, {:code=>"Q", :description=>"Human health and social work activities"},
+  {:code=>"R", :description=>"Arts, entertainment and recreation"},
+  {:code=>"S", :description=>"Other service activities"},
+  {:code=>"T", :description=>"Activities of households as employers; undifferentiated goods- and services-producing activities of households for own use"},
+  {:code=>"U", :description=>"Activities of extraterritorial organizations and bodies"}
+]
+```
 
 Find all the divisions of the "B" section:
 
-    > Isic.divisions(section: "B")
-    [
-      {:code=>"05", :description=>"Mining of coal and lignite"},
-      {:code=>"06", :description=>"Extraction of crude petroleum and natural gas"},
-      {:code=>"07", :description=>"Mining of metal ores"},
-      {:code=>"08", :description=>"Other mining and quarrying"},
-      {:code=>"09", :description=>"Mining support service activities"}
-    ]
+```ruby
+> Isic.divisions(section: "B")
+[
+  {:code=>"05", :description=>"Mining of coal and lignite"},
+  {:code=>"06", :description=>"Extraction of crude petroleum and natural gas"},
+  {:code=>"07", :description=>"Mining of metal ores"},
+  {:code=>"08", :description=>"Other mining and quarrying"},
+  {:code=>"09", :description=>"Mining support service activities"}
+]
+```
 
 Find all the groups of the "08" division:
 
-    > Isic.groups(division: "08")
-    [
-      {:code=>"081", :description=>"Quarrying of stone, sand and clay"},
-      {:code=>"089", :description=>"Mining and quarrying n.e.c."}
-    ]
+```ruby
+> Isic.groups(division: "08")
+[
+  {:code=>"081", :description=>"Quarrying of stone, sand and clay"},
+  {:code=>"089", :description=>"Mining and quarrying n.e.c."}
+]
+```
 
 Find all the classes of the "089" group:
 
-    > Isic.classes(group: "089")
-    [
-      {:code=>"0891", :description=>"Mining of chemical and fertilizer minerals"},
-      {:code=>"0892", :description=>"Extraction of peat"},
-      {:code=>"0893", :description=>"Extraction of salt"},
-      {:code=>"0899", :description=>"Other mining and quarrying n.e.c."}
-    ]
+```ruby
+> Isic.classes(group: "089")
+[
+  {:code=>"0891", :description=>"Mining of chemical and fertilizer minerals"},
+  {:code=>"0892", :description=>"Extraction of peat"},
+  {:code=>"0893", :description=>"Extraction of salt"},
+  {:code=>"0899", :description=>"Other mining and quarrying n.e.c."}
+]
+```
 
 ## Translations
 
 Descriptions are returned in English by default, but Spanish and French are supported. In any of the methods above you can specify the translation:
 
-    > Isic::Entity.new("0891").classify(translation: :es)
-    {
-      :class=>{:code=>"0891", :description=>"Extracción de minerales para la fabricación de abonos y productos químicos"},
-      :group=>{:code=>"089", :description=>"Explotación de minas y canteras n.c.p."},
-      :division=>{:code=>"08", :description=>"Explotación de otras minas y canteras"},
-      :section=>{:code=>"B", :description=>"Explotación de minas y canteras"}
-    }
-
-    > Isic.groups(division: "08", translation: :fr)
-    [
-      {:code=>"081", :description=>"Extraction de pierres, de sables et d'argiles"},
-      {:code=>"089", :description=>"Activités extractives, n.c.a."}
-    ]
-
+```ruby
+> Isic::Entity.new("0891").classify(translation: :es)
+{
+  :class=>{:code=>"0891", :description=>"Extracción de minerales para la fabricación de abonos y productos químicos"},
+  :group=>{:code=>"089", :description=>"Explotación de minas y canteras n.c.p."},
+  :division=>{:code=>"08", :description=>"Explotación de otras minas y canteras"},
+  :section=>{:code=>"B", :description=>"Explotación de minas y canteras"}
+}
+```
+
+```ruby
+> Isic.groups(division: "08", translation: :fr)
+[
+  {:code=>"081", :description=>"Extraction de pierres, de sables et d'argiles"},
+  {:code=>"089", :description=>"Activités extractives, n.c.a."}
+]
+```
 
 ## Contributing
 
@@ -114,6 +127,13 @@ Descriptions are returned in English by default, but Spanish and French are supp
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+## Code Status
+
+[![Gem Version](http://img.shields.io/badge/gem-v1.0.3-blue.svg)](https://rubygems.org/gems/mic)
+[![Build Status](https://travis-ci.org/javiervidal/isic.svg?branch=master)](https://travis-ci.org/javiervidal/isic)
+[![Coverage Status](https://coveralls.io/repos/javiervidal/isic/badge.png?branch=master)](https://coveralls.io/r/javiervidal/isic?branch=master)
+[![Code Climate](https://codeclimate.com/github/javiervidal/isic/badges/gpa.svg)](https://codeclimate.com/github/javiervidal/isic)
+
 ## Copyright
 
 Copyright (c) 2014 – ∞ Javier Vidal

data/isic.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "awesome_print"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "coveralls"
 end

data/lib/isic/entity.rb

@@ -1,4 +1,4 @@
-module Isic
+class Isic
   class Entity
 
     def initialize(code)

data/lib/isic/isic.rb

@@ -1,4 +1,4 @@
-module Isic
+class Isic
 
   DIVISIONS = {}
   DIVISIONS['A'] = %w( 01 02 03 )
@@ -41,19 +41,17 @@ module Isic
     end
 
     def groups(options = {})
-      translation = options[:translation] || :en
-      if options[:division] && /\d{2}/.match(options[:division])
-        code = "#{options[:division]}\\d"
-        Search.new(code, translation: translation).all
-      else
-        []
-      end
+      parse(:division, 2, options)
     end
 
     def classes(options = {})
+      parse(:group, 3, options)
+    end
+
+    def parse(symbol, digits, options = {})
       translation = options[:translation] || :en
-      if options[:group] && /\d{3}/.match(options[:group])
-        code = "#{options[:group]}\\d"
+      if options[symbol] && Regexp.new("\\d{#{digits}}").match(options[symbol])
+        code = "#{options[symbol]}\\d"
         Search.new(code, translation: translation).all
       else
         []
@@ -62,4 +60,6 @@ module Isic
 
   end
 
+  private_class_method :parse
+
 end

data/lib/isic/search.rb

@@ -1,4 +1,4 @@
-module Isic
+class Isic
   class Search
 
     FILES = {

data/lib/isic/version.rb

@@ -1,3 +1,3 @@
-module Isic
-  VERSION = "1.0.2"
+class Isic
+  VERSION = "1.0.3"
 end

data/spec/isic/entity_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Isic::Entity do
+
+  describe '#classify' do
+
+    context 'in english' do
+
+      let(:class_classification) { Isic::Entity.new("0891").classify }
+      let(:group_classification) { Isic::Entity.new("089").classify }
+      let(:division_classification) { Isic::Entity.new("08").classify }
+      let(:section_classification) { Isic::Entity.new("B").classify }
+
+      it "class is classified with section, division, group and class" do
+        expect(class_classification).to eq({
+                                             :class => {:code => "0891", :description => "Mining of chemical and fertilizer minerals"},
+                                             :group => {:code => "089", :description => "Mining and quarrying n.e.c."},
+                                             :division => {:code => "08", :description => "Other mining and quarrying"},
+                                             :section => {:code => "B", :description => "Mining and quarrying"}
+                                           })
+      end
+
+      it "group is classified with section, division and group" do
+        expect(group_classification).to eq({
+                                             :group => {:code => "089", :description => "Mining and quarrying n.e.c."},
+                                             :division => {:code => "08", :description => "Other mining and quarrying"},
+                                             :section => {:code => "B", :description => "Mining and quarrying"}
+                                           })
+      end
+
+      it "division is classified with section and division" do
+        expect(division_classification).to eq({
+                                                :division => {:code => "08", :description => "Other mining and quarrying"},
+                                                :section => {:code => "B", :description => "Mining and quarrying"}
+                                              })
+      end
+
+      it "section is classified with section" do
+        expect(section_classification).to eq({
+                                               :section => {:code => "B", :description => "Mining and quarrying"}
+                                             })
+      end
+
+    end
+
+    context 'in spanish' do
+
+      let(:class_classification) { Isic::Entity.new("0891").classify(translation: :es) }
+
+      it "classifies with section, division, group and class" do
+        expect(class_classification).to eq({
+                                             :class => {:code => "0891", :description => "Extracción de minerales para la fabricación de abonos y productos químicos"},
+                                             :group => {:code => "089", :description => "Explotación de minas y canteras n.c.p."},
+                                             :division => {:code => "08", :description => "Explotación de otras minas y canteras"},
+                                             :section => {:code => "B", :description => "Explotación de minas y canteras"}
+                                           })
+      end
+
+    end
+
+    context 'in french' do
+
+      let(:class_classification) { Isic::Entity.new("0891").classify(translation: :fr) }
+
+      it "classifies with section, division, group and class" do
+        expect(class_classification).to eq({
+                                             :class => {:code => "0891", :description => "Extraction de minerais pour l'industrie chimique et d'engrais naturels"},
+                                             :group => {:code => "089", :description => "Activités extractives, n.c.a."},
+                                             :division => {:code => "08", :description => "Autres activités extractives"},
+                                             :section => {:code => "B", :description => "Activités extractives"}
+                                           })
+      end
+
+    end
+
+  end
+
+end

data/spec/isic/isic_spec.rb

@@ -0,0 +1,104 @@
+require 'spec_helper'
+
+describe Isic do
+
+  describe 'Isic methods' do
+
+    context 'when english' do
+
+      let(:sections) { Isic.sections }
+      let(:divisions) { Isic.divisions(section: "B") }
+      let(:groups) { Isic.groups(division: "08") }
+      let(:classes) { Isic.classes(group: "089") }
+
+      it 'returns all the sections in english' do
+        expect(sections).to eq([{:code => "A", :description => "Agriculture, forestry and fishing"}, {:code => "B", :description => "Mining and quarrying"}, {:code => "C", :description => "Manufacturing"}, {:code => "D", :description => "Electricity, gas, steam and air conditioning supply"}, {:code => "E", :description => "Water supply; sewerage, waste management and remediation activities"}, {:code => "F", :description => "Construction"}, {:code => "G", :description => "Wholesale and retail trade; repair of motor vehicles and motorcycles"}, {:code => "H", :description => "Transportation and storage"}, {:code => "I", :description => "Accommodation and food service activities"}, {:code => "J", :description => "Information and communication"}, {:code => "K", :description => "Financial and insurance activities"}, {:code => "L", :description => "Real estate activities"}, {:code => "M", :description => "Professional, scientific and technical activities"}, {:code => "N", :description => "Administrative and support service activities"}, {:code => "O", :description => "Public administration and defence; compulsory social security"}, {:code => "P", :description => "Education"}, {:code => "Q", :description => "Human health and social work activities"}, {:code => "R", :description => "Arts, entertainment and recreation"}, {:code => "S", :description => "Other service activities"}, {:code => "T", :description => "Activities of households as employers; undifferentiated goods- and services-producing activities of households for own use"}, {:code => "U", :description => "Activities of extraterritorial organizations and bodies"}])
+      end
+
+      it 'returns all the divisions of the B section in english' do
+        expect(divisions).to eq([{:code => "05", :description => "Mining of coal and lignite"}, {:code => "06", :description => "Extraction of crude petroleum and natural gas"}, {:code => "07", :description => "Mining of metal ores"}, {:code => "08", :description => "Other mining and quarrying"}, {:code => "09", :description => "Mining support service activities"}])
+      end
+
+      it 'returns all the groups of the 08 division in english' do
+        expect(groups).to eq([{:code => "081", :description => "Quarrying of stone, sand and clay"}, {:code => "089", :description => "Mining and quarrying n.e.c."}])
+      end
+
+      it 'returns all the classes of the 089 group in english' do
+        expect(classes).to eq([{:code => "0891", :description => "Mining of chemical and fertilizer minerals"}, {:code => "0892", :description => "Extraction of peat"}, {:code => "0893", :description => "Extraction of salt"}, {:code => "0899", :description => "Other mining and quarrying n.e.c."}])
+      end
+
+    end
+
+    context 'when no specifying the parent entity' do
+
+      let(:divisions) { Isic.divisions }
+      let(:groups) { Isic.groups }
+      let(:classes) { Isic.classes }
+
+      it 'returns no divisions' do
+        expect(divisions).to match_array([])
+      end
+
+      it 'returns no groups' do
+        expect(groups).to match_array([])
+      end
+
+      it 'returns no classes' do
+        expect(classes).to match_array([])
+      end
+
+    end
+
+    context 'when spanish' do
+
+      let(:sections) { Isic.sections(translation: :es) }
+      let(:divisions) { Isic.divisions(section: "B", translation: :es) }
+      let(:groups) { Isic.groups(division: "08", translation: :es) }
+      let(:classes) { Isic.classes(group: "089", translation: :es) }
+
+      it 'returns all the sections in english' do
+        expect(sections).to eq([{:code => "A", :description => "Agricultura, ganadería, silvicultura y pesca"}, {:code => "B", :description => "Explotación de minas y canteras"}, {:code => "C", :description => "Industrias manufactureras"}, {:code => "D", :description => "Suministro de electricidad, gas, vapor y aire acondicionado"}, {:code => "E", :description => "Suministro de agua; evacuación de aguas residuales, gestión de desechos y descontaminación"}, {:code => "F", :description => "Construcción"}, {:code => "G", :description => "Comercio al por mayor y al por menor; reparación de vehículos automotores y motocicletas"}, {:code => "H", :description => "Transporte y almacenamiento"}, {:code => "I", :description => "Actividades de alojamiento y de servicio de comidas"}, {:code => "J", :description => "Información y comunicaciones"}, {:code => "K", :description => "Actividades financieras y de seguros"}, {:code => "L", :description => "Actividades inmobiliarias"}, {:code => "M", :description => "Actividades profesionales, científicas y técnicas"}, {:code => "N", :description => "Actividades de servicios administrativos y de apoyo"}, {:code => "O", :description => "Administración pública y defensa; planes de seguridad social de afiliación obligatoria"}, {:code => "P", :description => "Enseñanza"}, {:code => "Q", :description => "Actividades de atención de la salud humana y de asistencia social"}, {:code => "R", :description => "Actividades artísticas, de entretenimiento y recreativas"}, {:code => "S", :description => "Otras actividades de servicios"}, {:code => "T", :description => "Actividades de los hogares como empleadores; actividades no diferenciadas de los hogares como productores de bienes y servicios para uso propio"}, {:code => "U", :description => "Actividades de organizaciones y órganos extraterritoriales"}])
+      end
+
+      it 'returns all the divisions of the B section in english' do
+        expect(divisions).to eq([{:code => "05", :description => "Extracción de carbón de piedra y lignito"}, {:code => "06", :description => "Extracción de petróleo crudo y gas natural"}, {:code => "07", :description => "Extracción de minerales metalíferos"}, {:code => "08", :description => "Explotación de otras minas y canteras"}, {:code => "09", :description => "Actividades de servicios de apoyo para la explotación de minas y canteras"}])
+      end
+
+      it 'returns all the groups of the 08 division in english' do
+        expect(groups).to eq([{:code => "081", :description => "Extracción de piedra, arena y arcilla"}, {:code => "089", :description => "Explotación de minas y canteras n.c.p."}])
+      end
+
+      it 'returns all the classes of the 089 group in english' do
+        expect(classes).to eq([{:code => "0891", :description => "Extracción de minerales para la fabricación de abonos y productos químicos"}, {:code => "0892", :description => "Extracción de turba"}, {:code => "0893", :description => "Extracción de sal"}, {:code => "0899", :description => "Explotación de otras minas y canteras n.c.p."}])
+      end
+
+    end
+
+    context 'when french' do
+
+      let(:sections) { Isic.sections(translation: :fr) }
+      let(:divisions) { Isic.divisions(section: "B", translation: :fr) }
+      let(:groups) { Isic.groups(division: "08", translation: :fr) }
+      let(:classes) { Isic.classes(group: "089", translation: :fr) }
+
+      it 'returns all the sections in english' do
+        expect(sections).to eq([{:code => "A", :description => "Agriculture, sylviculture et pêche"}, {:code => "B", :description => "Activités extractives"}, {:code => "C", :description => "Activités de fabrication"}, {:code => "D", :description => "Production et distribution d'électricité, de gaz, de vapeur et climatisation"}, {:code => "E", :description => "Distribution d'eau; réseau d'assainissement; gestion des déchets et activités de remise en état"}, {:code => "F", :description => "Construction"}, {:code => "G", :description => "Commerce de gros et de détail, réparations de véhicules automobiles et de motocycles"}, {:code => "H", :description => "Transport et entreposage"}, {:code => "I", :description => "Activités d'hébergement et de restauration"}, {:code => "J", :description => "Information et communication"}, {:code => "K", :description => "Activités financières et d'assurances"}, {:code => "L", :description => "Activités immobilières"}, {:code => "M", :description => "Activités professionnelles, scientifiques et techniques"}, {:code => "N", :description => "Activités de services administratifs et d'appui"}, {:code => "O", :description => "Administration publique et défense; sécurité sociale obligatoire"}, {:code => "P", :description => "Éducation"}, {:code => "Q", :description => "Santé et et activités d'action sociale"}, {:code => "R", :description => "Arts, spectacles et loisirs"}, {:code => "S", :description => "Autres activités de services"}, {:code => "T", :description => "Activités des ménages privés employant du personnel domestique; activités non différenciées de production de biens et de services des ménages privés pour usage propre"}, {:code => "U", :description => "Activités des organisations et organismes extra-territoriaux"}])
+      end
+
+      it 'returns all the divisions of the B section in english' do
+        expect(divisions).to eq([{:code => "05", :description => "Extraction de charbon et de lignite"}, {:code => "06", :description => "Extraction de pétrole brut et de gaz naturel"}, {:code => "07", :description => "Extraction de minerais métalliques"}, {:code => "08", :description => "Autres activités extractives"}, {:code => "09", :description => "Activités annexes de l'extraction"}])
+      end
+
+      it 'returns all the groups of the 08 division in english' do
+        expect(groups).to eq([{:code => "081", :description => "Extraction de pierres, de sables et d'argiles"}, {:code => "089", :description => "Activités extractives, n.c.a."}])
+      end
+
+      it 'returns all the classes of the 089 group in english' do
+        expect(classes).to eq([{:code => "0891", :description => "Extraction de minerais pour l'industrie chimique et d'engrais naturels"}, {:code => "0892", :description => "Extraction de tourbe"}, {:code => "0893", :description => "Extraction de sel"}, {:code => "0899", :description => "Autres activités extractives, n.c.a."}])
+      end
+
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,93 +1,20 @@
 require 'simplecov'
+require 'coveralls'
+
+SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
+
 SimpleCov.start
+
 require 'isic'
 
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause this
-# file to always be loaded, without a need to explicitly require it in any files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
+
   config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    # be_bigger_than(2).and_smaller_than(4).description
-    #   # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #   # => "be bigger than 2"
     expectations.include_chain_clauses_in_custom_matcher_descriptions = true
   end
 
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
   config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
     mocks.verify_partial_doubles = true
   end
 
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # These two settings work together to allow you to limit a spec run
-  # to individual examples or groups you care about by tagging them with
-  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
-  # get run.
-  config.filter_run :focus
-  config.run_all_when_everything_filtered = true
-
-  # Limits the available syntax to the non-monkey patched syntax that is recommended.
-  # For more details, see:
-  #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
-  #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new__config_option_to_disable_rspeccore_monkey_patching
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: isic
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Javier Vidal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-09 00:00:00.000000000 Z
+date: 2014-12-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 'The International Standard Industrial Classification (ISIC) is a United
   Nations system for classifying economic data. The classification is based in four
   hierarchical levels: sections, divisions, groups and classes. This gem allows to
@@ -92,6 +106,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -105,8 +120,8 @@ files:
 - lib/isic/isic.rb
 - lib/isic/search.rb
 - lib/isic/version.rb
-- spec/entity_spec.rb
-- spec/isic_spec.rb
+- spec/isic/entity_spec.rb
+- spec/isic/isic_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/javiervidal/isic
 licenses:
@@ -133,6 +148,6 @@ signing_key:
 specification_version: 4
 summary: International Standard Industrial Classification
 test_files:
-- spec/entity_spec.rb
-- spec/isic_spec.rb
+- spec/isic/entity_spec.rb
+- spec/isic/isic_spec.rb
 - spec/spec_helper.rb

data/spec/entity_spec.rb

@@ -1,82 +0,0 @@
-require 'spec_helper'
-
-module Isic
-
-  describe Entity do
-
-    describe '#classify' do
-
-      context 'in english' do
-
-        let(:class_classification) { Isic::Entity.new("0891").classify }
-        let(:group_classification) { Isic::Entity.new("089").classify }
-        let(:division_classification) { Isic::Entity.new("08").classify }
-        let(:section_classification) { Isic::Entity.new("B").classify }
-
-        it "class is classified with section, division, group and class" do
-          expect(class_classification).to eq({
-                                               :class => {:code => "0891", :description => "Mining of chemical and fertilizer minerals"},
-                                               :group => {:code => "089", :description => "Mining and quarrying n.e.c."},
-                                               :division => {:code => "08", :description => "Other mining and quarrying"},
-                                               :section => {:code => "B", :description => "Mining and quarrying"}
-                                             })
-        end
-
-        it "group is classified with section, division and group" do
-          expect(group_classification).to eq({
-                                               :group => {:code => "089", :description => "Mining and quarrying n.e.c."},
-                                               :division => {:code => "08", :description => "Other mining and quarrying"},
-                                               :section => {:code => "B", :description => "Mining and quarrying"}
-                                             })
-        end
-
-        it "division is classified with section and division" do
-          expect(division_classification).to eq({
-                                                  :division => {:code => "08", :description => "Other mining and quarrying"},
-                                                  :section => {:code => "B", :description => "Mining and quarrying"}
-                                                })
-        end
-
-        it "section is classified with section" do
-          expect(section_classification).to eq({
-                                                 :section => {:code => "B", :description => "Mining and quarrying"}
-                                               })
-        end
-
-      end
-
-      context 'in spanish' do
-
-        let(:class_classification) { Isic::Entity.new("0891").classify(translation: :es) }
-
-        it "classifies with section, division, group and class" do
-          expect(class_classification).to eq({
-                                               :class => {:code => "0891", :description => "Extracción de minerales para la fabricación de abonos y productos químicos"},
-                                               :group => {:code => "089", :description => "Explotación de minas y canteras n.c.p."},
-                                               :division => {:code => "08", :description => "Explotación de otras minas y canteras"},
-                                               :section => {:code => "B", :description => "Explotación de minas y canteras"}
-                                             })
-        end
-
-      end
-
-      context 'in french' do
-
-        let(:class_classification) { Isic::Entity.new("0891").classify(translation: :fr) }
-
-        it "classifies with section, division, group and class" do
-          expect(class_classification).to eq({
-                                               :class => {:code => "0891", :description => "Extraction de minerais pour l'industrie chimique et d'engrais naturels"},
-                                               :group => {:code => "089", :description => "Activités extractives, n.c.a."},
-                                               :division => {:code => "08", :description => "Autres activités extractives"},
-                                               :section => {:code => "B", :description => "Activités extractives"}
-                                             })
-        end
-
-      end
-
-    end
-
-  end
-
-end

data/spec/isic_spec.rb

@@ -1,104 +0,0 @@
-require 'spec_helper'
-
-module Isic
-
-  describe 'Isic methods' do
-
-    context 'when english' do
-
-      let(:sections) { Isic.sections }
-      let(:divisions) { Isic.divisions(section: "B") }
-      let(:groups) { Isic.groups(division: "08") }
-      let(:classes) { Isic.classes(group: "089") }
-
-      it 'returns all the sections in english' do
-        expect(sections).to eq([{:code => "A", :description => "Agriculture, forestry and fishing"}, {:code => "B", :description => "Mining and quarrying"}, {:code => "C", :description => "Manufacturing"}, {:code => "D", :description => "Electricity, gas, steam and air conditioning supply"}, {:code => "E", :description => "Water supply; sewerage, waste management and remediation activities"}, {:code => "F", :description => "Construction"}, {:code => "G", :description => "Wholesale and retail trade; repair of motor vehicles and motorcycles"}, {:code => "H", :description => "Transportation and storage"}, {:code => "I", :description => "Accommodation and food service activities"}, {:code => "J", :description => "Information and communication"}, {:code => "K", :description => "Financial and insurance activities"}, {:code => "L", :description => "Real estate activities"}, {:code => "M", :description => "Professional, scientific and technical activities"}, {:code => "N", :description => "Administrative and support service activities"}, {:code => "O", :description => "Public administration and defence; compulsory social security"}, {:code => "P", :description => "Education"}, {:code => "Q", :description => "Human health and social work activities"}, {:code => "R", :description => "Arts, entertainment and recreation"}, {:code => "S", :description => "Other service activities"}, {:code => "T", :description => "Activities of households as employers; undifferentiated goods- and services-producing activities of households for own use"}, {:code => "U", :description => "Activities of extraterritorial organizations and bodies"}])
-      end
-
-      it 'returns all the divisions of the B section in english' do
-        expect(divisions).to eq([{:code => "05", :description => "Mining of coal and lignite"}, {:code => "06", :description => "Extraction of crude petroleum and natural gas"}, {:code => "07", :description => "Mining of metal ores"}, {:code => "08", :description => "Other mining and quarrying"}, {:code => "09", :description => "Mining support service activities"}])
-      end
-
-      it 'returns all the groups of the 08 division in english' do
-        expect(groups).to eq([{:code => "081", :description => "Quarrying of stone, sand and clay"}, {:code => "089", :description => "Mining and quarrying n.e.c."}])
-      end
-
-      it 'returns all the classes of the 089 group in english' do
-        expect(classes).to eq([{:code => "0891", :description => "Mining of chemical and fertilizer minerals"}, {:code => "0892", :description => "Extraction of peat"}, {:code => "0893", :description => "Extraction of salt"}, {:code => "0899", :description => "Other mining and quarrying n.e.c."}])
-      end
-
-    end
-
-    context 'when no specifying the parent entity' do
-
-      let(:divisions) { Isic.divisions }
-      let(:groups) { Isic.groups }
-      let(:classes) { Isic.classes }
-
-      it 'returns no divisions' do
-        expect(divisions).to match_array([])
-      end
-
-      it 'returns no groups' do
-        expect(groups).to match_array([])
-      end
-
-      it 'returns no classes' do
-        expect(classes).to match_array([])
-      end
-
-    end
-
-    context 'when spanish' do
-
-      let(:sections) { Isic.sections(translation: :es) }
-      let(:divisions) { Isic.divisions(section: "B",translation: :es) }
-      let(:groups) { Isic.groups(division: "08", translation: :es) }
-      let(:classes) { Isic.classes(group: "089", translation: :es) }
-
-      it 'returns all the sections in english' do
-        expect(sections).to eq([{:code=>"A", :description=>"Agricultura, ganadería, silvicultura y pesca"}, {:code=>"B", :description=>"Explotación de minas y canteras"}, {:code=>"C", :description=>"Industrias manufactureras"}, {:code=>"D", :description=>"Suministro de electricidad, gas, vapor y aire acondicionado"}, {:code=>"E", :description=>"Suministro de agua; evacuación de aguas residuales, gestión de desechos y descontaminación"}, {:code=>"F", :description=>"Construcción"}, {:code=>"G", :description=>"Comercio al por mayor y al por menor; reparación de vehículos automotores y motocicletas"}, {:code=>"H", :description=>"Transporte y almacenamiento"}, {:code=>"I", :description=>"Actividades de alojamiento y de servicio de comidas"}, {:code=>"J", :description=>"Información y comunicaciones"}, {:code=>"K", :description=>"Actividades financieras y de seguros"}, {:code=>"L", :description=>"Actividades inmobiliarias"}, {:code=>"M", :description=>"Actividades profesionales, científicas y técnicas"}, {:code=>"N", :description=>"Actividades de servicios administrativos y de apoyo"}, {:code=>"O", :description=>"Administración pública y defensa; planes de seguridad social de afiliación obligatoria"}, {:code=>"P", :description=>"Enseñanza"}, {:code=>"Q", :description=>"Actividades de atención de la salud humana y de asistencia social"}, {:code=>"R", :description=>"Actividades artísticas, de entretenimiento y recreativas"}, {:code=>"S", :description=>"Otras actividades de servicios"}, {:code=>"T", :description=>"Actividades de los hogares como empleadores; actividades no diferenciadas de los hogares como productores de bienes y servicios para uso propio"}, {:code=>"U", :description=>"Actividades de organizaciones y órganos extraterritoriales"}])
-      end
-
-      it 'returns all the divisions of the B section in english' do
-        expect(divisions).to eq([{:code=>"05", :description=>"Extracción de carbón de piedra y lignito"}, {:code=>"06", :description=>"Extracción de petróleo crudo y gas natural"}, {:code=>"07", :description=>"Extracción de minerales metalíferos"}, {:code=>"08", :description=>"Explotación de otras minas y canteras"}, {:code=>"09", :description=>"Actividades de servicios de apoyo para la explotación de minas y canteras"}])
-      end
-
-      it 'returns all the groups of the 08 division in english' do
-        expect(groups).to eq([{:code=>"081", :description=>"Extracción de piedra, arena y arcilla"}, {:code=>"089", :description=>"Explotación de minas y canteras n.c.p."}])
-      end
-
-      it 'returns all the classes of the 089 group in english' do
-        expect(classes).to eq([{:code=>"0891", :description=>"Extracción de minerales para la fabricación de abonos y productos químicos"}, {:code=>"0892", :description=>"Extracción de turba"}, {:code=>"0893", :description=>"Extracción de sal"}, {:code=>"0899", :description=>"Explotación de otras minas y canteras n.c.p."}])
-      end
-
-    end
-
-    context 'when french' do
-
-      let(:sections) { Isic.sections(translation: :fr) }
-      let(:divisions) { Isic.divisions(section: "B",translation: :fr) }
-      let(:groups) { Isic.groups(division: "08", translation: :fr) }
-      let(:classes) { Isic.classes(group: "089", translation: :fr) }
-
-      it 'returns all the sections in english' do
-        expect(sections).to eq([{:code=>"A", :description=>"Agriculture, sylviculture et pêche"}, {:code=>"B", :description=>"Activités extractives"}, {:code=>"C", :description=>"Activités de fabrication"}, {:code=>"D", :description=>"Production et distribution d'électricité, de gaz, de vapeur et climatisation"}, {:code=>"E", :description=>"Distribution d'eau; réseau d'assainissement; gestion des déchets et activités de remise en état"}, {:code=>"F", :description=>"Construction"}, {:code=>"G", :description=>"Commerce de gros et de détail, réparations de véhicules automobiles et de motocycles"}, {:code=>"H", :description=>"Transport et entreposage"}, {:code=>"I", :description=>"Activités d'hébergement et de restauration"}, {:code=>"J", :description=>"Information et communication"}, {:code=>"K", :description=>"Activités financières et d'assurances"}, {:code=>"L", :description=>"Activités immobilières"}, {:code=>"M", :description=>"Activités professionnelles, scientifiques et techniques"}, {:code=>"N", :description=>"Activités de services administratifs et d'appui"}, {:code=>"O", :description=>"Administration publique et défense; sécurité sociale obligatoire"}, {:code=>"P", :description=>"Éducation"}, {:code=>"Q", :description=>"Santé et et activités d'action sociale"}, {:code=>"R", :description=>"Arts, spectacles et loisirs"}, {:code=>"S", :description=>"Autres activités de services"}, {:code=>"T", :description=>"Activités des ménages privés employant du personnel domestique; activités non différenciées de production de biens et de services des ménages privés pour usage propre"}, {:code=>"U", :description=>"Activités des organisations et organismes extra-territoriaux"}])
-      end
-
-      it 'returns all the divisions of the B section in english' do
-        expect(divisions).to eq([{:code=>"05", :description=>"Extraction de charbon et de lignite"}, {:code=>"06", :description=>"Extraction de pétrole brut et de gaz naturel"}, {:code=>"07", :description=>"Extraction de minerais métalliques"}, {:code=>"08", :description=>"Autres activités extractives"}, {:code=>"09", :description=>"Activités annexes de l'extraction"}])
-      end
-
-      it 'returns all the groups of the 08 division in english' do
-        expect(groups).to eq([{:code=>"081", :description=>"Extraction de pierres, de sables et d'argiles"}, {:code=>"089", :description=>"Activités extractives, n.c.a."}])
-      end
-
-      it 'returns all the classes of the 089 group in english' do
-        expect(classes).to eq([{:code=>"0891", :description=>"Extraction de minerais pour l'industrie chimique et d'engrais naturels"}, {:code=>"0892", :description=>"Extraction de tourbe"}, {:code=>"0893", :description=>"Extraction de sel"}, {:code=>"0899", :description=>"Autres activités extractives, n.c.a."}])
-      end
-
-    end
-
-  end
-
-end