isbn_validation 1.1.0 → 1.1.1

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2011 Nick Plante
+Copyright (c) 2013 Nick Plante
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -33,4 +33,4 @@ support, please use v0.1.2.
 * Nick Plante
 * Omer Jakobinsky - Rails 3.0 compatibility
 
-Copyright © 2011 Nick Plante, released under the MIT license
+Copyright © 2013 Nick Plante, released under the MIT license

data/lib/isbn_validation/version.rb

@@ -1,3 +1,3 @@
 module IsbnValidation
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/lib/isbn_validation.rb

@@ -25,8 +25,8 @@ require "isbn_validation/version"
 #   method, proc or string should return or evaluate to a true or false value.
 module ValidationExtensions
   module IsbnValidation
-    ISBN10_REGEX = /^(?:\d[\ |-]?){9}[\d|X]$/
-    ISBN13_REGEX = /^(?:\d[\ |-]?){13}$/
+    ISBN10_REGEX = /^(?:\d[\ |-]?){9}[\d|X]$/i
+    ISBN13_REGEX = /^(?:\d[\ |-]?){13}$/i
 
     def self.included(base)
       base.extend(ClassMethods)
@@ -61,7 +61,7 @@ module ValidationExtensions
         if (isbn || '').match(ISBN10_REGEX)
           isbn_values = isbn.upcase.gsub(/\ |-/, '').split('')
           check_digit = isbn_values.pop # last digit is check digit
-          check_digit = (check_digit == 'X') ? 10 : check_digit.to_i
+          check_digit = (check_digit.upcase == 'X') ? 10 : check_digit.to_i
 
           sum = 0
           isbn_values.each_with_index do |value, index|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: isbn_validation
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2009-09-10 00:00:00.000000000 -04:00
-default_executable: 
+date: 2013-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &2153258500 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +21,15 @@ dependencies:
         version: '3'
   type: :runtime
   prerelease: false
-  version_requirements: *2153258500
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: sqlite3
-  requirement: &2153258080 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,32 +37,29 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153258080
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: isbn_validation adds an isbn validation routine to active record models.
-email: nap@zerosum.org
+email:
+- nap@zerosum.org
 executables: []
 extensions: []
 extra_rdoc_files:
 - README.md
-files:
 - MIT-LICENSE
-- Rakefile
-- README.md
+files:
 - lib/isbn_validation/version.rb
 - lib/isbn_validation.rb
-- test/isbn_validation_test.rb
-- test/models.rb
-- test/schema.rb
-- test/test_helper.rb
-has_rdoc: true
+- README.md
+- MIT-LICENSE
 homepage: 
 licenses: []
 post_install_message: 
-rdoc_options:
-- --line-numbers
-- --inline-source
-- --main
-- README.md
+rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -67,17 +68,22 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -239021533232196791
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -239021533232196791
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: isbn_validation adds an isbn validation routine to active record models.
-test_files:
-- test/isbn_validation_test.rb
+test_files: []

data/Rakefile

@@ -1,15 +0,0 @@
-require 'bundler'
-require 'rake'
-require 'rake/testtask'
-
-Bundler::GemHelper.install_tasks
-
-desc 'Default: run unit tests.'
-task :default => :test
-
-desc 'Test the isbn_validation plugin.'
-Rake::TestTask.new(:test) do |t|
-  t.libs << 'lib'
-  t.pattern = 'test/**/*_test.rb'
-  t.verbose = true
-end

data/test/isbn_validation_test.rb

@@ -1,120 +0,0 @@
-require File.dirname(__FILE__) + '/test_helper'
-require File.dirname(__FILE__) + '/models'
-
-class IsbnValidationTest < Test::Unit::TestCase
-  def test_isbn10_should_match_regex
-    isbn = '1590599934'
-    assert isbn.match(ValidationExtensions::IsbnValidation::ISBN10_REGEX)
-  end
-
-  def test_isbn10_should_not_match_regex
-    isbn = 'abc123ab3344'
-    assert !isbn.match(ValidationExtensions::IsbnValidation::ISBN10_REGEX)
-  end
-
-  def test_isbn10_with_dashes_and_spaces_should_match_regex
-    isbn = '159-059 9934'
-    assert isbn.match(ValidationExtensions::IsbnValidation::ISBN10_REGEX)
-  end
-
-  def test_isbn13_should_match_regex
-    isbn = '9781590599938'
-    assert isbn.match(ValidationExtensions::IsbnValidation::ISBN13_REGEX)
-  end
-
-  def test_isbn13_should_not_match_regex
-    isbn = '9991a9010599938'
-    assert !isbn.match(ValidationExtensions::IsbnValidation::ISBN13_REGEX)
-  end
-
-  def test_isbn13_with_dashes_and_spaces_should_match_regex
-    isbn = '978-159059 9938'
-    assert isbn.match(ValidationExtensions::IsbnValidation::ISBN13_REGEX)
-  end
-
-  def test_isbn_should_match_either_isbn10_or_isbn13
-    book = Book.new
-    book.isbn = 'invalid'
-    assert !book.valid?
-    book.isbn = '1590599934'
-    assert book.valid?
-    book.isbn = '9781590599938'
-    assert book.valid?
-  end
-
-  def test_isbn10_should_pass_check_digit_verification
-    book = Book10.new
-    book.isbn = '159059993-4'
-    assert book.valid?
-  end
-
-  def test_isbn10_should_fail_check_digit_verification
-    book = Book10.new
-    book.isbn = '159059993-0'
-    assert !book.valid?
-  end
-
-  def test_isbn10_should_handle_x_character_checksum
-    book = Book10.new
-    book.isbn = '0-9722051-1-X'
-    assert book.valid?
-  end
-
-  def test_isbn13_should_pass_check_digit_verification
-    book = Book13.new
-    book.isbn = '978-1590599938'
-    assert book.valid?
-  end
-
-  def test_isbn13_should_fail_check_digit_verification
-    book = Book13.new
-    book.isbn = '978-1590599934'
-    assert !book.valid?
-  end
-
-  def test_isbn13_with_zero_check_digit_should_validate
-    book = Book13.new
-    book.isbn = '978-1-60746-006-0'
-    assert book.valid?
-  end
-
-  def test_isbn_should_be_valid_to_isbn10_by_default
-    book = Book.new
-    book.isbn = '1590599934'
-    assert book.valid?
-  end
-
-  def test_should_have_custom_error_message
-    book = Book.new
-    book.isbn = '978-159059AAAAAA'
-    book.valid?
-    assert_equal 'is too fantastical!', book.errors[:isbn].first
-  end
-
-  def test_blank_should_not_be_valid_by_default
-    book = Book13.new
-    book.isbn = ''
-    book.valid?
-    assert_equal 'is not a valid ISBN code', book.errors[:isbn].first
-  end
-
-  def test_should_have_an_option_to_allow_nil
-    book = Book13.new
-    book.isbn = nil
-    assert book.valid?
-  end
-
-  def test_should_have_an_option_to_allow_blank
-    book = Book10.new
-    book.isbn = ''
-    assert book.valid?
-  end
-
-  def test_should_support_old_syntax
-    book = OldBook.new
-    book.isbn = ''
-    assert !book.valid?
-    book.isbn = '1590599934'
-    assert book.valid?
-  end
-end

data/test/models.rb

@@ -1,18 +0,0 @@
-class Book < ActiveRecord::Base
-  validates :isbn, :isbn_format => { :message => 'is too fantastical!' }
-end
-
-class Book10 < ActiveRecord::Base
-  set_table_name 'books'
-  validates :isbn, :isbn_format => { :with => :isbn10, :allow_blank => true }
-end
-
-class Book13 < ActiveRecord::Base
-  set_table_name 'books'
-  validates :isbn, :isbn_format => { :with => :isbn13, :allow_nil => true }
-end
-
-class OldBook < ActiveRecord::Base
-  set_table_name 'books'
-  validates_isbn :isbn
-end

data/test/schema.rb

@@ -1,5 +0,0 @@
-ActiveRecord::Schema.define(:version => 1) do
-  create_table :books, :force => true do |t|
-    t.string :isbn
-  end
-end

data/test/test_helper.rb

@@ -1,15 +0,0 @@
-$:.unshift(File.dirname(__FILE__) + '/../lib')
-RAILS_ROOT = File.dirname(__FILE__)
-
-require 'logger'
-require 'rubygems'
-require 'test/unit'
-require 'active_record'
-require "active_record/test_case"
-require "#{File.dirname(__FILE__)}/../init"
-
-config = YAML::load(IO.read(File.dirname(__FILE__) + '/database.yml'))
-ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__) + '/debug.log')
-ActiveRecord::Base.establish_connection(config[ENV['DB'] || 'sqlite3'])
-
-load(File.dirname(__FILE__) + "/schema.rb") if File.exist?(File.dirname(__FILE__) + "/schema.rb")